On June 9, 2015, 12:32 a.m., Ben Mahler wrote:
3rdparty/libprocess/src/tests/process_tests.cpp, line 1930
https://reviews.apache.org/r/33295/diff/10/?file=980632#file980632line1930
Any reason you could't use initializer list construction for this?
Lets add a `TODO(arojas): Use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review87100
---
3rdparty/libprocess/include/process/firewall.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review86800
---
Ship it!
3rdparty/libprocess/include/process/firewall.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review86169
---
Ship it!
Add an @return and fix the nits, and I'm ready to commit
On June 1, 2015, 1:06 a.m., Adam B wrote:
3rdparty/libprocess/include/process/firewall.hpp, lines 54-55
https://reviews.apache.org/r/33295/diff/6/?file=964946#file964946line54
Please capitalize The beginning of each @param description.
Alexander Rojas wrote:
I do completely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/
---
(Updated June 2, 2015, 11:57 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review85950
---
Looks very close! Just some minor nits and suggested rewordings,
On June 1, 2015, 10:06 a.m., Adam B wrote:
3rdparty/libprocess/include/process/firewall.hpp, lines 54-55
https://reviews.apache.org/r/33295/diff/6/?file=964946#file964946line54
Please capitalize The beginning of each @param description.
I do completely agree with you, and actually
On May 20, 2015, 7:18 a.m., Joerg Schad wrote:
docs/powered-by-mesos.md, line 28
https://reviews.apache.org/r/33295/diff/4/?file=947287#file947287line28
Is that dropped by a rebase or by you?
Same below
Thanks for fixing this so quickly :-).
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/
---
(Updated May 20, 2015, 9:46 a.m.)
Review request for mesos, Adam B, Benjamin
On April 23, 2015, 2:49 p.m., Till Toenshoff wrote:
3rdparty/libprocess/include/process/firewall.hpp, line 37
https://reviews.apache.org/r/33295/diff/1/?file=933067#file933067line37
I forgot the verbally proposed name for this function, but maybe a
negated result and the name
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/
---
(Updated May 1, 2015, 7:12 p.m.)
Review request for mesos, Adam B, Benjamin
On April 23, 2015, 8:19 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/src/process.cpp, lines 2461-2463
https://reviews.apache.org/r/33295/diff/2/?file=939497#file939497line2461
For this synchronized block, and above:
In order to ensure we don't end up in a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review81329
---
Please move the `*` for pointers to the left as per our style
14 matches
Mail list logo
