---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review91100
---
Ship it!
Will fix the below issue while comitting.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/
---
(Updated June 17, 2015, 5:42 p.m.)
Review request for mesos, Bernd Mathiske,
On June 16, 2015, 10:29 a.m., Bernd Mathiske wrote:
3rdparty/libprocess/src/time.cpp, line 41
https://reviews.apache.org/r/34703/diff/5/?file=984729#file984729line41
Why can't we use strfmt_l with a locale argument that matches the
output we want?
`strfmt_l` is available only on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/
---
(Updated June 16, 2015, 2:24 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review88038
---
3rdparty/libprocess/src/tests/time_tests.cpp (line 42)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/
---
(Updated June 15, 2015, 5:26 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87550
---
3rdparty/libprocess/include/process/time.hpp
On June 11, 2015, 11:10 a.m., Michael Park wrote:
3rdparty/libprocess/include/process/time.hpp, lines 111-114
https://reviews.apache.org/r/34703/diff/4/?file=980765#file980765line111
Formatting:
```static const char* WEEK_DAYS[] = {
Sun, Mon, Tue, Wed, Thu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87543
---
Can we also introduce a corresponding `.cpp` for the
On June 8, 2015, 2:59 p.m., Till Toenshoff wrote:
3rdparty/libprocess/include/process/time.hpp, line 150
https://reviews.apache.org/r/34703/diff/3/?file=974298#file974298line150
Lets think about a good replacement for that class name to make it
intuitive - first thing that came
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87028
---
3rdparty/libprocess/include/process/time.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87013
---
Looks pretty good. I just am unsure about the class naming - the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/
---
(Updated May 29, 2015, 2:59 p.m.)
Review request for mesos, Bernd Mathiske,
On May 28, 2015, 7:49 a.m., Nikita Vetoshkin wrote:
3rdparty/libprocess/include/process/time.hpp, line 109
https://reviews.apache.org/r/34703/diff/2/?file=972867#file972867line109
Can I add one more nitpick? If we make `WEEK_DAYS` and `MONTHS`
`static` then will put only array
On May 28, 2015, 5:49 a.m., Nikita Vetoshkin wrote:
3rdparty/libprocess/include/process/time.hpp, line 109
https://reviews.apache.org/r/34703/diff/2/?file=972867#file972867line109
Can I add one more nitpick? If we make `WEEK_DAYS` and `MONTHS`
`static` then will put only array
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review85380
---
3rdparty/libprocess/include/process/time.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/
---
(Updated May 27, 2015, 4:48 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review85364
---
Patch looks great!
Reviews applied: [34392, 34703]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review85514
---
3rdparty/libprocess/include/process/time.hpp
19 matches
Mail list logo
