Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review112665 --- Ship it! - Joris Van Remoortere On Dec. 22, 2015, 9:40 a.m.,

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Dec. 21, 2015, 10:22 p.m., Guangya Liu wrote: > > I assume that you will have another RR to cover the unit test, right? Yes, just updated the description (as we removed the dependency and there is no next review anymore). Thanks! - Joerg

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review111596 --- Ship it! Ship It! - Guangya Liu On 十二月 22, 2015, 9:40 a.m.,

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Dec. 22, 2015, 9:40 a.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Dec. 22, 2015, 8:38 a.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Dec. 21, 2015, 7:02 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review111547 --- Ship it! I assume that you will have another RR to cover the unit

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review111565 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Dec. 21, 2015, 2:56 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review111507 --- Ship it! src/master/master.hpp (line 945)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Dec. 16, 2015, 9:34 a.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 25, 2015, 3:50 p.m., Alexander Rukletsov wrote: > > Please adjust the JIRA ticket: MESOS-4013. Done. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review108007

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review108007 --- Please adjust the JIRA ticket: MESOS-4013. - Alexander Rukletsov

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 19, 2015, 10:39 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 195 > > > > > > Am I right that there is another way to achieve the same: > > ``` > >

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 19, 2015, 12:43 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review107157 --- include/mesos/quota/quota.proto (line 56)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 19, 2015, 3:19 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review107185 --- src/master/quota_handler.cpp (line 347)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 19, 2015, 2:53 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 338 > > > > > > s/Status/status > > Do you think it makes sense to add `request.body`. > > Joerg Schad wrote: >

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 19, 2015, 4:06 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 19, 2015, 2:53 p.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 338 > > > > > > s/Status/status > > Do you think it makes sense to add `request.body`. Considered adding request

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 19, 2015, 10:39 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, line 195 > > > > > > Am I right that there is another way to achieve the same: > > ``` > >

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Nov. 16, 2015, 7:01 p.m., Joseph Wu wrote: > > include/mesos/quota/quota.proto, lines 54-57 > > > > > > I noticed that the other endpoints do not take `QuotaInfo` objects; but > > instead take a `Resources`

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Nov. 16, 2015, 1:13 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review106701 --- include/mesos/quota/quota.proto (lines 54 - 57)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review106541 --- src/master/quota_handler.cpp (line 239)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review105340 --- src/master/quota_handler.cpp (line 239)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

> On Oct. 25, 2015, 3:28 a.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, line 237 > > > > > > Can you please add a new test case for this? You can refer to > >

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review103928 --- Where did you set this endpoint of quota?

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review103934 --- src/master/quota_handler.cpp (line 246)

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Oct. 23, 2015, 10:34 p.m.) Review request for mesos, Alexander

Re: Review Request 39492: Added status endpoint for quota master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/ --- (Updated Oct. 23, 2015, 9:32 p.m.) Review request for mesos, Alexander