Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 5, 2016, 4:46 a.m., Ben Mahler wrote: > > src/master/allocator/mesos/metrics.cpp, lines 17-21 > > > > > > Any reason for the unusual ordering? The reason for this is an agreement that we include the .hpp

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review122176 --- Fix it, then Ship it! I like the idea of making this more

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121904 --- Ship it! src/master/allocator/mesos/metrics.hpp (line 26)

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 3, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 29 > > > > > > Maybe make it a struct? > > Benjamin Bannier wrote: > I am not sure why that would be

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review122040 --- Ship it! Ship It! - Alexander Rukletsov On March 3, 2016,

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 3, 2016, 3:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 29 > > > > > > Maybe make it a struct? I am not sure why that would be useful; also, it is defined as a

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 3, 2016, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, lines 28-30 > > > > > > I actually don't think we should wright this obvious comment here, but > > maybe there

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121861 --- src/master/allocator/mesos/metrics.hpp (line 29)

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121840 --- src/Makefile.am (line 632)

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 12:37 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 23 > > > > > > s/ > s/>/" > > > > We use <> only for "library" or public includes: libprocess,

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 11:37 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 23 > > > > > > s/ > s/>/" > > > > We use <> only for "library" or public includes: libprocess,

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 11:37 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 43 > > > > > > Is it what clnag-format suggest? I doubt it : ) > > Benjamin Bannier wrote: > Yes,

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 1:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 2, 2016, 6:49 p.m.) Review request for mesos, Alexander

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 2:58 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 37 > > > > > > You don't really need to call `.self()` here, there exists an `defer` > > override taking

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

> On March 2, 2016, 12:37 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 43 > > > > > > Is it what clnag-format suggest? I doubt it : ) Yes, that's indeed what it suggests, at

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121638 --- src/master/allocator/mesos/metrics.hpp (line 37)

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121624 --- src/master/allocator/mesos/metrics.hpp (line 23)

Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4718