Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-10-17 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated Oct. 17, 2016, 5:24 p.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-10-17 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review152882 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:59

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-10-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated Oct. 6, 2016, 4:59 p.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-09-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated Sept. 29, 2016, 2:55 p.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-08-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review145534 --- Bad patch! Reviews applied: [46825, 46824, 46823, 46822, 46821]

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-08-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated Aug. 11, 2016, 6:32 p.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review140768 --- Patch looks great! Reviews applied: [46821, 46822, 46823, 46824,

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated July 5, 2016, 10:58 a.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-05 Thread Benjamin Bannier
> On May 11, 2016, 11:38 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 147-179 > > > > > > do we even need these overloads anymore? can't we just use the

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated July 5, 2016, 1:13 a.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review140647 --- Patch looks great! Reviews applied: [46821, 46822, 46823, 46824,

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated July 4, 2016, 10:17 a.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review140597 --- Patch looks great! Reviews applied: [46821, 46822, 46823, 46824,

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-07-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated July 3, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-05-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review132753 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-04-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review131093 --- Patch looks great! Reviews applied: [46821, 46822, 46823, 46824,

Review Request 46825: Fully-typed all FlagsBase::add overloads.

2016-04-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-3335