Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142104 --- Ship it! I committed this patch and helped address some style

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-13 Thread Gilbert Song
> On July 13, 2016, 11 a.m., Gilbert Song wrote: > > src/tests/containerizer/appc_spec_tests.cpp, lines 227-228 > > > > > > ``` > > EXPECT_EQ( > > imageManifest->annotations(0).value(), > >

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142087 --- Fix it, then Ship it!

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142025 --- src/tests/containerizer/appc_spec_tests.cpp (lines 77 - 80)

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated July 12, 2016, 4:14 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-11 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated July 12, 2016, 4:38 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-06 Thread Guangya Liu
> On July 5, 2016, 4:47 p.m., Gilbert Song wrote: > > src/tests/containerizer/appc_spec_tests.cpp, line 80 > > > > > > We should firstly check `has_workingDirectory()` right? Otherwise, it > > may segfault if not

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-07-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review140808 --- Thanks, Srini! This patch looks good to me. Please address my

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-06-30 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated June 30, 2016, 6 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-06-29 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated June 30, 2016, 5:38 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-06-28 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated June 28, 2016, 10:13 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-06-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review139777 --- src/Makefile.am (lines 2097 - 2098)

Re: Review Request 49208: Added tests to check if appc spec is properly parsed.

2016-06-27 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/ --- (Updated June 28, 2016, 5:05 a.m.) Review request for mesos, Gilbert Song and