---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/
---
Review request for mesos and Till Toenshoff.
Bugs: MESOS-2871
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/#review89475
---
Ship it!
Ship It!
- Adam B
On June 26, 2015, 12:47 a.m., Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/#review89476
---
Ship it!
Ship It!
- Kapil Arya
On June 26, 2015, 3:47 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/
---
(Updated June 26, 2015, 12:47 a.m.)
Review request for mesos, Adam B, Till
On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
docs/reservation.md, line 25
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25
existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0?
I went with `introduced in 0.14.0` instead.
- Michael
On May 11, 2015, 9:51 a.m., Joerg Schad wrote:
docs/reservation.md, line 25
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25
s/existed prior/available since version x.x.x?
I went with `introduced in 0.14.0` here.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35919/
---
(Updated June 26, 2015, 12:18 p.m.)
Review request for mesos, Adam B and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 4:04 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35927/
---
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-2035
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89512
---
Patch looks great!
Reviews applied: [32982]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/#review89503
---
Ship it!
Ship It!
- Michael Park
On June 26, 2015, 1:12 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/
---
(Updated June 26, 2015, 3:24 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 3:36 p.m.)
Review request for mesos, Alexander
On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
docs/reservation.md, line 243
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line243
What happens if you try to unreserve a reservation that is being used
right now?
The reason why we go through the offer cycle is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 6:12 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/#review89534
---
Ship it!
3rdparty/libprocess/include/process/http.hpp (line 444)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89538
---
I made a minor naming comment, which I'll get cleaned up for you.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35927/#review89518
---
Patch looks great!
Reviews applied: [35927]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/
---
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35757/
---
(Updated June 26, 2015, 5:38 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89532
---
Patch looks great!
Reviews applied: [32982]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 6:13 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35934/
---
(Updated June 26, 2015, 6:30 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 5:04 p.m.)
Review request for mesos, Alexander
On June 25, 2015, 10:35 p.m., Kapil Arya wrote:
The ordering parts looks good. Should we also fix the differentiation
between `#include stout/os.hpp` and `#include os.hpp`?
I would prefer to not make any changes here that are not required by the style
guide or cannot be automatically
On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
docs/reservation.md, line 168
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line168
state of the recources - what does this mean?
Suggestion: resource specifications
I've updated this to:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 8:43 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review89559
---
Ship it!
docs/mesos-c++-style-guide.md (line 535)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35910/#review89565
---
Just a question: what do we mean by a pure client here?
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35935/
---
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-2941
On June 26, 2015, 11:44 a.m., Ben Mahler wrote:
I made a minor naming comment, which I'll get cleaned up for you.
Is there a plan to consistently add reserved and unreserved to the other
resources? e.g. used and offered.
Curious if you thought about how to express volumes as well?
On May 8, 2015, 7:02 p.m., Timothy Chen wrote:
docs/reservation.md, line 79
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line79
A notable difference between static reservation is the principal here,
are you going to cover that?
Thanks for bringing this up!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35943/#review89572
---
Ship it!
Ship It!
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 4:54 p.m.)
Review request for mesos, Alexander
On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
docs/reservation.md, line 71
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line71
this seems to imply that in the Request, the `slave_id` is some part of
a form submission:
```
-d, --data data
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35943/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35912/
---
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-2940
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35910/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35911/
---
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-2940
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35914/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-1988
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35909/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89562
---
Patch looks great!
Reviews applied: [32982]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35943/#review89564
---
Ship it!
Ship It!
- Michael Park
On June 26, 2015, 9:11 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35909/#review89563
---
Ship it!
Ship It!
- Michael Park
On June 26, 2015, 9:11 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35914/#review89571
---
Ship it!
Ship It!
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35909/#review89568
---
Ship it!
Ship It!
- Vinod Kone
On June 26, 2015, 9:11 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35939/#review89547
---
Patch looks great!
Reviews applied: [35934, 35939]
All tests
On May 11, 2015, 9:51 a.m., Joerg Schad wrote:
docs/reservation.md, line 25
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25
s/existed prior/available since version x.x.x?
Michael Park wrote:
I went with `introduced in 0.14.0` here.
Actually decided
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35939/
---
Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and
On June 26, 2015, 6:44 p.m., Ben Mahler wrote:
src/common/http.cpp, line 84
https://reviews.apache.org/r/35717/diff/4/?file=989671#file989671line84
How about calling this 'roleResources' to be clear that this is a role
breakdown, rather than say, a type, name, etc breakdown?
On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
docs/reservation.md, line 71
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line71
this seems to imply that in the Request, the `slave_id` is some part of
a form submission:
```
-d, --data data
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review89551
---
Patch looks great!
Reviews applied: [32982]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 8:35 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35939/#review89543
---
Ship it!
Ship It!
- Marco Massenzio
On June 26, 2015, 6:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35939/#review89546
---
Ship it!
Ship It!
- Michael Park
On June 26, 2015, 6:58 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 7:53 p.m.)
Review request for mesos, Alexander
On May 13, 2015, 11:16 p.m., Bernd Mathiske wrote:
docs/reservation.md, line 95
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line95
This sentence does not strictly add any information. It is more likely
confusing. What does it mean to convert a resource? I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 26, 2015, 8:33 p.m.)
Review request for mesos, Alexander
On May 13, 2015, 10:25 p.m., Marco Massenzio wrote:
docs/reservation.md, lines 97-100
https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line97
Let us please add at least a suggestion of the possible error codes
(and a couple Response bodies) here too - at least
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated June 26, 2015, 3:12 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35919/
---
Review request for mesos, Adam B and Till Toenshoff.
Bugs: MESOS-2877
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35958/
---
Review request for mesos and Ben Mahler.
Repository: mesos
Description
On June 3, 2015, 2:24 p.m., Ben Mahler wrote:
src/tests/partition_tests.cpp, lines 647-650
https://reviews.apache.org/r/29507/diff/7/?file=973888#file973888line647
This sounds like testing two particular behaviors in a single test:
(1) A registered slave that never
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review89597
---
Patch looks great!
Reviews applied: [35799]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35962/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35889/
---
(Updated June 27, 2015, 1:18 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/
---
Review request for mesos, Adam B and Ben Whitehead.
Bugs: MESOS-1552
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35935/#review89598
---
Bad patch!
Reviews applied: [35909, 35914, 35943, 35910, 35911]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35962/#review89599
---
Ship it!
Ship It!
- Benjamin Hindman
On June 27, 2015, 1:18
On June 25, 2015, 1:41 a.m., Ben Mahler wrote:
Actually, we should think about one more thing, how does this interact with
the zookeeper session timeout?
Adam B wrote:
The hardcoded individual ping timeout (15secs) was previously longer than
the default zk session timeout
On June 26, 2015, 9:23 p.m., Michael Park wrote:
Just a question: what do we mean by a pure client here?
Before we figured out that HTTP API was a better name, we used to call it
pure as in the clients don't need libmesos pulled in. Removed the reference
to pure here :)
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35889/
---
(Updated June 27, 2015, 1:29 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35889/#review89603
---
Ship it!
3rdparty/libprocess/src/tests/ssl_client.cpp (line 60)
On June 26, 2015, 6:30 p.m., Ben Whitehead wrote:
Ship It!
Downloaded patch, applied, configure make, Manual Verification.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/#review89605
---
Ship it!
Ship It!
- Ben Whitehead
On June 26, 2015, 6:18 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35958/#review89609
---
Patch looks great!
Reviews applied: [29507, 35958]
All tests
On June 26, 2015, 9:23 p.m., Michael Park wrote:
Just a question: what do we mean by a pure client here?
Ben Mahler wrote:
Before we figured out that HTTP API was a better name, we used to call it
pure as in the clients don't need libmesos pulled in. Removed the reference
to pure
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35955/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review89595
---
Patch looks great!
Reviews applied: [35934, 35939, 35947, 35702]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35910/#review89573
---
src/exec/exec.cpp (line 492)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89577
---
include/mesos/mesos.proto (lines 1212 - 1214)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated June 26, 2015, 10:55 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35947/
---
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35911/
---
(Updated June 27, 2015, 12:36 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35912/
---
(Updated June 27, 2015, 12:37 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35935/
---
(Updated June 27, 2015, 12:37 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35910/
---
(Updated June 27, 2015, 12:36 a.m.)
Review request for mesos and Vinod Kone.
On June 26, 2015, 9:44 p.m., Vinod Kone wrote:
src/exec/exec.cpp, lines 496-497
https://reviews.apache.org/r/35910/diff/1/?file=993586#file993586line496
s/create/overwrite/
s/pure clients/HTTP API/
Can you move this down to #514 where we also overwrite
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated June 26, 2015, 10:56 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated June 26, 2015, 10:55 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/
---
(Updated June 26, 2015, 11:26 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review89588
---
Patch looks great!
Reviews applied: [34835]
All tests passed.
-
On June 26, 2015, 9:44 p.m., Vinod Kone wrote:
src/exec/exec.cpp, lines 496-497
https://reviews.apache.org/r/35910/diff/1/?file=993586#file993586line496
s/create/overwrite/
s/pure clients/HTTP API/
Can you move this down to #514 where we also overwrite
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35912/#review89581
---
Ship it!
src/common/protobuf_utils.hpp (line 45)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35935/#review89583
---
src/tests/reconciliation_tests.cpp (lines 905 - 908)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated June 27, 2015, 2:23 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 27, 2015, 2:32 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35919/#review89483
---
Patch looks great!
Reviews applied: [35919]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/#review89488
---
Patch looks great!
Reviews applied: [35920]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/
---
Review request for mesos, Bernd Mathiske and Timothy Chen.
Repository: mesos
1 - 100 of 104 matches
Mail list logo
