Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

> On Oct. 7, 2015, 7:41 a.m., Bernd Mathiske wrote: > > src/master/quota_handler.cpp, line 74 > > > > > > Again, we could output more info here. > > Alexander Rukletsov wrote: > What exactly? I checked the error

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 6:19 a.m.) Review request for mesos, Adam B, Joris Van R

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 6:18 a.m.) Review request for mesos, Benjamin Hindman, J

Re: Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/#review105488 --- As discussed, let's re-iterate on the actual function / signature.

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote: > > src/tests/master_quota_tests.cpp, lines 110-112 > > > > > > The resource string you have is equivalent to the resource string from > > `CreateSlaveFlags`. Is ther

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

> On Nov. 3, 2015, 7:14 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, line 237 > > > > > > move to upper line? That's what `clang-format` suggests. Also, I think it's slightly readable this way.

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39592/ --- (Updated Nov. 9, 2015, 1:37 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39591/ --- (Updated Nov. 9, 2015, 1:37 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 39590: Made license-headers doxygen-compatible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39590/ --- (Updated Nov. 9, 2015, 1:37 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

> On Oct. 8, 2015, 10:21 a.m., Bernd Mathiske wrote: > > src/tests/master_quota_tests.cpp, line 132 > > > > > > How about adding each test function and have it do nothing, with a TODO > > inside, but with a comment

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

> On Nov. 5, 2015, 10:48 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 166-168 > > > > > > I checked the codepaths for `Operation::RESERVE` and apparently there's > > nothing preventing you from re

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

> On Nov. 4, 2015, 2:44 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 164 > > > > > > Do we want to filter out the slave which is not active (slave->active > > == false)? I think it makes sense to

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

> On Nov. 3, 2015, 5:52 a.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, lines 159-186 > > > > > > How to handle the following cases? Say two roles request quota: r1 and > > r2. > > > > When r1 r

Re: Review Request 39595: Took mtime into account in the fetcher cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105587 --- src/hdfs/hdfs.hpp (lines 204 - 208)

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

> On Oct. 13, 2015, 3:35 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, line 60 > > > > > > Should we follow the pattern of other validation routines where we use > > the validation namespace and

Re: Review Request 39947: Refactored mock allocator into a separate header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39947/#review105670 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 5, 2015, 12:56

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

> On Oct. 6, 2015, 12:40 p.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, line 65 > > > > > > Just as early comments: What about PUT and DELETE? > > Alexander Rukletsov wrote: > See my comment in the su

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

> On Nov. 5, 2015, 8:24 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, line 52 > > > > > > I feel this shouldn't be left for later. I think I have to apologize for the confusion I create with this ticket.

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105668 --- Ship it! Ship It! - Klaus Ma On Nov. 9, 2015, 8:51 p.m., Joerg

Re: Review Request 39285: Added Quota Request Validation.

> On Nov. 7, 2015, 12:19 a.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 140 > > > > > > Suggest to move it into the loop; if any role is not known by master, > > we did not need to continue to check ot

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 12:51 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105664 --- Bad patch! Reviews applied: [38705, 38883, 39410, 39420] Failed c

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 2:58 a.m.) Review request for mesos, Joris Van Remoorter

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 2:57 a.m.) Review request for mesos, Adam B, Joris Van R

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 2:57 a.m.) Review request for mesos, Benjamin Hindman, J

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Nov. 9, 2015, 2:52 a.m.) Review request for mesos, Benjamin Hindman, J

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Nov. 9, 2015, 10:15 a.m.) Review request for mesos, Bernd Mathiske, Jo

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not includ

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review105662 --- Bad patch! Reviews applied: [38705, 38883, 39410, 39420] Failed c

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review105661 --- Patch looks great! Reviews applied: [37168] All tests passed. -

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/ --- (Updated Nov. 9, 2015, 12:30 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 12:30 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/ --- (Updated Nov. 9, 2015, 12:29 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Nov. 9, 2015, 12:28 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 39285: Added Quota Request Validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 8:16 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 9, 2015, 8:15 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

> On Oct. 6, 2015, 7:12 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 120-123 > > > > > > `reserveResources` returns an error when there are not enough resources > > available.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Nov. 9, 2015, 4:10 p.m.) Review request for mesos and Michael Park.

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review105659 --- Bad patch! Reviews applied: [38747] Failed command: ./support/app

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

> On Nov. 6, 2015, 2:58 p.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 1 > > > > > > It seems other feature named file without "_handler"; any consideration > > for it? In this case the file acutally o

<    1   2