Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/#review106604
---

Ship it!



3rdparty/libprocess/3rdparty/Makefile.am (line 212)


I think the emphasis is slightly off here; we aren't working around noisy 
warnings (which are all valid), but the fact that these warnings are useless to 
us as we have no intention of fixing them. I'd also drop the ref to the jira 
issue since it can be reached via the commit message.

How about:

> We use "-isystem" instead of "-I" to add Boost to the include search 
path. This disables compiler warnings inside Boost headers since we have no 
intention of fixing those.



3rdparty/libprocess/3rdparty/Makefile.am (line 216)


I think it would make sense to also update the mesos `CMakeLists.txt`.



3rdparty/libprocess/Makefile.am (line 89)


I think the emphasis is slightly off here; we aren't working around noisy 
warnings (which are all valid), but the fact that these warnings are useless to 
us as we have no intention of fixing them. I'd also drop the ref to the jira 
issue since it can be reached via the commit message.

How about:

> We use "-isystem" instead of "-I" to add Boost to the include search 
path. This disables compiler warnings inside Boost headers since we have no 
intention of fixing those.



3rdparty/libprocess/Makefile.am (line 92)


I think it would make sense to also update the mesos `CMakeLists.txt`.



3rdparty/libprocess/configure.ac (line 207)


I think the emphasis is slightly off here; we aren't working around noisy 
warnings (which are all valid), but the fact that these warnings are useless to 
us as we have no intention of fixing them. I'd also drop the ref to the jira 
issue since it can be reached via the commit message.

How about:

> We use "-isystem" instead of "-I" to add Boost to the include search 
path. This disables compiler warnings inside Boost headers since we have no 
intention of fixing those.


- Benjamin Bannier


On Nov. 15, 2015, 10:30 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40326/
> ---
> 
> (Updated Nov. 15, 2015, 10:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
> 
> Diff: https://reviews.apache.org/r/40326/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40327: mesos: Marked Boost as a "system" header.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40327/#review106603
---

Ship it!



src/Makefile.am (lines 108 - 109)


I think the emphasis is slightly off here; we aren't working around noisy 
warnings (which are all valid), but the fact that these warnings are useless to 
us as we have no intention of fixing them. I'd also drop the ref to the jira 
issue since it can be reached via the commit message.

How about:

> We use "-isystem" instead of "-I" to add Boost to the include search 
path. This disables compiler warnings inside Boost headers since we have no 
intention of fixing those.



src/Makefile.am (line 110)


I think it would make sense to also update the mesos `CMakeLists.txt`.


- Benjamin Bannier


On Nov. 15, 2015, 10:31 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40327/
> ---
> 
> (Updated Nov. 15, 2015, 10:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
> 
> Diff: https://reviews.apache.org/r/40327/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40339: WIP: Added a flag to master to enable optimistic offers.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/
---

(Updated Nov. 16, 2015, 8:18 a.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Summary (updated)
-

WIP: Added a flag to master to enable optimistic offers.


Bugs: MESOS-3887
https://issues.apache.org/jira/browse/MESOS-3887


Repository: mesos


Description
---

Added a flag to master to enable optimistic offers.


Diffs
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
cd3c7019952bfe7c1049a9c42a90943b681f1939 
  src/master/allocator/mesos/hierarchical.cpp 
e9286260f490915327f44492086c1160d5567ac5 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 

Diff: https://reviews.apache.org/r/40339/diff/


Testing
---


Thanks,

Guangya Liu

Review Request 40195: Changed commit hook linting to ignore empty diffs.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40195/
---

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

On Windows, if you attempt to commit an empty changeset, the commit hooks will
attempt to lint the entire repository. This is because we pass blank arguments
to the call to `xargs` that kicks off the C++ linter (e.g., in
`support/pre-commit`). In the git bash, the default behavior of blank arguments
is *not* to ignore them, as it is on certain other platforms.

Thus, we pass the `-r` flag in explicitly to `xargs`, which causes us to ignore
whitespace-only calls to `xargs`. This will remove the whole-repository linting
problem altogether.


Diffs
-

  support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
  support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 

Diff: https://reviews.apache.org/r/40195/diff/


Testing
---

Branches tested manually.


Thanks,

Alex Clemmer

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40131/
---

(Updated Nov. 16, 2015, 8:30 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.


Diffs (updated)
-

  bootstrap.bat PRE-CREATION 

Diff: https://reviews.apache.org/r/40131/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40131/
---

(Updated Nov. 16, 2015, 8:30 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.


Diffs
-

  bootstrap.bat PRE-CREATION 

Diff: https://reviews.apache.org/r/40131/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 40131: Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.

[Alex Clemmer]

> On Nov. 11, 2015, 9:47 p.m., Joseph Wu wrote:
> > bootstrap.bat, line 40
> > 
> >
> > `mklink` only works with the Windows command prompt, run as an 
> > administrator.  Is that correct?
> > 
> > (At least, I don't think the command exists in other Windows shells, 
> > like PowerShell.)

That's mostly correct, yes: we do not assume the user has PowerShell right now, 
and we do assume the shell running this is `cmd.exe`.

The symlink thing is a bit more subtle, though: creating symlinks in general 
requires the `SeCreateSymbolicLinkPrivilege` privilege, which is by default 
only granted to administrators. This need not be the case, though.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40131/#review106154
---


On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40131/
> ---
> 
> (Updated Nov. 16, 2015, 8:30 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.
> 
> 
> Diffs
> -
> 
>   bootstrap.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

[Neil Conway]

> On Nov. 16, 2015, 8:02 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 216
> > 
> >
> > I think it would make sense to also update the mesos `CMakeLists.txt`.

We should, but it requires some other changes -- we want to do 
`include_directories(SYSTEM ...)` in CMake, but that isn't trivial because 
right now all the include paths are collected into a single variable and then 
passed to `include_directories()`. I'm inclined to leave this for a subsequent 
patch (CMake still needs fixes for `-Wno-unused-local-typedef` anyway.)


> On Nov. 16, 2015, 8:02 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 212
> > 
> >
> > I think the emphasis is slightly off here; we aren't working around 
> > noisy warnings (which are all valid), but the fact that these warnings are 
> > useless to us as we have no intention of fixing them. I'd also drop the ref 
> > to the jira issue since it can be reached via the commit message.
> > 
> > How about:
> > 
> > > We use "-isystem" instead of "-I" to add Boost to the include search 
> > path. This disables compiler warnings inside Boost headers since we have no 
> > intention of fixing those.

Thanks, fixed. I used this text:

```We use "-isystem" instead of "-I" to add Boost to the include search path. 
This disables compiler warnings inside Boost headers since we can't easily fix 
them. See MESOS-3799.```


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/#review106604
---


On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40326/
> ---
> 
> (Updated Nov. 16, 2015, 8:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
> 
> Diff: https://reviews.apache.org/r/40326/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/
---

(Updated Nov. 16, 2015, 8:47 a.m.)


Review request for mesos, Benjamin Bannier and Joris Van Remoortere.


Changes
---

Tweak comment wording.


Bugs: MESOS-3799
https://issues.apache.org/jira/browse/MESOS-3799


Repository: mesos


Description
---

This instructs the compiler to ignore warnings in the Boost headers. This is
useful, because those headers often contain hard-to-silence warnings that are
not otherwise useful to display. See MESOS-3799.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
0adbe539afaf683e4a85582463a2930049a63998 
  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 

Diff: https://reviews.apache.org/r/40326/diff/


Testing
---

Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.

Note that the cmake build still emits boost-related warnings: I didn't try to 
fix this, since cmake emits other warnings that autotools suppresses (e.g., 
no-unused-local-typedefs).


Thanks,

Neil Conway

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

[Neil Conway]

> On Nov. 16, 2015, 7:55 a.m., Joerg Schad wrote:
> > 3rdparty/libprocess/configure.ac, line 211
> > 
> >
> > Should we add this to the CMake files as well?

We should, but it requires some other changes -- we want to do 
`include_directories(SYSTEM ...)` in CMake, but that isn't trivial because 
right now all the include paths are collected into a single variable and then 
passed to `include_directories()`. I'm inclined to leave this for a subsequent 
patch (CMake still needs fixes for `-Wno-unused-local-typedef` anyway.)


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/#review106602
---


On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40326/
> ---
> 
> (Updated Nov. 16, 2015, 8:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
> 
> Diff: https://reviews.apache.org/r/40326/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40327: mesos: Marked Boost as a "system" header.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40327/
---

(Updated Nov. 16, 2015, 8:48 a.m.)


Review request for mesos, Benjamin Bannier and Joris Van Remoortere.


Changes
---

Tweak comment wording.


Bugs: MESOS-3799
https://issues.apache.org/jira/browse/MESOS-3799


Repository: mesos


Description
---

This instructs the compiler to ignore warnings in the Boost headers. This is
useful, because those headers often contain hard-to-silence warnings that are
not otherwise useful to display. See MESOS-3799.


Diffs (updated)
-

  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 

Diff: https://reviews.apache.org/r/40327/diff/


Testing
---

Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.

Note that the cmake build still emits boost-related warnings: I didn't try to 
fix this, since cmake emits other warnings that autotools suppresses (e.g., 
no-unused-local-typedefs).


Thanks,

Neil Conway

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

[Joerg Schad]

> On Nov. 16, 2015, 7:55 a.m., Joerg Schad wrote:
> > 3rdparty/libprocess/configure.ac, line 211
> > 
> >
> > Should we add this to the CMake files as well?
> 
> Neil Conway wrote:
> We should, but it requires some other changes -- we want to do 
> `include_directories(SYSTEM ...)` in CMake, but that isn't trivial because 
> right now all the include paths are collected into a single variable and then 
> passed to `include_directories()`. I'm inclined to leave this for a 
> subsequent patch (CMake still needs fixes for `-Wno-unused-local-typedef` 
> anyway.)

Thanks! We could document these intentions by a todo or Jira...


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/#review106602
---


On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40326/
> ---
> 
> (Updated Nov. 16, 2015, 8:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
> 
> Diff: https://reviews.apache.org/r/40326/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/#review106614
---

Ship it!


Ship It!

- Joerg Schad


On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40326/
> ---
> 
> (Updated Nov. 16, 2015, 8:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
> 
> Diff: https://reviews.apache.org/r/40326/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40327: mesos: Marked Boost as a "system" header.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40327/#review106613
---

Ship it!


Ship It!

- Joerg Schad


On Nov. 16, 2015, 8:48 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40327/
> ---
> 
> (Updated Nov. 16, 2015, 8:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
> 
> Diff: https://reviews.apache.org/r/40327/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39800: Fix HDFS du output parsing.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39800/#review106615
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 13, 2015, 9:38 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39800/
> ---
> 
> (Updated Nov. 13, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, haosdent huang, and Timothy Chen.
> 
> 
> Bugs: MESOS-3605
> https://issues.apache.org/jira/browse/MESOS-3605
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Swallow WARN log messages unless the command failed or we could
>not parse the output.
>  - Make the actual du output parsing more reliable by not using
>human-readable format, scanning all the output lines, and
>tokenizing rather than splitting the output lines.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/39800/diff/
> 
> 
> Testing
> ---
> 
> make check. Manual testing with a framework that uses the fetcher with HDFS 
> urls.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40326: libprocess: Marked Boost as a "system" header.

[Neil Conway]

> On Nov. 16, 2015, 7:55 a.m., Joerg Schad wrote:
> > 3rdparty/libprocess/configure.ac, line 211
> > 
> >
> > Should we add this to the CMake files as well?
> 
> Neil Conway wrote:
> We should, but it requires some other changes -- we want to do 
> `include_directories(SYSTEM ...)` in CMake, but that isn't trivial because 
> right now all the include paths are collected into a single variable and then 
> passed to `include_directories()`. I'm inclined to leave this for a 
> subsequent patch (CMake still needs fixes for `-Wno-unused-local-typedef` 
> anyway.)
> 
> Joerg Schad wrote:
> Thanks! We could document these intentions by a todo or Jira...

Sounds good, I opened https://issues.apache.org/jira/browse/MESOS-3932 for this.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40326/#review106602
---


On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40326/
> ---
> 
> (Updated Nov. 16, 2015, 8:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
> https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
> 
> Diff: https://reviews.apache.org/r/40326/diff/
> 
> 
> Testing
> ---
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to 
> fix this, since cmake emits other warnings that autotools suppresses (e.g., 
> no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 38059: Quota: Created a bare pipeline for quota set requests.

[Alexander Rukletsov]

> On Nov. 13, 2015, 10:32 a.m., Bernd Mathiske wrote:
> > src/master/master.hpp, line 1983
> > 
> >
> > Suggestion: move this to the end of the struct, ca. line 1983 and 
> > change the comment to this.
> > 
> > "NOTE: There is no direct representation of quota information here to 
> > support that the operator can associate quota (by name) with a role before 
> > the role is created. Such ordering of operator requests prevents a race of 
> > premature unbounded allocation that setting quota first is intended to 
> > contain. The dynamic role/quota relation is administrated by the master 
> > instance."

Thanks a lot! I'm going to resolve it later.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review106391
---


On Nov. 10, 2015, 4:19 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> ---
> 
> (Updated Nov. 10, 2015, 4:19 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
>   src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39560/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Add state.cpp, flags.cpp to Windows agent build.


Diffs (updated)
-

  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 

Diff: https://reviews.apache.org/r/39560/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Windows: Added dirent compat code for non-Unix systems.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39019/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, 
MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693


Repository: mesos


Description
---

Windows: Added support for `slave/state.cpp`.


Diffs (updated)
-

  src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a 
  src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135 

Diff: https://reviews.apache.org/r/39219/diff/


Testing
---

Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 
15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.


Thanks,

Alex Clemmer

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::mkdtemp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d 

Diff: https://reviews.apache.org/r/39559/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39623/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Added protobuf compilation to Windows builds.


Diffs (updated)
-

  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 

Diff: https://reviews.apache.org/r/39623/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Included headers to make `stout/windows.hpp` standalone.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39620/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39583/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Added `WindowsError` to parallel `ErrnoError`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
fdd33512c8d8752093f72f597a7d647eb5e3c285 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39583/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39802/
---

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `stout/os/windows/ls.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ls.hpp 
5b6fba13ce215af5801fd0867f6e774e100689ca 

Diff: https://reviews.apache.org/r/39802/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39621/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Corrected linking path for gmock libraries on Windows builds.


Diffs (updated)
-

  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
6eda46b0e08829b269b13a78f22510e6d03940d9 

Diff: https://reviews.apache.org/r/39621/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::rmdir.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d 

Diff: https://reviews.apache.org/r/39584/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39622/
---

(Updated Nov. 16, 2015, 9:13 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Pointed Stout test linker flags at correct gtest directory.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
9893d741cd7c611dc65eba76be03e06dac618132 

Diff: https://reviews.apache.org/r/39622/diff/


Testing
---

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH 
into my Ubuntu box to test this from Ubuntu


Thanks,

Alex Clemmer

Re: Review Request 39805: Moved filesystems tests to their own file.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39805/
---

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Moved filesystems tests to their own file.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
5a0ffc38d4194b9f9c53dc1cf0c90ca7bbae2afd 
  3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
141003cb36c44ee5fd56107726b7c80442521ca6 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
14fb644b38a5cbb8cde74aab39e84305f6ab7041 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
8791cfe628563b25ac86a8170966d458c3a9c0c8 

Diff: https://reviews.apache.org/r/39805/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39803/
---

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Implemented stout/os/stat.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp
 PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp 
675b2e712358a55b3580026936890eaf80e5af71 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39803/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/
---

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Process: Added headers to make `process/mime.hpp` standalone.


Diffs (updated)
-

  3rdparty/libprocess/include/process/mime.hpp 
decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 

Diff: https://reviews.apache.org/r/39850/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/
---

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: fixed ambiguousity error in `process/owned.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/owned.hpp 
1b41477d555ce567c58033f8993dc2ae0ac80a05 

Diff: https://reviews.apache.org/r/39851/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39834: Made `path_tests.cpp` standalone.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39834/
---

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Made `path_tests.cpp` standalone.

NB, more of these tests will move when `Hopcroft` is done with his 
`os::symlink` changeset.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
ad9ce324eaf940f68d04c6db7ba37d05efb1216a 

Diff: https://reviews.apache.org/r/39834/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/
---

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39804/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39888/
---

(Updated Nov. 16, 2015, 9:15 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

This code will be particularly useful when we expand Windows support for
`files/files.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39888/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39852/
---

(Updated Nov. 16, 2015, 9:15 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Replaced global `GetMessage` macro with inline function.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
1a7037d64afeedc340258c92067e95d1d3caa027 

Diff: https://reviews.apache.org/r/39852/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40102/
---

(Updated Nov. 16, 2015, 9:15 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3860
https://issues.apache.org/jira/browse/MESOS-3860


Repository: mesos


Description
---

Windows: Unified POSIX and Windows implementation of process.hpp.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/process.hpp 
99afbf8e9424b3644aaec2739bb3734bdaffbfde 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 
204acaf7836e8a516e10767cc9f9632bca352cce 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp 
e8238383c3c5feb688b10e37e544556ba9d43107 

Diff: https://reviews.apache.org/r/40102/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39889: Windows: Added support for `files/files.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/
---

(Updated Nov. 16, 2015, 9:15 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Added support for `files/files.hpp`.


Diffs (updated)
-

  src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9 

Diff: https://reviews.apache.org/r/39889/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40340/
---

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, Joseph Wu, and Marco Massenzio.


Repository: mesos


Description
---

Windows: Added Windows support to `support/post-reviews.py`.

Early draft of the update to the Windows-compatible `post-reviews.py`. I'd like 
to get early feedback from people in case this is entirely the wrong direction.

At the outset, I will say that the "right way" to do this would be to refactor 
`cppylint.py` and `post-reviews.py` entirely so that they are more modular (for 
example, make `post-reviews.py` function-oriented, instead of a pile of 
statements and expressions, and `cpplint.py` should be a module proper). I 
didn't do this the "right way" because it is blocking for our Windows friends. 
If it's really important to do this the "right way", we may need to break it 
into a couple reviews.

Note that the most questionable part of this is the point at which we redirect 
`stderr` in `cpplint.py` to a string capture it for use in `post-reviews.py`. 
This is certainly the quickest way to do it, but it is not the best -- the best 
way would be to refactor `cpplint.py` to be a module, at least, and to handle 
error logging in a more pluggable way. We aimed for the shortest diff because 
there are no tests for any of these scripts, and to be honest, I was afraid of 
changing them without tests.


Diffs
-

  .gitignore-template 90b6697d19a5e0a68805b23b587b362731a1df25 
  support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1 
  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
  support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 

Diff: https://reviews.apache.org/r/40340/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 40195: Changed commit hook linting to ignore empty diffs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40195/#review106621
---


Patch looks great!

Reviews applied: [40131, 40195]

All tests passed.

- Mesos ReviewBot


On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40195/
> ---
> 
> (Updated Nov. 16, 2015, 8:30 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On Windows, if you attempt to commit an empty changeset, the commit hooks will
> attempt to lint the entire repository. This is because we pass blank arguments
> to the call to `xargs` that kicks off the C++ linter (e.g., in
> `support/pre-commit`). In the git bash, the default behavior of blank 
> arguments
> is *not* to ignore them, as it is on certain other platforms.
> 
> Thus, we pass the `-r` flag in explicitly to `xargs`, which causes us to 
> ignore
> whitespace-only calls to `xargs`. This will remove the whole-repository 
> linting
> problem altogether.
> 
> 
> Diffs
> -
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
> 
> Diff: https://reviews.apache.org/r/40195/diff/
> 
> 
> Testing
> ---
> 
> Branches tested manually.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

[Alexander Rukletsov]

> On Nov. 15, 2015, 3:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 112-114
> > 
> >
> > Is this really necessary? If so let's add a comment.

I think yes since we do not rely on disconnected or inactive agents. Do you 
have a different opinion?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review106560
---


On Nov. 14, 2015, 3:44 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 14, 2015, 3:44 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performs a check whether a quota request is reasonable and can be satisfied 
> at the moment. A precise answer is impossible here, but a sanity check is 
> still helpful, because it allows us to filter knowingly unsatisfiable 
> requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40339: Added a flag to master to enable optimistic offers.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/
---

(Updated 十一月 16, 2015, 9:40 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Klaus Ma.


Summary (updated)
-

Added a flag to master to enable optimistic offers.


Bugs: MESOS-3887
https://issues.apache.org/jira/browse/MESOS-3887


Repository: mesos


Description
---

Added a flag to master to enable optimistic offers.


Diffs (updated)
-

  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  src/master/allocator/mesos/allocator.hpp 
d2d32af227d66c4030becd4cd64b907a70d25f49 
  src/master/allocator/mesos/hierarchical.hpp 
cd3c7019952bfe7c1049a9c42a90943b681f1939 
  src/master/allocator/mesos/hierarchical.cpp 
e9286260f490915327f44492086c1160d5567ac5 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
  src/tests/hierarchical_allocator_tests.cpp 
740cfa801ee90417c038308192d1f4f2416f8315 
  src/tests/master_allocator_tests.cpp 646cacd3e16b9e0b72c0b259eecf2760cfb530db 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
  src/tests/resource_offers_tests.cpp bf2fe3ac7b982e31d289a703ae637d8e2b3a2d8a 
  src/tests/slave_recovery_tests.cpp 2cc7132deb9b8c324aa9dbab0b81643d07377a89 

Diff: https://reviews.apache.org/r/40339/diff/


Testing (updated)
---

Ubuntu 14.04
make
make check


Thanks,

Guangya Liu

Re: Review Request 38110: Quota: Checked sanity of quota set requests.

[Alexander Rukletsov]

> On Nov. 15, 2015, 3:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 117-118
> > 
> >
> > This is a great comment. Can you also make it clear why we actually 
> > want to account for them?

Do you mean something like:
```
// In contrast to static
// reservations, dynamic reservations may be unreserved at any time,
// hence making resources available for quota'ed framewroks.
```


> On Nov. 15, 2015, 3:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, line 119
> > 
> >
> > Then we can rename this to `nonStaticAgentResources`. It might be so 
> > clear we can remove the first line of the comment above! :-)

A very good proposal, thanks!


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review106560
---


On Nov. 14, 2015, 3:44 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 14, 2015, 3:44 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Performs a check whether a quota request is reasonable and can be satisfied 
> at the moment. A precise answer is impossible here, but a sanity check is 
> still helpful, because it allows us to filter knowingly unsatisfiable 
> requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40136: Updated documentation on fetcher cache internals.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40136/#review106624
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 12, 2015, 12:26 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40136/
> ---
> 
> (Updated Nov. 12, 2015, 12:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3839
> https://issues.apache.org/jira/browse/MESOS-3839
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update the documentation for a fetcher cache behavior using both
> source file size and mtime information.
> 
> Also:
> * Remove outdated information regarding long supported fetcher cache
>   support for ftp/ftps.
> * Use png instead of jpeg for fetcher cache internal documentation.
>   Jpeg are designed to work well for compressing photos, but produce
>   artifacts for line art. Use a bitmap format instead.
> 
> 
> Diffs
> -
> 
>   docs/fetcher-cache-internals.md b71d225 
>   docs/fetcher.md 8e64341 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/fetch_components.png PRE-CREATION 
>   docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b 
>   docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7 
>   docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5 
>   docs/images/fetch_evict_1.png PRE-CREATION 
>   docs/images/fetch_evict_2.png PRE-CREATION 
>   docs/images/fetch_evict_3.png PRE-CREATION 
>   docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b 
>   docs/images/fetch_flow.png PRE-CREATION 
>   docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e 
>   docs/images/fetch_state.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40136/diff/
> 
> 
> Testing
> ---
> 
> Built and served with bundled site docker container,
> 
> % docker build support/site-docker
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/
---

(Updated Nov. 16, 2015, 10:48 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebasing.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

`ProcessManager::handle()` is a method used to process HTTP requests, its 
signature returns a boolean which is not used anywhere and it doesn't allow for 
asynchronous operations within handle.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp b45b5b14cc7868d73a6fe02c02b9baf8b44b891f 

Diff: https://reviews.apache.org/r/37998/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Nov. 16, 2015, 10:51 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Review changes.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the authenticator manager, which is a class which handles the actual 
authentication procedure during the execution of `ProcessManager::handle()` and 
it also takes care of the life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of 
this patch is to implement the manager and verify nothing breaks afterwards. 
Authenticator manager tests proper come in a latter patch.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/Makefile.am 
e6be2c4db121585bbe7f3c0627de048adc7cfb2c 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
28ce1928877084f0e1a73fdad789224c86e53f46 
  3rdparty/libprocess/include/process/http.hpp 
90c9be122ee0c402b806d70fc818e3c03b15101a 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authentication_manager.hpp PRE-CREATION 
  3rdparty/libprocess/src/authentication_manager.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp b45b5b14cc7868d73a6fe02c02b9baf8b44b891f 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/
---

(Updated Nov. 16, 2015, 10:53 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Changes after review.


Bugs: MESOS-3233
https://issues.apache.org/jira/browse/MESOS-3233


Repository: mesos


Description
---

Adds functions which allows libprocess users to add handlers which require 
authentication as well as functions to install and remove authenticators.

Includes tests.


Diffs (updated)
-

  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/process.cpp b45b5b14cc7868d73a6fe02c02b9baf8b44b891f 
  3rdparty/libprocess/src/tests/http_tests.cpp 
5e70f1896a86104ac01dfe725eb4d7d1d25bee77 

Diff: https://reviews.apache.org/r/38000/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/
---

(Updated Nov. 16, 2015, 10:54 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Update for changes in the interface.


Bugs: MESOS-3232
https://issues.apache.org/jira/browse/MESOS-3232


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/http_tests.cpp 
5e70f1896a86104ac01dfe725eb4d7d1d25bee77 

Diff: https://reviews.apache.org/r/38094/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review106626
---



src/tests/module_tests.cpp (line 293)


This tests whether we can retrieve the parameters that were filled it back 
out. Unlike the tests above we don't test if the parameters actually get used 
in the module. I suggest adding a test that does this.


- Bernd Mathiske


On Nov. 9, 2015, 8:01 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Nov. 9, 2015, 8:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/examples/example_module_impl.cpp 
> db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review106628
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 9, 2015, 8:01 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Nov. 9, 2015, 8:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/examples/example_module_impl.cpp 
> db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Bernd Mathiske]

> On Nov. 16, 2015, 1:55 a.m., Bernd Mathiske wrote:
> > src/tests/module_tests.cpp, line 293
> > 
> >
> > This tests whether we can retrieve the parameters that were filled it 
> > back out. Unlike the tests above we don't test if the parameters actually 
> > get used in the module. I suggest adding a test that does this.

I see you only added parameters() to this particular test module. In this case, 
we have proof enough the parameters got where they need to be.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review106626
---


On Nov. 9, 2015, 8:01 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Nov. 9, 2015, 8:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/examples/example_module_impl.cpp 
> db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
---

(Updated Nov. 16, 2015, 11:01 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Changes
---

Changes to take into account changes in the interface in previous reviews.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 

Diff: https://reviews.apache.org/r/38950/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
---

(Updated Nov. 16, 2015, 11:06 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
Toenshoff.


Changes
---

Updates to take into account changes in the interface in previous patches.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP 
Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP 
authenticator with the libprocess one.
4. Updates one test which expected the wrong results since now credentials are 
checked before the body of the request.


Diffs (updated)
-

  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
  src/master/http.cpp f4ec23d74e203b2a8f2af187f0e56fbde7d9b3e5 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
---

(Updated Nov. 16, 2015, 11:08 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Changes
---

Update dependencies.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.


Diffs
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 

Diff: https://reviews.apache.org/r/38950/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/
---

(Updated Nov. 16, 2015, 11:08 a.m.)


Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
Toenshoff.


Changes
---

Removes unnecesary dependency.


Bugs: MESOS-3072
https://issues.apache.org/jira/browse/MESOS-3072


Repository: mesos


Description
---

Allows developers to provide their own parameters when loading modules instead 
of using the ones provided by the user when loading Mesos. This helps to deal 
with default modules (those used when the user doesn't provide any), and for 
testing of the modules.


Diffs
-

  src/examples/example_module_impl.cpp db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
  src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
  src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 

Diff: https://reviews.apache.org/r/38627/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 39991: fetcher should extract from .tar archive

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39991/#review106629
---

Ship it!


I believe the copy-n-paste should be fine here until we add a third test case; 
then would definitely be the time to got for a parametrized test.

- Benjamin Bannier


On Nov. 12, 2015, 1:47 a.m., Bhuvan Arumugam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39991/
> ---
> 
> (Updated Nov. 12, 2015, 1:47 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: mesos-2935
> https://issues.apache.org/jira/browse/mesos-2935
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> fetcher should extract from .tar archive
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 8fb6c83981a141df9c0a8a6f8267230bef64f218 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/39991/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40340/#review106630
---


Patch looks great!

Reviews applied: [40131, 40195, 40340]

All tests passed.

- Mesos ReviewBot


On Nov. 16, 2015, 9:25 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40340/
> ---
> 
> (Updated Nov. 16, 2015, 9:25 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, Joseph Wu, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added Windows support to `support/post-reviews.py`.
> 
> Early draft of the update to the Windows-compatible `post-reviews.py`. I'd 
> like to get early feedback from people in case this is entirely the wrong 
> direction.
> 
> At the outset, I will say that the "right way" to do this would be to 
> refactor `cppylint.py` and `post-reviews.py` entirely so that they are more 
> modular (for example, make `post-reviews.py` function-oriented, instead of a 
> pile of statements and expressions, and `cpplint.py` should be a module 
> proper). I didn't do this the "right way" because it is blocking for our 
> Windows friends. If it's really important to do this the "right way", we may 
> need to break it into a couple reviews.
> 
> Note that the most questionable part of this is the point at which we 
> redirect `stderr` in `cpplint.py` to a string capture it for use in 
> `post-reviews.py`. This is certainly the quickest way to do it, but it is not 
> the best -- the best way would be to refactor `cpplint.py` to be a module, at 
> least, and to handle error logging in a more pluggable way. We aimed for the 
> shortest diff because there are no tests for any of these scripts, and to be 
> honest, I was afraid of changing them without tests.
> 
> 
> Diffs
> -
> 
>   .gitignore-template 90b6697d19a5e0a68805b23b587b362731a1df25 
>   support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
>   support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 
> 
> Diff: https://reviews.apache.org/r/40340/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38110: Quota: Introduced capacity heuristic for quota set requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/
---

(Updated Nov. 16, 2015, 10:26 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Joris' comments.


Summary (updated)
-

Quota: Introduced capacity heuristic for quota set requests.


Bugs: MESOS-3074
https://issues.apache.org/jira/browse/MESOS-3074


Repository: mesos


Description (updated)
---

The heuristic tests whether the total quota, including the new request, does 
not exceed the sum of non-static cluster resources. The goal of this checkis to 
determine whether a user may accidentally request an amount of resources that 
would prevent frameworks without quota from getting any offers. A force flag 
will be introduced in the future and will allow users to bypass this check.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38110/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38110: Quota: Introduced capacity heuristic for quota set requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/
---

(Updated Nov. 16, 2015, 10:27 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Logs and error messages, NNTR.


Bugs: MESOS-3074
https://issues.apache.org/jira/browse/MESOS-3074


Repository: mesos


Description
---

The heuristic tests whether the total quota, including the new request, does 
not exceed the sum of non-static cluster resources. The goal of this checkis to 
determine whether a user may accidentally request an amount of resources that 
would prevent frameworks without quota from getting any offers. A force flag 
will be introduced in the future and will allow users to bypass this check.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38110/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

> On Oct. 19, 2015, 10:21 p.m., Joerg Schad wrote:
> > src/tests/master_quota_tests.cpp, line 139
> > 
> >
> > Is there a reason to repeat 'protected:' here
> 
> Alexander Rukletsov wrote:
> It separates methods section from fields. We are inconsitent, see for 
> example `HierarchicalAllocatorTestBase`, `PortMappingIsolatorTest`.

I will leave the extra `protected` because it doesn't hurt and it's self 
documenting code.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review103175
---


On Nov. 14, 2015, 3:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 14, 2015, 3:46 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

> On Nov. 6, 2015, 12:39 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > 
> >
> > The resource string you have is equivalent to the resource string from 
> > `CreateSlaveFlags`.  Is there some reason you're re-setting it?
> 
> Alexander Rukletsov wrote:
> One of the comments I got earlier from Bernd is that it is hard to track 
> what resources are available, hence I decided to re-introduce the resources 
> explicitly.
> 
> Joseph Wu wrote:
> Can you add a comment about this to the test?

I have introduced the constant in the `MesosTest` fixture and got rid of this 
fucntion here.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/#review105339
---


On Nov. 14, 2015, 3:46 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38956/
> ---
> 
> (Updated Nov. 14, 2015, 3:46 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38956/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40339: Added a flag to master to enable optimistic offers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/#review106642
---


Patch looks great!

Reviews applied: [40339]

All tests passed.

- Mesos ReviewBot


On Nov. 16, 2015, 9:40 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40339/
> ---
> 
> (Updated Nov. 16, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Klaus 
> Ma.
> 
> 
> Bugs: MESOS-3887
> https://issues.apache.org/jira/browse/MESOS-3887
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a flag to master to enable optimistic offers.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
>   src/master/allocator/mesos/allocator.hpp 
> d2d32af227d66c4030becd4cd64b907a70d25f49 
>   src/master/allocator/mesos/hierarchical.hpp 
> cd3c7019952bfe7c1049a9c42a90943b681f1939 
>   src/master/allocator/mesos/hierarchical.cpp 
> e9286260f490915327f44492086c1160d5567ac5 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 
>   src/tests/hierarchical_allocator_tests.cpp 
> 740cfa801ee90417c038308192d1f4f2416f8315 
>   src/tests/master_allocator_tests.cpp 
> 646cacd3e16b9e0b72c0b259eecf2760cfb530db 
>   src/tests/reservation_endpoints_tests.cpp 
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
>   src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
>   src/tests/resource_offers_tests.cpp 
> bf2fe3ac7b982e31d289a703ae637d8e2b3a2d8a 
>   src/tests/slave_recovery_tests.cpp 2cc7132deb9b8c324aa9dbab0b81643d07377a89 
> 
> Diff: https://reviews.apache.org/r/40339/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/#review106643
---


Bad patch!

Reviews applied: [38627, 40226, 40227, 39276, 37998, 37999, 38000]

Failed command: ./support/apply-review.sh -n -r 38000

Error:
 2015-11-16 11:46:39 URL:https://reviews.apache.org/r/38000/diff/raw/ 
[11582/11582] -> "38000.patch" [1]
error: patch failed: 3rdparty/libprocess/src/tests/http_tests.cpp:27
error: 3rdparty/libprocess/src/tests/http_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 16, 2015, 10:06 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
> 
> (Updated Nov. 16, 2015, 10:06 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3756
> https://issues.apache.org/jira/browse/MESOS-3756
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> 1. Adds a flag to load an HTTP Authenticator module from the flags.
> 2. If provided, uses the credentials file to initialize the default HTTP 
> Authenticator.
> 3. Updates the existing endpoints which implement their own basic HTTP 
> authenticator with the libprocess one.
> 4. Updates one test which expected the wrong results since now credentials 
> are checked before the body of the request.
> 
> 
> Diffs
> -
> 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
>   src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
>   src/master/http.cpp f4ec23d74e203b2a8f2af187f0e56fbde7d9b3e5 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
> 
> Diff: https://reviews.apache.org/r/39043/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 16, 2015, 12:24 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Removed duplicated code.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Review Request 40342: Quota: Exposed agent resources string from the `MesosTest` fixture.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40342/
---

Review request for mesos, Joerg Schad, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
  src/tests/mesos.cpp 5667e961fe70d15defbb127c174e91376ca9de3d 

Diff: https://reviews.apache.org/r/40342/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37998/#review106649
---

Ship it!


Ship It!

- Bernd Mathiske


On Nov. 16, 2015, 1:48 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37998/
> ---
> 
> (Updated Nov. 16, 2015, 1:48 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `ProcessManager::handle()` is a method used to process HTTP requests, its 
> signature returns a boolean which is not used anywhere and it doesn't allow 
> for asynchronous operations within handle.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> b45b5b14cc7868d73a6fe02c02b9baf8b44b891f 
> 
> Diff: https://reviews.apache.org/r/37998/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39289: Quota: Added authorization of quota requests.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39289/
---

(Updated Nov. 16, 2015, 1:41 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Changes
---

Addressed issues, refactored, authorization principal is set using the 
authorization data from the HTTP request header.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Added authorization of quota requests.


Diffs (updated)
-

  docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/39289/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 39223: Added Quota Request Validation Tests.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/
---

(Updated Nov. 16, 2015, 12:48 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

see Summary.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39223/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 39289: Quota: Added authorization of quota requests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39289/#review106653
---


Bad patch!

Reviews applied: [39211, 39018, 39102, 36913]

Failed command: ./support/apply-review.sh -n -r 36913

Error:
 2015-11-16 12:55:10 URL:https://reviews.apache.org/r/36913/diff/raw/ 
[7367/7367] -> "36913.patch" [1]
error: patch failed: src/Makefile.am:511
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 16, 2015, 12:41 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39289/
> ---
> 
> (Updated Nov. 16, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authorization of quota requests.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
>   src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
> 
> Diff: https://reviews.apache.org/r/39289/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 39492: Added status endpoint for quota master endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
---

(Updated Nov. 16, 2015, 1:13 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added status handling for quota master endpoint.
Tests are in next Review.


Diffs (updated)
-

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
---

Test output: 
{"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}


Thanks,

Joerg Schad

Re: Review Request 40342: Quota: Exposed agent resources string from the `MesosTest` fixture.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40342/#review106657
---

Ship it!


Ship It!

- Joerg Schad


On Nov. 16, 2015, 12:24 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40342/
> ---
> 
> (Updated Nov. 16, 2015, 12:24 p.m.)
> 
> 
> Review request for mesos, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3720
> https://issues.apache.org/jira/browse/MESOS-3720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
>   src/tests/mesos.cpp 5667e961fe70d15defbb127c174e91376ca9de3d 
> 
> Diff: https://reviews.apache.org/r/40342/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/
---

Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Implemented authorization of quota requests in the authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/40346/diff/


Testing
---


Thanks,

Jan Schlicht

Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40345/
---

Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Added "RequestQuota" message to ACL protobuf.


Diffs
-

  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 

Diff: https://reviews.apache.org/r/40345/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/
---

Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Implemented quota request authorization.


Diffs
-

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40347/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/
---

Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Documented quota authorization.


Diffs
-

  docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
  src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 

Diff: https://reviews.apache.org/r/40348/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/
---

(Updated Nov. 16, 2015, 2:53 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Implemented authorization of quota requests in the authorizer.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/40346/diff/


Testing (updated)
---

make check


Thanks,

Jan Schlicht

Re: Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40345/#review106659
---



include/mesos/authorizer/authorizer.proto (line 74)


Wouldn't that be SetQuota()?
same below


- Joerg Schad


On Nov. 16, 2015, 1:53 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40345/
> ---
> 
> (Updated Nov. 16, 2015, 1:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Added "RequestQuota" message to ACL protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
> 
> Diff: https://reviews.apache.org/r/40345/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review106661
---


Bad patch!

Reviews applied: [39211, 39018, 39102, 36913]

Failed command: ./support/apply-review.sh -n -r 36913

Error:
 2015-11-16 14:22:13 URL:https://reviews.apache.org/r/36913/diff/raw/ 
[7367/7367] -> "36913.patch" [1]
error: patch failed: src/Makefile.am:511
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 16, 2015, 1:54 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> ---
> 
> (Updated Nov. 16, 2015, 1:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/#review106660
---



include/mesos/authorizer/authorizer.hpp (line 136)


s/request/set



include/mesos/authorizer/authorizer.hpp (line 140)


/s/Then/This



src/tests/mesos.hpp (line 1245)


This looks somehow weird... Who is satisfying the expect_call?


- Joerg Schad


On Nov. 16, 2015, 1:53 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40346/
> ---
> 
> (Updated Nov. 16, 2015, 1:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Implemented authorization of quota requests in the authorizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 
> 32de102fd588f029882ef121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 
> 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
> 
> Diff: https://reviews.apache.org/r/40346/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/#review106662
---



src/master/master.hpp (line 910)


Shouldn't this be autherize (similar to authenticate() and the other calls)?



src/master/master.hpp (line 913)


s/request/set ?



src/master/quota_handler.cpp (line 188)


Should this be part of the validation below?



src/master/quota_handler.cpp (line 239)


I see that this is consistent witht the rest of the code, but in my opinion 
the realm should be `Mesos`. If it turns out that this is intended, feel free 
to drop...



src/master/quota_handler.cpp (line 314)


VLog?



src/master/quota_handler.cpp (line 324)


validateQuotaInfo would have failed


- Joerg Schad


On Nov. 16, 2015, 1:53 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40347/
> ---
> 
> (Updated Nov. 16, 2015, 1:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Implemented quota request authorization.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40347/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

[Jan Schlicht]

> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 315
> > 
> >
> > VLog?

I'm trying to be consistent with other logs of this kind (e.g. in 
`master.cpp`), which are all `LOG(INFO)`.


> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 188
> > 
> >
> > Should this be part of the validation below?

I'd rather put it into `createQuotaInfo` as it's not validating but setting 
properties of `create`.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/#review106662
---


On Nov. 16, 2015, 2:53 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40347/
> ---
> 
> (Updated Nov. 16, 2015, 2:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Implemented quota request authorization.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40347/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 38956: Quota: Added allocator-agnostic tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38956/
---

(Updated Nov. 16, 2015, 3:21 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Michael Park.


Changes
---

Added a todo for rescind test.


Bugs: MESOS-3720
https://issues.apache.org/jira/browse/MESOS-3720


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38956/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38110: Quota: Introduced capacity heuristic for quota set requests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review10
---

Ship it!



src/master/quota_handler.cpp (line 133)


typo


- Joris Van Remoortere


On Nov. 16, 2015, 10:27 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 16, 2015, 10:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The heuristic tests whether the total quota, including the new request, does 
> not exceed the sum of non-static cluster resources. The goal of this checkis 
> to determine whether a user may accidentally request an amount of resources 
> that would prevent frameworks without quota from getting any offers. A force 
> flag will be introduced in the future and will allow users to bypass this 
> check.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

[Jan Schlicht]

> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 239
> > 
> >
> > I see that this is consistent witht the rest of the code, but in my 
> > opinion the realm should be `Mesos`. If it turns out that this is intended, 
> > feel free to drop...

Also my opinion! But I'm trying to be consistent with the other `Unauthorized` 
return values, that all use `Mesos master` as realm. Let's create a ticket and 
fix it independently from this RR.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/#review106662
---


On Nov. 16, 2015, 2:53 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40347/
> ---
> 
> (Updated Nov. 16, 2015, 2:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Implemented quota request authorization.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40347/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40349/
---

(Updated Nov. 16, 2015, 3:36 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Remove `WIP` tag since not WIP anymore.


Summary (updated)
-

Added tests for use of mtime in fetcher cache.


Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785


Repository: mesos


Description
---

Added tests for use of mtime in fetcher cache.


Diffs
-

  src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0 
  src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
  src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961 

Diff: https://reviews.apache.org/r/40349/diff/


Testing
---

make check under OS X and ubuntu-trusty.


Thanks,

Benjamin Bannier

Re: Review Request 40349: WIP Added tests for use of mtime in fetcher cache.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40349/
---

(Updated Nov. 16, 2015, 3:35 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Added a missing test case.

Also some stylistic fixes, like e.g. pulling out the lambda into a function. 
This required marking a few semantically `const` functions as actually `const`.


Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785


Repository: mesos


Description
---

Added tests for use of mtime in fetcher cache.


Diffs (updated)
-

  src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0 
  src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
  src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961 

Diff: https://reviews.apache.org/r/40349/diff/


Testing
---

make check under OS X and ubuntu-trusty.


Thanks,

Benjamin Bannier

Review Request 40351: Quota: Added rescinding offers for set quota requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Bugs: MESOS-3912
https://issues.apache.org/jira/browse/MESOS-3912


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40351/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

[Jan Schlicht]

> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 239
> > 
> >
> > I see that this is consistent witht the rest of the code, but in my 
> > opinion the realm should be `Mesos`. If it turns out that this is intended, 
> > feel free to drop...
> 
> Jan Schlicht wrote:
> Also my opinion! But I'm trying to be consistent with the other 
> `Unauthorized` return values, that all use `Mesos master` as realm. Let's 
> create a ticket and fix it independently from this RR.

A [JIRA ticket](https://issues.apache.org/jira/browse/MESOS-3933) has been 
created.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/#review106662
---


On Nov. 16, 2015, 2:53 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40347/
> ---
> 
> (Updated Nov. 16, 2015, 2:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Implemented quota request authorization.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40347/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 38110: Quota: Introduced capacity heuristic for quota set requests.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review106670
---



src/master/master.hpp (line 880)


s/reasonabily/reasonably?



src/master/master.hpp (line 883)


As the force flag isn't there, whould we add a todo? Otherwise this comment 
is misleading.



src/master/master.hpp (line 886)


This heuristic can still prevent frameworks without quota to receive offers 
in contrast to the above goal...



src/master/quota_handler.cpp (line 117)


Is non-static cluster resources a fixed term?



src/master/quota_handler.cpp (line 149)


this sounds like as if the force flag is a solution to this. 
How about consider: If you want to override this check, consider using the 
force attribute.


- Joerg Schad


On Nov. 16, 2015, 10:27 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> ---
> 
> (Updated Nov. 16, 2015, 10:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-3074
> https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The heuristic tests whether the total quota, including the new request, does 
> not exceed the sum of non-static cluster resources. The goal of this checkis 
> to determine whether a user may accidentally request an amount of resources 
> that would prevent frameworks without quota from getting any offers. A force 
> flag will be introduced in the future and will allow users to bypass this 
> check.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40349/
---

(Updated Nov. 16, 2015, 3:44 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Linked correct issue.


Bugs: MESOS-3856
https://issues.apache.org/jira/browse/MESOS-3856


Repository: mesos


Description
---

Added tests for use of mtime in fetcher cache.


Diffs
-

  src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0 
  src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
  src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961 

Diff: https://reviews.apache.org/r/40349/diff/


Testing
---

make check under OS X and ubuntu-trusty.


Thanks,

Benjamin Bannier

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/#review106672
---


Bad patch!

Reviews applied: [39211, 39018, 39102, 36913]

Failed command: ./support/apply-review.sh -n -r 36913

Error:
 2015-11-16 15:48:31 URL:https://reviews.apache.org/r/36913/diff/raw/ 
[7367/7367] -> "36913.patch" [1]
error: patch failed: src/Makefile.am:511
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 16, 2015, 3:43 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40351/
> ---
> 
> (Updated Nov. 16, 2015, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3912
> https://issues.apache.org/jira/browse/MESOS-3912
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40351/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/
---

(Updated Nov. 16, 2015, 4:48 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Changes
---

Fix issues.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Implemented authorization of quota requests in the authorizer.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/40346/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40345/
---

(Updated Nov. 16, 2015, 4:49 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Summary (updated)
-

[1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Added "RequestQuota" message to ACL protobuf.


Diffs
-

  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 

Diff: https://reviews.apache.org/r/40345/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 40347: [3/4] Quota Authorization: Implemented quota request authorization.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/
---

(Updated Nov. 16, 2015, 4:50 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Changes
---

Fix issues.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Implemented quota request authorization.


Diffs (updated)
-

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40347/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 40345: [1/4] Quota Authorization: Added "RequestQuota" message to ACL protobuf.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40345/
---

(Updated Nov. 16, 2015, 4:47 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Changes
---

Fix issues.


Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862


Repository: mesos


Description
---

Quota: Added "RequestQuota" message to ACL protobuf.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 

Diff: https://reviews.apache.org/r/40345/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 40349: Added tests for use of mtime in fetcher cache.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40349/#review106677
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Nov. 16, 2015, 3:44 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40349/
> ---
> 
> (Updated Nov. 16, 2015, 3:44 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3856
> https://issues.apache.org/jira/browse/MESOS-3856
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for use of mtime in fetcher cache.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.hpp 
> c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp 
> 0b676f43e8529c6790824c8cf82e21a81d885ef1 
>   src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961 
> 
> Diff: https://reviews.apache.org/r/40349/diff/
> 
> 
> Testing
> ---
> 
> make check under OS X and ubuntu-trusty.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 37999: Implemented http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37999/
---

(Updated Nov. 16, 2015, 5:23 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Second round of reviews.


Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231


Repository: mesos


Description
---

Introduces the authenticator manager, which is a class which handles the actual 
authentication procedure during the execution of `ProcessManager::handle()` and 
it also takes care of the life cycle of instances of http::Authenticator.

No tests are added at this point since no public API is generated, the goal of 
this patch is to implement the manager and verify nothing breaks afterwards. 
Authenticator manager tests proper come in a latter patch.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/Makefile.am 
e6be2c4db121585bbe7f3c0627de048adc7cfb2c 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/event.hpp 
28ce1928877084f0e1a73fdad789224c86e53f46 
  3rdparty/libprocess/include/process/http.hpp 
90c9be122ee0c402b806d70fc818e3c03b15101a 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/process.cpp 7abdf21a5784920251c3627f9820c12fdc356c6e 
  3rdparty/libprocess/src/realm_manager.hpp PRE-CREATION 
  3rdparty/libprocess/src/realm_manager.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37999/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/
---

(Updated Nov. 16, 2015, 5:25 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Second round of reviews.


Bugs: MESOS-3233
https://issues.apache.org/jira/browse/MESOS-3233


Repository: mesos


Description
---

Adds functions which allows libprocess users to add handlers which require 
authentication as well as functions to install and remove authenticators.

Includes tests.


Diffs (updated)
-

  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/process.cpp 7abdf21a5784920251c3627f9820c12fdc356c6e 
  3rdparty/libprocess/src/tests/http_tests.cpp 
5e70f1896a86104ac01dfe725eb4d7d1d25bee77 

Diff: https://reviews.apache.org/r/38000/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38094/
---

(Updated Nov. 16, 2015, 5:26 p.m.)


Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Second round of reviews.


Bugs: MESOS-3232
https://issues.apache.org/jira/browse/MESOS-3232


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 
  3rdparty/libprocess/include/process/authenticator.hpp PRE-CREATION 
  3rdparty/libprocess/src/CMakeLists.txt 
fb9bd04832779ac43151f2feb3dfbf58cb996434 
  3rdparty/libprocess/src/authenticator.cpp PRE-CREATION 
  3rdparty/libprocess/src/tests/http_tests.cpp 
5e70f1896a86104ac01dfe725eb4d7d1d25bee77 

Diff: https://reviews.apache.org/r/38094/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/
---

(Updated Nov. 16, 2015, 5:28 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Changes
---

Second round of reviews.


Bugs: MESOS-3756
https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
---

Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.


Diffs (updated)
-

  include/mesos/authentication/http/basic_authenticator_factory.hpp 
PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 04f42dc4f687e55c4e6758ef2f7c7096f1b1ec47 
  src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 

Diff: https://reviews.apache.org/r/38950/diff/


Testing
---

make check


Thanks,

Alexander Rojas