Review Request 40586: Corrected a typo and a formatting issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40586/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Nov. 23, 2015, 12:12 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 40224: Fix wrong flags infos in /state and /flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/ --- Review request for mesos, Ben Mahler and haosdent huang. Bugs: MESOS-3792

Re: Review Request 40531: Added the public Mesos events calendar to the Community page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40531/#review107562 --- Patch looks great! Reviews applied: [40531] Passed command:

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/ --- (Updated Nov. 23, 2015, 5:37 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 40531: Added the public Mesos events calendar to the Community page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40531/ --- (Updated Nov. 23, 2015, 5:48 a.m.) Review request for mesos and Dave Lester.

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review107558 --- Patch looks great! Reviews applied: [38287] Passed command:

Re: Review Request 40570: Modified stateUpdate(...) function to get the TaskStatus object by constant reference instead of copy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40570/#review107559 --- Ship it! Ship It! - Qian Zhang On Nov. 21, 2015, 8:21 a.m.,

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review107493 --- include/mesos/mesos.proto (line 643)

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > docs/persistent-volume.md, lines 255-280 > > > > > > This looks to be formatted weird, could you double check? Here and below > > Neil Conway wrote: > I

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 23, 2015, 12:31 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 23, 2015, 12:57 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107527 --- src/slave/slave.cpp (line 4417)

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review107529 --- src/common/resources.cpp (lines 94 - 106)

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107535 --- src/master/allocator/mesos/hierarchical.cpp (line 193)

Re: Review Request 40529: WIP: Added helper function to get stateless resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/#review107540 --- src/common/resources.cpp (line 654)

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 541 > > > > > > Can you please add some comments here to clarify why need this? Another point is that can we set this as a helper

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review107533 --- Patch looks great! Reviews applied: [40586, 40551, 39450] Passed

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107539 --- src/master/allocator/mesos/hierarchical.cpp (line 171)

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 328 > > > > > > I don't like the name 'execute'. When you create the Subprocess > > instance, the

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107543 --- Patch looks great! Reviews applied: [40332] Passed command:

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Nov. 22, 2015, 11:55 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review107525 --- Bad patch! Reviews applied: [39401] Failed command:

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107531 --- docs/persistent-volume.md (line 236)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review107545 --- src/master/quota_handler.cpp (line 332)

Re: Review Request 40396: Quota: Added a test for offer rescinding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40396/#review107546 --- src/tests/master_quota_tests.cpp (line 539)

Re: Review Request 40497: Add hex number support to numify()

> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp, line 39 > > > > > > Where you planning to output `c` here? Otherwise I suggest replacing > >

Re: Review Request 40586: Corrected a typo and a formatting issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40586/#review107548 --- src/master/allocator/mesos/hierarchical.hpp (lines 367 - 376)

Re: Review Request 40544: Added quota remove handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40544/ --- (Updated Nov. 22, 2015, 1:35 p.m.) Review request for mesos, Alexander

Re: Review Request 40580: Added remove quota test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40580/#review107503 --- Patch looks great! Reviews applied: [39211, 39018, 39102, 36913,

Review Request 40580: Added remove quota test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40580/ --- Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.

Re: Review Request 40291: Added the stye guideline for blank line after line-wrapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40291/ --- (Updated Nov. 22, 2015, 11:52 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 40400: Quota: Added registry tests.

> On Nov. 22, 2015, 6:07 p.m., Joris Van Remoortere wrote: > > src/tests/registrar_tests.cpp, line 687 > > > > > > Let's use full words. `Alternate`, or we could enumerate them. The reason why I didin't want to

Re: Review Request 39400: Quota: Implemented quota API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review107517 --- Ship it! src/master/allocator/mesos/hierarchical.cpp (lines 152

Re: Review Request 40401: Quota: Persisted quota to registry for set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40401/#review107512 --- Ship it! src/master/quota_handler.cpp (lines 240 - 241)

Re: Review Request 40398: Quota: Extended allocator interface with recovery method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40398/#review107513 --- Ship it! If we move `struct Quota` from "master.hpp" to

Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40402/#review107514 --- Ship it! src/master/master.cpp (lines 1421 - 1423)

Re: Review Request 40329: Removed stale comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40329/#review107515 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015,

Re: Review Request 40401: Quota: Persisted quota to registry for set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40401/ --- (Updated Nov. 22, 2015, 5:02 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40400: Quota: Added registry tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40400/ --- (Updated Nov. 22, 2015, 5:02 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40399: Quota: Introduced quota registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40399/ --- (Updated Nov. 22, 2015, 5:03 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40399: Quota: Introduced quota registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40399/#review107508 --- Ship it! src/master/quota.cpp (lines 70 - 85)

Re: Review Request 40400: Quota: Added registry tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40400/#review107510 --- Ship it! src/tests/registrar_tests.cpp (line 685)

Re: Review Request 40398: Quota: Extended allocator interface with recovery method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40398/ --- (Updated Nov. 22, 2015, 5 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40568: Windows: 2/3 Added zlib compilation steps for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40568/ --- (Updated Nov. 22, 2015, 5:54 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review107520 --- src/master/master.hpp (line 898)