Review Request 41752: Use Path::extension to simplify libprocess code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41752/ --- Review request for mesos, Anand Mazumdar and Artem Harutyunyan. Repository:

Review Request 41753: Use Path::extension to simplify mesos code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41753/ --- Review request for mesos, Anand Mazumdar and Artem Harutyunyan. Repository:

Review Request 41751: Added Path::extension for obtaining file extensions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41751/ --- Review request for mesos, Anand Mazumdar and Artem Harutyunyan. Repository:

Re: Review Request 41751: Added Path::extension for obtaining file extensions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41751/#review112069 --- Ship it! LGTM, just some minor nits and cleanups.

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/#review112068 --- Patch looks great! Reviews applied: [41656, 41657] Passed

Re: Review Request 41752: Use Path::extension to simplify libprocess code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41752/#review112072 --- Ship it! Ship It! - Anand Mazumdar On Dec. 28, 2015, 10:09

Re: Review Request 41753: Use Path::extension to simplify mesos code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41753/#review112073 --- Ship it! Ship It! - Anand Mazumdar On Dec. 28, 2015, 10:09

Re: Review Request 41714: Added tests for HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41714/#review112108 --- src/tests/uri_fetcher_tests.cpp (line 165)

Review Request 41675: Speed up SlaveTest.HTTPSchedulerSlaveRestart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41675/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-4163

Re: Review Request 41675: Speed up SlaveTest.HTTPSchedulerSlaveRestart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41675/#review112113 --- Patch looks great! Reviews applied: [41675] Passed command:

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review111967 --- src/tests/slave_tests.cpp (line 435)

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

> On Dec. 24, 2015, 11:10 a.m., Adam B wrote: > > Looks good, but I wonder if we need to go so far as to introduce the `enum > > Protocol` misnomer in the global IPAddress message now. We could always add > > it in later, when we actually get NetworkInfo off of it. > > Anand Mazumdar wrote: >

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/ --- (Updated Dec. 28, 2015, 3:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41460: Used `std::is_bind_expression` to SFINAE correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41460/ --- (Updated Dec. 28, 2015, 3:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41462: libprocess: Used SFINAE-friendly `result_of`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41462/ --- (Updated Dec. 28, 2015, 3:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41461: stout: Added SFINAE-friendly `result_of`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/#review111984 --- Do you think it makes sense to add some configure checks?

Re: Review Request 41462: libprocess: Used SFINAE-friendly `result_of`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41462/#review112021 --- I see some `result_of` in "async.hpp" and "lambda.hpp". Do you

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/ --- (Updated Dec. 28, 2015, 3:42 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41731: Removed docker puller flag.

> On Dec. 26, 2015, 9:42 p.m., Gilbert Song wrote: > > src/slave/flags.cpp, lines 145-146 > > > > > > Could we use pure directory only for local puller? > > > > Instead of adding `file://` to the flag &

Re: Review Request 41731: Removed docker puller flag.

> On Dec. 27, 2015, 5:42 a.m., Gilbert Song wrote: > > src/slave/flags.cpp, lines 145-146 > > > > > > Could we use pure directory only for local puller? > > > > Instead of adding `file://` to the flag &

Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41604/#review112019 --- Ship it! Ship It! - Daniel Pravat On Dec. 23, 2015, 6:52 a.m.,

Review Request 41754: Added reference to docker registry bearer token spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41754/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 41754: Added reference to docker registry bearer token spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41754/#review112080 --- Patch looks great! Reviews applied: [41754] Passed command:

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/ --- (Updated Dec. 28, 2015, 10:31 a.m.) Review request for mesos, Artem

Re: Review Request 41715: Support parsing url in libprocess.

> On Dec. 28, 2015, 8:02 p.m., Jojy Varghese wrote: > > 3rdparty/libprocess/src/http.cpp, line 183 > > > > > > Have we considered using a regex parser for doing this? C++11 regex > > support is added since gcc 4.9

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Dec. 28, 2015, 11:36 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 41704: Added support for checking whether a given path is absolute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 28, 2015, 11:35 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/#review112060 --- Bad patch! Reviews applied: [41656] Failed command:

Re: Review Request 41715: Support parsing url in libprocess.

> On Dec. 27, 2015, 2:56 a.m., Jojy Varghese wrote: > > 3rdparty/libprocess/src/http.cpp, line 182 > > > > > > I would add some comments through the function to explain each > > sub-section's intent. We usually

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review112045 --- Patch looks great! Reviews applied: [40944] Passed command:

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/ --- (Updated Dec. 28, 2015, 7:49 p.m.) Review request for mesos, Jie Yu and Joerg

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review112061 --- 3rdparty/libprocess/src/http.cpp (line 183)

Re: Review Request 41715: Support parsing url in libprocess.

> On Dec. 27, 2015, 2:56 a.m., Jojy Varghese wrote: > > 3rdparty/libprocess/src/http.cpp, line 190 > > > > > > Can we avoid using magic numbers ('3' here)? It's paired with the magic string '://' :) I'm not sure

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/ --- (Updated Dec. 28, 2015, 8:23 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 41657: Added user facing documentation for containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41657/ --- (Updated Dec. 28, 2015, 8:23 p.m.) Review request for mesos, Jie Yu and Joerg

Re: Review Request 41656: Renamed containerizer.md to mesos-containerizer.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41656/ --- (Updated Dec. 28, 2015, 8:23 p.m.) Review request for mesos, Jie Yu and Joerg

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Dec. 29, 2015, 3:11 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > > > > > "else" case? Nothing needs to be done for the `else` case. These env variables **might** be set by the agent

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112114 --- src/executor/executor.cpp (line 54)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112125 --- src/executor/executor.cpp (line 354)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > > > > > "else" case? > > Anand Mazumdar wrote: > Nothing needs to be done for the `else` case. These env variables

Review Request 41757: Unified Container: Added passing Env in docker runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41757/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Dec. 28, 2015, 3:49 p.m.) Review request for mesos, Artem

Review Request 41758: Unified Container: Added passing Cmd in docker runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41758/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 41753: Use Path::extension to simplify mesos code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41753/#review112092 --- Patch looks great! Reviews applied: [41751, 41752, 41753] Passed

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/#review112086 --- 3rdparty/libprocess/include/process/future.hpp (line 347)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Dec. 29, 2015, 12:11 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 41713: Added HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41713/#review112105 --- Ship it! Ship It! src/uri/fetcher.cpp (line 57)

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 29, 2015, 1:10 a.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41758: Unified Container: Added passing Cmd in docker runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41758/#review112106 --- Patch looks great! Reviews applied: [41491, 41757, 41758] Passed

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 6:09 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 354 > > > > > > What is the purpose of mutex? It looks like we do the callbacks > > asynchronously. Which means, we have the

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 6:38 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review112132 --- Patch looks great! Reviews applied: [41597, 41681] Passed

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 29, 2015, 6:40 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 7:03 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 7:20 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 29, 2015, 7:21 a.m.) Review request for mesos, Adam B, Neil