Re: Review Request 42053: Added flags to set size of completed task/framework history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 10:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- (Updated Jan. 12, 2016, 2:20 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

> On Jan. 12, 2016, 6:43 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, line 3084 > > > > > > Since there's a clean separation among offers and inverse offers, it > > seems we could begin logging unknown

Review Request 42216: Fixed gmock warnings in hook tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Bugs: MESOS-434

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/#review114041 --- Overall structure and flow of the test looks good. A few nits: s

Re: Review Request 41963: Logger Module: Implement ContainerLogger recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41963/ --- (Updated Jan. 12, 2016, 2:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 12, 2016, 2:31 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 42215: Added expectations for call to mocked executor shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/ --- Review request for mesos and Neil Conway. Repository: mesos Description -

Re: Review Request 42053: Added flags to set size of completed task/framework history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/#review114077 --- Just a couple of suggestions. src/master/flags.cpp (lines 464 - 4

Re: Review Request 42209: Updated getting started page to install Java on OSX.

> On Jan. 12, 2016, 10:04 p.m., Kevin Klues wrote: > > Can you veirfy that this doesn't break things for Yosemite? I don't have yosemite handy to test it :) but from looking online it looks like cask and caskroom have existed for a while, pre-yosemite. - Vinod --

Review Request 42217: Modified commit msg hook to include newline character.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42217/ --- Review request for mesos, Adam B and Artem Harutyunyan. Repository: mesos Des

Re: Review Request 42209: Updated getting started page to install Java on OSX.

> On Jan. 12, 2016, 2:04 p.m., Kevin Klues wrote: > > Can you veirfy that this doesn't break things for Yosemite? > > Vinod Kone wrote: > I don't have yosemite handy to test it :) but from looking online it > looks like cask and caskroom have existed for a while, pre-yosemite. Maybe just a

Re: Review Request 41277: Added environment variables to be used by HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41277/#review114089 --- Ship it! Ship It! - Vinod Kone On Jan. 12, 2016, 5:29 p.m., Ana

Re: Review Request 41280: Fixed header include order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41280/#review114090 --- Ship it! Ship It! - Vinod Kone On Dec. 11, 2015, 11:51 p.m., An

Re: Review Request 41281: Added output operator to output call/event types in the Executor V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41281/#review114091 --- Ship it! Ship It! - Vinod Kone On Dec. 11, 2015, 11:51 p.m., An

Re: Review Request 40553: Enable mesos tests installation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 12, 2016, 10:50 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42172: Add documentation for logging and ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42172/#review114092 --- Patch looks great! Reviews applied: [42172] Passed command: expor

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114086 --- Thanks for cleaning this up. I've got a question about the overhead

Re: Review Request 42217: Modified commit msg hook to include newline character.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42217/#review114094 --- Ship it! Ship It! - Adam B On Jan. 12, 2016, 2:41 p.m., Anand M

Re: Review Request 42149: Replaced mutex in HTTP server for fetcher cache tests with latch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/#review114096 --- Ship it! LGTM. - Joseph Wu On Jan. 12, 2016, 6:55 a.m., Bernd M

Review Request 42221: Removed references to wDRF from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository: meso

Review Request 42222: Added a comment on allocator recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository: meso

Re: Review Request 42053: Added flags to set size of completed task/framework history.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42053/ --- (Updated Jan. 12, 2016, 11:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 42053: Added flags to set size of completed task/framework history.

> On Jan. 12, 2016, 10:33 p.m., Adam B wrote: > > src/master/master.hpp, line 1683 > > > > > > Could you call this `masterFlags` so it doesn't get confused with > > FrameworkInfo parameters? > > Even better wou

Re: Review Request 42208: Fixed flakiness in RegistryTokenTest.ExpiredToken.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42208/#review114102 --- Ship it! Ship It! - Timothy Chen On Jan. 12, 2016, 8:46 p.m., N

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114100 --- We aren't porting the (deprecated) external containerizer to Window

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/ --- (Updated Jan. 12, 2016, 11:31 p.m.) Review request for mesos, Ben Mahler, Jojy

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/ --- (Updated Jan. 12, 2016, 11:33 p.m.) Review request for mesos, Ben Mahler, Jojy

Re: Review Request 41649: Removed slave checkpointing logic after deprecation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review114097 --- Ship it! Looks great! Only a handful of minor doc/comment changes.

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 3:48 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42215: Added expectations for call to mocked executor shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/ --- (Updated Jan. 13, 2016, 12:05 a.m.) Review request for mesos, Neil Conway and T

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114114 --- Ship it! Ship It! - Alex Naparu On Jan. 7, 2016, 9:47 p.m., Ale

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 13, 2016, 12:57 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 5, 2016, 9:28 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 107 > > > > > > Here and in all dtrs below: Given that we don't know whether exceptions >

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/ --- (Updated Jan. 13, 2016, 1:04 a.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 42212: Added unit test for framework/task history flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42212/#review114119 --- Patch looks great! Reviews applied: [42053, 42212] Passed command

Re: Review Request 41282: Added the interface for the V1 Executor HTTP Library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41282/#review114118 --- Ship it! - Vinod Kone On Dec. 12, 2015, 2:13 a.m., Anand Mazumda

Re: Review Request 42222: Added a comment on allocator recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114125 --- Ship it! Ship It! - Guangya Liu On 一月 12, 2016, 11:06 p.m., Ale

Re: Review Request 42221: Removed references to wDRF from allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42221/#review114126 --- Since the comments are mainly to developers, the `second stage` is

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review114133 --- Patch looks great! Reviews applied: [42092, 42086] Passed command

Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

> On 一月 12, 2016, 2:33 a.m., Guangya Liu wrote: > > Greg, I think that the document of reservation.md should also be updated. > > > > BTW: Did you test your patch? I did some test as this and mesos-master core > > dump. > > > > curl -i -d slaveId="4c737d19-e3b2-41c0-b4d0-ffc60190b8eb-S0" -d

Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42165/#review114135 --- I think that you may also want a coming patch to address the docume

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/#review114136 --- src/tests/master_validation_tests.cpp

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 一月 13, 2016, 2:24 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41847: Updated allocation slack when slave was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41847/ --- (Updated 一月 13, 2016, 2:32 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 2:37 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

> On Jan. 13, 2016, 2:17 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 294 > > > > > > Can you update the test case to verify that those validation still > > passed even without a principa

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/ --- (Updated Jan. 13, 2016, 2:45 a.m.) Review request for mesos, Alexander Rojas, M

Re: Review Request 42165: Removed `hasPrincipal` parameter from unreserve validation.

> On Jan. 13, 2016, 2:13 a.m., Guangya Liu wrote: > > I think that you may also want a coming patch to address the document > > issue: reservation.md. Update the document to clarify how to use > > (un)reserve without principal. Yep, thanks Guangya! I'll follow up soon with a patch for the docu

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 2:53 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/#review114140 --- src/tests/master_validation_tests.cpp

Re: Review Request 42098: Added unit test-case for CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/ --- (Updated Jan. 13, 2016, 3:07 a.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 42209: Updated getting started page to install Java on OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114142 --- Patch looks great! Reviews applied: [42209] Passed command: expor

Re: Review Request 40553: Enable mesos tests installation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review114144 --- Bad patch! Reviews applied: [39780, 39781, 39782, 40553] Failed c

Re: Review Request 40553: Enable mesos tests installation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 13, 2016, 4:06 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

> On Jan. 13, 2016, 2:56 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, lines 368-381 > > > > > > Sorry, I should have propsed my comments in one review. Seems we need > > validate both reserve

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

> On 一月 13, 2016, 2:56 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, lines 368-381 > > > > > > Sorry, I should have propsed my comments in one review. Seems we need > > validate both reserve an

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114148 --- Patch looks great! Reviews applied: [41806] Passed command: expor

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/#review114149 --- src/master/validation.cpp (line 699)

Re: Review Request 42030: Added example of a `defer` bug to libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42030/#review114151 --- Patch looks great! Reviews applied: [42030] Passed command: expor

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114150 --- Started to look at this review. A few minor comments here, I'll loo

Review Request 42234: Added test case on re-using evicting executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42234/ --- Review request for mesos, Guangya Liu and Jian Qiu. Bugs: MESOS-3897 https:

Re: Review Request 42234: WIP: Added test case on re-using evicting executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42234/ --- (Updated Jan. 13, 2016, 2:14 p.m.) Review request for mesos, Guangya Liu and Ji

Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C

Review Request 42237: Added docker image manifest parsing functions for strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C

Review Request 42236: Added a utility function to create https URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C

Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C

Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C

Re: Review Request 41961: Added an HTTP decode response method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41961/ --- (Updated Jan. 13, 2016, 6:36 a.m.) Review request for mesos, Ben Mahler and Tim

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review114153 --- src/master/master.cpp (line 3048)

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review114111 --- Patch looks great! Reviews applied: [41704, 41705, 41818] Passed

<    1   2