Re: Review Request 37531: Fix master CHECK failure if a framework uses duplicated task id.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/#review114243 --- Patch looks great! Reviews applied: [37531] Passed command: expor

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114246 --- src/slave/flags.cpp (line 196)

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

2016-01-13 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Jan. 13, 2016, 6:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Jan. 13, 2016, 6:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-13 Thread Kevin Klues
> On Jan. 13, 2016, 12:26 p.m., Till Toenshoff wrote: > > This recent change breaks the functionality - it hangs now. Looks like 'git rev-parse --git-common-dir' sometimes returns the absolute path of the .git directory, and other times it returns a relative path. My relPath() function assume

Re: Review Request 42235: Added protobuf for docker ImageReference and the parsing function.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42235/#review114250 --- Ship it! Verified that the logic in `parseImageReference` is gener

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

2016-01-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review114255 --- Ship it! Thanks! THis is great! src/slave/containerizer/mesos/co

Re: Review Request 42236: Added a utility function to create https URI.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114257 --- Ship it! LGTM! Just consider whether or not we should put it as `h

Re: Review Request 42059: Updated ContainerLogger to use Subprocess::IO type.

2016-01-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42059/#review114254 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp (lines 8

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40936/ --- (Updated Jan. 13, 2016, 7:14 p.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 42237: Added docker image manifest parsing functions for strings.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/#review114260 --- Ship it! LGTM! - Gilbert Song On Jan. 12, 2016, 10:23 p.m., Jie

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-13 Thread Daniel Pravat
> On Jan. 6, 2016, 2:23 a.m., Alex Clemmer wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp, line > > 73 > > > > > > How semantically similar is this to the POSIX code? If it's very >

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-13 Thread Neil Conway
> On Jan. 12, 2016, 10:56 p.m., Adam B wrote: > > src/tests/executor_http_api_tests.cpp, line 394 > > > > > > Do you think there's any test overhead in doing another AWAIT for a > > `response` that has already been

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/ --- (Updated Jan. 13, 2016, 7:19 p.m.) Review request for mesos and Adam B. Chang

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

2016-01-13 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review113378 --- src/slave/container_loggers/rotate.hpp (line 36)

Re: Review Request 42254: Checked whether the remaining cluster resources is allocatable.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42254/#review114262 --- Patch looks great! Reviews applied: [42221, 42254] Passed command

Re: Review Request 42196: Added cgroup instructions for CentOS 6.6.

2016-01-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42196/#review114267 --- docs/getting-started.md (line 117)

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

2016-01-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/#review114266 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/option.

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

2016-01-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/ --- (Updated Jan. 13, 2016, 8:11 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 41870: Added ref-qualifiers to Option::get().

2016-01-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41870/ --- (Updated Jan. 13, 2016, 8:12 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 41617: Added a new category called whitespace/mesos-comments to capture missing, leading, white-space in comments

2016-01-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41617/ --- (Updated Jan. 13, 2016, 8:15 p.m.) Review request for mesos and Michael Park.

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review114268 --- Patch looks great! Reviews applied: [41275, 41277, 41280, 41281, 4

Re: Review Request 42262: Improved links at containerizer.md.

2016-01-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42262/ --- (Updated Jan. 13, 2016, 8:38 p.m.) Review request for mesos, Joerg Schad and Jo

Re: Review Request 42263: Added more structure for containerizer related subpages in home.md.

2016-01-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42263/ --- (Updated Jan. 13, 2016, 8:38 p.m.) Review request for mesos, Joerg Schad and Jo

Re: Review Request 42216: Fixed gmock warnings in hook tests.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114271 --- Ship it! Ship It! - Neil Conway On Jan. 12, 2016, 10:27 p.m., A

Re: Review Request 42262: Improved links at containerizer.md.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42262/#review114272 --- Ship it! Ship It! - Neil Conway On Jan. 13, 2016, 8:38 p.m., Jo

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42211/#review114273 --- Bad patch! Reviews applied: [42047] Failed command: ./support/app

Re: Review Request 42263: Added more structure for containerizer related subpages in home.md.

2016-01-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42263/#review114274 --- Ship it! Ship It! - Jojy Varghese On Jan. 13, 2016, 8:38 p.m.,

Re: Review Request 42236: Added a utility function to create https URI.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114278 --- Ship it! Ship It! src/uri/schemes/http.hpp (line 54)

Re: Review Request 42237: Added docker image manifest parsing functions for strings.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/#review114277 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 6:23 a.m., J

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review114279 --- Ship it! Ship It! - Timothy Chen On Jan. 11, 2016, 8:15 p.m., G

Re: Review Request 42215: Added expectations for call to mocked executor shutdown.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/#review114281 --- Ship it! Can you include the names of the tests in the commit mess

Re: Review Request 42216: Fixed gmock warnings in hook tests.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114282 --- Can you include the names of the tests in the commit message? - Ne

Re: Review Request 41819: Added ContainerConfig to all isolators.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41819/ --- (Updated Jan. 13, 2016, 1:19 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/ --- (Updated Jan. 13, 2016, 1:19 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 42215: Added expectations for call to mocked executor shutdown.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/#review114285 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 12:05 a.m.,

Review Request 42264: Fixed a GMock warning in RoleTest.ImplicitRoleStaticReservation.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42264/ --- Review request for mesos, Joris Van Remoortere and Timothy Chen. Bugs: MESOS-43

Review Request 42265: Fixed more tests that didn't set a shutdown expect for MockExecutor.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42265/ --- Review request for mesos, Joris Van Remoortere and Timothy Chen. Bugs: MESOS-43

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review114288 --- Bad patch! Reviews applied: [41096, 41185, 41108] Failed command:

Re: Review Request 42215: Added expectations for a shutdown call in ReservationTests.

2016-01-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/ --- (Updated Jan. 13, 2016, 9:31 p.m.) Review request for mesos, Neil Conway and Ti

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review114290 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 12, 2016, 12:4

Re: Review Request 42215: Added expectations for a shutdown call in ReservationTests.

2016-01-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42215/ --- (Updated Jan. 13, 2016, 9:37 p.m.) Review request for mesos, Neil Conway and Ti

Re: Review Request 41411: Added flags to update summary / desc for reviews.

2016-01-13 Thread Kevin Klues
> On Dec. 17, 2015, 2:26 a.m., Till Toenshoff wrote: > > Ship It! > > Till Toenshoff wrote: > Something is off with your local post-reviews variant - note how the > description here shows `Review: https://reviews.apache.org/r/41411`. Seems a > slash is missing to make the pattern matching

Review Request 42266: Updated post-reviews.py to strip review URL in RR summary.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42266/ --- Review request for mesos, Artem Harutyunyan and Till Toenshoff. Repository: mes

Re: Review Request 42164: Allowed (un)reserve operations without a principal.

2016-01-13 Thread Greg Mann
> On Jan. 13, 2016, 5:22 a.m., Michael Park wrote: > > src/master/validation.cpp, line 703 > > > > > > First thing here is that the `principal` field in `ReservationInfo` is > > still marked `required`. What's our p

Re: Review Request 42052: Refactored Subprocess::IO into an abstract type.

2016-01-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42052/ --- (Updated Jan. 13, 2016, 2:02 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 42059: Updated ContainerLogger to use Subprocess::IO type.

2016-01-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42059/ --- (Updated Jan. 13, 2016, 2:02 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 42059: Updated ContainerLogger to use Subprocess::IO type.

2016-01-13 Thread Joseph Wu
> On Jan. 13, 2016, 11:11 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 829-832 > > > > > > Subprocess::IO out = Subprocess::FD(STDOUT_FILENO); > > Subprocess::IO err =

Review Request 42268: Fixed comment in ReservationTests.

2016-01-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42268/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 42269: Fixed broken links in mesos-provisioner.md.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42269/#review114296 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 10:06 p.m.,

Review Request 42269: Fixed broken links in mesos-provisioner.md.

2016-01-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42269/ --- Review request for mesos, Neil Conway and Timothy Chen. Repository: mesos Des

Re: Review Request 42269: Fixed broken links in mesos-provisioner.md.

2016-01-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42269/#review114297 --- Ship it! Ship It! - Neil Conway On Jan. 13, 2016, 10:06 p.m., J

Re: Review Request 42269: Fixed broken links in mesos-provisioner.md.

2016-01-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42269/ --- (Updated Jan. 13, 2016, 10:09 p.m.) Review request for mesos, Neil Conway and T

Re: Review Request 42216: Fixed gmock warnings in hook tests.

2016-01-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/ --- (Updated Jan. 13, 2016, 10:20 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 42216: Fixed gmock warnings in hook tests.

2016-01-13 Thread Anand Mazumdar
> On Jan. 13, 2016, 9:17 p.m., Neil Conway wrote: > > Can you include the names of the tests in the commit message? Done. - Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114301 --- Patch looks great! Reviews applied: [41244, 41243] Passed command

Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su

2016-01-13 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/#review114307 --- Ship it! Ship It! - M Lawindi On Dec. 23, 2015, 7:16 a.m., Dani

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114295 --- src/uri/fetchers/docker.cpp (lines 435 - 437)

Review Request 42273: Modified scheduler library to move the queue contents before `async`.

2016-01-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42273/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- (Updated Jan. 13, 2016, 11:08 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114318 --- src/uri/fetchers/docker.cpp (line 75)

Re: Review Request 42263: Added more structure for containerizer related subpages in home.md.

2016-01-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42263/#review114320 --- Ship it! Ship It! - Till Toenshoff On Jan. 13, 2016, 8:38 p.m.,

Review Request 42274: Added common command utils file.

2016-01-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42274/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- T

Re: Review Request 41806: Cleaned up assertions in test cases around JSON HTTP responses.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review114322 --- Patch looks great! Reviews applied: [41806] Passed command: expor

Re: Review Request 42262: Improved links at containerizer.md.

2016-01-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42262/#review114321 --- Ship it! Ship It! - Till Toenshoff On Jan. 13, 2016, 11:10 p.m.

Review Request 42275: Added utility functions to create docker URI.

2016-01-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42275/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C

Re: Review Request 42274: Added common command utils file.

2016-01-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42274/ --- (Updated Jan. 13, 2016, 11:13 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/ --- (Updated Jan. 13, 2016, 11:14 p.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 42268: Fixed comment in ReservationTests.

2016-01-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42268/#review114324 --- Ship it! Ship It! - Michael Park On Jan. 13, 2016, 10:02 p.m.,

Re: Review Request 42266: Updated post-reviews.py to strip review URL in RR summary.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42266/ --- (Updated Jan. 13, 2016, 11:23 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

2016-01-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 13, 2016, 11:29 p.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-13 Thread Michael Hopcroft
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114329 --- Ship it! Ship It! - Michael Hopcroft On Jan. 12, 2016, 2:03 a.m

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114299 --- 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/

Review Request 42277: Add mount_all to linux fs.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42277/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42278/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. Repository:

Re: Review Request 42278: Fixed volume paths for command tasks with image.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42278/ --- (Updated Jan. 14, 2016, 12:15 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 41820: Pulled out provisioner from linux filesystem isolator.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41820/#review114340 --- Patch looks great! Reviews applied: [41814, 41999, 41815, 41816, 4

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114342 --- src/uri/fetchers/docker.cpp (line 219)

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review114341 --- Ship it! bootstrap (line 16)

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

2016-01-13 Thread Kevin Klues
> On Jan. 14, 2016, 12:30 a.m., Till Toenshoff wrote: > > bootstrap, line 16 > > > > > > s/allows/allow/ > > > > fixing while committing... sounds good > On Jan. 14, 2016, 12:30 a.m., Till Toenshoff wrote:

Re: Review Request 42238: Implemented the Docker URI fetcher plugin based on curl.

2016-01-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42238/#review114344 --- src/uri/fetchers/docker.cpp (line 280)

Re: Review Request 42018: Windows: Updating ZK patch. Update to winconfig.h. Ignore deprecated warnings

2016-01-13 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42018/ --- (Updated Jan. 14, 2016, 12:43 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 42016: Windows: Apply patch.exe without elevation prompt

2016-01-13 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 14, 2016, 12:43 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114347 --- Ship it! Ship It! - Daniel Pravat On Jan. 7, 2016, 9:47 p.m., A

Re: Review Request 42265: Fixed more tests that didn't set a shutdown expect for MockExecutor.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42265/#review114349 --- Bad patch! Reviews applied: [42265] Failed command: export OS=ubu

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

2016-01-13 Thread Alex Clemmer
> On Jan. 13, 2016, 6:21 p.m., Daniel Pravat wrote: > > src/slave/flags.cpp, line 196 > > > > > > There is a reason why this change is so extensive. This block should be > > replaced with a reasonable default for sw

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated Jan. 14, 2016, 1:13 a.m.) Review request for Alex Naparu, Alex Clemmer

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated Jan. 14, 2016, 1:14 a.m.) Review request for Alex Naparu, Alex Clemmer

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated Jan. 14, 2016, 1:15 a.m.) Review request for Alex Naparu, Alex Clemmer

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Jan. 14, 2016, 1:15 a.m.) Review request for Alex Naparu and Alex Clem

Re: Review Request 42266: Updated post-reviews.py to strip review URL in RR summary.

2016-01-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42266/ --- (Updated Jan. 14, 2016, 1:29 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 35711: Disallow special characters in role name.

2016-01-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review114367 --- Ship it! Ship It! - Klaus Ma On Jan. 14, 2016, 1:12 a.m., haosd

Re: Review Request 42282: Test commit 4.

2016-01-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42282/ --- (Updated Jan. 14, 2016, 1:37 a.m.) Review request for mesos and Kevin Klues.

Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-13 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-4174 https://

Re: Review Request 42052: Refactored Subprocess::IO to improve readability.

2016-01-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42052/ --- (Updated Jan. 13, 2016, 5:55 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41617: Added a new category called whitespace/mesos-comments to capture missing, leading, white-space in comments

2016-01-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41617/ --- (Updated Jan. 14, 2016, 1:59 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42266: Updated post-reviews.py to strip review URL in RR summary.

2016-01-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42266/#review114376 --- Ship it! The whole RBT amending now now works like a charm - thank

Re: Review Request 41491: Unified Container: Exposed docker/appc image manifest to mesos containerizer.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 13, 2016, 6:03 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40940: Windows: Modified `launch.cpp`

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40940/ --- (Updated Jan. 14, 2016, 2:10 a.m.) Review request for mesos, Alex Naparu, Alex

Re: Review Request 41780: Changed ContainerLogger and Fetcher to not duplicate FDs.

2016-01-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41780/ --- (Updated Jan. 13, 2016, 6:12 p.m.) Review request for mesos, Benjamin Hindman,

<    1   2   3   >