Re: Review Request 43312: Updated docs/presentations.md.

> On 二月 10, 2016, 1:57 a.m., haosdent huang wrote: > > docs/presentations.md, line 12 > > > > > > Could we add sildes together? > > > >

Review Request 43403: Updated `docs/presentations.md` to include MesosCon 2015 slides.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43403/ --- Review request for mesos, haosdent huang and Michael Park. Repository: mesos

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

> On Feb. 10, 2016, 3:39 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 424 > > > > > > Can you introduce a new member variable named as `master flags` and get > > the allocation interval from

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

> On Feb. 10, 2016, 4:12 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 64 > > > > > > Do you need the DEFAULT_ALLOCATION_INTERVAL namespace? `using > >

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On 二月 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e. prior

Re: Review Request 43199: Updated authorization documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review118583 --- Ship it! Ship It! - Guangya Liu On 二月 10, 2016, 12:32 a.m.,

Re: Review Request 42342: Added a new test cases for revive offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/ --- (Updated 二月 10, 2016, 5:09 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118586 --- src/docker/docker.cpp (line 521)

Re: Review Request 43388: Revised authentication documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/#review118588 --- Patch looks great! Reviews applied: [43388] Passed command:

Re: Review Request 43328: Title for documentation webpages.

> On Feb. 10, 2016, 1:12 a.m., Neil Conway wrote: > > We should make sure we're consistent with capitalization of titles. Also we > > should make the title match the Markdown title (the "#" phrase at the top > > of the page), not the file name. > > > > Lastly, I think we should probably have

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 10, 2016, 1:42 a.m.) Review request for mesos and Bernd

Re: Review Request 43312: Updated docs/presentations.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43312/#review118549 --- Fix it, then Ship it! Ship It! docs/presentations.md (line

Re: Review Request 42908: Fixed a flaky test in quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review118551 --- src/tests/master_quota_tests.cpp (lines 990 - 991)

Re: Review Request 43388: Revised authentication documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/#review118556 --- Fix it, then Ship it! Ship It! docs/authentication.md (line

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 850 > > > > > > Does this still needed? > > haosdent huang wrote: > I think still need, we don't sure what would happend

Re: Review Request 43403: Updated `docs/presentations.md` to include MesosCon 2015 slides.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43403/#review118562 --- Ship it! Please also update the `bug` field to MESOS-2444 -

Re: Review Request 43312: Updated docs/presentations.md.

> On Feb. 10, 2016, 1:57 a.m., haosdent huang wrote: > > docs/presentations.md, line 12 > > > > > > Could we add sildes together? > > > >

Re: Review Request 43403: Updated `docs/presentations.md` to include MesosCon 2015 slides.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43403/ --- (Updated 二月 10, 2016, 3:28 a.m.) Review request for mesos, haosdent huang and

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

> On 二月 10, 2016, 3:39 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 424 > > > > > > Can you introduce a new member variable named as `master flags` and get > > the allocation interval from

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118566 --- Patch looks great! Reviews applied: [42696, 43316, 43367]

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 850 > > > > > > Does this still needed? > > haosdent huang wrote: > I think still need, we don't sure what would happend

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On 二月 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processed

Re: Review Request 43318: Updated release guide to include doxygen site generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43318/#review118555 --- Patch looks great! Reviews applied: [43382, 43319, 43122, 43318]

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On 二月 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 850 > > > > > > Does this still needed? > > haosdent huang wrote: > I think still need, we don't sure what would happend in

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 10, 2016, 4:01 a.m.) Review request for mesos and Bernd

Re: Review Request 43304: Mesos: Disambiguated call to 'subprocess' in linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43304/#review118570 --- Ship it! Ship It! - Benjamin Hindman On Feb. 9, 2016, 7:13

Re: Review Request 43303: Libprocess: Added 'parent_hooks' as an argument to 'subprocess'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43303/#review118568 --- Fix it, then Ship it! 3rdparty/libprocess/src/subprocess.cpp

Re: Review Request 43305: Moved systemd executor slice initialization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43305/#review118480 --- Fix it, then Ship it! src/linux/systemd.hpp (line 30)

Re: Review Request 43307: Added systemd life-extension option to docker process containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43307/#review118571 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43309/#review118573 --- Fix it, then Ship it!

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43308/#review118572 --- Fix it, then Ship it!

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118576 --- src/tests/fetcher_cache_tests.cpp (line 64)

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 10, 2016, 4:17 a.m.) Review request for mesos and Bernd

Re: Review Request 43384: Improved error handling in generate-endpoint-help script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/#review118544 --- Patch looks great! Reviews applied: [43384] Passed command:

Re: Review Request 43399: Windows: Added `stout/os/read.hpp` include to `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43399/#review118543 --- Ship it! Ship It! - Michael Park On Feb. 10, 2016, 1:12

Re: Review Request 43398: CMake: Added AppC spec protocol buffer to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43398/#review118542 --- Ship it! Ship It! - Michael Park On Feb. 10, 2016, 1:12

Re: Review Request 43312: Updated docs/presentations.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43312/#review118548 --- Ship it! Ship It! - Michael Park On Feb. 10, 2016, 1:51

Re: Review Request 43313: Fixed Typos in support/hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43313/#review118547 --- Ship it! Ship It! - Michael Park On Feb. 10, 2016, 1:51

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118546 --- Fix it, then Ship it! Ship It! src/linux/perf.cpp (line 466)

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118563 --- src/tests/fetcher_cache_tests.cpp (lines 193 - 195)

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

> On Feb. 10, 2016, 3:39 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 424 > > > > > > Can you introduce a new member variable named as `master flags` and get > > the allocation interval from

Re: Review Request 43302: Libprocess: Introduced Hooks for Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43302/#review118567 --- Fix it, then Ship it!

Re: Review Request 43322: Exposed `ContainerStatus` in `state.json`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43322/#review118581 --- Ship it! Ship It! - Guangya Liu On 二月 8, 2016, 8:33 p.m.,

Review Request 43410: Windows: Added support for dynamic library loading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 39968: Enable endpoint include nested paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/#review118596 --- 3rdparty/libprocess/src/help.cpp (line 122)

Re: Review Request 43410: Windows: Added support for dynamic library loading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/ --- (Updated Feb. 10, 2016, 6:47 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 10, 2016, 6:47 a.m.) Review request for mesos, Alex Naparu,

Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Review Request 43411: Windows: Added dynamic library loading tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 43201: Updated reservation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118609 --- Fix it, then Ship it! docs/reservation.md (lines 56 - 57)

Re: Review Request 43201: Updated reservation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118608 --- docs/reservation.md (line 62)

Review Request 43407: CMake: Force GMock to build and link statically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Repository:

Re: Review Request 43410: Windows: Added support for dynamic library loading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/ --- (Updated Feb. 10, 2016, 6:44 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/ --- (Updated Feb. 10, 2016, 6:44 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/ --- (Updated Feb. 10, 2016, 6:44 a.m.) Review request for mesos, Joris Van

Re: Review Request 43407: CMake: Force GMock to build and link statically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/ --- (Updated Feb. 10, 2016, 6:44 a.m.) Review request for mesos, Joris Van

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43323/ --- (Updated Feb. 10, 2016, 6:49 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

> On Feb. 10, 2016, 1:26 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, line 1089 > > > > > > Can you do > > ``` > > namespace http = process::http; > > ``` > > in the begining

Re: Review Request 43403: Updated `docs/presentations.md` to include MesosCon 2015 slides.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43403/#review118599 --- Patch looks great! Reviews applied: [43403] Passed command:

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43323/ --- (Updated Feb. 10, 2016, 7:05 a.m.) Review request for mesos and Jie Yu.

Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43418/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Review Request 43416: Windows: Removed ambiguous call to `::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and

Re: Review Request 43200: Updated role documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118606 --- Ship it! Ship It! - Adam B On Feb. 9, 2016, 4:41 p.m., Greg

Re: Review Request 42658: Restructured comments in allocator tests for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42658/#review118418 --- Ship it! Ship It! - Ben Mahler On Jan. 28, 2016, 1:11 p.m.,

Re: Review Request 42672: Explicitly checked for the absence of allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42672/#review118420 --- Ship it! Ship It! - Ben Mahler On Jan. 28, 2016, 1:22 p.m.,

Re: Review Request 42911: Removed extra blank line.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42911/#review118426 --- Ship it! Ship It! - Ben Mahler On Jan. 28, 2016, 1:13 p.m.,

Re: Review Request 42633: Corrected a comment in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42633/#review118416 --- Ship it! Ship It! - Ben Mahler On Feb. 2, 2016, 10:28 a.m.,

<    1   2