Re: Review Request 42516: Add support for user-defined networks.

> On 二月 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. > >

Review Request 43422: Added missing test finalization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43422/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 42908: Fixed a flaky test in quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/ --- (Updated Feb. 10, 2016, 3:56 p.m.) Review request for mesos, Michael Park and

Re: Review Request 43127: Introduced Appc image cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43127/ --- (Updated Feb. 10, 2016, 3:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 39968: Enabled http endpoint include nested paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/ --- (Updated 二月 10, 2016, 1:37 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39968: Enabled http endpoint include nested paths.

> On 二月 10, 2016, 6:47 a.m., haosdent huang wrote: > > 3rdparty/libprocess/src/help.cpp, line 124 > > > > > > I think could use > > ``` > > strings::split(strings::trim(request.url.path, strings::ANY, "/"),

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:41 p.m., Szymon Konefal wrote: > > src/linux/perf.cpp, line 479 > > > > > > Shouldn't we use 'nullptr' instead of NULL? > > Bartek Plotka wrote: > +1 IMO `nullptr` sounds like a good

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:41 p.m., Szymon Konefal wrote: > > src/linux/perf.cpp, line 479 > > > > > > Shouldn't we use 'nullptr' instead of NULL? +1 IMO `nullptr` sounds like a good choice. All, do you agree with that?

Re: Review Request 42342: Added a new test cases for revive offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review118646 --- Ship it! Ship It! - haosdent huang On Feb. 10, 2016, 5:09

Re: Review Request 43198: Added common appc spec utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43198/ --- (Updated Feb. 10, 2016, 3:11 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 42342: Added a new test cases for revive offer.

> On 二月 10, 2016, 11:32 a.m., haosdent huang wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2409 > > > > > > should we settle before `advance` I think it should be OK as long as the `settle` is before

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim.

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. >

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118637 --- src/linux/perf.cpp (line 474)

Re: Review Request 43328: Title for documentation webpages.

> On Feb. 10, 2016, 1:12 a.m., Neil Conway wrote: > > We should make sure we're consistent with capitalization of titles. Also we > > should make the title match the Markdown title (the "#" phrase at the top > > of the page), not the file name. > > > > Lastly, I think we should probably have

Re: Review Request 42516: Add support for user-defined networks.

> On Feb. 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. >

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. > >

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

> On 二月 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processed

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43309/ --- (Updated Feb. 10, 2016, 4:54 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43304: Mesos: Disambiguated call to 'subprocess' in linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43304/ --- (Updated Feb. 10, 2016, 4:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43322: Exposed `ContainerStatus` in `state.json`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43322/#review118676 --- May be rename the description to mention `cgroup_info` instead of

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

> On Feb. 9, 2016, 10:22 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp, line 310 > > > > > > What about something like: > > > > ```c++ > > // Capture the freezer

Re: Review Request 43302: Libprocess: Introduced Hooks for Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43302/ --- (Updated Feb. 10, 2016, 4:48 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43303: Libprocess: Added 'parent_hooks' as an argument to 'subprocess'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43303/ --- (Updated Feb. 10, 2016, 4:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43323/#review118678 --- Patch looks great! Reviews applied: [42782, 42947, 42982, 42983,

Re: Review Request 43105: Ensured the allocator does not double account resources.

> On Feb. 4, 2016, 3:46 p.m., Guangya Liu wrote: > > This case may happen when master is recovering, framework recovery start > > before some agent. Can you please add a unit test to cover this code > > change? It could be register framework first, then addslave and check the > > result. > >

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

> On Feb. 10, 2016, 11:50 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43407, 43409, 43410] > > > > Failed command: ./support/apply-review.sh -n -r 43410 > > > > Error: > > 2016-02-10 11:49:59 URL:https://reviews.apache.org/r/43410/diff/raw/ > > [8010/8010] ->

Re: Review Request 39968: Enabled http endpoint include nested paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/#review118671 --- 3rdparty/libprocess/src/help.cpp (lines 170 - 187)

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/ --- (Updated Feb. 10, 2016, 4:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43308/ --- (Updated Feb. 10, 2016, 4:53 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43307: Added systemd life-extension option to docker process containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43307/ --- (Updated Feb. 10, 2016, 4:52 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 2:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43344: Added flag `--cgroups_net_cls_primary_handle`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43344/#review118680 --- Ship it! Ship It! - Jie Yu On Feb. 8, 2016, 11:43 p.m.,

Re: Review Request 43305: Moved systemd executor slice initialization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43305/ --- (Updated Feb. 10, 2016, 4:50 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118674 --- Ship it! Ship It! - Kapil Arya On Feb. 9, 2016, 6:47 p.m.,

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 10, 2016, 4:36 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43323/#review118677 --- Ship it! Ship It! - Kapil Arya On Feb. 10, 2016, 2:05 a.m.,

Re: Review Request 43388: Revised authentication documentation.

> On Feb. 10, 2016, 3:04 a.m., Guangya Liu wrote: > > docs/authentication.md, line 65 > > > > > > The MESOS-2281 is planning to remove the JSON format credential, does > > it make sense to remove the `JSON format`

Re: Review Request 42754: Added support for labels to resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review118700 --- include/mesos/type_utils.hpp (line 71)

Re: Review Request 42754: Added support for labels to resource reservations.

> On Feb. 10, 2016, 12:19 a.m., Michael Park wrote: > > include/mesos/type_utils.hpp, line 71 > > > > > > We should keep the 2 newlines here. There are other parts that need 2 > > lines also, for example between

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42842/#review118689 --- Ship it! Ship It! - haosdent huang On Feb. 10, 2016, 5:49

Re: Review Request 43410: Windows: Added support for dynamic library loading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/ --- (Updated Feb. 10, 2016, 6:01 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42908: Fixed a flaky test in quota tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42908/#review118721 --- Patch looks great! Reviews applied: [43422, 42908] Passed

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/ --- (Updated Feb. 10, 2016, 9:15 p.m.) Review request for mesos, Joris Van

Re: Review Request 42908: Fixed a flaky test in quota tests.

> On Feb. 10, 2016, 2:04 a.m., Michael Park wrote: > > src/tests/master_quota_tests.cpp, lines 993-1000 > > > > > > Did we not need these before for some reason? > > Alexander Rukletsov wrote: > We did, it was

Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43432/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118742 --- Patch looks great! Reviews applied: [43358] Passed command:

Re: Review Request 39968: Enabled http endpoint include nested paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/#review118727 --- Patch looks great! Reviews applied: [39968] Passed command:

Re: Review Request 43305: Moved systemd executor slice initialization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43305/#review118733 --- src/slave/containerizer/mesos/linux_launcher.cpp

Re: Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43432/ --- (Updated Feb. 10, 2016, 2:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42842/ --- (Updated Feb. 10, 2016, 9:49 a.m.) Review request for mesos, Artem

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118708 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42754: Added support for labels to resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- (Updated Feb. 10, 2016, 6:59 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43456: Prevented linux fs isolator mounting rootfs for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43456/ --- (Updated Feb. 10, 2016, 4:43 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43432/ --- (Updated Feb. 10, 2016, 4:34 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43432/#review118782 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 11, 2016,

Review Request 43461: Used C++11 for loop to iterate std list/set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Repository:

Review Request 43462: Used list::splice() for clock::tick().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43462/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Repository:

Re: Review Request 43452: Removed `Volumes` in docker v1 manifest protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43452/ --- (Updated Feb. 10, 2016, 4:42 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43451: Fixed local puller switch condition to support docker registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43451/ --- (Updated Feb. 10, 2016, 4:42 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43453: Added shell flag to mesos-execute to run image default config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43453/ --- (Updated Feb. 10, 2016, 4:43 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 38117: Added per container SNMP statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Feb. 11, 2016, 12:48 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 43201: Updated reservation documentation.

> On 二月 11, 2016, 2:59 a.m., Guangya Liu wrote: > > docs/reservation.md, lines 61-63 > > > > > > What about putting NOTE to a new line? > > > > > NOTE: As of 0.27.0, these endpoints cannot be used when HTTP

Re: Review Request 43466: Added const qualifier for uri::Fetcher::fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43466/#review118816 --- Bad patch! Reviews applied: [41958, 41959, 42156, 42157, 43127,

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118817 --- Ship it! Ship It! - haosdent huang On Feb. 11, 2016, 5:37

Re: Review Request 43461: Used C++11 for loop to iterate std list/set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43461/#review118809 --- Patch looks great! Reviews applied: [43461] Passed command:

Re: Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/#review118818 --- 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp (line

Re: Review Request 39968: Enabled http endpoint include nested paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/#review118819 --- Ship it! Ship It! - haosdent huang On Feb. 11, 2016, 5:37

Re: Review Request 39968: Enabled http endpoint include nested paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/ --- (Updated 二月 11, 2016, 5:37 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43201: Updated reservation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118830 --- Patch looks great! Reviews applied: [43199, 43200, 43201]

Review Request 43469: Added a parameter to specify the maximum number of tokens for tokenize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43469/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3833

Re: Review Request 43201: Updated reservation documentation.

> On Feb. 11, 2016, 2:59 a.m., Guangya Liu wrote: > > docs/reservation.md, lines 61-63 > > > > > > What about putting NOTE to a new line? > > > > > NOTE: As of 0.27.0, these endpoints cannot be used when

Re: Review Request 38117: Added per container SNMP statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review118813 --- Patch looks great! Reviews applied: [38117] Passed command:

Re: Review Request 43199: Updated authorization documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review118611 --- Fix it, then Ship it! Just a few clarification questions, but

Re: Review Request 42342: Added a new test cases for revive offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review118626 --- Patch looks great! Reviews applied: [39628, 42342] Passed

Re: Review Request 39968: Enable endpoint include nested paths

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39968/#review118622 --- 3rdparty/libprocess/src/help.cpp (lines 120 - 131)

Re: Review Request 43328: Title for documentation webpages.

> On Feb. 10, 2016, 1:12 a.m., Neil Conway wrote: > > We should make sure we're consistent with capitalization of titles. Also we > > should make the title match the Markdown title (the "#" phrase at the top > > of the page), not the file name. > > > > Lastly, I think we should probably have

Re: Review Request 42342: Added a new test cases for revive offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review118627 --- src/tests/hierarchical_allocator_tests.cpp (line 2409)

Re: Review Request 43388: Revised authentication documentation.

> On Feb. 9, 2016, 5:28 p.m., Adam B wrote: > > docs/authentication.md, line 49 > > > > > > We may be deprecating the plaintext format soon As Guangya points out, it's actually the json format that we'll be

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118616 --- Ship it! Ship It! - haosdent huang On Feb. 10, 2016, 8:34

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review118617 --- Looks good, but I think we can pull this information into the

Re: Review Request 42754: Added support for labels to resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review118612 --- include/mesos/v1/mesos.hpp (line 64)

Re: Review Request 42908: Fixed a flaky test in quota tests.

> On Feb. 5, 2016, 3:11 a.m., Till Toenshoff wrote: > > src/tests/master_quota_tests.cpp, line 901 > > > > > > I feel this comment as-is does not add much. > > > > Either removing it or supplying a

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 10, 2016, 8:34 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 42908: Fixed a flaky test in quota tests.

> On Feb. 10, 2016, 2:04 a.m., Michael Park wrote: > > src/tests/master_quota_tests.cpp, lines 993-1000 > > > > > > Did we not need these before for some reason? We did, it was a bug. I believe you mean we should

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 10, 2016, 12:39 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review118629 --- Bad patch! Reviews applied: [43407, 43409, 43410] Failed

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:54 a.m., haosdent huang wrote: > > src/linux/perf.cpp, line 471 > > > > > > How about move `` and `` out in a const > > variable? So that avoid we write these strings again and agiain. +1,

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:54 a.m., haosdent huang wrote: > > src/linux/perf.cpp, line 493 > > > > > > should be better use `0u` here? Refer to bernd's patch > > https://reviews.apache.org/r/43359/diff/1#index_header to

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 10, 2016, 12:38 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118633 --- src/docker/docker.cpp (line 526)

Re: Review Request 42516: Add support for user-defined networks.

> On 二月 10, 2016, 1:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 526 > > > > > > I prefer that we use "higher than" or "greater than" instead of ">=", > > we can wait for the comments from Tim. > >

Re: Review Request 43201: Updated reservation documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118806 --- Fix it, then Ship it! docs/reservation.md (lines 61 - 63)

Re: Review Request 43462: Used list::splice() for clock::tick().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43462/#review118807 --- Patch looks great! Reviews applied: [43462] Passed command:

Re: Review Request 43127: Introduced Appc image cache.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43127/#review118704 --- src/slave/containerizer/mesos/provisioner/appc/cache.hpp (line

Re: Review Request 43450: Fixed typo in log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43450/ --- (Updated Feb. 10, 2016, 11:16 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43198: Added common appc spec utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43198/#review118756 --- Fix it, then Ship it! include/mesos/appc/spec.hpp (line 60)

  1   2   >