Re: Review Request 48028: Implemented v1::master::Call::GET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48028/#review135476 --- Patch looks great! Reviews applied: [48028] Passed command:

Re: Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/#review135482 --- Ship it! I like this new layout and it give use foundation for

Re: Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/#review135469 --- site/source/assets/css/main.css (line 121)

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47987/#review135466 --- Ship it! Ship It! - Vinod Kone On May 29, 2016, 9:05 a.m.,

Re: Review Request 48020: Refreshed the Mesos project website homepage.

> On May 30, 2016, 8:02 a.m., Tomasz Janiszewski wrote: > > @janisz, Thanks a lot for your helpful review comments, could you help review this again? Thank you in advance. > On May 30, 2016, 8:02 a.m., Tomasz Janiszewski wrote: > > site/source/assets/css/main.css, line 134 > >

Review Request 48028: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48028/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5485

Re: Review Request 48028: Implemented v1::master::Call::GET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48028/ --- (Updated May 30, 2016, 7:50 a.m.) Review request for mesos and Vinod Kone.

Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48029/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5512

Re: Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/ --- (Updated May 30, 2016, 9:13 a.m.) Review request for mesos, Tomasz Janiszewski

Re: Review Request 46756: V1 API: Split Resource offers and Inverse Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46756/#review135481 --- src/examples/test_http_framework.cpp (lines 130 - 131)

Re: Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48029/#review135471 --- Ship it! Ship It! - Vinod Kone On May 30, 2016, 7:50 a.m.,

Re: Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48029/#review135477 --- @haosdent, are you missing the `validation` for both master and

Re: Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

> On May 30, 2016, 8:50 a.m., Guangya Liu wrote: > > @haosdent, are you missing the `validation` for both master and agent for > > GET_LOGGING_LEVEL? > > https://github.com/apache/mesos/blob/master/src/master/validation.cpp#L87-L88 Hi, @gyliu Thanks a lot for your review. Because we don't

Review Request 48033: Fixed sign/unsigned comparison introduced in `f22af98`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48033/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46757/#review135487 --- src/messages/messages.proto (line 292)

Re: Review Request 48034: Added v1 files to CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48034/#review135495 --- Ship it! The original autotools specific patch introducing

Re: Review Request 48020: Refreshed the Mesos project website homepage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48020/#review135490 --- Patch looks great! Reviews applied: [48020] Passed command:

Re: Review Request 48020: Refreshed the Mesos project website homepage.

> On May 30, 2016, 9:26 a.m., Tomasz Janiszewski wrote: > > I like this new layout and it give use foundation for further enhancements Agreed, credited by @jmanalus's nice design XD. - haosdent --- This is an automatically generated

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

> On 五月 29, 2016, 1:36 a.m., Vinod Kone wrote: > > src/files/files.cpp, line 374 > > > > > > Can we fix the pailer to not send -1 length in a follow up patch? yes, will submit a patch then - zhou

Re: Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

> On 五月 30, 2016, 8:50 a.m., Guangya Liu wrote: > > @haosdent, are you missing the `validation` for both master and agent for > > GET_LOGGING_LEVEL? > > https://github.com/apache/mesos/blob/master/src/master/validation.cpp#L87-L88 > > haosdent huang wrote: > Hi, @gyliu Thanks a lot for

Review Request 48034: Added v1 files to CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48034/ --- Review request for mesos and Bernd Mathiske. Repository: mesos Description

Re: Review Request 48034: Added v1 files to CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48034/#review135494 --- Ship it! Ship It! - Bernd Mathiske On May 30, 2016, 3:21

Re: Review Request 48033: Fixed signed/unsigned comparison introduced in `f22af98`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48033/ --- (Updated May 30, 2016, 12:23 p.m.) Review request for mesos and Bernd

Re: Review Request 46758: V1 API: Split Accept/Decline for offers and Inverse Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46758/#review135489 --- include/mesos/scheduler/scheduler.proto (line 270)

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135504 --- Patch looks great! Reviews applied: [46373] Passed command:

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/ --- (Updated May 30, 2016, 3:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47906: Added/updated documentation for --modules and --modules_dir flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47906/#review135514 --- docs/modules.md (line 37)

Re: Review Request 47905: Added test for --modules_dir flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47905/#review135515 --- Fix it, then Ship it! src/tests/module_tests.cpp (lines 17 -

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/#review135510 --- src/master/quota_handler.cpp (lines 517 - 522)

Re: Review Request 47805: Add authorization to GET /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/ --- (Updated 五月 30, 2016, 2:05 p.m.) Review request for mesos and Adam B.

Re: Review Request 47906: Added/updated documentation for --modules and --modules_dir flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47906/ --- (Updated May 30, 2016, 10:43 a.m.) Review request for mesos and Till

Re: Review Request 47905: Added test for --modules_dir flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47905/ --- (Updated May 30, 2016, 11 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/#review135516 --- Fix it, then Ship it! src/module/manager.hpp (line 37)

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/#review135513 --- Bad patch! Reviews applied: [48040, 48039, 48038, 48037, 47977,

Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod

Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod

Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48040/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod

Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135517 --- Patch looks great! Reviews applied: [47891] Passed command:

Re: Review Request 47906: Added/updated documentation for --modules and --modules_dir flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47906/#review135519 --- Ship it! Ship It! - Till Toenshoff On May 30, 2016, 2:43

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/#review135524 --- src/authorizer/local/authorizer.cpp (line 59)

Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5493

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/ --- (Updated May 30, 2016, 4:55 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135525 --- LGTM, just one minor issue where we could benefit from

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 30, 2016, 11:19 a.m.) Review request for mesos, Cody Maloney and

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/#review135520 --- Fix it, then Ship it!

Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48048/ --- Review request for mesos, Adam B, Joerg Schad, and Michael Park. Bugs:

Re: Review Request 47905: Added test for --modules_dir flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47905/ --- (Updated May 30, 2016, 11:22 a.m.) Review request for mesos and Till

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 30, 2016, 11:22 a.m.) Review request for mesos, Cody Maloney and

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

> On May 30, 2016, 3:28 p.m., Joerg Schad wrote: > > include/mesos/authorizer/authorizer.hpp, line 58 > > > > > > I guess we also need to copy this new field over to the C++ object, or? > > See `Future

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/#review135521 --- include/mesos/authorizer/authorizer.hpp (line 58)

Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47123/ --- (Updated May 30, 2016, 11:54 a.m.) Review request for mesos, Cody Maloney and

Re: Review Request 47805: Add authorization to GET /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/#review135523 --- Patch looks great! Reviews applied: [47805] Passed command:

Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5497

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 30, 2016, 4:47 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 30, 2016, 4:48 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 30, 2016, 4:47 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47559: Added authorization based filtering to /state-summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 30, 2016, 4:47 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47905: Added test for --modules_dir flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47905/ --- (Updated May 30, 2016, 1:17 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 30, 2016, 10:05 p.m.) Review request for mesos, Adam B and

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 30, 2016, 10:05 p.m.) Review request for mesos and Michael Park.

Re: Review Request 45562: Edited `--work_dir` configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated May 30, 2016, 11:20 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/ --- (Updated May 31, 2016, 12:09 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

> On May 24, 2016, 11:07 p.m., Joris Van Remoortere wrote: > > src/CMakeLists.txt, line 259 > > > > > > Why here as opposed to alphabetical? > > Alex Clemmer wrote: > In `CMakeLists.txt`, we have making them

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review135583 --- Bad patch! Reviews applied: [47511] Failed command:

Review Request 48054: Added intergration tests for authorization based endpoint filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 47558: Added ObjectApprover interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 30, 2016, 10:07 p.m.) Review request for mesos, Adam B and

Re: Review Request 47704: Used TaskObjectApprover to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 30, 2016, 10:08 p.m.) Review request for mesos and Michael Park.

Re: Review Request 46004: Updated master '--work_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/#review135556 --- Fix it, then Ship it! src/master/flags.cpp (line 59)

Re: Review Request 46003: Removed the default value for agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/#review13 --- Fix it, then Ship it! src/local/local.cpp (line 351)

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/ --- (Updated May 30, 2016, 11:54 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 31, 2016, 12:46 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review135585 --- Fix it, then Ship it!

Re: Review Request 48033: Fixed signed/unsigned comparison introduced in `f22af98`.

> On May 30, 2016, 5:46 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 180 > > > > > > should we change the GetLoggingLevel::level to be int32 instead? not > > sure why glog chose FLAGS_v to be signed. >

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

> On May 30, 2016, 5:42 p.m., Gilbert Song wrote: > > docs/docker-volume-isolator.md, lines 45-55 > > > > > > Or it seems to me that you should merge this to the 'without' paragraph. I have removed the `without`

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 30, 2016, 11:44 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 48052: Factored out `approved` function for `LocalAuthorizerObjectApprover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48052/#review135566 --- Bad patch! Reviews applied: [48052, 47558, 47875, 46613, 47069,

Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47474/#review135570 --- src/logging/logging.cpp (line 202)

Re: Review Request 46104: Made use of random container IDs in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/#review135578 --- Patch looks great! Reviews applied: [46620, 46814, 46621, 47078,

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47603/ --- (Updated May 31, 2016, 3:31 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47943/ --- (Updated May 31, 2016, 3:31 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48038/#review135548 --- src/authorizer/local/authorizer.cpp (line 349)

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48039/#review135549 --- src/master/master.hpp

Re: Review Request 48051: Expose auto refresh port in site docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/#review135552 --- Patch looks great! Reviews applied: [48051] Passed command:

Re: Review Request 46003: Removed the default value for agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- (Updated May 30, 2016, 11:18 p.m.) Review request for mesos, Michael Park and

Review Request 48053: Removed discarded handling from .repair() call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48053/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47873/#review135574 --- src/exec/exec.cpp (line 652)

Re: Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47873/#review135575 --- Ship it! Ship It! - Joris Van Remoortere On May 30, 2016,

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review135586 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp

Re: Review Request 48051: Expose auto refresh port in site docker.

> On May 30, 2016, 9:10 p.m., Vinod Kone wrote: > > site/Dockerfile, line 4 > > > > > > what is this additional port for? It's used by middleman to provide page autoreload when changes to files are deteted. In

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48037/#review135547 --- include/mesos/authorizer/authorizer.proto

Re: Review Request 47821: Remove SASL dependency for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47821/ --- (Updated May 30, 2016, 10:03 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/ --- (Updated May 30, 2016, 10:19 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 46093: Enhanced the error message for invalid duration unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46093/#review135551 --- Fix it, then Ship it! I'll fix the issue and commit it for

Re: Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/#review135559 --- Fix it, then Ship it! docs/operational-guide.md (line 55)

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/ --- (Updated May 30, 2016, 11:21 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review135564 --- Bad patch! Reviews applied: [47511] Failed command:

Re: Review Request 48052: Factored out `approved` function for `LocalAuthorizerObjectApprover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48052/#review135562 --- Ship it! Ship It! - Joerg Schad On May 30, 2016, 11:46

Review Request 48052: Factored out `approved` function for `LocalAuthorizerObjectApprover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48052/ --- Review request for mesos, Alexander Rukletsov and Joerg Schad. Repository:

Re: Review Request 46104: Made use of random container IDs in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46104/ --- (Updated May 30, 2016, 11:54 p.m.) Review request for mesos and Jie Yu.

  1   2   >