Re: Review Request 49219: Added runtime isolator interface to run appc containers.

2016-07-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/#review140320 --- Fix it, then Ship it! Ship It!

Re: Review Request 49412: Updated SSL.md with 'SSL_VERIFY_IPADD'.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49412/#review140322 --- Patch looks great! Reviews applied: [49400, 49401, 49402, 49411,

Re: Review Request 49501: Added cmake target to build mesos-master.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49501/#review140338 --- Patch looks great! Reviews applied: [49501] Passed command:

Review Request 49503: Fixed usage of some GMock expectations.

2016-07-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49503/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.

2016-07-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49465/ --- (Updated July 1, 2016, 10:31 a.m.) Review request for mesos, Abhishek

Re: Review Request 49464: Updated operator APIs proto files for `GET_EXECUTORS` call.

2016-07-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49464/ --- (Updated July 1, 2016, 10:31 a.m.) Review request for mesos, Abhishek

Re: Review Request 49369: Introduced authorization based filtering for /roles.

2016-07-01 Thread Joerg Schad
> On June 30, 2016, 8:53 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2855 > > > > > > can you please fix this as well? > > > > also you need to fix the GET_WEIGHTS call. Fixed getRoles() With

Re: Review Request 49469: Added new utility function, `frameworkHasCapability()`.

2016-07-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49469/ --- (Updated July 1, 2016, 10:59 a.m.) Review request for mesos and Vinod Kone.

Review Request 49501: Added cmake target to build mesos-master.

2016-07-01 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49501/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-3541

Re: Review Request 49376: Added assertions to DRFSorter.

2016-07-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49376/ --- (Updated July 1, 2016, 9:47 a.m.) Review request for mesos, Alexander

Re: Review Request 49323: Added tests that combine the two ways of creating volumes.

2016-07-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49323/ --- (Updated July 1, 2016, 9:47 a.m.) Review request for mesos, Alexander

Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.

2016-07-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/ --- (Updated July 1, 2016, 9:47 a.m.) Review request for mesos, Alexander

Re: Review Request 49375: Simplified DRFSorter to not track per-slave total resources.

2016-07-01 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49375/ --- (Updated July 1, 2016, 9:47 a.m.) Review request for mesos, Alexander

Re: Review Request 49500: Moved TODO to correct place in master/http.cpp.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49500/#review140333 --- Bad patch! Reviews applied: [49500, 49370, 49369] Failed

Review Request 49500: Moved TODO to correct place in master/http.cpp.

2016-07-01 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49500/ --- Review request for mesos, Adam B and Vinod Kone. Repository: mesos

Re: Review Request 49201: Added validation for the `get_endpoints` ACL.

2016-07-01 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49201/ --- (Updated July 1, 2016, 11:48 a.m.) Review request for mesos, Adam B, Jan

Re: Review Request 49489: Refactor master::Http::getFrameworks to resuable helper.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140328 --- Patch looks great! Reviews applied: [49487, 49488, 49489]

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-07-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review140313 --- Srini, this patch was already merged, why are you continually

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

2016-07-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review140123 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

2016-07-01 Thread Guangya Liu
> On 七月 1, 2016, 7:06 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 212-213 > > > > > > 1) You should add a "'" to the end of the log message. > > 2) s/image/Appc

Re: Review Request 49348: Added basic test to invoke Appc Runtime Isolator.

2016-07-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review140317 --- You will probably need to add a new test file just like what we

Re: Review Request 49483: Add Charles Allen to contributors

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49483/#review140312 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 49348: Added basic test to invoke Appc Runtime Isolator.

2016-07-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review140315 --- I think that this patch should be created after the function

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-07-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/#review140343 --- 3rdparty/Makefile.am (line 305)

Re: Review Request 49483: Add Charles Allen to contributors

2016-07-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49483/#review140339 --- Ship it! Ship It! - Alexander Rukletsov On July 1, 2016,

Re: Review Request 49487: Refactor masterHttp::getTasks into helper function.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- (Updated July 1, 2016, 1:31 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49487: Refactor master::Http::getTasks into helper function.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/ --- (Updated July 1, 2016, 1:32 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/ --- (Updated July 1, 2016, 1:34 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/ --- (Updated July 1, 2016, 1:37 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49377: Fixed allocator to update total resources in quota sorter.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/#review140359 --- Patch looks great! Reviews applied: [49323, 49375, 49376, 49377]

Re: Review Request 49369: Introduced authorization based filtering for /roles.

2016-07-01 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/ --- (Updated July 1, 2016, 2:39 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

2016-07-01 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49370/ --- (Updated July 1, 2016, 2:40 p.m.) Review request for mesos, Adam B and Vinod

Review Request 49518: Initial snapshot for v1 master event stream.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Review Request 49516: Refactor Master::Http::getExecutors into helper function.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-07-01 Thread Kevin Klues
> On July 1, 2016, 1:29 p.m., Kapil Arya wrote: > > 3rdparty/Makefile.am, line 305 > > > > > > Will `NVML` install any additional non-include files? If so, we need to > > fix `DESTDIR`. No. Here are the contents

Review Request 49520: Fixed the flaky BusyMountPoint test.

2016-07-01 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5752

Re: Review Request 49509: Revised protobuf definition of GetState response.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/ --- (Updated July 1, 2016, 4:07 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49503: Fixed usage of some GMock expectations.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49503/#review140377 --- Patch looks great! Reviews applied: [49503] Passed command:

Review Request 49509: Revised protobuf definition of GetState response.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/ --- Review request for mesos. Repository: mesos Description --- Revised

Re: Review Request 49369: Introduced authorization based filtering for /roles.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/#review140399 --- src/master/http.cpp (lines 2896 - 2938)

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49370/#review140400 --- Fix it, then Ship it! CHANGELOG (line 51)

Re: Review Request 49488: Refactor master::Http::getAgents into helper function.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140404 --- src/master/http.cpp (lines 1964 - 1967)

Re: Review Request 49516: Refactor Master::Http::getExecutors into helper function.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/#review140411 --- src/master/http.cpp (line 1428)

Re: Review Request 49523: Moved MESOS_CONTAINERIZER to a separate constants file.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49523/ --- (Updated July 1, 2016, 6:02 p.m.) Review request for mesos, Gilbert Song, Ian

Review Request 49524: Fixed a const ref issue in command executor.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49524/ --- Review request for mesos, Gilbert Song, Ian Downes, and Joris Van Remoortere.

Re: Review Request 49500: Moved TODO to correct place in master/http.cpp.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49500/#review140401 --- src/master/http.cpp (lines 3102 - 3139)

Re: Review Request 49487: Refactor master::Http::getTasks into helper function.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49487/#review140402 --- src/master/http.cpp (lines 3335 - 3336)

Re: Review Request 49517: Implement GetState V1 master API.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140412 --- src/master/http.cpp (line 1428)

Review Request 49523: Moved MESOS_CONTAINERIZER to a separate constants file.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49523/ --- Review request for mesos, Gilbert Song, Ian Downes, and Joris Van Remoortere.

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

2016-07-01 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/ --- (Updated July 1, 2016, 6:22 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49465/#review140396 --- Ship it! Ship It! - Vinod Kone On July 1, 2016, 10:31 a.m.,

Re: Review Request 49518: Initial snapshot for v1 master event stream.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140403 --- Bad patch! Reviews applied: [49518, 49517, 49516, 49509, 49489,

Re: Review Request 49489: Refactor master::Http::getFrameworks to helper function.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140406 --- src/master/http.cpp (lines 1336 - 1339)

Review Request 49543: Fix ProcessRemoteLinkTests that try to emulate 'stale' sockets.

2016-07-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49543/ --- Review request for mesos, Benjamin Mahler and Artem Harutyunyan. Bugs:

Review Request 49542: Explicitly passed in launcher dir to command executor.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49542/ --- Review request for mesos, Gilbert Song, Joris Van Remoortere, and Timothy Chen.

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49532: Fixed unit test os test nonblock.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49532/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 49534: Fixed linux filesystem test recover orphaned persistent volume.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49534/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 49388: Added devolve method for TaskID and HealthCheck.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49388/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49533: Added sleep binary to test rootfs.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49533/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, haosdent huang, Artem

Re: Review Request 49390: Added test for container image command task with health check.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49390/ --- (Updated July 1, 2016, 5 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review140466 --- Patch looks great! Reviews applied: [48313, 48314, 48315]

Re: Review Request 49518: Initial snapshot for v1 master event stream.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/ --- (Updated July 2, 2016, 12:20 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49517: Implement GetState V1 master API.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/ --- (Updated July 2, 2016, 12:19 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49518: Initial snapshot for v1 master event stream.

2016-07-01 Thread Zhitao Li
> On July 1, 2016, 7:41 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 595 > > > > > > just capture `http`? Also needed `ok`. - Zhitao --- This is

Re: Review Request 49501: Added cmake target to build mesos-master.

2016-07-01 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49501/ --- (Updated July 2, 2016, 12:37 a.m.) Review request for mesos, Alex Clemmer and

Review Request 49544: Made stout::Path default constructible / assignable / copyable.

2016-07-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49544/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Review Request 49545: Updated code to use Path::string() instead of Path::value.

2016-07-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49545/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Review Request 49547: Fixed dangerous use of Subprocess::PIPE as default Docker::run IO.

2016-07-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49547/ --- Review request for mesos, Joseph Wu and Kevin Klues. Repository: mesos

Review Request 49546: Added device support to Docker::run.

2016-07-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49546/ --- Review request for mesos and Kevin Klues. Repository: mesos Description

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

2016-07-01 Thread Anindya Sinha
> On June 20, 2016, 5:16 p.m., Jiang Yan Xu wrote: > > In terms of testing, if we don't crash the agent within > > `syncCheckpointedResources()` but rather return a failure when its fails > > during recovery, we can capture this in `Slave::__recover` and verify the > > failed future right? >

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

2016-07-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated July 1, 2016, 9:39 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

2016-07-01 Thread Srinivas Brahmaroutu
> On July 1, 2016, 7:30 a.m., Guangya Liu wrote: > > I think that this patch should be created after the function patches > > finished. @gyliu I have merged runtime implementation to here and moving the testing to another patch. - Srinivas

Review Request 49532: Fixed unit test os test nonblock.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49532/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, and

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

2016-07-01 Thread Anindya Sinha
> On June 23, 2016, 5:35 p.m., Jiang Yan Xu wrote: > > src/slave/state.hpp, line 271 > > > > > > It looks a bit odd that we are explicitly initiating `target` but not > > `resources`. > > > > Note that

Re: Review Request 49388: Added devolve method for TaskID and HealthCheck.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49388/#review140443 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Re: Review Request 49533: Added sleep binary to test rootfs.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49533/#review140441 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Re: Review Request 49534: Fixed linux filesystem test recover orphaned persistent volume.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49534/#review140442 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Re: Review Request 49532: Fixed unit test os test nonblock.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49532/#review140440 --- Ship it! Ship It! - Jie Yu On July 1, 2016, 9:54 p.m.,

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-07-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/#review140445 --- Ship it! Ship It! - Kapil Arya On June 30, 2016, 7:54 p.m.,

Re: Review Request 49389: Refactored HealthCheck from a binary to be a library.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49389/#review140444 --- Fix it, then Ship it! src/health-check/health_checker.hpp

Re: Review Request 45964: Add unit tests for sharing of resources.

2016-07-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated July 1, 2016, 10:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/#review140452 --- Patch looks great! Reviews applied: [49520] Passed command:

Re: Review Request 49480: Added installing NVML headers with --enable-install-module-dependencies.

2016-07-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49480/ --- (Updated July 1, 2016, 10:32 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 49390: Added test for container image command task with health check.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49390/#review140453 --- src/tests/health_check_tests.cpp (line 309)

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

2016-07-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/#review140386 --- Could you verify on testing done section that it's been run on

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

2016-07-01 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49520/ --- (Updated July 1, 2016, 6:06 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49469: Added new utility function, `frameworkHasCapability()`.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49469/#review140393 --- Patch looks great! Reviews applied: [49469] Passed command:

Re: Review Request 49509: Revised protobuf definition of GetState response.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/#review140409 --- include/mesos/master/master.proto (lines 273 - 274)

Re: Review Request 49518: Initial snapshot for v1 master event stream.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49518/#review140416 --- include/mesos/master/master.proto (line 446)

Review Request 49548: Added devolve function for CommandInfo.

2016-07-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49548/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-5753

Review Request 49529: Remove jsonFileInfo implementation from files.hpp.

2016-07-01 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49529/ --- Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

2016-07-01 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49447/ --- (Updated July 1, 2016, 8:13 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 49530: Added 'nvidia-uvm-tools' as optional control device for Nvidia GPUs.

2016-07-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49530/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5764

Re: Review Request 49523: Moved MESOS_CONTAINERIZER to a separate constants file.

2016-07-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49523/#review140426 --- Patch looks great! Reviews applied: [49415, 49424, 49425, 49472,

Re: Review Request 49524: Fixed a const ref issue in command executor.

2016-07-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49524/#review140428 --- Ship it! Ship It! - Gilbert Song On July 1, 2016, 11:02

Re: Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.

2016-07-01 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49444/ --- (Updated July 1, 2016, 7:53 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49530: Added 'nvidia-uvm-tools' as optional control device for Nvidia GPUs.

2016-07-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49530/#review140424 --- Ship it!

Re: Review Request 49523: Moved MESOS_CONTAINERIZER to a separate constants file.

2016-07-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49523/#review140432 --- Ship it! Ship It! - Joris Van Remoortere On July 1, 2016,

Re: Review Request 49524: Fixed a const ref issue in command executor.

2016-07-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49524/#review140431 --- Ship it! Ship It! - Joris Van Remoortere On July 1, 2016,

  1   2   >