Re: Review Request 52154: Avoided modifying process environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52154/#review150421 --- Patch looks great! Reviews applied: [52256, 52154] Passed

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Sept. 26, 2016, 6:36 p.m.) Review request for mesos, Alexander

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Sept. 26, 2016, 6:36 p.m.) Review request for mesos, Alexander

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Sept. 26, 2016, 6:36 p.m.) Review request for mesos, Alexander

Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.

- Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52235/#review150344 --- On Sept. 24, 2016, 6:50 p.m., Gilbert Song wrote: > >

Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.

> On Sept. 25, 2016, 7:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 800-812 > > > > > > Why having a separate look for extras? Can you just inline into the > > first loop? Let's

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Sept. 26, 2016, 6:36 p.m.) Review request for mesos, Alexander

Re: Review Request 52154: Avoided modifying process environment.

> On Sept. 22, 2016, 2:15 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp, lines 317-318 > > > > > > Can we have a short comment here explaining that `load` overload? Does > > it still even try

Re: Review Request 52147: Added support for launching child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52147/#review150407 --- Fix it, then Ship it! src/launcher/default_executor.cpp (line

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review150374 --- src/health-check/health_checker.cpp (lines 185 - 189)

Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.

> On Sept. 25, 2016, 12:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 705 > > > > > > Why the extra `!containerId.has_parent` check here? Will the first > > check implie the

Re: Review Request 51560: Deprecated using health checks without setting the type.

> On Sept. 26, 2016, 10:22 a.m., Jiang Yan Xu wrote: > > src/health-check/health_checker.cpp, lines 185-189 > > > > > > How about the following? > > > > ``` > > if (check.has_command() &&

Re: Review Request 52254: Updated aufs mount with `rw` and `ro+wh` options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52254/#review150404 --- Patch looks great! Reviews applied: [52254] Passed command:

Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.

> On Sept. 25, 2016, 7:27 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 743-748 > > > > > > We still need to call 'destroy' for a container that does not have pid > > to make sure

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ --- (Updated Sept. 26, 2016, 3:27 p.m.) Review request for hbase. Changes

Re: Review Request 52154: Avoided modifying process environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52154/ --- (Updated Sept. 26, 2016, 6:16 p.m.) Review request for mesos, Joris Van

Re: Review Request 52147: Added support for launching child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52147/#review150410 --- src/launcher/default_executor.cpp (line 380)

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/#review150433 --- Fix it, then Ship it! src/launcher/default_executor.cpp (line

Re: Review Request 52196: Fixed warnings in `read/write` functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150439 --- 3rdparty/stout/include/stout/os/windows/read.hpp (line 32)

Re: Review Request 52196: Fixed warnings in `read/write` functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/#review150447 --- 3rdparty/stout/include/stout/os/windows/read.hpp (line 35)

Re: Review Request 52195: Used functions from net:: namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52195/#review150440 --- Ship it! - Joseph Wu On Sept. 22, 2016, 10:05 p.m., Daniel

Re: Review Request 52194: Added functions to translate parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52194/ --- (Updated Sept. 26, 2016, 9:21 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52004: Supported docker runtime isolator to be nested aware.

> On Sept. 18, 2016, 2:03 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 77-82 > > > > > > We can remove this. The default behavior is this. > > Guangya Liu wrote: >

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/ --- (Updated Sept. 26, 2016, 8:58 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 26, 2016, 8:58 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/#review150442 --- Patch looks great! Reviews applied: [52250, 52251, 52252, 52253]

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Sept. 26, 2016, 8:59 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Sept. 26, 2016, 8:59 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/ --- (Updated Sept. 26, 2016, 9 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52196: Fixed warnings in `read/write` functions.

> On Sept. 26, 2016, 8:38 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/sendfile.hpp, line 31 > > > > > > What's this used for? Is MSVC warning because of the bit shifting > > (`offset >> 32`)

Re: Review Request 52194: Added `socket` functions to translate parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52194/#review150438 --- Fix it, then Ship it! I can tweak these before committing.

Re: Review Request 52196: Fixed warnings in `read/write` functions.

> On Sept. 26, 2016, 8:43 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/read.hpp, line 35 > > > > > > You wrapped the `::recv` in an earlier patch. Want to use it here? > > (`net::recv`) Good

Re: Review Request 52196: Fixed warnings in `read/write` functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52196/ --- (Updated Sept. 26, 2016, 9:15 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52195: Used functions from `net::` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52195/ --- (Updated Sept. 26, 2016, 9:37 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52062: Fixed warnings in `numify.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/ --- (Updated Sept. 26, 2016, 9:37 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review150291 --- include/mesos/resources.hpp (lines 179 - 213)

Re: Review Request 51999: Refactor parsing of resources.

> On Sept. 22, 2016, 10:14 p.m., Guangya Liu wrote: > > include/mesos/resources.hpp, lines 183-217 > > > > > > I think we do not intend to expose those two APIs, so `private` them? We would call these two APIs from

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/ --- (Updated Sept. 26, 2016, 6:46 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 25, 2016, 9:13 p.m., Michael Stack wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionPipeline.java, > > line 93 > > > > > > The hyphen will look weird when the javadoc

Review Request 52254: Updated aufs mount with `rw` and `ro+wh` options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52254/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6002

Re: Review Request 52254: Updated aufs mount with `rw` and `ro+wh` options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52254/#review150377 --- Ship it! Ship It! - Gilbert Song On Sept. 26, 2016, 12:26

Re: Review Request 52071: Updated docs to reflect handling of disk resource with size of 0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/ --- (Updated Sept. 26, 2016, 6:52 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Sept. 26, 2016, 6:51 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51880/ --- (Updated Sept. 26, 2016, 6:52 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52165: Disabled default executor tests for now.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52165/#review150466 --- Ship it! Ship It! - Vinod Kone On Sept. 25, 2016, 10:06

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 26, 2016, 10:33 p.m.) Review request for mesos and Vinod Kone.

Review Request 52285: Added 'volume/sandbox_path' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52285/ --- Review request for mesos, Gilbert Song and Joseph Wu. Bugs: MESOS-6258

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Sept. 26, 2016, 11:50 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Sept. 26, 2016, 4:27 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52290: Removed resources field from LaunchNestedContainer agent::Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52290/#review150502 --- Ship it! Ship It! - Vinod Kone On Sept. 27, 2016, 12:10

Re: Review Request 52291: Added TODOs to validate against empty task and persistence IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52291/#review150505 --- Ship it! Ship It! - Anand Mazumdar On Sept. 27, 2016, 12:15

Re: Review Request 52292: Updated nested container agent API to allow custom ContainerIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52292/#review150496 --- Fix it, then Ship it! LGTM, minus a few style nits + a query

Re: Review Request 52290: Removed resources field from LaunchNestedContainer agent::Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52290/#review150492 --- Ship it! - Anand Mazumdar On Sept. 27, 2016, 12:10 a.m.,

Review Request 52295: Added additional unit tests for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6185

Re: Review Request 52287: Added a test for default executor reconnect upon an process restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52287/#review150501 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp

Re: Review Request 52291: Added TODOs to validate against empty task and persistence IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52291/#review150503 --- Ship it! Ship It! - Vinod Kone On Sept. 27, 2016, 12:15

Re: Review Request 52233: Changed 'ExecutorInfo' to be optional in ContainerState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52233/ --- (Updated Sept. 26, 2016, 6:11 p.m.) Review request for mesos, Benjamin

Re: Review Request 52292: Updated nested container agent API to allow custom ContainerIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52292/#review150504 --- Fix it, then Ship it! src/slave/validation.cpp (line 49)

Re: Review Request 51879: Determine disk size when not specified in static resources.

> On Sept. 22, 2016, 6:02 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/containerizer.cpp, lines 275-280 > > > > > > Mulling it over, I think we can achieve the consistency of "honoring > > explicitly

Re: Review Request 52258: Fixed an assertion failure when testing for systemd support.

> On Sept. 26, 2016, 12:38 p.m., Benjamin Bannier wrote: > > src/linux/systemd.cpp, line 202 > > > > > > Let's `s/"No such entry"/"No such file or directory"/` or even `"No > > such file"` here. Okay, changing it

Re: Review Request 52258: Fixed an assertion failure when testing for systemd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52258/ --- (Updated Sept. 26, 2016, 12:18 p.m.) Review request for mesos, Benjamin

Re: Review Request 52258: Fixed an assertion failure when testing for systemd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52258/#review150385 --- src/linux/systemd.cpp (line 202)

Re: Review Request 52258: Fixed an assertion failure when testing for systemd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52258/#review150391 --- Ship it! Ship It! - Michael Park On Sept. 26, 2016, 11:49

Re: Review Request 52002: Added helper methods to determine types of disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/ --- (Updated Sept. 26, 2016, 6:48 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52258: Fixed an assertion failure when testing for systemd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52258/ --- (Updated Sept. 26, 2016, 1:49 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 52258: Fixed an assertion failure when testing for systemd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52258/ --- (Updated Sept. 26, 2016, 1:49 p.m.) Review request for mesos, Benjamin Bannier

Review Request 52258: Fixed an assertion failure when testing for systemd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52258/ --- Review request for mesos, Benjamin Bannier and Michael Park. Bugs: MESOS-6248

Re: Review Request 52258: Fixed an assertion failure when testing for systemd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52258/#review150384 --- Ship it! Ship It! - Michael Park On Sept. 26, 2016, 10:18

Re: Review Request 52206: Fixed warnings in os.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52206/#review150476 --- Fix it, then Ship it! I can tweak these before committing.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in

Re: Review Request 52284: Implement more quota validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52284/#review150490 --- Patch looks great! Reviews applied: [52103, 52284] Passed

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Sept. 26, 2016, 11:50 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 26, 2016, 11:49 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 26, 2016, 11:50 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 51674: Supported mesos containerizer destroy to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51674/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 51668: Changed the nested ContainerID from hashmap to hashset in memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/ --- (Updated Sept. 26, 2016, 5:12 p.m.) Review request for mesos, Benjamin

Re: Review Request 51670: Implemented containerizer::launch for nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51670/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/ --- (Updated Sept. 26, 2016, 5:12 p.m.) Review request for mesos, Benjamin

Re: Review Request 52008: Added slave helper function for nested containers 'getSandboxPath()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52008/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 51673: Updated mesos containerizer isolate and status for nested support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51673/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52233: Changed 'ExecutorInfo' to be optional in ContainerState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52233/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52003: Supported volume/image isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52003/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52004: Supported docker runtime isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52004/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 51669: Changed ContainerConfig::ExecutorInfo from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51669/ --- (Updated Sept. 26, 2016, 5:12 p.m.) Review request for mesos, Benjamin

Re: Review Request 52005: Supported appc/runtime isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52005/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52006: Supported docker/volume isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52006/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52234: Added containerizer helper method 'getContainerIds()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52234/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52241: Removed unit test 'IsolatorCleanupBeforePrepare'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52241/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52235/ --- (Updated Sept. 26, 2016, 5:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52235/ --- (Updated Sept. 26, 2016, 5:34 p.m.) Review request for mesos, Benjamin

Review Request 52294: Renamed the children list in 'Container' struct to 'children'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52294/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review150525 --- Patch looks great! Reviews applied: [52288] Passed command:

Review Request 52296: Fixed a memory leak in ns::clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52296/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 52004: Supported docker runtime isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52004/#review150524 --- Ship it! Ship It! - Jie Yu On Sept. 27, 2016, 4:53 a.m.,

Re: Review Request 52005: Supported appc/runtime isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52005/#review150523 --- Ship it! Ship It! - Jie Yu On Sept. 27, 2016, 4:53 a.m.,

Re: Review Request 52245: Added WEXITSTATUS and WTERMSIG gtest helpers in stout.

> On Sept. 25, 2016, 8:48 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/gtest.hpp, line 189 > > > > > > Not sure if `strsignal` works fine on windows or not. @joseph, can you > > verify that? It's hard to

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

> On Sept. 25, 2016, 10:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp, line 614 > > > > > > using executor_pid here is weird. I think we should rethink how we > > should

Re: Review Request 52292: Updated nested container agent API to allow custom ContainerIDs.

> On Sept. 27, 2016, 1:18 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 213 > > > > > > don't you want to validate multi-level nesting here like you did in > > launch? The thinking here was to just

Re: Review Request 52292: Updated nested container agent API to allow custom ContainerIDs.

> On Sept. 27, 2016, 1:20 a.m., Anand Mazumdar wrote: > > src/slave/validation.cpp, line 53 > > > > > > Use `os::PATH_SEPARATOR` for checking for directories instead? Although I'll use both POSIX and WINDOWS

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review150508 --- Looking to the test update.

  1   2   >