Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 5, 2017, 3:12 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 271-284 (patched) > > > > > > Mind to explain why running the loop inside the isolator

Review Request 62113: Fixed compilation issue on Mac OS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62113/ --- Review request for mesos, Jie Yu, Jan Schlicht, and Till Toenshoff.

Re: Review Request 62069: Moved SANDBOX_PATH volume tests to the right place.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62069/#review184641 --- src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp

Re: Review Request 62113: Fixed compilation issue on Mac OS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62113/#review184635 --- src/Makefile.am Lines 2519 (patched)

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review184636 --- Ship it! Ship It! - Qian Zhang On Sept. 6, 2017, 1:57 a.m.,

Review Request 62115: Fix stout build with newer boost versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/ --- Review request for mesos. Repository: mesos Description --- Starting

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/ --- (Updated Sept. 6, 2017, 9:57 a.m.) Review request for mesos, Andrei Budnik and

Review Request 62116: Excluded invalid offers from abnormal termination metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62116/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Repository: mesos

Review Request 62114: Revert usage of `-isystem` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62114/ --- Review request for mesos. Repository: mesos Description --- This flag

Re: Review Request 62094: Updated CMake version in docker build helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62094/#review184633 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 5, 2017,

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/ --- (Updated Sept. 6, 2017, 9:48 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

> On Sept. 4, 2017, 1:39 p.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp > > Lines 1202-1204 (original), 1206-1208 (patched) > > > > > > Explicitly call `process::initialize()` here? As libprocess is

Re: Review Request 61495: Add documentation for possible task reasons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/ --- (Updated Sept. 6, 2017, 9:29 a.m.) Review request for mesos, Alexander

Re: Review Request 62115: Fix stout build with newer boost versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/ --- (Updated Sept. 6, 2017, 10:08 a.m.) Review request for mesos and Benno Evers.

Re: Review Request 62115: Fix stout build with newer boost versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/ --- (Updated Sept. 6, 2017, 10:08 a.m.) Review request for mesos and Benno Evers.

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

> On Aug. 8, 2017, 3:53 p.m., Jan Schlicht wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 383 (patched) > > > > > > Nit: Use `v1::ResourceProviderInfo` instead of > >

Re: Review Request 60765: Added basic `network/ports` isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60765/#review184652 --- Fix it, then Ship it!

Re: Review Request 60593: Added `network/ports` isolator recovery tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/#review184657 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 704-706

Re: Review Request 62113: Fixed compilation issue on Mac OS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62113/#review184645 --- FAIL: Mesos tests failed to run Reviews applied: [62113] Logs

Re: Review Request 62115: Fix stout build with newer boost versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/#review184647 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62116/#review184656 --- FAIL: Mesos tests failed to run Reviews applied: [62116] Logs

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

> On Aug. 8, 2017, 3:53 p.m., Jan Schlicht wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 383 (patched) > > > > > > Nit: Use `v1::ResourceProviderInfo` instead of > >

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

> On Aug. 1, 2017, 12:48 a.m., Jie Yu wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 134 (patched) > > > > > > In fact, what's the different between this and > >

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/ --- (Updated Sept. 6, 2017, 1:59 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 6, 2017, 2 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/ --- (Updated Sept. 6, 2017, 2:01 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 60593: Added `network/ports` isolator recovery tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/#review184663 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 784

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184660 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 910

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62116/#review184667 --- LGTM. - Armand Grillet On Sept. 6, 2017, 10:03 a.m., Alexander

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review184673 --- FAIL: Mesos tests failed to run Reviews applied: [62018, 62037]

Review Request 62122: Fixed parameter name in uri/fetcher.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62122/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 6, 2017, 4:52 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62116/#review184721 --- Ship it! Ship It! - Chun-Hung Hsiao On Sept. 6, 2017, 10:03

Re: Review Request 62113: Fixed compilation issue on Mac OS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62113/#review184722 --- Ship it! Ship It! - Andrew Schwartzmeyer On Sept. 6, 2017,

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/ --- (Updated Sept. 6, 2017, 8:35 p.m.) Review request for mesos, Andrew

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/ --- (Updated Sept. 6, 2017, 8:35 p.m.) Review request for mesos, Andrew

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/#review184725 --- cmake/CompilationConfigure.cmake Lines 114-121 (original)

Re: Review Request 62040: Also log attached path in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62040/#review184732 --- Looks good! Just a few minor items to take care of.

Re: Review Request 62115: Fix stout build with newer boost versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/#review184720 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184728 --- 3rdparty/CMakeLists.txt Lines 194 (patched)

Re: Review Request 58021: Added storage-related offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/#review184731 --- include/mesos/mesos.proto Lines 1835 (patched)

Re: Review Request 58021: Added storage-related offer operations.

> On Sept. 6, 2017, 8:55 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 1835 (patched) > > > > > > I'd love to see documentation for these new operations to distinguish > > them from the

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184717 --- Also make sure you pull the master branch and rebase so this

Re: Review Request 62070: Added protobufs to CMake project to facilitate indexing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62070/#review184723 --- src/CMakeLists.txt Line 594 (original), 597 (patched)

Re: Review Request 62071: Added non-src files to CMake project to facilitate indexing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62071/#review184724 --- src/CMakeLists.txt Line 597 (original), 597 (patched)

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184712 --- 3rdparty/CMakeLists.txt Lines 208 (patched)

Re: Review Request 60890: WIP: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/ --- (Updated Sept. 6, 2017, 5:37 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 60891: WIP: Added ACLs and AuthZ for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60891/ --- (Updated Sept. 6, 2017, 5:38 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/#review184766 --- src/CMakeLists.txt Line 620 (original), 616 (patched)

Re: Review Request 62053: Removed garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62053/#review184775 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Review Request 62143: WIP: Added validation for Standalone Container APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62143/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7492

Review Request 62144: Added extra constructors for ObjectApprover::Object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62144/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7492

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/ --- (Updated Sept. 7, 2017, 1:11 a.m.) Review request for mesos, Andrew

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/ --- (Updated Sept. 7, 2017, 1:11 a.m.) Review request for mesos, Andrew

Re: Review Request 62053: Removed garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62053/#review184735 --- Looks good, just curious why you had to change the semantics of

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/#review184737 --- src/slave/slave.cpp Line 7457 (original), 7471 (patched)

Re: Review Request 61946: Added validation of resource provider operations.

> On Aug. 28, 2017, 9:31 p.m., Jie Yu wrote: > > src/master/validation.cpp > > Lines 2205 (patched) > > > > > > I think `checkpointedResources` should not be used for Resource > > Provider provided resources. It

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

> On Sept. 6, 2017, 1:48 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 197-198 (patched) > > > > > > I think Joe ended up committing slightly different formatting > > conventions here,

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review184751 --- src/slave/slave.hpp Lines 658 (patched)

Re: Review Request 61182: Sent a resource provider message when providers subscribe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61182/#review184746 --- Ship it! Ship It! - Jie Yu On Sept. 6, 2017, 11:59 a.m.,

Review Request 62140: Trigger the first disk-usage GC during recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62140/ --- Review request for mesos, Benjamin Mahler, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 62140: Shorten the default interval between disk-usage GCs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62140/ --- (Updated Sept. 7, 2017, 4:01 a.m.) Review request for mesos, Alexander

Re: Review Request 62017: Allows port mapper plugin to have optional args.

> On Sept. 6, 2017, 2:09 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > > Lines 149 (patched) > > > > > > Why are we setting this empty

Re: Review Request 62140: Shorten the default interval between disk-usage GCs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62140/ --- (Updated Sept. 7, 2017, 4 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 61800: Enhanced async-signal safety of `signalSafeWriteStatus` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61800/#review184785 --- Ship it! Ship It! - James Peach On Aug. 21, 2017, 8:54

Re: Review Request 61798: Added SAFE_EXIT as alternative to ABORT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/#review184786 --- Ship it! Ship It! - James Peach On Aug. 21, 2017, 8:54

Re: Review Request 61801: Used SAFE_EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61801/#review184784 --- Ship it! Ship It! - James Peach On Aug. 21, 2017, 8:54

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 9 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Review Request 62147: Added a comment about master sending a checkpointed resources message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62147/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, and

Re: Review Request 61799: Replaced ABORT with SAFE_EXIT in childhook in `subprocess_posix.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61799/#review184783 --- Ship it! Ship It! - James Peach On Aug. 21, 2017, 8:54

Review Request 62123: Send additional TASK_STARTING update from built-in executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62123/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 62113: Fixed compilation issue on Mac OS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62113/#review184685 --- Patch looks great! Reviews applied: [62113] Passed command:

Re: Review Request 62116: Excluded invalid offers from abnormal termination metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62116/#review184700 --- Ship it! Ship It! - Joseph Wu On Sept. 6, 2017, 3:03 a.m.,

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

> On Sept. 6, 2017, 1 p.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1051-1052 (patched) > > > > > > Can you please elaborate a bit about this? What do you mean for `the > >

Re: Review Request 62113: Fixed compilation issue on Mac OS.

> On Sept. 6, 2017, 8:32 a.m., Jan Schlicht wrote: > > src/tests/CMakeLists.txt > > Lines 224 (patched) > > > > > > See above. sorry guys, will fix this. - Jie

Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Vinod Kone.

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/ --- (Updated Sept. 7, 2017, 5:54 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 62142: Moved GPU resource validation into common file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62142/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7492

Review Request 62145: WIP: Implemented Standalone Container API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62145/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7492

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

> On Sept. 6, 2017, 8:48 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/cyrus_sasl-2.1.27rc3.patch > > Lines 1 (patched) > > > > > > Since it's a patch, I won't review it too much. However, we should > > ensure we

Re: Review Request 62053: Removed garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62053/#review184773 --- Ship it! Modulo deletion of the managed process. - Benjamin

Re: Review Request 62122: Fixed parameter name in uri/fetcher.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62122/#review184701 --- FAIL: Mesos tests failed to run Reviews applied: [62122] Logs

Re: Review Request 58048: Added id to Resource.DiskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review184703 --- include/mesos/mesos.proto Lines 1044 (patched)