Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197156 --- Patch looks great! Reviews applied: [65109, 65110, 65111, 65369,

Review Request 65584: Improved new CLI README regarding bash completion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65584/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 65585: Improved new CLI bootstrap script, now runnable from anywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65585/ --- Review request for mesos, Benjamin Bannier and Kevin Klues. Bugs: MESOS-8240

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/#review197179 --- Ship it! LGTM - Jie Yu On Feb. 8, 2018, 7:54 p.m., Andrew

Re: Review Request 65569: Install ping for docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65569/#review197181 --- Patch looks great! Reviews applied: [65569] Passed command:

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/#review197187 --- Ship it! src/slave/containerizer/mesos/launch.cpp Lines 534

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197173 --- I am wondering whether it wouldn't be simpler to have the site

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197172 --- Patch looks great! Reviews applied: [65445, 65504, 65446, 65449,

Re: Review Request 65545: Start from merge-base when posting reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/#review197174 --- Fix it, then Ship it! support/post-reviews.py Lines 206-209

Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65409/#review197185 --- Ship it! Ship It! - Joseph Wu On Feb. 8, 2018, 11:53 a.m.,

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197175 --- PASS: Mesos patch 65591 was successfully built and tested.

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197165 --- Bad patch! Reviews applied: [52064] Failed command: python

Re: Review Request 65585: Improved new CLI bootstrap script, now runnable from anywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65585/#review197166 --- PASS: Mesos patch 65585 was successfully built and tested.

Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65588/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8382

Review Request 65589: Added comparison operators for operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65589/ --- Review request for mesos, Greg Mann and Jie Yu. Bugs: MESOS-8382

Review Request 65587: Added hash function for mesos::UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65587/ --- Review request for mesos and Jan Schlicht. Bugs: MESOS-8382

Review Request 65590: Added helper function to determine provider ID of a conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65590/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8382

Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8382

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review197199 --- Patch looks great! Reviews applied: [65571] Passed command:

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

> On Feb. 8, 2018, 5:28 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp > > Lines 4725 (patched) > > > > > > Can you also add a test with default executor? And maybe instead of > > kill task path, try to

Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/#review197193 --- Ship it! Ship It! - Joseph Wu On Feb. 8, 2018, 2:35 p.m.,

Re: Review Request 65574: Windows: Fixed handle inheritance in `create_process` wrapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65574/#review197196 --- LGTM, but I'd like this part of the chain to be committed

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/#review197192 --- src/slave/containerizer/mesos/launch.cpp Lines 534 (patched)

Re: Review Request 65593: Added a test to ensure master removes fail-launched deafult executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197212 --- PASS: Mesos patch 65593 was successfully built and tested.

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- (Updated Feb. 9, 2018, 5:37 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197205 --- PASS: Mesos patch 65448 was successfully built and tested.

Re: Review Request 62798: Added named cgroup hierarchy support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62798/#review197207 --- Ship it! Ship It! - James Peach On Feb. 7, 2018, 8:01 p.m.,

Re: Review Request 65548: Added `Event::Update` and `v1::scheduler::TaskStatus` ostream operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65548/#review197214 --- Ship it! LGTM. src/v1/mesos.cpp Lines 604 (patched)

Re: Review Request 65585: Improved new CLI bootstrap script, now runnable from anywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65585/#review197204 --- Patch looks great! Reviews applied: [65584, 65585] Passed

Review Request 65593: Added a test to ensure master removes fail-launched deafult executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1720

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62800/#review197209 --- Ship it! Ship It! - James Peach On Feb. 7, 2018, 8:01 p.m.,

Re: Review Request 62799: Fixed an issue for the I/O switchboard process lifetime.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62799/#review197208 --- Ship it! Ship It! - James Peach On Feb. 7, 2018, 8:01 p.m.,

Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. Bugs:

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197213 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197203 --- src/docker/executor.cpp Lines 273-302 (patched)

Re: Review Request 65570: WIP: Attached/detached volume directory for task which has volume specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65570/ --- (Updated Feb. 10, 2018, 9:01 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

> On Feb. 8, 2018, 2:19 a.m., Benjamin Mahler wrote: > > src/tests/mock_slave.cpp > > Lines 107-108 (original), 107-109 (patched) > > > > > > What's going on here? > > Meng Zhu wrote: > For the agent failover

Re: Review Request 65549: Improved some default executor log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65549/#review197215 --- Harmless enough. What's the reason behind wanting to

Re: Review Request 65545: Start from merge-base when posting reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65545/#review197220 --- Patch looks great! Reviews applied: [65545] Passed command:

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197222 --- Patch looks great! Reviews applied: [65587, 65588, 65589, 65590,

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197206 --- src/docker/executor.cpp Lines 277 (patched)

Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65497/#review197211 --- src/tests/mesos.cpp Line 391 (original), 400 (patched)

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197218 --- src/resource_provider/storage/uri_disk_profile.cpp Line 248

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197217 --- src/launcher/default_executor.cpp Lines 539-546 (original), 537

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

> On Feb. 9, 2018, 6:36 p.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp > > Lines 539-546 (original), 537 (patched) > > > > > > Since the guard above was removed, this CHECK could potentially be hit >

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/ --- (Updated Feb. 9, 2018, 10:35 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- (Updated Feb. 9, 2018, 10:35 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65549: Improved some default executor log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65549/ --- (Updated Feb. 9, 2018, 10:34 p.m.) Review request for mesos, Greg Mann, Qian

Re: Review Request 65549: Improved some default executor log messages.

> On Feb. 9, 2018, 6:06 p.m., Joseph Wu wrote: > > Harmless enough. What's the reason behind wanting to `s/launch/launch > > group/` ? I wanted to clearly differentiate between launching groups, tasks, and children containers (this executor does it all). - Gaston

Re: Review Request 65556: Made the default executor treat agent disconnections more gracefully.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65556/#review197227 --- PASS: Mesos patch 65556 was successfully built and tested.

Re: Review Request 65550: Made default executor not shutdown if unsubscribed during task launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65550/#review197223 --- src/launcher/default_executor.cpp Lines 539-546 (original), 537

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

> On Feb. 8, 2018, 8:22 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 2186 (patched) > > > > > > s/Leader detector indicated no master elected/No master was elected/ > > > > More importantly,

Re: Review Request 65584: Improved new CLI README regarding bash completion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65584/#review197159 --- PASS: Mesos patch 65584 was successfully built and tested.

Re: Review Request 65572: Fixed two slave recovery tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65572/#review197160 --- Bad patch! Reviews applied: [65572] Failed command: python

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/ --- (Updated Feb. 9, 2018, 12:55 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/#review197157 --- Failed test `DiskQuotaTest.SlaveRecovery` is known to be flaky,

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/memory_profiler.cpp > > Lines 243-249 (patched) > > > > > > I think it is safe to use this function because it is only accessed >

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review197163 --- PASS: Mesos patch 65571 was successfully built and tested.

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197164 --- Patch looks great! Reviews applied: [65518] Passed command: