Re: Review Request 59987: Added protobuf map support.

2018-02-26 Thread Qian Zhang
> On Feb. 9, 2018, 4:26 a.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 499-500 (patched) > > > > > > How about using `UNREACHABLE` instead? With `ABORT`, we can output

Re: Review Request 59987: Added protobuf map support.

2018-02-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated Feb. 26, 2018, 5:05 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65804: Fixed a typo in the NsTest.SupportedNamespaces test.

2018-02-26 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65804/#review198285 --- PASS: Mesos patch 65804 was successfully built and tested.

Re: Review Request 59987: Added protobuf map support.

2018-02-26 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review198292 --- Ship it! Ship It! - Chun-Hung Hsiao On Feb. 26, 2018, 9:05

Re: Review Request 52064: Support for multiple versions of docs.

2018-02-26 Thread Benjamin Mahler
> On Feb. 24, 2018, 12:50 a.m., Benjamin Mahler wrote: > > Vinod and I went over this, a couple of issues: > > > > * The [endpoint > > documentation](http://mesos.apache.org/documentation/latest/endpoints/) is > > only being generated for latest (see > >

Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)

2018-02-26 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-26 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review198317 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-26 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James

Re: Review Request 65806: Fixed a bug where quota headroom is miscalculated.

2018-02-26 Thread Meng Zhu
> On Feb. 26, 2018, 6:41 p.m., Benjamin Mahler wrote: > > Does this need to depend on the previous renaming patch? Makes > > cherry-picking a little messier Nope. Removed the dependency. - Meng --- This is an automatically generated

Re: Review Request 65807: Added an allocator test for quota with ancestor reservation.

2018-02-26 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65807/#review198303 --- PASS: Mesos patch 65807 was successfully built and tested.

Review Request 65807: Added an allocator test for quota with ancestor reservation.

2018-02-26 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65807/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-8604

Review Request 65806: Fixed a bug where quota headroom is miscalculated.

2018-02-26 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65806/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-8604

Re: Review Request 65806: Fixed a bug where quota headroom is miscalculated.

2018-02-26 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65806/ --- (Updated Feb. 26, 2018, 6:46 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 65661: Updated comment and variables to decouple quota limit and guarantee.

2018-02-26 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review198300 --- PASS: Mesos patch 65661 was successfully built and tested.

Re: Review Request 65807: Added an allocator test for quota with ancestor reservation.

2018-02-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65807/#review198301 --- Patch looks great! Reviews applied: [65661, 65806, 65807]

Re: Review Request 65791: Removed stale generated HTTP endpoint documentation.

2018-02-26 Thread Benjamin Mahler
> On Feb. 24, 2018, 11:08 a.m., Benjamin Bannier wrote: > > I think a sticky issue which would have been great to resolve here is to > > make sure that we enable building of endpoint documentation generation for > > non-dockerized site builds as well (i.e., `cd site/ && bundle install && > >

Re: Review Request 65806: Fixed a bug where quota headroom is miscalculated.

2018-02-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65806/#review198304 --- Does this need to depend on the previous renaming patch? Makes

Re: Review Request 65806: Fixed a bug where quota headroom is miscalculated.

2018-02-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65806/#review198307 --- Ship it! src/master/allocator/mesos/hierarchical.cpp Lines

Re: Review Request 65807: Added an allocator test for quota with ancestor reservation.

2018-02-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65807/#review198308 --- Fix it, then Ship it!

Re: Review Request 65661: Updated comment and variables to decouple quota limit and guarantee.

2018-02-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review198309 --- Patch looks great! Reviews applied: [65661] Passed command:

Review Request 65804: Fixed a typo in the NsTest.SupportedNamespaces test.

2018-02-26 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65804/ --- Review request for mesos, Alexander Rukletsov and Jie Yu. Bugs: MESOS-8610

Re: Review Request 65804: Fixed a typo in the NsTest.SupportedNamespaces test.

2018-02-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65804/#review198283 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 26, 2018,