Re: Review Request 67579: Added chenrc to the contributors list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67579/#review204764 --- Patch looks great! Reviews applied: [67579] Passed command:

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/#review204765 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67590: Added a dedicated benchmark for range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review204769 --- Patch looks great! Reviews applied: [67590] Passed command:

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67356/#review204784 --- PASS: Mesos patch 67356 was successfully built and tested.

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > > > > > Why not using `process::http::Status::string()` > >

Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/#review204788 --- src/tests/containerizer/port_mapping_tests.cpp Line 355

Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/ --- Review request for mesos, Alexander Rukletsov and James Peach. Repository:

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

> On 六月 13, 2018, 4:41 p.m., Gilbert Song wrote: > > also, please use this commit message: "Added to the contributor > > list." OK,I have changed,please review . - cui --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 67525: Removed static variable with non-constant initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67525/#review204779 --- Ship it! Ship It! - Alexander Rukletsov On June 13, 2018,

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204775 --- Ship it! Ship It! - Alexander Rukletsov On June 13, 2018,

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204782 --- PASS: Mesos patch 67488 was successfully built and tested.

Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/ --- (Updated June 14, 2018, 1:22 p.m.) Review request for mesos, Alexander

Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/#review204795 --- Ship it! Ship It! - James Peach On June 14, 2018, 8:22

Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/#review204796 --- Ship it! This built for James Peach on his machine, so I'm

Re: Review Request 67602: Improve the debug logging in mesos container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67602/#review204799 --- PASS: Mesos patch 67602 was successfully built and tested.

Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

> On June 14, 2018, 11:31 a.m., James Peach wrote: > > src/tests/containerizer/port_mapping_tests.cpp > > Line 355 (original), 356 (patched) > > > > > > Need a comma here. Thank you! Sorry, I really can't seem to

Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/ --- (Updated June 14, 2018, 11:46 a.m.) Review request for mesos, Alexander

Review Request 67602: Improve the debug logging in mesos container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67602/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67602: Improve the debug logging in mesos container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67602/ --- (Updated 六月 14, 2018, 7:45 p.m.) Review request for mesos and Gilbert Song.

Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- Review request for mesos and Gilbert Song. Summary (updated) -

Re: Review Request 67600: Fixed break of `port_mapping_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/#review204791 --- PASS: Mesos patch 67600 was successfully built and tested.

Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/#review204797 --- Ship it! Ship It! - Benjamin Bannier On June 12, 2018,

Re: Review Request 67579: Added chenrc to the contributors list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67579/#review204800 --- Ship it! Ship It! - Gilbert Song On June 13, 2018, 10:24

Re: Review Request 67579: Added chenrc to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67579/ --- (Updated June 14, 2018, 3:37 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67591: Improving the accuracy of this failure message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67591/#review204803 --- Patch looks great! Reviews applied: [67591] Passed command:

Review Request 67607: Windows: Fixed libarchive and zlib linkage warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67607/ --- Review request for mesos, Benjamin Bannier, John Kordich, and Joseph Wu.

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review204802 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67558: Cai change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67558/ --- (Updated 六月 14, 2018, 11:01 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67502: Refactored API functionality into separate module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew

Re: Review Request 67504: Added helper for posting the result of a build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew

Re: Review Request 67604: Made configured shell script inputs executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67604/#review204811 --- PASS: Mesos patch 67604 was successfully built and tested.

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review204813 --- Patch looks great! Reviews applied: [67411, 67412, 67413, 67487,

Re: Review Request 67558: Cai change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67558/ --- (Updated 六月 14, 2018, 11:06 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/#review204804 --- Fix it, then Ship it! LGTM

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/#review204807 --- docs/contributors.yaml Lines 758 (patched)

Re: Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/#review204806 ---

Re: Review Request 67607: Windows: Fixed libarchive and zlib linkage warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67607/#review204814 --- PASS: Mesos patch 67607 was successfully built and tested.

Re: Review Request 67609: Added DaoTan Cui to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67609/#review204815 --- PASS: Mesos patch 67609 was successfully built and tested.

Review Request 67603: Made sure all configured shell script outputs are executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67603/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 67604: Made configured shell script inputs executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67604/ --- Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff. Repository:

Re: Review Request 67594: Improve the debug logging in mesos container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67594/ --- (Updated 六月 14, 2018, 11:28 p.m.) Review request for mesos. Bugs: MESOS-8423

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review204808 --- Fix it, then Ship it! LGTM! Thanks!

Review Request 67609: Added DaoTan Cui to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67609/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 67606: Allow for unbundled libevent cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/#review204818 --- PASS: Mesos patch 67606 was successfully built and tested.

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review204816 --- PASS: Mesos patch 67505 was successfully built and tested.

Review Request 67606: Allow for unbundled libevent cmake builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67606/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.

Re: Review Request 67607: Windows: Fixed libarchive and zlib linkage warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67607/#review204817 --- Ship it! Ship It! - John Kordich On June 14, 2018, 11:20

Review Request 67597: Fixed an issue where agent may fail to recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8871

Re: Review Request 67557: Add contributor info at the file contributors.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67557/#review204760 --- Patch looks great! Reviews applied: [67557] Passed command:

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew

Re: Review Request 67503: Added helper for fetching review id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated June 14, 2018, 11:13 p.m.) Review request for mesos, Andrew