Re: Review Request 69480: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69480/ --- (Updated Dec. 11, 2018, 1:15 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69538: Added UCR bridge network for Mesos Mini.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69538/#review211153 --- Ship it! - Sergey Urbanovich On Dec. 10, 2018, 6:11 a.m.,

Re: Review Request 69538: Added UCR bridge network for Mesos Mini.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69538/#review211154 --- Ship it! Ship It! - James Peach On Dec. 10, 2018, 6:11

Re: Review Request 69538: Added UCR bridge network for Mesos Mini.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69538/#review211155 --- Ship it! Ship It! - Deepak Goel On Dec. 10, 2018, 6:11

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211166 --- Fix it, then Ship it! docs/monitoring.md Lines 984 (patched)

Re: Review Request 69545: Refactored `LinuxFilesystemIsolator{Test, MesosTest}` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69545/#review211167 --- PASS: Mesos patch 69545 was successfully built and tested.

Re: Review Request 69344: Added volume gid manager to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69344/ --- (Updated Dec. 11, 2018, 1 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69478: Added `task_supplementary_groups` into `ContainerLaunchInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69478/ --- (Updated Dec. 11, 2018, 1:09 a.m.) Review request for mesos, Andrei Budnik,

Review Request 69542: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69542/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin,

Review Request 69541: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin,

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

> On Dec. 10, 2018, 8:22 a.m., Benno Evers wrote: > > src/slave/http.cpp > > Lines 862 (patched) > > > > > > I wonder: This `switch` statement doesn't have a `default` case, so if > > a new executor sends a

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/#review211162 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/ --- Review request for mesos, Jie Yu and James Peach. Bugs: MESOS-9462

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211146 --- Fix it, then Ship it!

Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin,

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

> On Dec. 10, 2018, 5:06 p.m., James Peach wrote: > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > > Lines 137 (patched) > > > > > > As a separate commit, can we factor out the flags set up from all

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211151 --- Ship it! Ship It! - Jie Yu On Dec. 10, 2018, 4:41 p.m.,

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211156 --- PASS: Mesos patch 69540 was successfully built and tested.

Review Request 69543: Implemented recovery for volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69543/ --- Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin,

Review Request 69545: Refactored `LinuxFilesystemIsolator{Test, MesosTest}` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69545/ --- Review request for mesos, Jie Yu and James Peach. Bugs: MESOS-9462

Re: Review Request 69474: Added tests for agent/executor heartbeating.

> On Dec. 10, 2018, 8:33 a.m., Benno Evers wrote: > > src/tests/executor_http_api_tests.cpp > > Lines 1232 (patched) > > > > > > Let's please fix this `TODO` before committing. I left this TODO because none of the

Re: Review Request 69505: Added an operation status update manager to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/ --- (Updated Dec. 10, 2018, 11:34 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211174 --- PASS: Mesos patch 69514 was successfully built and tested.

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/ --- (Updated Dec. 10, 2018, 2:24 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69505: Added an operation status update manager to the agent.

> On Dec. 6, 2018, 12:32 a.m., Gastón Kleiman wrote: > > src/master/master.cpp > > Lines 8539-8541 (original) > > > > > > Should we replace this with something like the following? > > > > ``` > >

Re: Review Request 69505: Added an operation status update manager to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/ --- (Updated Dec. 10, 2018, 11:03 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 69472: Refactored master and agent streaming connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/ --- (Updated Dec. 10, 2018, 2 p.m.) Review request for mesos, Benno Evers, Gastón

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211175 --- Ship it! Ship It! - Gilbert Song On Dec. 10, 2018, 8:41

Re: Review Request 69545: Refactored `LinuxFilesystemIsolator{Test, MesosTest}` tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69545/#review211176 --- Ship it! Ship It! - Gilbert Song On Dec. 10, 2018, 10:37

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

> On Dec. 10, 2018, 8:22 a.m., Benno Evers wrote: > > src/executor/executor.cpp > > Lines 798 (patched) > > > > > > I think you're adding a constant in `src/slave/constants.hpp` in this > > review, so we could use

Re: Review Request 69505: Added an operation status update manager to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/ --- (Updated Dec. 10, 2018, 11:01 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68162/ --- (Updated Dec. 11, 2018, 2:49 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69474: Added tests for agent/executor heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/ --- (Updated Dec. 10, 2018, 5:20 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69479/ --- (Updated Dec. 11, 2018, 12:27 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69505: Added an operation status update manager to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/#review211178 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67997/ --- (Updated Dec. 11, 2018, 2:45 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/ --- (Updated Dec. 11, 2018, 9:17 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/ --- (Updated Dec. 10, 2018, 5:20 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69544/#review211180 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69474: Added tests for agent/executor heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/#review211182 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68040: Added a new method `getDefaultBackend()` to the provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68040/ --- (Updated Dec. 11, 2018, 2:49 p.m.) Review request for mesos, Gilbert Song,

Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/ --- Review request for mesos. Bugs: MESOS-8813

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68163/ --- (Updated Dec. 11, 2018, 2:51 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211184 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69463/#review211140 --- Ship it! Ship It! - Benno Evers On Dec. 6, 2018, 12:15

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211141 --- Ship it! The `active_`-prefix could probably be dropped

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211142 --- src/executor/executor.cpp Lines 798 (patched)

Re: Review Request 69474: Added tests for agent/executor heartbeating.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/#review211143 --- Fix it, then Ship it! src/tests/executor_http_api_tests.cpp

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review211138 --- Ship it! Ship It! - Benno Evers On Dec. 5, 2018, 10:01

Re: Review Request 69472: Refactored master and agent streaming connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/#review210957 --- Fix it, then Ship it! src/common/heartbeater.hpp Lines 17