Review Request 71501: Gc'ed nested container sandbox only if we have root container sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71501/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9966

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/ --- (Updated Sept. 18, 2019, 12:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217787 --- 3rdparty/libprocess/src/openssl.cpp Lines 545-547 (patched)

Re: Review Request 71503: Manually created clang-tidy config in mesos-tidy setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71503/#review217808 --- Ship it! Ship It! - Benno Evers On Sept. 18, 2019, 12:09

Review Request 71503: Manually created clang-tidy config in mesos-tidy setup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71503/ --- Review request for mesos and Benno Evers. Repository: mesos Description

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/ --- (Updated Sept. 18, 2019, 12:59 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

> On Sept. 18, 2019, 9:50 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 545-547 (patched) > > > > > > We are stating that there would be a deprecation; does that mean at > > some

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

> On Sept. 17, 2019, 5:39 p.m., Vinod Kone wrote: > > docs/ssl.md > > Lines 100 (patched) > > > > > > These deprecations need to be documented in CHANGELOG and upgrades.md. I updated `upgrades.md`, but I think the

Re: Review Request 71501: Gc'ed nested container sandbox only if we have root container sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71501/#review217815 --- Patch looks great! Reviews applied: [71501] Passed command:

Re: Review Request 71178: Implemented displaying roles of multi-role frameworks as a tree.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71178/ --- (Updated Sept. 18, 2019, 1:23 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71178: Implemented displaying roles of multi-role frameworks as a tree.

> On Sept. 14, 2019, 8:08 p.m., Meng Zhu wrote: > > src/webui/app/app.js > > Lines 276 (patched) > > > > > > s/g/'g'/ Thanks for noticing! > On Sept. 14, 2019, 8:08 p.m., Meng Zhu wrote: > >

Re: Review Request 71178: Implemented displaying roles of multi-role frameworks as a tree.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71178/ --- (Updated Sept. 18, 2019, 1:40 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71179: WIP: Added a flag for running example framework with a list of roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71179/#review217821 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

> On Sept. 17, 2019, 5:39 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 118 (patched) > > > > > > can you use the `alias` argument in `add()` for these? Actually, after having

Re: Review Request 71476: Simplified recover resources when removing frameworks or agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71476/#review217826 --- Fix it, then Ship it! Oh, that's a long-awaited fix! Looks

Re: Review Request 71487: Added method to notify allocator that offered transitioned to allocated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71487/ --- (Updated Sept. 18, 2019, 5:06 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71488: Track per-role allocated resources in the roles tree.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71488/ --- (Updated Sept. 18, 2019, 5:07 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71479/#review217827 --- Ship it! Ship It! - Andrei Sekretenko On Sept. 12, 2019,

Re: Review Request 71490: Added quota consumption metrics to the hierarchial allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71490/ --- (Updated Sept. 18, 2019, 5:13 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71488: Track per-role allocated resources in the roles tree.

> On Sept. 17, 2019, 10:12 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 134 (patched) > > > > > > why not resource quantities? what matter data do we need? I've removed exposing

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71497/#review217834 --- Patch looks great! Reviews applied: [71496, 71497] Passed

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71498/#review217828 --- Patch looks great! Reviews applied: [71489, 71486, 71487, 71488,

Re: Review Request 71507: Windows: Disabled the dist and distcheck targets with a note.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71507/#review217830 --- Fix it, then Ship it! In addition to testing the `dist`

Re: Review Request 71507: Windows: Disabled the dist and distcheck targets with a note.

> On Sept. 18, 2019, 1:07 p.m., Benjamin Bannier wrote: > > CMakeLists.txt > > Lines 100 (patched) > > > > > > This is consistent with how we do it elsewhere, but I wonder: is the > > reason we cannot have these

Review Request 71507: Windows: Disable the dist and distcheck targets with a note.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71507/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.

Re: Review Request 71507: Windows: Disabled the dist and distcheck targets with a note.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71507/ --- (Updated Sept. 18, 2019, 1:21 p.m.) Review request for mesos, Benjamin

Re: Review Request 71507: Windows: Disabled the dist and distcheck targets with a note.

> On Sept. 18, 2019, 10:07 p.m., Benjamin Bannier wrote: > > CMakeLists.txt > > Lines 100 (patched) > > > > > > This is consistent with how we do it elsewhere, but I wonder: is the > > reason we cannot have these

Re: Review Request 71509: Windows: Fixed AllocationRoleEnvironmentVariable tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71509/#review217837 --- Ship it! Ship It! - Gilbert Song On Sept. 18, 2019, 3:57

Review Request 71509: Windows: Fixed AllocationRoleEnvironmentVariable tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71509/ --- Review request for mesos, Gilbert Song, Greg Mann, Qian Zhang, and Till

Review Request 71510: Windows: Fixed parallel test execution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71510/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.

Re: Review Request 71509: Windows: Fixed AllocationRoleEnvironmentVariable tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71509/#review217836 --- Ship it! Ship It! - Till Toenshoff On Sept. 18, 2019, 10:57

Review Request 71511: Windows: Stout: Fixed parallel test execution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71511/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.

Review Request 71512: Windows: Libprocess: Fixed parallel test execution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71512/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.

Re: Review Request 71478: Windows: Moved definition out of inline function call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71478/#review217838 --- Ship it! Ship It! - Greg Mann On Sept. 12, 2019, 7:35 p.m.,

Re: Review Request 71488: Track per-role allocated resources in the roles tree.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71488/#review217839 --- Bad patch! Reviews applied: [71486, 71487, 71488] Failed

Review Request 71516: Refactored framework role tracking logic in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71516/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 71441: Fixed URI stringification.

> On Sept. 16, 2019, 5:24 a.m., Qian Zhang wrote: > > In the description of this patch, I see you mentioned we only have this > > issue with a non-default Docker registry, but that seems not what I found. > > I started Mesos agent without setting the flag `--docker_registry` (so it > > just

Re: Review Request 71441: Fixed URI stringification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71441/ --- (Updated Sept. 19, 2019, 5:11 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 71516: Refactored framework role tracking logic in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71516/#review217845 --- Patch looks great! Reviews applied: [71515, 71516] Passed

Review Request 71515: Fixed a bug where sorter may leak clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71515/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Re: Review Request 71516: Refactored framework role tracking logic in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71516/ --- (Updated Sept. 18, 2019, 8:41 p.m.) Review request for mesos, Andrei

Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71512/#review217842 --- Patch looks great! Reviews applied: [71510, 71511, 71512]