Re: Review Request 34353: Added right ammount of spacing between structs

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34353/#review84157 --- Patch looks great! Reviews applied: [34353] All tests passed. -

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated May 18, 2015, 2:56 p.m.) Review request for mesos, Adam B, Joerg

Review Request 34353: Added right ammount of spacing between structs

2015-05-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34353/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review82935 --- This one may be entirely outdated - sry for that in advance

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review84146 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
On May 16, 2015, 1:03 a.m., Niklas Nielsen wrote: src/slave/slave.cpp, line 4080 https://reviews.apache.org/r/34299/diff/1/?file=961836#file961836line4080 This is being executed in the context of the estimator thread? Is this safe? This will be executed in the slave's thread

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-18 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/ --- (Updated May 18, 2015, 5:26 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/ --- (Updated May 18, 2015, 5:41 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/ --- (Updated May 18, 2015, 5:58 p.m.) Review request for mesos, Joris Van

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
On May 16, 2015, 12:13 a.m., Vinod Kone wrote: include/mesos/slave/resource_estimator.hpp, line 59 https://reviews.apache.org/r/34299/diff/1/?file=961828#file961828line59 s/oversubscribed/oversubscribable/ ? or s/oversubscribed/oversubscribe/

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/ --- (Updated May 18, 2015, 10:33 a.m.) Review request for mesos, Joris Van

Re: Review Request 34195: Refactoring to use BaseFlags common functionality

2015-05-18 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34195/ --- (Updated May 18, 2015, 5:28 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-18 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/ --- (Updated May 18, 2015, 10:33 a.m.) Review request for mesos, Joris Van

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-18 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review84172 --- src/examples/test_hook_module.cpp

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); This cannot be implemented in terms on `Time`, since `Path`

Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.

2015-05-18 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/#review84161 --- include/mesos/mesos.proto

Review Request 34361: converted hard-coded strings to consts

2015-05-18 Thread Colin Williams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/ --- Review request for mesos. Bugs: MESOS-2637

Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/ --- Review request for mesos and Adam B. Bugs: MESOS-2743

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review84183 --- configure.ac https://reviews.apache.org/r/33753/#comment135308

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84187 --- There are still places where it says oversubscribed. I pointed to

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-18 Thread Ian Downes
On May 16, 2015, 12:31 p.m., Joris Van Remoortere wrote: src/tests/sched_tests.cpp, line 40 https://reviews.apache.org/r/34309/diff/1/?file=961961#file961961line40 Could you elaborate on this comment and explain what you are testing in the child? I don't think it's clear.

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Ian Downes
On May 16, 2015, 1:03 p.m., Joris Van Remoortere wrote: Hi Ian, I'm wondering about the `Note` regarding only setting the scheduling policy to IDLE if the initial resources are revocable. I think this exposes many scenarios where the isolator will seem `enabled` to the operator,

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Ian Downes
On May 15, 2015, 9:46 p.m., Timothy Chen wrote: src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 345 https://reviews.apache.org/r/34310/diff/1/?file=961963#file961963line345 What if the same set of resources contains both revocable and non-revocable resources? Hmm, I

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33754/#review84184 --- 3rdparty/libprocess/configure.ac

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review84180 --- Patch looks great! Reviews applied: [34361] All tests passed. -

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review84185 --- m4/ax_python_devel.m4

Re: Review Request 34195: Refactoring to use BaseFlags common functionality

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34195/#review84186 --- Bad patch! Reviews applied: [34193, 34193] Failed command:

Re: Review Request 34195: Refactoring to use BaseFlags common functionality

2015-05-18 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34195/ --- (Updated May 18, 2015, 7:01 p.m.) Review request for Benjamin Hindman and

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/#review84198 --- Patch looks great! Reviews applied: [34362] All tests passed. -

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/ --- (Updated May 18, 2015, 7:19 p.m.) Review request for mesos, Joris Van

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Till Toenshoff
On March 26, 2015, 4:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented in

Review Request 34371: Add framework's pid to json summary of framework.

2015-05-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34371/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-2746

Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

2015-05-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- Review request for mesos. Bugs: mesos-2665

Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

2015-05-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/ --- (Updated May 18, 2015, 10:08 p.m.) Review request for mesos and Cosmin Lehene.

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/#review84213 --- Bad patch! Reviews applied: [34308, 34309, 34308] Failed command:

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/#review84218 --- Bad patch! Reviews applied: [34308, 34308] Failed command:

Re: Review Request 34142: AppC provisioner.

2015-05-18 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/#review84199 --- src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 34371: Add framework's pid to json summary of framework.

2015-05-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34371/#review84220 --- Ship it! Ship It! - Benjamin Hindman On May 18, 2015, 8:57

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review84222 --- Ship it! Ship It! - Benjamin Hindman On May 17, 2015, 10:11

Review Request 34375: Removed use of namespace aliases.

2015-05-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/ --- Review request for mesos. Repository: mesos Description --- See

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/#review84221 --- Ship it! Ship It! - Benjamin Hindman On May 17, 2015, 10:11

Re: Review Request 34375: Removed use of namespace aliases.

2015-05-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/#review84238 --- Ship it! Ship It! - Till Toenshoff On May 18, 2015, 11:13 p.m.,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented in

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated May 19, 2015, 6:20 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 34392: Added a method to Path which returns the modification time of the represented path.

2015-05-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34392/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad,

Re: Review Request 34378: Fixed the dependency between 'summarize' and 'model'.

2015-05-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34378/#review84241 --- Ship it! Ship It! - Till Toenshoff On May 18, 2015, 11:23 p.m.,

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84202 --- Thanks a lot for this, Stan - much appreciated! There are a couple

Re: Review Request 34140: Appc image store

2015-05-18 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review84233 --- src/slave/containerizer/provisioners/appc/store.hpp

Re: Review Request 34141: AppC provsioning backend.

2015-05-18 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34141/#review84237 --- src/slave/containerizer/provisioners/appc/backend.hpp

Re: Review Request 34139: AppC image discovery.

2015-05-18 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review84196 --- src/slave/containerizer/provisioners/appc/discovery.hpp

Re: Review Request 34138: AppC hash computation.

2015-05-18 Thread Ian Downes
On May 18, 2015, 4:37 p.m., Chi Zhang wrote: push the implementation down to stout? is it possible to swap to use devel packages for hashing in the future? Not to stout because it's asynchronous but perhaps to libprocess. - Ian

Re: Review Request 34375: Removed use of namespace aliases.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/#review84247 --- Patch looks great! Reviews applied: [34375] All tests passed. -

Re: Review Request 34359: Support multiple reasons in status update message.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34359/#review84205 --- Patch looks great! Reviews applied: [34359] All tests passed. -

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-18 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/ --- (Updated May 18, 2015, 1:48 p.m.) Review request for mesos, Joris Van

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-18 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/ --- (Updated May 18, 2015, 1:49 p.m.) Review request for mesos, Joris Van

Re: Review Request 34308: Filter revocable resources.

2015-05-18 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- (Updated May 18, 2015, 1:49 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented in

Re: Review Request 34138: AppC hash computation.

2015-05-18 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review84195 --- push the implementation down to stout? is it possible to swap to

Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/#review84243 --- Patch looks great! Reviews applied: [34129] All tests passed. -

Re: Review Request 34375: Removed use of namespace aliases.

2015-05-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/#review84251 --- This might be a valid namespace alias use case that we hadn't

Re: Review Request 34378: Fixed the dependency between 'summarize' and 'model'.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34378/#review84252 --- Patch looks great! Reviews applied: [34378] All tests passed. -

Re: Review Request 34387: Moved up Slave and Framework structs in master.hpp.

2015-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34387/#review84254 --- Patch looks great! Reviews applied: [34387] All tests passed. -

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-18 Thread Colin Williams
On May 18, 2015, 5:48 p.m., Marco Massenzio wrote: src/examples/test_hook_module.cpp, lines 36-38 https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36 Thanks for doing this! I'm wondering whether, as these are constants, shouldn't they be in

Review Request 34387: Moved up Slave and Framework structs in master.hpp.

2015-05-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34387/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2507

Review Request 34389: Removed Master::getSlave.

2015-05-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34389/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2507