Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36173/#review90445 --- docs/attributes-resources.md (line 35)

Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

> On July 6, 2015, 5:25 a.m., Adam B wrote: > > docs/attributes-resources.md, line 11 > > > > > > s/either supported by Attributes or Resources/supported by Attributes > > and Resources/ > > And are sets a 'type' o

Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

> On July 6, 2015, 5:25 a.m., Adam B wrote: > > docs/attributes-resources.md, line 31 > > > > > > No sets? Or are attributes implicitly sets? I was suprised when I read the source code too, but we actually explicitly

Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36173/#review90437 --- Ship it! Seems like scalar and text are basic types, and then range

Re: Review Request 32543: Documented problem and solution with slave recovery and systemd settings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32543/#review90433 --- Ship it! I updated this to be specific to using 'posix' isolation m

Re: Review Request 32543: Documented problem and solution with slave recovery and systemd settings.

> On March 27, 2015, 9:17 a.m., Adam B wrote: > > docs/slave-recovery.md, line 71 > > > > > > (If the slave does not come back, each executorDriver shuts itself down > > after $MESOS_RECOVERY_TIMEOUT.) > > > >

Re: Review Request 32384: Adding perf check to configure

> On July 2, 2015, 11:45 a.m., haosdent huang wrote: > > configure.ac, line 1121 > > > > > > Seems other exist checks use AC_CHECK_TOOL, such as > > ``` > > AC_CHECK_TOOL([PROTOCOMPILER_TEST], [protoc], []

Re: Review Request 32384: Adding perf check to configure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/#review90428 --- Ship it! Your check for 'perf' in the configuration is really not s

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/#review90423 --- src/launcher/fetcher.cpp (line 160)

Re: Review Request 36189: Add strings::Mode to strings::trim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90427 --- Bad patch! Reviews applied: [36189] Failed command: ./support/appl

Review Request 36189: Add strings::Mode to strings::trim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/ --- Review request for mesos and Artem Harutyunyan. Bugs: MESOS-2862 https://is

Re: Review Request 36116: MESOS-2965: Add implicit conversion from Path to std::string.

> On July 6, 2015, 2:36 a.m., Benjamin Hindman wrote: > > Ship It! Thanks Joseph! It would be great to follow up this with JIRA + reviews that eliminate the use of 'value' from a lot of our existing code that uses Path. - Benjamin ---

Re: Review Request 36116: MESOS-2965: Add implicit conversion from Path to std::string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36116/#review90425 --- Ship it! Ship It! - Benjamin Hindman On July 6, 2015, 2:34 a.m.,

Re: Review Request 36116: MESOS-2965: Add implicit conversion from Path to std::string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36116/ --- (Updated July 6, 2015, 2:34 a.m.) Review request for mesos, Artem Harutyunyan a

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated July 6, 2015, 2:25 a.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 36037: Adding /call endpoint to Master

> On July 3, 2015, 12:29 a.m., Ben Mahler wrote: > > I chatted with Isabel on IRC and asked her to break apart this change into > > more bite-sized chunks, so that we can do smaller reviews and get things > > committed incrementally: > > > > (1) Dummy /call handler on the master. > > (2) Valid

Re: Review Request 36037: Adding /call endpoint to Master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review90408 --- src/master/http.cpp (lines 328 - 345)

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90407 --- Patch looks great! Reviews applied: [36106] All tests passed. - M

Re: Review Request 36106: cgroups: added cpuacct subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- (Updated July 5, 2015, 6:30 p.m.) Review request for mesos, Ian Downes, Jie Yu,

Re: Review Request 36106: cgroups: added cpuacct subsystem

> On July 2, 2015, 11:32 p.m., Ben Mahler wrote: > > src/linux/cgroups.cpp, lines 2014-2027 > > > > > > Any reason you're not just re-using cgroups::stat here? I'd suggest > > just calling cgroups::stat for now, shou

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review90405 --- Patch looks great! Reviews applied: [36185] All tests passed. - M

Review Request 36185: Create pre-launch hook before a docker container launches in slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2588 https://issues.