Re: Review Request 40737: Took unmodified parameter by const void*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40737/ --- (Updated Nov. 26, 2015, 9:39 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 40737: Took unmodified parameter by const void*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40737/#review108108 --- Ship it! Ship It! - Bernd Mathiske On Nov. 26, 2015, 1:39

Re: Review Request 40679: Added filtering of CFS cgroup tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/ --- (Updated Nov. 26, 2015, 10:06 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40679: Added filtering of CFS cgroup tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/#review108110 --- Ship it! Ship It! - haosdent huang On Nov. 26, 2015, 10:06

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 22, 2015, 9:50 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 324-328 > > > > > > We should set the quota before we rescind so that we avoid the race > > above ;-) > >

Re: Review Request 40679: Added filtering of CFS cgroup tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/ --- (Updated Nov. 26, 2015, 10:12 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40732: Enabling ResourcesTest.Precision

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108097 --- Patch looks great! Reviews applied: [40730, 40732] Passed

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/ --- (Updated Nov. 26, 2015, 12:05 p.m.) Review request for mesos and Niklas

Review Request 40746: Quota: Removed quota from registry for remove request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40746/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-4021

Review Request 40745: Cleaned up `RemoveSingleQuota` test and corrected formatting issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40745/ --- Review request for mesos, Joerg Schad and Joris Van Remoortere. Repository:

Review Request 40748: Updated documentation to point out the need of a resolvable hostname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40748/ --- Review request for mesos, Bernd Mathiske, Lukas Loesche, and Timothy Chen.

Re: Review Request 40748: Updated documentation to point out the need of a resolvable hostname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40748/#review108124 --- Ship it! Ship It! - Lukas Loesche On Nov. 26, 2015, 1:08 p.m.,

Re: Review Request 40737: Took unmodified parameter by const void*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40737/#review108127 --- Patch looks great! Reviews applied: [40737] Passed command:

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 26, 2015, 2:01 p.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/ --- (Updated Nov. 26, 2015, 2:16 p.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40697/ --- (Updated Nov. 26, 2015, 2:18 p.m.) Review request for mesos and Adam B.

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108129 --- Ship it! Ship It! - Bernd Mathiske On Nov. 25, 2015, 10:52

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108130 --- Ship it! Thanks a bunch for coming up with this short-term-fix,

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 6:27 a.m., Till Toenshoff wrote: > > src/common/resources.cpp, line 947 > > > > > > Why introducing the leading space after the bracket? > > > > s/CHECK( /CHECK(/g I will fix this when

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108132 --- src/common/resources.cpp (line 35)

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108133 --- src/common/resources.cpp

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108134 --- Sorry for multiple shards instead of a single review.

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108136 --- Ship it! Ship It! - Klaus Ma On Nov. 26, 2015, 2:52 p.m.,

Re: Review Request 40396: Quota: Added a test for offer rescinding.

> On Nov. 25, 2015, 11:35 p.m., Joris Van Remoortere wrote: > > Added > > ``` > > EXPECT_CALL(sched2, resourceOffers(, _)) > > .Times(0); > > EXPECT_CALL(sched3, resourceOffers(, _)) > > .Times(0); > > ``` > > to resolve The assertion issue opened. > > > > Tested with gtest_shuffle, repeat

Re: Review Request 40679: Added filtering of CFS cgroup tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/#review108139 --- Patch looks great! Reviews applied: [40679] Passed command:

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108140 --- src/common/resources.cpp (line 949)

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 7:14 a.m., Neil Conway wrote: > > src/common/resources.cpp, line 951 > > > > > > This definitely needs an explanatory comment. I'll propose a patch that addresses these issues. - Bernd

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108142 --- src/tests/reservation_tests.cpp (line 163)

Review Request 40752: Fixed FetcherCacheTest test fixture initialization ordering issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40752/ --- Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3755

Re: Review Request 40679: Added filtering of CFS cgroup tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40679/#review108145 --- Ship it! Ship It! - Bernd Mathiske On Nov. 26, 2015, 2:12

Re: Review Request 40630: Upgrade pip to 7.1.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40630/#review108148 --- Ship it! Ship It! - Bernd Mathiske On Nov. 24, 2015, 12:45

Re: Review Request 40732: Enabling ResourcesTest.Precision

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108141 --- I don't think we're ready to enable this test yet. The test is

Re: Review Request 40752: Fixed FetcherCacheTest test fixture initialization ordering issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40752/#review108149 --- Ship it! Ship It! - Bernd Mathiske On Nov. 26, 2015, 7:21

Re: Review Request 40732: Enabling ResourcesTest.Precision

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108150 --- src/tests/resources_tests.cpp (line 1534)

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 3:14 p.m., Neil Conway wrote: > > src/common/resources.cpp, line 951 > > > > > > This definitely needs an explanatory comment. > > Bernd Mathiske wrote: > I'll propose a patch that addresses

Re: Review Request 40752: Fixed FetcherCacheTest test fixture initialization ordering issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40752/#review108155 --- Ship it! src/tests/fetcher_cache_tests.cpp (line 280)

Re: Review Request 40721: Cleaned up a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40721/#review108156 --- Ship it! Ship It! - Till Toenshoff On Nov. 25, 2015, 11:23

Re: Review Request 40630: Upgrade pip to 7.1.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40630/#review108157 --- Ship it! Ship It! - Till Toenshoff On Nov. 24, 2015, 8:45

Re: Review Request 40630: Upgrade pip to 7.1.2

> On Nov. 25, 2015, 6:11 p.m., Joseph Wu wrote: > > Verified `make distcheck` on Centos7, Ubunut 14, and Debian 8. > > > > Our usage of `pip` is fairly innocuous (it installs the python > > scheduler/executor drivers), so this change should be fine. > > > > Note: The CMake does not support

Review Request 40754: Fixed flaky test (AvailableResourcesAfterRescinding).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40754/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 40756: Updated allocator to use `nonRevocable()` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/ --- Review request for mesos and Michael Park. Bugs: MESOS-4020

Re: Review Request 40721: Cleaned up a test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40721/ --- (Updated Nov. 26, 2015, 10:42 p.m.) Review request for mesos and Michael Park.

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote: > > src/master/http.cpp, lines 541-551 > > > > > > As far as its implementation, let's do: > > > > ```cpp > > static Resources removeDisks(Resources

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 26, 2015, 9:26 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40697/#review108169 --- Patch looks great! Reviews applied: [40431, 40424, 40697] Passed

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/#review108168 --- Ship it! Ship It! - Till Toenshoff On Nov. 25, 2015, 2:32

Re: Review Request 40752: Fixed FetcherCacheTest test fixture initialization ordering issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40752/ --- (Updated Nov. 26, 2015, 9:59 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 40746: Quota: Removed quota from registry for remove request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40746/#review108165 --- Patch looks great! Reviews applied: [40745, 40746] Passed

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 26, 2015, 10:42 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 40756: Updated allocator to use `nonRevocable()` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/#review108173 --- Patch looks great! Reviews applied: [40755, 40756] Passed

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review108181 --- src/Makefile.am (line 1708)

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108176 --- src/common/resources.cpp (line 779)

Re: Review Request 40756: Updated allocator to use `nonRevocable()` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/#review108177 --- I think we should also update

Review Request 40759: [WIP] Command executor can overcommit the slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40759/ --- Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Summary

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40697/#review108183 --- Can you translate your test cases into GTest? - Klaus Ma On

Re: Review Request 40756: Updated allocator to use `nonRevocable()` where appropriate.

> On 十一月 27, 2015, 12:54 a.m., Guangya Liu wrote: > > I think we should also update > > https://github.com/apache/mesos/blob/master/src/common/http.cpp#L94 It is ok if only want to handle allocator part. - Guangya --- This is an

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review108180 --- Submitted with the following minor changes. src/master/http.cpp

Re: Review Request 40755: Introduced filter for non-revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40755/#review108182 --- src/common/resources.cpp (lines 777 - 778)