Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- (Updated Dec. 19, 2015, 7:58 a.m.) Review request for mesos, Adam B and Anand M

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 19, 2015, 7:16 a.m.) Review request for mesos, Adam B and Anand M

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- (Updated Dec. 19, 2015, 7:05 a.m.) Review request for mesos, Adam B and Anand M

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 19, 2015, 5:23 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 2675 > > > > > > Can we rename this as _isValidRole_ or some others which is more clear? > > The current _isWhitelistedRole_ can re

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

> On Dec. 17, 2015, 5:40 p.m., Adam B wrote: > > Let's get rid of the Vips message per MPark's recommendation, since we're > > unlikely to ever add any more fields to that message. Could you please also clean the `Depends On` field for this review? - Artem --

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review111362 --- src/tests/common/http_tests.cpp (line 101)

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

> On Dec. 18, 2015, 2:54 p.m., Artem Harutyunyan wrote: > > Commit messages should usually end with a period. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111222 -

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review111360 --- src/master/master.cpp (line 2658)

Re: Review Request 41408: Updated documentation for implicit roles.

> On 十二月 19, 2015, 3:58 a.m., Guangya Liu wrote: > > docs/roles.md, line 29 > > > > > > One minor comment: The whitelist is already a keyword when mesos master > > star up, not sure if this may bring some confusion f

Re: Review Request 41408: Updated documentation for implicit roles.

> On Dec. 19, 2015, 3:58 a.m., Guangya Liu wrote: > > docs/roles.md, line 29 > > > > > > One minor comment: The whitelist is already a keyword when mesos master > > star up, not sure if this may bring some confusion

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111357 --- Patch looks great! Reviews applied: [41474] Passed command: expor

Re: Review Request 41408: Updated documentation for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review111356 --- docs/roles.md (line 29)

Re: Review Request 41575: Removed outdated "Logging and Debugging" doc page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41575/#review111355 --- Patch looks great! Reviews applied: [41575] Passed command: expor

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111352 --- 3rdparty/libprocess/README.md (line 107)

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/#review111347 --- Patch looks great! Reviews applied: [41026] Passed command: expor

Re: Review Request 39597: Add Newbie guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review111338 --- Ship it! Ship It! - Timothy Chen On Dec. 8, 2015, 11:40 p.m., D

Re: Review Request 39597: Add Newbie guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review111337 --- I cleaned up all the URLs and I'm going to commit this for now. Tha

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

> On Dec. 18, 2015, 10:37 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 150 > > > > > > The need to use `lambda::_1` here is a bit unfortunate. I added a comment to clarify this. > On Dec. 18, 2

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

> On Dec. 18, 2015, 10:43 p.m., Neil Conway wrote: > > 3rdparty/libprocess/README.md, line 176 > > > > > > We should be consistent (between code samples) about whether we're > > assuming any `using` statements are i

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41567/#review111335 --- Patch looks great! Reviews applied: [40995, 41075, 41225, 41408, 4

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/ --- (Updated Dec. 19, 2015, 1:26 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review111333 --- src/slave/containerizer/mesos/provisioner/docker/message.proto (li

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40838/#review111332 --- src/docker/docker.cpp (line 363)

Re: Review Request 41573: Added DEFAULT_ALLOCATION_INTERVAL to master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41573/#review111329 --- Ship it! Ship It! - Guangya Liu On 十二月 18, 2015, 11:12 p.m., Gr

Re: Review Request 41573: Added DEFAULT_ALLOCATION_INTERVAL to master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41573/#review111325 --- Ship it! Ship It! - Jie Yu On Dec. 18, 2015, 11:12 p.m., Greg M

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review111321 --- Patch looks great! Reviews applied: [41011, 41125, 41194, 41406, 4

Re: Review Request 41575: Removed outdated "Logging and Debugging" doc page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41575/#review111318 --- Ship it! Ship It! - Joseph Wu On Dec. 18, 2015, 4:14 p.m., Neil

Re: Review Request 41575: Removed outdated "Logging and Debugging" doc page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41575/ --- (Updated Dec. 19, 2015, 12:14 a.m.) Review request for mesos and Joris Van Remo

Review Request 41575: Removed outdated "Logging and Debugging" doc page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41575/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111317 --- Ship it! LGTM - Anand Mazumdar On Dec. 18, 2015, 11:58 p.m., Ar

Re: Review Request 41571: Removed deprecated code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos and Jie Yu. Repos

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41426: Changed MergeFrom() to CopyFrom() in protobuf::createTask().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41426/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos and Artem Harutyuny

Re: Review Request 41560: Change Docker::run to take Subprocess::IO instead of Option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41560/ --- (Updated Dec. 18, 2015, 3:57 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/ --- (Updated Dec. 18, 2015, 11:53 p.m.) Review request for mesos and Joris Van Remo

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/ --- (Updated Dec. 18, 2015, 11:51 p.m.) Review request for mesos and Joris Van Remo

Re: Review Request 41422: Removed manual construction of Task in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 18, 2015, 3:49 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 18, 2015, 3:48 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 18, 2015, 3:48 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

> On Dec. 18, 2015, 8:05 p.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 99 > > > > > > Looks like `MasterFlags` is not needed anymore with implicit roles. Can > > you do a sweep to remove it in a

Re: Review Request 41225: Added test cases for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/#review111313 --- Ship it! Ship It! - Adam B On Dec. 18, 2015, 2:55 p.m., Neil Co

Re: Review Request 41408: Updated documentation for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review111312 --- Ship it! Ship It! - Adam B On Dec. 18, 2015, noon, Neil Conway

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

> On Dec. 18, 2015, 11:21 p.m., Anand Mazumdar wrote: > > src/common/http.cpp, line 299 > > > > > > Shouldn't this be: > > > > ``` > > object.values["container"] = std::move(task.container()); > > ``

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111307 --- Ship it! LGTM , minus a query about using `model(...)` and not usi

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/ --- (Updated Dec. 18, 2015, 11:19 p.m.) Review request for mesos, Jie Yu, Michael P

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

> On Dec. 18, 2015, 7:59 p.m., Jie Yu wrote: > > Thanks for the reviews, Jie! > On Dec. 18, 2015, 7:59 p.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 751 > > > > > > If you pause the clock, lo

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

> On Dec. 18, 2015, 10:48 a.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_tests.cpp, lines 888-891 > > > > > > It looks like this rule is not used in this test. Could you please > > explain why yo

Re: Review Request 41571: Removed deprecated code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/ --- (Updated Dec. 18, 2015, 3:13 p.m.) Review request for mesos and Jie Yu. Repos

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/ --- (Updated Dec. 18, 2015, 11:12 p.m.) Review request for mesos, Jie Yu, Michael P

Review Request 41573: Added DEFAULT_ALLOCATION_INTERVAL to master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41573/ --- Review request for mesos, Jie Yu and Michael Park. Repository: mesos Descript

Re: Review Request 41426: Changed MergeFrom() to CopyFrom() in protobuf::createTask().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41426/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos and Artem Harutyuny

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/#review111306 --- src/common/http.cpp (lines 232 - 259)

Re: Review Request 41422: Removed manual construction of Task in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 18, 2015, 3:10 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 18, 2015, 3:09 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 18, 2015, 3:04 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41571: Removed deprecated code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/#review111304 --- Ship it! Ship It! - Jie Yu On Dec. 18, 2015, 10:49 p.m., Artem

Re: Review Request 41571: Removed deprecated code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/#review111303 --- Ship it! Ship It! - Anand Mazumdar On Dec. 18, 2015, 10:49 p.m.

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review111302 --- Patch looks great! Reviews applied: [40951, 41090, 41108] Passed

Re: Review Request 41225: Added test cases for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/ --- (Updated Dec. 18, 2015, 10:55 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41225: Added test cases for implicit roles.

> On Dec. 18, 2015, 7:37 a.m., Adam B wrote: > > src/tests/role_tests.cpp, line 107 > > > > > > Is this necessary? The defaultAgentResourcesString is > > "cpus:2;mem:1024;disk:1024;ports:[31000-32000]" > > Overr

Re: Review Request 41560: Change Docker::run to take Subprocess::IO instead of Option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41560/ --- (Updated Dec. 18, 2015, 2:55 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111222 --- include/mesos/mesos.proto (line 1579)

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

> On Dec. 18, 2015, 10:35 a.m., Jie Yu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, lines 506-510 > > > > > > Maybe remove this in a followup patch? Thanks for spotting it, Jie! https://reviews

Review Request 41571: Removed deprecated code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41571/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- R

Re: Review Request 41026: libevent ssl: Added check for buffer length before swapping request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41026/#review111295 --- 3rdparty/libprocess/src/libevent_ssl_socket.cpp (lines 225 - 226)

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 2:45 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41225: Added test cases for implicit roles.

> On Dec. 17, 2015, 11:37 p.m., Adam B wrote: > > src/tests/role_tests.cpp, line 107 > > > > > > Is this necessary? The defaultAgentResourcesString is > > "cpus:2;mem:1024;disk:1024;ports:[31000-32000]" > > Over

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111297 --- 3rdparty/libprocess/README.md (line 176)

Re: Review Request 41474: Added documentation for `defer` in libprocess README.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41474/#review111287 --- 3rdparty/libprocess/README.md (line 106)

Re: Review Request 41567: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41567/#review111292 --- Ship it! Ship It! - Adam B On Dec. 18, 2015, 1:30 p.m., Neil Co

Re: Review Request 41253: Changed ownership semantics of ssl connect socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41253/ --- (Updated Dec. 18, 2015, 10:11 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 41472: Disallowed dynamic reservations for roles not on the role whitelist.

> On Dec. 17, 2015, 1:17 a.m., Michael Park wrote: > > src/master/http.cpp, lines 1000-1006 > > > > > > Hm, should this be added to `validation::operation::validate` instead? > > That way if/when we have frameworks

Re: Review Request 41253: Changed ownership semantics of ssl connect socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41253/#review111279 --- Ship it! 3rdparty/libprocess/src/libevent_ssl_socket.cpp (line 43

Re: Review Request 41560: Change Docker::run to take Subprocess::IO instead of Option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41560/#review111278 --- Patch looks great! Reviews applied: [41560] Passed command: expor

Re: Review Request 41488: Provisioner: Added docker v1 manifest protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41488/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41407: Unified Container: Save all docker image information on disk instead of rootfs only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41407/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41489/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41406: Unified Container: Added path helper method to get image layer manifest on local store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41406/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41125: Unified Container: Changed docker store and appc store to support passing runtime config to provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41125/ --- (Updated Dec. 18, 2015, 1:30 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41194: Unified Container: Cleanup uneccessary JSON parse in local puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41194/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41225: Added test cases for implicit roles.

> On Dec. 18, 2015, 7:37 a.m., Adam B wrote: > > src/tests/role_tests.cpp, line 120 > > > > > > s/by default/the default/ > > Neil Conway wrote: > ``` > $ ag "be filtered for 5 seconds (by default)" src/test

Re: Review Request 41011: Unified Container: Implemented interface for runtime configure to be returned from provisioner to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41011/ --- (Updated Dec. 18, 2015, 1:30 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 41567: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41567/ --- Review request for mesos and Adam B. Repository: mesos Description --- C

Re: Review Request 41225: Added test cases for implicit roles.

> On Dec. 18, 2015, 7:37 a.m., Adam B wrote: > > src/tests/role_tests.cpp, line 107 > > > > > > Is this necessary? The defaultAgentResourcesString is > > "cpus:2;mem:1024;disk:1024;ports:[31000-32000]" > > Overr

Re: Review Request 41253: Changed ownership semantics of ssl connect socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41253/#review111263 --- Patch looks great! Reviews applied: [41253] Passed command: expor

Re: Review Request 41108: CMake: Add sasl and dl link flags, add curl link library and add protobuf library directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/ --- (Updated Dec. 18, 2015, 8:25 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory

> On Dec. 9, 2015, 5:59 p.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 62 > > > > > > Same comment about the include directories, but with libraries. We > > probably want to include `CURL_LI

Re: Review Request 39520: Quota: Added authentication, authorization tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/#review111234 --- src/tests/master_quota_tests.cpp (line 1018)

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

> On Dec. 18, 2015, 11:04 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 386 > > > > > > s/v1DockerImageManifest/manifest/ v2 fixed as well. - Gilbert

Re: Review Request 41490: Provisioner: Added test case for docker v1 manifest serialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41490/ --- (Updated Dec. 18, 2015, 12:11 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 18, 2015, 12:10 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40271: [7/7] Added documentation for RESERVE, UNRESERVE, CREATE, and DESTROY authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40271/#review111252 --- Ship it! docs/authorization.md (line 11)

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40256/#review111249 --- Ship it! src/tests/persistent_volume_tests.cpp (line 99)

Re: Review Request 41225: Added test cases for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41225/ --- (Updated Dec. 18, 2015, 8:01 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41408: Updated documentation for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/ --- (Updated Dec. 18, 2015, 8 p.m.) Review request for mesos, Adam B and Yongqiao W

Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/#review111233 --- Ship it! src/master/master.cpp (line 3425)

  1   2   >