Review Request 47816: Show framework id in log of long-lived-framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47816/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5451 https://issues.ap

Re: Review Request 46418: Refactored the `os::access` function between POSIX and Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46418/#review134713 --- Ship it! Ship It! - Daniel Pravat On May 24, 2016, 9:36 p.m.

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 25, 2016, 5:21 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 25, 2016, 5:21 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 25, 2016, 5:19 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47795: Enabled authorization for sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47795/#review134695 --- Great job! Just a few suggestions: 1. role -> user (to match /stat

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 25, 2016, 4:29 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 25, 2016, 4:28 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47559: Added authorization based filtering to /state-summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 25, 2016, 4:27 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47558: Added Allower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 25, 2016, 4:26 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/ --- (Updated May 25, 2016, 4:09 a.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 47068: Added fine-grained filtering master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47068/ --- (Updated May 25, 2016, 4:02 a.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

> On May 25, 2016, 1:35 a.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 1353 > > > > > > Can you log the warning like we do in acceptOffers()? > > > > ``` > > if (!savedOffers.contains(offerId)) {

Re: Review Request 47805: Add authorization to GET /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/#review134697 --- Patch looks great! Reviews applied: [47805] Passed command: expo

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/ --- (Updated May 25, 2016, 3:45 a.m.) Review request for mesos. Bugs: https://iss

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47794/#review134693 --- src/files/files.cpp (lines 66 - 67)

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47794/#review134688 --- Looking pretty good. Just a couple of comments about wrapping/inde

Re: Review Request 47795: Enabled authorization for sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47795/#review134689 --- include/mesos/authorizer/acls.proto (lines 182 - 187)

Re: Review Request 47558: Added allower interface to authorizer.

> On May 24, 2016, 8:39 p.m., Alexander Rojas wrote: > > src/authorizer/local/authorizer.cpp, line 116 > > > > > > This method is reentrant and it doesn't depends on anything but its > > parameters, so it would be b

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

> On 五月 14, 2016, 1:55 p.m., Guangya Liu wrote: > > docs/persistent-volume.md, line 96 > > > > > > Can you please show more detail for `may take any value, or may be > > omitted.` > > > > a) In which conditi

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/#review134683 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 17, 2016, 1:27 p.m., haosdent huang wrote: > > src/Makefile.am, line 2048 > > > > > > I think you forgot to update the CMake build files. > > Qian Zhang wrote: > I see all the tests are not included in

Review Request 47805: Add authorization to GET /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/ --- Review request for mesos and Adam B. Bugs: mesos-5335 https://issues.apache

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/#review134679 --- Patch looks great! Reviews applied: [47359, 47360] Passed comman

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

> On May 25, 2016, 1:27 a.m., Joseph Wu wrote: > > src/sched/sched.cpp, line 325 > > > > > > On inspection, there's another (rarer) leak that can appear if: > > > > 1) Master sends offers to the framework. >

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/#review134676 --- Fix it, then Ship it! Thanks for catching this. src/sched/sch

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

> On May 25, 2016, 1:27 a.m., Joseph Wu wrote: > > src/sched/sched.cpp, line 325 > > > > > > On inspection, there's another (rarer) leak that can appear if: > > > > 1) Master sends offers to the framework. >

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated May 24, 2016, 6:33 p.m.) Review request for mesos, Guangya Liu, Artem

Review Request 47807: Implemented parsing a docker config to a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47807/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs: ME

Re: Review Request 45951: Implemented http basic auth to get docker auth token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45951/ --- (Updated May 24, 2016, 6:33 p.m.) Review request for mesos, Guangya Liu, Artem

Review Request 47806: Add docker config auth protobuf to docker spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47806/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs: ME

Review Request 47808: Added test for parsing docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47808/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs: ME

Re: Review Request 45950: Added test for docker spec get credential helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45950/ --- (Updated May 24, 2016, 6:31 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 45949: Implemented docker config get credential helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/ --- (Updated May 24, 2016, 6:31 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/#review134675 --- Fix it, then Ship it! Note: You'll need add newlines to your de

Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/ --- Review request for mesos. Bugs: https://issues.apache.org/jira/browse/MESOS-544

Re: Review Request 47486: Windows: Escaped command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47486/ --- (Updated May 25, 2016, 12:47 a.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 47486: Windows: Escaped command line arguments.

> On May 24, 2016, 11:49 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, lines 134-138 > > > > > > Can you explain why `strings::replace` doesn't work here? Why do we

Re: Review Request 47795: Enabled authorization for sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47795/#review134669 --- Patch looks great! Reviews applied: [47794, 47795] Passed comman

Re: Review Request 47577: Agent: Added minor changes to various .cpp files to support Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47577/#review134663 --- src/docker/docker.cpp (lines 451 - 452)

Re: Review Request 47602: Stout:[1/2] Added Windows support for folder `launcher/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47602/#review134665 --- 3rdparty/stout/include/stout/windows.hpp (lines 420 - 431)

Re: Review Request 47486: Windows: Escaped command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47486/#review134664 --- 3rdparty/libprocess/include/process/windows/subprocess.hpp (lines

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47576/#review134662 --- src/slave/containerizer/docker.cpp (line 251)

Re: Review Request 46418: Refactored the `os::access` function between POSIX and Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46418/#review134661 --- Patch looks great! Reviews applied: [46418] Passed command: expo

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/#review134660 --- src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lin

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review134659 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp (lin

Re: Review Request 47470: Stout: Added `path::temp_path`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47470/#review134657 --- 3rdparty/stout/include/stout/posix/path.hpp (line 19)

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47469/#review134656 --- src/CMakeLists.txt (line 259)

Re: Review Request 47468: Windows: Implemented IPC pipe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47468/#review134655 --- 3rdparty/libprocess/include/process/posix/pipe.hpp (line 25)

Re: Review Request 47359: Fixed a typo in persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47359/ --- (Updated May 24, 2016, 10:14 p.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

> On May 14, 2016, 1:55 p.m., Guangya Liu wrote: > > docs/persistent-volume.md, line 96 > > > > > > Can you please show more detail for `may take any value, or may be > > omitted.` > > > > a) In which condit

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47360/ --- (Updated May 24, 2016, 10:09 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/#review134648 --- Patch looks great! Reviews applied: [47149, 47205, 47212, 47213,

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 24, 2016, 9:44 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 24, 2016, 9:43 p.m.) Review request for mesos, Adam B, Alexander R

Review Request 47795: Enabled authorization for sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47795/ --- Review request for mesos, Adam B, Benjamin Mahler, Joerg Schad, Michael Park, an

Review Request 47794: Added authorization support for mesos::internal::Files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47794/ --- Review request for mesos, Adam B, Benjamin Mahler, Joerg Schad, Michael Park, an

Re: Review Request 46418: Refactored the `os::access` function between POSIX and Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46418/ --- (Updated May 24, 2016, 9:36 p.m.) Review request for mesos, Daniel Pravat, Alex

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/ --- (Updated May 24, 2016, 2:05 p.m.) Review request for mesos, Adam B, Artem Harut

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47150/ --- (Updated May 24, 2016, 2:04 p.m.) Review request for mesos, Adam B, Artem Harut

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

> On May 23, 2016, 8:38 p.m., Kapil Arya wrote: > > include/mesos/hook.hpp, line 112 > > > > > > Can we replace `name` with something more explicit/precise? This argument is a combination of the AgentID and Containe

Re: Review Request 47212: Removed duplicate call to containerizer::executorEnvironment.

> On May 23, 2016, 8:10 p.m., Kapil Arya wrote: > > src/slave/containerizer/docker.cpp, line 1195 > > > > > > Would there be any difference in the computed environment here vs in > > container constructor? The fir

Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

> On May 23, 2016, 8:17 p.m., Kapil Arya wrote: > > 3rdparty/stout/include/stout/flags/flags.hpp, line 1027 > > > > > > Just curious, will it do the right thing for boolean flags such as > > `--quiet`, `--no-quiet`

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/ --- (Updated May 24, 2016, 2:02 p.m.) Review request for mesos, Adam B, Artem Harut

Re: Review Request 47558: Added allower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/#review134631 --- src/authorizer/local/authorizer.cpp (line 116)

Re: Review Request 47786: Removed unneeded #includes from type_utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47786/#review134622 --- Patch looks great! Reviews applied: [47752, 47753, 47754, 47755,

Re: Review Request 47559: Added authorization based filtering to /state-summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/#review134523 --- src/authorizer/local/authorizer.cpp (line 471)

Review Request 47786: Removed unneeded #includes from type_utils.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47786/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- (Updated May 24, 2016, 10:18 a.m.) Review request for mesos, Benjamin Mahler, A

Re: Review Request 47198: Added labels to docker v1 spec config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/ --- (Updated May 24, 2016, 10:18 a.m.) Review request for mesos, Benjamin Mahler, A

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/#review134596 --- Ship it! Ship It! - Jie Yu On May 24, 2016, 3:20 a.m., Qian

Re: Review Request 47402: Fixed agent to properly handle killTask during agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47402/#review134595 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp (line

Re: Review Request 46370: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review133860 --- src/linux/capabilities.hpp (line 37)

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47069/ --- (Updated May 24, 2016, 4:06 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 47491: Added `environment` field to `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47491/ --- (Updated May 24, 2016, 3:59 p.m.) Review request for mesos and Michael Park.

Re: Review Request 36610: Add explicit syscall header file to linux fs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review134588 --- Is this patch still valid? Take a look at https://reviews.apache.o

Re: Review Request 47509: Fixed authorization::Request initializings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47509/#review134586 --- LGTM! I had to mechanically update the patch for changes in `mast

Re: Review Request 47771: Validate ACLs on creating an instance of local authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47771/#review134581 --- Patch looks great! Reviews applied: [47771] Passed command: expo

Review Request 47771: Validate ACLs on creating an instance of local authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47771/ --- Review request for mesos and Adam B. Bugs: MESOS-5406 https://issues.apache

Re: Review Request 45668: Enable CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134558 --- Patch looks great! Reviews applied: [45668] Passed command: expo

Re: Review Request 45668: Enable CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/ --- (Updated Mayo 24, 2016, 9:22 a.m.) Review request for mesos, Alex Clemmer, Joer

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review134543 --- Bad patch! Reviews applied: [47511] Failed command: ./support/ap

Re: Review Request 46904: Fixed a typo in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46904/#review134538 --- Ship it! Ship It! - Adam B On May 19, 2016, 2:44 p.m., Greg

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/#review134536 --- Patch looks great! Reviews applied: [46096, 46097, 46435, 46436,

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On 四月 11, 2016, 7:37 a.m., Guangya Liu wrote: > > src/uri/fetchers/docker.cpp, line 636 > > > > > > Add a log here to identify that the fetcher is now using auth to fetch > > the image? > > Guangya Liu wrote: >

Re: Review Request 45949: Implemented docker config get credential helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/#review134532 --- include/mesos/docker/spec.hpp (line 75)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134531 --- Ship it! Ship It! - Tomasz Janiszewski On May 24, 2016, 2:38

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated 五月 24, 2016, 7:20 a.m.) Review request for mesos, Gilbert Song and Jie