Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review134931 --- Bad patch! Reviews applied: [47511] Failed command:

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

> On 五月 14, 2016, 1:55 p.m., Guangya Liu wrote: > > docs/persistent-volume.md, line 96 > > > > > > Can you please show more detail for `may take any value, or may be > > omitted.` > > > > a) In which

Re: Review Request 47844: Agent: Added support for `slave/main.cpp`.

> On May 25, 2016, 9:04 p.m., Joris Van Remoortere wrote: > > src/slave/main.cpp, lines 153-162 > > > > > > Can we add a JIRA (and reference it in a comment) to add support for > > this? > > I know a lot of

Re: Review Request 47874: Windows: Added support for `--ip_discovery_command` parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47874/ --- (Updated May 26, 2016, 5:24 a.m.) Review request for mesos, Alex Naparu, Artem

Review Request 47874: Windows: Added support for `--ip_discovery_command` parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47874/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/#review134926 --- Patch looks great! Reviews applied: [47149, 47205, 47212, 47215,

Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47873/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 26, 2016, 4:56 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 26, 2016, 4:44 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review134909 --- include/mesos/authorizer/acls.proto (line 194)

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47069/ --- (Updated May 26, 2016, 4:43 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47490: Moved `Task` to public protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47490/ --- (Updated May 26, 2016, 4:42 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47866: Updated committers.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47866/#review134915 --- Ship it! - Joris Van Remoortere On May 26, 2016, 12:06 a.m.,

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 26, 2016, 3:19 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 26, 2016, 3:16 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47865: Sorted values of the enums authorization::Action and ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47865/#review134908 --- Patch looks great! Reviews applied: [47864, 47794, 47795, 47865]

Re: Review Request 47216: Wired up the new docker environment hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/ --- (Updated May 25, 2016, 7:21 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47215: Changed the dockerized docker command executor CommandInfo usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47215/ --- (Updated May 25, 2016, 7:21 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

> On May 25, 2016, 6:50 p.m., Jie Yu wrote: > > include/mesos/hook.hpp, lines 108-116 > > > > > > Any reason why all the fields here are needed? For instance, > > 'containerInfo' is part of either taskInfo or

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

> On May 25, 2016, 6:18 p.m., Jie Yu wrote: > > src/docker/executor.hpp, line 90 > > > > > > Can this be `Option`? If I make this a `JSON::Object`, the invocation site (https://reviews.apache.org/r/47216/diff/2#1)

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/ --- (Updated May 25, 2016, 7:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47149: Split DockerContainerizerProcess::launch into two functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47149/ --- (Updated May 25, 2016, 7:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

> On May 25, 2016, 6:25 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152 > > > > > > Is this change absolutely necessary for the ticket? > > Jie Yu wrote: > Oh, i see that being

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

> On May 26, 2016, 1:25 a.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152 > > > > > > Is this change absolutely necessary for the ticket? > > Jie Yu wrote: > Oh, i see that being

Re: Review Request 47866: Updated committers.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47866/#review134896 --- Patch looks great! Reviews applied: [47866] Passed command:

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 26, 2016, 1:36 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 45377: Made "driver" as optional for DockerVolume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/ --- (Updated 五月 26, 2016, 1:34 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 47736: Used Tasked ObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 26, 2016, 1:29 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 26, 2016, 1:28 a.m.) Review request for mesos and Michael Park.

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

> On May 26, 2016, 1:25 a.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152 > > > > > > Is this change absolutely necessary for the ticket? Oh, i see that being useful in the following

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/#review134892 --- 3rdparty/libprocess/src/subprocess.cpp (lines 150 - 152)

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review134882 --- src/docker/executor.hpp (line 89)

Re: Review Request 47559: Added authorization based filtering to /state-summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47559/ --- (Updated May 26, 2016, 1:16 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47865: Sorted values of the enums authorization::Action and ACLs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47865/ --- (Updated May 26, 2016, 3:09 a.m.) Review request for mesos and Adam B.

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 26, 2016, 1:09 a.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47795: Enabled authorization for sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47795/ --- (Updated May 26, 2016, 3:09 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 26, 2016, 1:07 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47794/ --- (Updated May 26, 2016, 3:07 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 47864: Extended authorization::Object message with optional fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47864/ --- (Updated May 26, 2016, 3:06 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 47258: Make sure 'activate' is a no-op if the client is already active.

> On May 25, 2016, 1:24 p.m., Joris Van Remoortere wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 90-91 > > > > > > Is this a guard as opposed to a `CHECK` because someone is using this > > API

Re: Review Request 47149: Split DockerContainerizerProcess::launch into two functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47149/#review134859 --- src/slave/containerizer/docker.cpp (lines 1025 - 1032)

Re: Review Request 47865: Sorted values of the enum authorization::Action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47865/#review134880 --- Patch looks great! Reviews applied: [47794, 47864, 47795, 47865]

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

> On May 25, 2016, 1:28 p.m., Joris Van Remoortere wrote: > > src/master/allocator/sorter/drf/sorter.cpp, line 50 > > > > > > Why can this be a `CHECK` if the previous review can't? > > What is the standard we're

Review Request 47866: Updated committers.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47866/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van

Re: Review Request 47865: Sorted values of the enum authorization::Action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47865/#review134878 --- Please also reorder the `ACLs` in `authorizer/acls.proto` - Adam

Re: Review Request 47864: Extended authorization::Object message with optional fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47864/#review134871 --- Fix it, then Ship it! Update the ordering and the comment, and

Re: Review Request 47795: Enabled authorization for sandboxes.

> On May 25, 2016, 6:34 a.m., Adam B wrote: > > include/mesos/authorizer/acls.proto, lines 221-222 > > > > > > Not yours, but.. Please put these in numerical order. Deprecated fields > > already have the deprecated

Review Request 47865: Sorted values of the enum authorization::Action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47865/ --- Review request for mesos and Adam B. Bugs: MESOS-5153

Re: Review Request 47795: Enabled authorization for sandboxes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47795/ --- (Updated May 26, 2016, 1:18 a.m.) Review request for mesos, Adam B, Benjamin

Review Request 47864: Extended authorization::Object message with optional fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47864/ --- Review request for mesos, Adam B, Joerg Schad, and Michael Park. Bugs:

Re: Review Request 47795: Enabled authorization for sandboxes.

> On May 25, 2016, 6:34 a.m., Adam B wrote: > > include/mesos/authorizer/acls.proto, lines 221-222 > > > > > > Not yours, but.. Please put these in numerical order. Deprecated fields > > already have the deprecated

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/#review134839 --- src/master/http.cpp (line 1573)

Re: Review Request 47821: Remove SASL dependency for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47821/#review134840 --- Thanks for proposing this workaround for the SASL on Windows

Re: Review Request 47265: Fixed provisioner parameter naming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47265/#review134843 --- Ship it! Ship It! - Jie Yu On May 11, 2016, 10:46 p.m.,

Re: Review Request 47843: Agent: Added Windows support for launcher/fetcher.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47843/#review134833 --- src/launcher/fetcher.cpp (lines 76 - 80)

Re: Review Request 47844: Agent: Added support for `slave/main.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47844/#review134836 --- Fix it, then Ship it! src/slave/main.cpp (lines 153 - 162)

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review134813 --- include/mesos/authorizer/acls.proto (line 200)

Re: Review Request 47842: Point slave flags at programmatic temp path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47842/#review134832 --- src/slave/flags.cpp (line 34)

Re: Review Request 47470: Stout: Added `path::temp_path`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47470/#review134831 --- As discussed offline: Let's move this into the `os` namespace.

Re: Review Request 47259: CHECK if DRFSorter::add() would introduce a duplicate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/#review134829 --- src/master/allocator/sorter/drf/sorter.cpp (line 50)

Re: Review Request 47258: Make sure 'activate' is a no-op if the client is already active.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47258/#review134826 --- src/master/allocator/sorter/drf/sorter.cpp (lines 90 - 91)

Re: Review Request 47257: Fixed an unassigned member variable in DRF sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47257/#review134814 --- Ship it! Ship It! - Joris Van Remoortere On May 19, 2016,

Re: Review Request 47844: Agent: Added support for `slave/main.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47844/#review134810 --- Bad patch! Reviews applied: [47844, 47843, 47842, 47442, 47489,

Re: Review Request 47821: Remove SASL dependency for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47821/#review134808 --- Bad patch! Reviews applied: [47821, 47671, 47442, 47489, 47474,

Review Request 47844: Agent: Added support for `slave/main.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47844/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134805 --- Ship it! Ship It! - Vinod Kone On May 23, 2016, 9:08 p.m.,

Review Request 47843: Agent: Added Windows support for launcher/fetcher.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47843/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47842: Point slave flags at programmatic temp path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47842/ --- (Updated May 25, 2016, 6:47 p.m.) Review request for mesos, Daniel Pravat,

Review Request 47821: Remove SASL dependency for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47821/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 46371: Added basic tests for capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated May 25, 2016, 6:39 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46370: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 25, 2016, 6:38 p.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review134535 --- I think for this patch we should at least have one test case

Re: Review Request 47528: Updated validation tests with creator principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47528/ --- (Updated May 25, 2016, 6:08 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

> On May 14, 2016, 1:55 p.m., Guangya Liu wrote: > > docs/persistent-volume.md, line 96 > > > > > > Can you please show more detail for `may take any value, or may be > > omitted.` > > > > a) In which

Re: Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134796 --- Ship it! Ship It! - Vinod Kone On May 24, 2016, 2:38 a.m.,

Re: Review Request 47795: Enabled authorization for sandboxes.

> On May 25, 2016, 5:14 a.m., Guangya Liu wrote: > > include/mesos/authorizer/authorizer.proto, line 69 > > > > > > New line above Any reason why we need a new line here? excep for the deprecate entries we don't

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47794/ --- (Updated May 25, 2016, 7:27 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

> On May 25, 2016, 5:27 a.m., Adam B wrote: > > src/files/files.cpp, lines 309-310 > > > > > > Can you wrap on `.then(` instead, please? Sorry, you are right. This is the output generated by clang format. -

Re: Review Request 44839: Enabled mesos containerizer do not cache image for appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review134787 --- Fix it, then Ship it!

Re: Review Request 44837: Added cached field to Image protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44837/#review134786 --- Ship it! Ship It! - Jie Yu On May 23, 2016, 11:30 p.m.,

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47736/ --- (Updated May 25, 2016, 4:59 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47704/ --- (Updated May 25, 2016, 4:58 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/ --- (Updated May 25, 2016, 4:57 p.m.) Review request for mesos, Adam B and Michael

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 25, 2016, 4:55 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134782 --- src/slave/slave.cpp (line 3454)

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/ --- (Updated May 25, 2016, 4:27 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/ --- (Updated May 25, 2016, 4:26 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 46613: Introduced filtering relevant actions and acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review134771 --- include/mesos/authorizer/authorizer.proto (line 42)

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47558/#review134772 --- include/mesos/authorizer/authorizer.hpp (line 43)

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134778 --- Sometimes mesos master would also send status update to the

Re: Review Request 47198: Added labels to docker v1 spec config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review134776 --- Ship it! Ship It! - Jie Yu On May 24, 2016, 5:18 p.m.,

Re: Review Request 47528: Updated validation tests with creator principal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47528/#review134766 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 11:45 a.m., Benjamin Bannier wrote: > > src/slave/http.cpp, line 379 > > > > > > Why was this needed? IMHO the existing explicitness helps to document > > what state we drag into the lambdas and

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 11:45 a.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 651 > > > > > > Remove this, same rationale as the comments in `Slave::Http::flags`. > > Abhishek Dasgupta wrote: > One thing I

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 9:45 a.m., Benjamin Bannier wrote: > > src/slave/http.cpp, line 379 > > > > > > Why was this needed? IMHO the existing explicitness helps to document > > what state we drag into the lambdas and

Re: Review Request 47753: Enabled building libprocess without building 3rdparty first.

> On May 25, 2016, 5 a.m., Till Toenshoff wrote: > > Seems you still need to fix configure.ac within libprocess. When running a > > `bootstrap` I am getting > > ``` > > configure.ac:62: error: required file '3rdparty/Makefile.in' not found > > configure.ac:64: error: required file

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 9:45 a.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 651 > > > > > > Remove this, same rationale as the comments in `Slave::Http::flags`. One thing I want to be sure here: "pid" is getting

Re: Review Request 47609: Reverted adding libelf as a default dynamic library in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47609/#review134750 --- Ship it! Ship It! - Till Toenshoff On May 19, 2016, 6:08

Re: Review Request 47610: Reverted adding libelf as a default dynamic library in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47610/#review134749 --- Ship it! Ship It! - Till Toenshoff On May 20, 2016, 12:56

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review134746 --- Patch looks great! Reviews applied: [47822] Passed command:

  1   2   >