Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 30, 2016, 6:59 a.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 50556: Added benchmark test for `Resources::nonRevocable`.

> On July 29, 2016, 8:39 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 2581-2589 > > > > > > The Arithmetic test should contain only the arithemtic operations. We > > can add a 'Filters' or

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

> On July 29, 2016, 8:35 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 2515-2523 > > > > > > Can we make the initial resources another parameter? I believe Klaus > > took this approach initi

Re: Review Request 50569: Added `isNegative` to check if the scalar resource is negative.

> On July 29, 2016, 8:52 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp, lines 1456-1457 > > > > > > On second thought, can we inline the logic here and add a TODO? > > > > ``` > > // R

Re: Review Request 50253: Added native implementation for the V0 Mesos Adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50253/ --- (Updated July 30, 2016, 2:26 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50252: Added native implementation for v1 Mesos interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50252/ --- (Updated July 30, 2016, 2:26 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50247: Added a abstract base class for scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50247/ --- (Updated July 30, 2016, 2:26 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50609: Moved check for '--version' in agent's 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/#review144245 --- src/slave/main.cpp (line 190)

Re: Review Request 50570: Mesos-slave --help should not return as failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50570/#review144244 --- Ship it! Ship It! - Vinod Kone On July 29, 2016, 10:32 a.m.,

Re: Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50254/#review144243 --- Ship it! Ship It! - Vinod Kone On July 29, 2016, 5:26 p.m.,

Re: Review Request 50253: Added native implementation for the V0 Mesos Adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50253/#review144242 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp (line 84)

Re: Review Request 50253: Added native implementation for the V0 Mesos Adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50253/#review144241 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp (line 786)

Re: Review Request 50609: Moved check for '--version' in agent's 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/#review144240 --- Ship it! Ship It! - haosdent huang On July 29, 2016, 5:16 p.

Re: Review Request 50482: Fixed the CORS error when redirect in WEB UI.

> On July 29, 2016, 11:46 p.m., Jiang Yan Xu wrote: > > src/webui/master/static/js/controllers.js, lines 399-402 > > > > > > Committing with minor comment tweaking > > > > ``` > > // When the curre

Re: Review Request 50323: Added build script for mesos-local executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50323/ --- (Updated July 30, 2016, 1:33 a.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50179: Added mesos-logrotate-logger utility executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50179/ --- (Updated July 30, 2016, 1:32 a.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50179: Added mesos-logrotate-logger utility executable.

> On July 28, 2016, 10:12 p.m., Joseph Wu wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 32 > > > > > > For consistency, this target should be called the > > `MESOS_LOGROTATE_LOGGER_TARGET`. Renamed to MESOS_

Re: Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/ --- (Updated July 30, 2016, 1:30 a.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50252: Added native implementation for v1 Mesos interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50252/#review144236 --- src/java/jni/org_apache_mesos_v1_scheduler_JNIMesos.cpp (line 282

Re: Review Request 50250: Added v1 Scheduler/Mesos interface in Java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50250/#review144234 --- Ship it! Ship It! - Vinod Kone On July 29, 2016, 5:26 p.m.,

Re: Review Request 50251: Added java implementations for the V0/V1 implementation for Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50251/#review144235 --- Ship it! Ship It! - Vinod Kone On July 29, 2016, 5:26 p.m.,

Re: Review Request 50248: Added helper functions for v1 JNI `construct()`/`convert()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50248/#review144233 --- Ship it! Ship It! - Vinod Kone On July 29, 2016, 5:26 p.m.,

Re: Review Request 50247: Added a abstract base class for scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50247/#review144232 --- Fix it, then Ship it! include/mesos/v1/scheduler.hpp (line 55)

Re: Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/ --- (Updated July 30, 2016, 12:29 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50569: Added `isNegative` to check if the scalar resource is negative.

> On 七月 29, 2016, 8:52 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp, lines 1456-1457 > > > > > > On second thought, can we inline the logic here and add a TODO? > > > > ``` > > // Rem

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review144227 --- src/tests/hierarchical_allocator_tests.cpp (lines 3470 - 3476)

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- (Updated July 29, 2016, 5 p.m.) Review request for mesos, Greg Mann, Artem Haru

Re: Review Request 40268: Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/ --- (Updated July 29, 2016, 4:59 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

> On July 28, 2016, 1:01 p.m., Greg Mann wrote: > > 3rdparty/libprocess/include/process/reap.hpp, line 22 > > > > > > I tend to prefer leaving includes when we explicitly make use of the > > type, as is the case with

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/ --- (Updated July 29, 2016, 4:58 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated July 29, 2016, 4:56 p.m.) Review request for mesos, Greg Mann, Artem H

Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50621/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, an

Re: Review Request 50556: Added benchmark test for `Resources::nonRevocable`.

> On 七月 29, 2016, 8:39 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 2581-2589 > > > > > > The Arithmetic test should contain only the arithemtic operations. We > > can add a 'Filters' or 'F

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

> On 七月 29, 2016, 8:35 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 2515-2523 > > > > > > Can we make the initial resources another parameter? I believe Klaus > > took this approach initial

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

> On July 27, 2016, 4:35 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/process.cpp, line 1162 > > > > > > Maybe not significant, but perhaps we should reinitialize this to > > `INADDR_ANY`, since that's the in

Re: Review Request 50482: Fixed the CORS error when redirect in WEB UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review144221 --- Ship it! src/webui/master/static/js/controllers.js (lines 375

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

> On April 25, 2016, 3:55 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/process.cpp, line 1106 > > > > > > Consider moving to `::finalize`. The unproxy code should mostly remain > > in-place. Added another r

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- (Updated July 29, 2016, 4:44 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50488/#review144217 --- Ship it! I'll change the description to ``` When the request w

Re: Review Request 50593: Added `URL::isAbsolute` to check if the URL is absolute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50593/#review144216 --- Ship it! Ship It! - Jiang Yan Xu On July 29, 2016, 12:02 a.m

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/#review144194 --- 3rdparty/libprocess/src/process.cpp (line 863)

Re: Review Request 50569: Added `isNegative` to check if the scalar resource is negative.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50569/#review144190 --- src/common/resources.cpp (lines 1456 - 1457)

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50568/#review144182 --- Ship it! Ship It! - Benjamin Mahler On July 29, 2016, 1:34 a

Re: Review Request 50557: Used `add` instead of `+=` for `Resources::filter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50557/#review144180 --- Ship it! Ship It! - Benjamin Mahler On July 28, 2016, 9:29 a

Re: Review Request 50556: Added benchmark test for `Resources::nonRevocable`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50556/#review144179 --- src/tests/resources_tests.cpp (lines 2581 - 2589)

Re: Review Request 50553: Used `subtract` instead of `-=` for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50553/#review144176 --- Ship it! Ship It! - Benjamin Mahler On July 28, 2016, 9:30 a

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/#review144175 --- src/tests/resources_tests.cpp (lines 2515 - 2523)

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/#review144173 --- src/tests/resources_tests.cpp (lines 2537 - 2548)

Re: Review Request 50459: Added code to generate JNI Header files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50459/ --- (Updated July 29, 2016, 8:13 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated July 29, 2016, 8:13 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50460: Added code to build libstate shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50460/ --- (Updated July 29, 2016, 8:13 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- (Updated July 29, 2016, 8:12 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50456: Added custom command to generate Java protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50456/ --- (Updated July 29, 2016, 8:13 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50457/ --- (Updated July 29, 2016, 8:13 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50458: Added code to build mesos-java.jar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50458/ --- (Updated July 29, 2016, 8:13 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/ --- (Updated July 29, 2016, 8:12 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50455: Enabled Java builds if Java is found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50455/ --- (Updated July 29, 2016, 8:13 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50456: Added custom command to generate Java protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50456/ --- (Updated July 29, 2016, 7:55 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50457/ --- (Updated July 29, 2016, 7:56 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50455: Enabled Java builds if Java is found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50455/ --- (Updated July 29, 2016, 7:55 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- (Updated July 29, 2016, 7:54 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/ --- (Updated July 29, 2016, 7:55 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50520: Tweaked agent logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50520/#review144163 --- Fix it, then Ship it! src/slave/slave.cpp

Re: Review Request 50518: Clarified log messages during master startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50518/ --- (Updated July 29, 2016, 7:22 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 50518: Clarified log messages during master startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50518/#review144162 --- Ship it! Ship It! - Anand Mazumdar On July 27, 2016, 5:30 p.

Re: Review Request 50517: Reduced verbosity of version logging in executor/scheduler driver.

> On July 29, 2016, 7:09 p.m., Anand Mazumdar wrote: > > src/exec/exec.cpp, line 161 > > > > > > Why this change? This is very useful when debugging to know the version > > of mesos the executable was compiled again

Re: Review Request 48616: Add v1 changes for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48616/ --- (Updated July 29, 2016, 7:09 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50205/ --- (Updated July 29, 2016, 7:09 p.m.) Review request for mesos, Klaus Ma and Jiang

Re: Review Request 50517: Reduced verbosity of version logging in executor/scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50517/#review144157 --- src/exec/exec.cpp (line 161)

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 29, 2016, 7:09 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On July 29, 2016, 1:14 a.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, lines 848-850 > > > > > > Just trying to see if the comments can be made more concise: > > > > ``` > > Assuming the wrappe

Re: Review Request 50516: Fixed quoting for executor and task IDs in log messages.

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote: > > hmm, why can't the TaskID's have spaces? > > > > They are generated by the framework and are free to contain spaces. Yeah, I was wondering that myself :) We don't quote them almost all the time, however. I figured I would first make it

Re: Review Request 50516: Fixed quoting for executor and task IDs in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50516/#review144155 --- hmm, why can't the TaskID's have spaces? They are generated by t

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review144154 --- This test is VERY slow as it currently stands but /r/43666/ should

Re: Review Request 50301: Reduced logging verbosity for replicated log operations.

> On July 29, 2016, 6:48 p.m., Anand Mazumdar wrote: > > src/log/recover.cpp, line 466 > > > > > > hmm, why did you reduce the verbosity here? Do you think that is important to log? Note that this doesn't indicate a

Re: Review Request 50301: Reduced logging verbosity for replicated log operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50301/#review144148 --- Fix it, then Ship it! src/log/recover.cpp (line 466)

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46227/#review144147 --- include/mesos/mesos.proto (line 711)

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/ --- (Updated July 29, 2016, 6:15 p.m.) Review request for mesos, Benjamin Mahler, K

Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50524/ --- (Updated July 29, 2016, 6:16 p.m.) Review request for mesos, Benjamin Mahler, K

Re: Review Request 50253: Added native implementation for the V0 Mesos Adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50253/ --- (Updated July 29, 2016, 6:06 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On July 20, 2016, 2:36 a.m., Klaus Ma wrote: > > src/common/resources.cpp, lines 308-316 > > > > > > I think we can check name,type, role firstly, then check SharedInfo. Although I updated it based on your comment

Re: Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.

> On July 26, 2016, 11:56 p.m., Vinod Kone wrote: > > src/examples/java/V1TestFramework.java, line 134 > > > > > > can you add a hearbeat timer and do a `reconnect()` if it fires? I left a TODO to do this in a follo

Re: Review Request 50248: Added helper functions for v1 JNI `construct()`/`convert()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50248/ --- (Updated July 29, 2016, 5:26 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50251: Added java implementations for the V0/V1 implementation for Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50251/ --- (Updated July 29, 2016, 5:26 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50253: Added native implementation for the V0 Mesos Adapter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50253/ --- (Updated July 29, 2016, 5:26 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50247: Added a abstract base class for scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50247/ --- (Updated July 29, 2016, 5:26 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50252: Added native implementation for v1 Mesos interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50252/ --- (Updated July 29, 2016, 5:26 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50250: Added v1 Scheduler/Mesos interface in Java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50250/ --- (Updated July 29, 2016, 5:26 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50254/ --- (Updated July 29, 2016, 5:26 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 50570: Mesos-slave --help should not return as failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50570/#review144122 --- Ship it! Ship It! - Greg Mann On July 29, 2016, 10:32 a.m.,

Review Request 50609: Moved check for '--version' in agent's 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/ --- Review request for mesos, Jie Yu and Pierre Cheynier. Bugs: MESOS-5928 http

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/ --- (Updated July 29, 2016, 5:05 p.m.) Review request for mesos, James Peach, Joris

Re: Review Request 50017: Do not validate resource when add/subtract `Resources` object.

> On 七月 29, 2016, 5:54 a.m., Jiang Yan Xu wrote: > > By extension of this, wouldn't any resource in Resources be non-empty as > > well? Had some offline discussion with Yan, I can see that the only case we can get empty resource in `resources` object is: End user can start up agent by setting

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review144080 --- Ship it! Ship It! - Alexander Rukletsov On July 19, 2016, 9:

Re: Review Request 50570: Mesos-slave --help should not return as failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50570/ --- (Updated July 29, 2016, 10:32 a.m.) Review request for mesos and Greg Mann. C

Re: Review Request 50601: Fixed Rakefile to generate links to external .md files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50601/#review144073 --- Ship it! Ship It! - Till Toenshoff On July 29, 2016, 9:35 a.

Re: Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 七月 29, 2016, 9:57 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50125: Added mesos-docker-executor support for device control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 七月 29, 2016, 9:56 a.m.) Review request for mesos, Benjamin Mahler, Kev

Re: Review Request 50599: Added a new 'device' entry to 'docker::Flags'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/ --- (Updated 七月 29, 2016, 9:54 a.m.) Review request for mesos, Benjamin Mahler, Gua

Re: Review Request 50128: Added helpful functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 七月 29, 2016, 9:52 a.m.) Review request for mesos, Benjamin Mahler, Kev

  1   2   >