Review Request 51411: Added provisioner tests to provision using meta discovery.

2016-08-24 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/ --- Review request for mesos. Bugs: MESOS-4288

Review Request 51410: Enabled meta discovery using appc labels.

2016-08-24 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 51408: Updated test to account for new 'init' process semantics in a container.

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51408/#review146753 --- Patch looks great! Reviews applied: [51272, 51273, 51274, 51275,

Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer.

2016-08-24 Thread Jie Yu
> On Aug. 24, 2016, 11:49 p.m., Joseph Wu wrote: > > Looks like the same code in the docker containerizer is missing the same > > check. Can you create a ticket to track? :) - Jie --- This is an automatically generated e-mail. To

Review Request 51417: Removed a NOTE in MesosContainerizer that no longer applies.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51417/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-08-24 Thread Guangya Liu
> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 1555 > > > > > > I wouldn't just blindly call this function here. It should be wrapped > > in some logic that makes

Review Request 51418: Updated a few comments in MesosContainerizer.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51418/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos

Review Request 51414: Fixed the using statements in MesosContainerizer.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51414/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos

Review Request 51416: Fixed a TODO in the MesosContainerizer.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51416/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos

Review Request 51415: A few consistency fix on indentation.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51415/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-24 Thread Guangya Liu
> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 45967: Added documentation for shareable resources.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Aug. 25, 2016, 4:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45964: Add unit tests for sharing of resources.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated Aug. 25, 2016, 4:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49571: Added a benchmark test for allocations.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Aug. 25, 2016, 4:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45966: Offer shared resources to frameworks only if opted in.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated Aug. 25, 2016, 4:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Aug. 25, 2016, 4:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Aug. 25, 2016, 4:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 25, 2016, 4:14 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated Aug. 25, 2016, 4:13 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 51412: Add offeredResources to Allocator::updateAllocation() API.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51412/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4431

Re: Review Request 51412: Add offeredResources to Allocator::updateAllocation() API.

2016-08-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51412/ --- (Updated Aug. 25, 2016, 4:13 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51402: Added nested container check in provisioner destroy.

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51402/#review146747 --- Patch looks great! Reviews applied: [51323, 51343, 51358, 51359,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

2016-08-24 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review146046 --- Comments mainly on tests (which I didn't look at earlier).

Re: Review Request 51404: Updated the agent to reject multiple terminal status updates.

2016-08-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51404/#review146745 --- Fix it, then Ship it! src/slave/slave.cpp (line 3468)

Re: Review Request 51403: Added 'at' to LinkedHashMap.

2016-08-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51403/#review146743 --- Ship it! Ship It! - Vinod Kone On Aug. 25, 2016, 1:06 a.m.,

Review Request 51409: Printed all the isolator cleanup errors during destory.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51409/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 51393: Added unit test for provisioner recursive listContainers().

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/#review146741 --- Patch looks great! Reviews applied: [51323, 51343, 51358, 51359,

Review Request 51404: Updated the agent to reject multiple terminal status updates.

2016-08-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51404/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6026

Review Request 51408: Updated test to account for new 'init' process semantics in a container.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51408/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6088

Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51407/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6088

Review Request 51406: Updated 'launcher' to optionally spawn an 'init' process.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51406/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6088

Review Request 51405: Updated a few more tests to create a temporary 'runtime_dir'.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51405/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6050

Review Request 51403: Added 'at' to LinkedHashMap.

2016-08-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51403/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 51402: Added nested container check in provisioner destroy.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51402/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review146740 --- src/slave/containerizer/mesos/linux_launcher.cpp (line 132)

Review Request 51401: Removed 'status' in the destroy chain in MesosContainerizer.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51401/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 51400: Stopped passing messages in MesosContainerizer destroy methods.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51400/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146724 --- src/slave/containerizer/docker.hpp (lines 20 - 25)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review146726 --- src/slave/containerizer/docker.hpp (lines 505 - 507)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review146736 --- src/docker/docker.hpp (lines 73 - 84)

Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51391/#review146738 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 2:09

Re: Review Request 51124: Support more layers through symlink for overlay backend.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51124/#review146732 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

2016-08-24 Thread Guangya Liu
> On 八月 23, 2016, 11:48 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 93 > > > > > > I'd prefer that we move this under `using std::xxx`. > > > > ``` > > using std::list; > > using

Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer.

2016-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51391/#review146735 --- Ship it! Looks like the same code in the docker containerizer

Re: Review Request 51391: Fixed a bug related to logger in MesosContainerizer.

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51391/#review146731 --- Patch looks great! Reviews applied: [51388, 51389, 51390, 51391]

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-08-24 Thread Jiang Yan Xu
> On Aug. 23, 2016, 2:26 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 276-279 > > > > > > Probably extract this snippet in a function, e.g. > > `conditionalAllocate()`? >

Re: Review Request 51358: Implemented recursive helper method findContainerDir for provisioner.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51358/ --- (Updated Aug. 24, 2016, 3:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-24 Thread Benjamin Mahler
> On Aug. 24, 2016, 10:04 p.m., Benjamin Mahler wrote: > > Ship It! Note that the change isn't C++11 related (my TODO was suggesting to use a lambda which requires C++11, but your change just uses defer. Since this didn't use to work, I updated the commit summary to be the following: ```

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/#review146720 --- Ship it! Ship It! - Benjamin Mahler On Aug. 5, 2016, 3:30

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146717 --- Patch looks great! Reviews applied: [51052] Passed command:

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

2016-08-24 Thread Benjamin Mahler
> On Aug. 23, 2016, 11:48 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 4056 > > > > > > how about s/int/size_t? Yes for most containers or loop iterators, but protobuf uses `int` for `.size()` so I

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

2016-08-24 Thread Benjamin Mahler
> On Aug. 24, 2016, 12:38 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 3257 > > > > > > do you want to add a "messages_launch_task_groups" metric? My understanding is that `messages_launch_tasks`

Review Request 51392: Supported provisioner listContainers() to be recursive.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51392/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Review Request 51393: Added unit test for provisioner recursive listContainers().

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 51234: Add `userenv` import library to `Windows` build.

2016-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51234/#review146715 --- 3rdparty/stout/cmake/StoutConfigure.cmake (line 114)

Re: Review Request 51390: Added a TODO about a bug in MesosContainerizer.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51390/#review146716 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 2:08

Re: Review Request 51213: Used `os::execlp` instead of `::execlp`.

2016-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51213/#review146710 --- Ship it! - Joseph Wu On Aug. 19, 2016, 10:38 a.m., Daniel

Re: Review Request 51233: Build a clean `Windows` environment for `mesos-executor`.

2016-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51233/#review146706 --- Mostly naming and comment suggestions. But there's one major

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/#review146709 --- Fix it, then Ship it!

Re: Review Request 51210: Update mesos-executor name for Windows.

2016-08-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51210/#review146708 --- Fix it, then Ship it! src/slave/slave.cpp (lines 128 - 130)

Re: Review Request 51389: A few style cleanups in MesosContainerizer.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51389/#review146714 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 2:08

Re: Review Request 51388: Replaced raw pointers in MesosContainerizer with Owned pointers.

2016-08-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51388/#review146713 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 2:08

Review Request 51391: Fixed a bug related to logger in MesosContainerizer.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51391/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 51390: Added a TODO about a bug in MesosContainerizer.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51390/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 51389: A few style cleanups in MesosContainerizer.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51389/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 51388: Replaced raw pointers in MesosContainerizer with Owned pointers.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51388/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

2016-08-24 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Aug. 24, 2016, 8:32 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/#review146704 --- src/health-check/health_checker.cpp (line 79)

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 24, 2016, 6:04 p.m.) Review request for mesos, Alexander

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 24, 2016, 6:04 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 24, 2016, 6:03 p.m.) Review request for mesos, Alexander

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 24, 2016, 6:03 p.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 24, 2016, 5:28 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 51083: Passed the pid of the container into `HealthChecker`.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51083/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 49556: Removed the binary way of HealthCheck in src.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 50657: Removed the binary way of health check in libprocess.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 24, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 24, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 24, 2016, 5:22 p.m.) Review request for mesos, Alexander

Review Request 51379: Entered the appropriate namespaces of the task during health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman,

Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman,

Re: Review Request 51083: Passed the pid of the container into `HealthChecker`.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51083/ --- (Updated Aug. 24, 2016, 5:03 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 24, 2016, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 24, 2016, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 24, 2016, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 49556: Removed the binary way of HealthCheck in src.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 24, 2016, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 51323: Supported provisioner provision() and destroy() to be nested aware.

2016-08-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51323/#review146679 --- Ship it! Ship It! - Jie Yu On Aug. 23, 2016, 8:05 a.m.,

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 24, 2016, 4:50 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 24, 2016, 4:49 p.m.) Review request for mesos, Alexander

Re: Review Request 49556: Removed the binary way of HealthCheck in src.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 24, 2016, 4:48 p.m.) Review request for mesos, Alexander

Re: Review Request 50657: Removed the binary way of health check in libprocess.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 24, 2016, 4:48 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 24, 2016, 4:48 p.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 24, 2016, 4:47 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 24, 2016, 4:46 p.m.) Review request for mesos, Alexander

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-08-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146673 --- Patch looks great! Reviews applied: [51028, 51027] Passed

Re: Review Request 51217: Added `os::execlp' in `stout` library.

2016-08-24 Thread Daniel Pravat
> On Aug. 22, 2016, 6:39 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/shell.hpp, lines 114-115 > > > > > > I'm not sure I understand what this comment is saying. Are you > > explaining the

Review Request 51371: Fixed a fragile test case.

2016-08-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51371/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049

  1   2   >