Re: Review Request 57623: Updated the maintenance tab in the webui to auto-refresh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57623/#review169357 --- Ship it! Ship It! - haosdent huang On March 14, 2017, 10:30

Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57713/#review169355 --- Patch looks great! Reviews applied: [57713] Passed command:

Re: Review Request 57574: Ensured the cgroup memory+swap limit is no less than the memory limit.

> On March 14, 2017, 4:56 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > > Lines 266-270 (patched) > > > > > > It's not clear to me how we ensure this invariant

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

> On March 16, 2017, 2:25 p.m., Neil Conway wrote: > > Seems like a legitimate problem in `SlaveRecoveryTest/0.CleanupExecutor`, > > per the review bot. Can you take a look? > > Megha Sharma wrote: > So, the thing is I see this error only in the review bot. I tested this > patch on OS X

Review Request 57750: Turned off executor authentication in the ExecutorHttpApiTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57750/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Review Request 57749: Updated the mock agent for executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57749/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Review Request 57748: Enabled executor authentication in the tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57748/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Review Request 57747: Fixed invocations of 'executorEnvironment' in the tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57747/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Review Request 57746: Adjusted namespaces in the tests to prevent collisions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57746/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Review Request 57745: Added secret generation to the agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57745/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Review Request 57744: Added secret generation to the local agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57744/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Review Request 57743: Updated the agent to generate executor secrets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57743/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 57739: Completed frameworks should be tracked based on source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57739/#review169351 --- Patch looks great! Reviews applied: [57739] Passed command:

Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57713/ --- (Updated March 18, 2017, 12:19 a.m.) Review request for mesos, Alexander

Re: Review Request 57527: Avoided storing weights in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57527/#review169345 --- For posterity, Neil and I discussed at length offline whether we

Review Request 57739: Completed frameworks should be tracked based on source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57739/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7181

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/#review169344 --- Patch looks great! Reviews applied: [55895, 55896, 55897, 55903]

Re: Review Request 55896: Stop storing agent flags in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55896/ --- (Updated March 17, 2017, 9:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55903: Update XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55903/ --- (Updated March 17, 2017, 9:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55895: Add zero byte disk resource support to XFS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated March 17, 2017, 9:57 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated March 17, 2017, 9:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review169323 --- src/authorizer/local/authorizer.cpp Lines 1155 (patched)

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/#review169325 --- src/master/master.hpp Lines 684-686 (patched)

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

> On March 16, 2017, 9:25 p.m., Neil Conway wrote: > > Seems like a legitimate problem in `SlaveRecoveryTest/0.CleanupExecutor`, > > per the review bot. Can you take a look? So, the thing is I see this error only in the review bot. I tested this patch on OS X and we ran it on a linux

Re: Review Request 57714: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57714/#review169318 --- Ship it! Ship It! - Benjamin Mahler On March 17, 2017,

Re: Review Request 57527: Avoided storing weights in the allocator.

> On March 17, 2017, 1:41 a.m., Benjamin Mahler wrote: > > Thinking a little more about this, it seems odd that the sorter is storing > > weight information for clients that are unknown to it. Why? It seems > > cleaner if the sorter only understands weights for its clients, rather than > >

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 17, 2017, 1:33 a.m., Benjamin Mahler wrote: > > Hm.. this seems to introduce a performance regression in the case where > > there are many inactive roles in the system? I assume it's difficult to > > avoid in the hierarchical case? Otherwise, this looks good. > > Neil Conway wrote:

Re: Review Request 57527: Avoided storing weights in the allocator.

> On March 17, 2017, 1:41 a.m., Benjamin Mahler wrote: > > Thinking a little more about this, it seems odd that the sorter is storing > > weight information for clients that are unknown to it. Why? It seems > > cleaner if the sorter only understands weights for its clients, rather than > >

Re: Review Request 57731: Fix a test in MasterAuthorizationTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/#review169310 --- Patch looks great! Reviews applied: [57520, 57534, 57535, 57710,

Re: Review Request 56215: Reused previous task status to generate a new one in default executor.

> On March 17, 2017, 10:44 a.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Line 910 (original), 921 (patched) > > > > > > is this safe because before `taskHealthUpdated` is called we would've > >

Re: Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.

> On March 17, 2017, 10:26 a.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Lines 286 (patched) > > > > > > So, a cosequence of putting `acknowledged` inside `containers` is that > > now an

Re: Review Request 57712: No need to set `agent_subsystems` for all the slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57712/#review169259 --- Ship it! - Jiang Yan Xu On March 16, 2017, 5 p.m., Anindya

Re: Review Request 56410: Increased granularity of environment handling in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56410/#review169300 --- src/launcher/executor.cpp Lines 396-397 (patched)

Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57713/#review169299 --- Patch looks great! Reviews applied: [57713] Passed command:

Re: Review Request 57426: Added PULL_CONTAINER_IMAGE agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57426/#review169294 --- include/mesos/agent/agent.proto Lines 179 (patched)

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 17, 2017, 1:33 a.m., Benjamin Mahler wrote: > > Hm.. this seems to introduce a performance regression in the case where > > there are many inactive roles in the system? I assume it's difficult to > > avoid in the hierarchical case? Otherwise, this looks good. True -- if there are

Review Request 57731: Fix a test in MasterAuthorizationTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/ --- Review request for mesos, Anindya Sinha and Vinod Kone. Bugs: MESOS-7097

Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57730/ --- Review request for mesos and Anindya Sinha. Bugs: MESOS-7097

Re: Review Request 57714: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57714/#review169290 --- Bad review! Reviews applied: [57714, 57529, 57513, 57512, 57511,

Re: Review Request 57712: No need to set `agent_subsystems` for all the slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57712/#review169284 --- Patch looks great! Reviews applied: [57712] Passed command:

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated March 17, 2017, 12:54 p.m.) Review request for mesos, Adam B and

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57472/ --- (Updated March 17, 2017, 12:09 p.m.) Review request for mesos, Adam B,

Re: Review Request 56449: Moved health checker closer to container in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review169281 --- Ship it! Ship It! - Vinod Kone On March 16, 2017, 4:48

Re: Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57695/#review169280 --- Ship it! Ship It! - Vinod Kone On March 16, 2017, 4:45

Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`.

> On March 13, 2017, 10:23 p.m., Alexander Rukletsov wrote: > > docs/upgrades.md > > Lines 261-263 (patched) > > > > > > Let's say how they should update the cluster. > > > > ``` > > * When upgrading a

Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57696/#review169279 --- Ship it! Ship It! - Vinod Kone On March 16, 2017, 5:22

Re: Review Request 56218: Added a check test for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169278 --- Fix it, then Ship it! src/tests/check_tests.cpp Lines 846-848

Re: Review Request 56213: Added check tests for command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review169277 --- Ship it! Assuming existing issues are resolved and the file is

Re: Review Request 57696: Overloaded `<<` for `CheckStatusInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57696/#review169274 --- src/common/type_utils.cpp Lines 490 (patched)

Re: Review Request 56217: Added support for general checks to default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/#review169272 --- Fix it, then Ship it! src/launcher/default_executor.cpp Lines

Re: Review Request 56215: Reused previous task status to generate a new one in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56215/#review169271 --- Ship it! src/launcher/default_executor.cpp Line 910

Re: Review Request 57695: Kept TaskInfo beyond first scheduler ack in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57695/#review169267 --- src/launcher/default_executor.cpp Lines 88 (patched)

Re: Review Request 57694: Added a warning if default executor gets an unknown acknowledgement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57694/#review169266 --- Ship it! Ship It! - Vinod Kone On March 16, 2017, 4:51

Re: Review Request 56449: Moved health checker closer to container in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56449/#review169265 --- src/launcher/default_executor.cpp Line 873 (original)

Re: Review Request 57713: Added `virtualenv` as a dependency in `getting-started.md`.

> On March 17, 2017, 1:46 a.m., Joseph Wu wrote: > > docs/windows.md > > Lines 26 (patched) > > > > > > I'd prefer a link to the download page, rather than to some random > > blog: