Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/#review171082 --- Patch looks great! Reviews applied: [57815, 57816, 57817, 57818]

Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated April 5, 2017, 10:24 a.m.) Review request for mesos, Adam B,

Re: Review Request 58196: Implemented TCP check support in command and default executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58196/#review171079 --- Patch looks great! Reviews applied: [58190, 58191, 58192, 58193,

Re: Review Request 58058: Moved libprocess initialization of worker threads later.

> On April 4, 2017, 9:58 p.m., Greg Mann wrote: > > IIUC, previously-queued events can execute in a later instance of > > libprocess because they persist in the file-scope `functions` queue that we > > declare in the event loop implementations? So this patch still allows > > previously-queued

Re: Review Request 58058: Moved libprocess initialization of worker threads later.

> On April 4, 2017, 9:58 p.m., Greg Mann wrote: > > IIUC, previously-queued events can execute in a later instance of > > libprocess because they persist in the file-scope `functions` queue that we > > declare in the event loop implementations? So this patch still allows > > previously-queued

Re: Review Request 58059: Changed libprocess SocketManager to refer to HttpProxy by PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58059/#review171075 --- Have you encountered a deadlock at all when running the test in

Re: Review Request 58058: Moved libprocess initialization of worker threads later.

> On April 4, 2017, 2:58 p.m., Greg Mann wrote: > > IIUC, previously-queued events can execute in a later instance of > > libprocess because they persist in the file-scope `functions` queue that we > > declare in the event loop implementations? So this patch still allows > > previously-queued

Re: Review Request 58186: Stop logging the HTTP user agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58186/#review171072 --- Patch looks great! Reviews applied: [58185, 58186] Passed

Re: Review Request 58125: Stout: Added stringify for std::wstring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58125/#review171069 --- Ship it! 3rdparty/stout/include/stout/stringify.hpp Lines

Re: Review Request 58160: Stout: Removed `TRUE_COMMAND`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58160/#review171066 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 2:21 p.m.,

Re: Review Request 58127: Windows: Rewrote subprocess helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58127/#review171064 --- - Joseph Wu On March 31, 2017, 4:52 p.m., Andrew Schwartzmeyer

Re: Review Request 58128: Windows: Updated use of UTF-16 `getSystemEnvironment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58128/#review171065 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 10:54 a.m.,

Re: Review Request 58161: Fixed HealthyTaskNonShell test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58161/#review171067 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 4:35 p.m.,

Re: Review Request 58128: Windows: Updated use of UTF-16 `getSystemEnvironment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58128/#review171059 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 10:54 a.m.,

Re: Review Request 58160: Stout: Removed `TRUE_COMMAND`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58160/#review171060 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 2:21 p.m.,

Re: Review Request 58161: Fixed HealthyTaskNonShell test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58161/#review171061 --- Ship it! Ship It! - Joseph Wu On April 3, 2017, 4:35 p.m.,

Re: Review Request 58127: Windows: Rewrote subprocess helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58127/#review171037 --- Ship it! Basically a refactoring. Looks functionally similar

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/ --- (Updated April 4, 2017, 10:37 p.m.) Review request for mesos, James Peach,

Re: Review Request 57817: Suppress offers for frameworks on registration.

> On April 4, 2017, 5:57 p.m., James Peach wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 271 (original), 272 (patched) > > > > > > Remove double space after `framework`. There does not seem to be

Re: Review Request 57817: Suppress offers for frameworks on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated April 4, 2017, 10:37 p.m.) Review request for mesos, James Peach,

Re: Review Request 58188: Linked task group doc from home.md.

> On April 4, 2017, 10:09 p.m., Gilbert Song wrote: > > docs/home.md > > Lines 39 (patched) > > > > > > * [Nested Container and Task Group](nested-container-and-task-group.md) > > a.k.a. Pods in Mesos. Renamed it

Review Request 58196: Implemented TCP check support in command and default executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58196/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-7275

Review Request 58195: Added TCP checks in Mesos API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58195/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-7275

Review Request 58194: Hardened HTTP check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Review Request 58192: Used constexpr char instead of static const string for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58192/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Review Request 58193: Renamed variables in checker library for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58193/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Review Request 58191: Renamed a test helper for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58191/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Review Request 58190: Improved termination logging in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58190/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Re: Review Request 58188: Linked task group doc from home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58188/#review171049 --- docs/home.md Lines 39 (patched)

Review Request 58188: Linked task group doc from home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58188/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 58058: Moved libprocess initialization of worker threads later.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58058/#review171046 --- IIUC, previously-queued events can execute in a later instance of

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/#review171043 --- Patch looks great! Reviews applied: [58095, 58096, 58097, 58099]

Re: Review Request 57998: Added ResourceProviderID to Resource protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57998/#review171040 --- src/tests/resources_tests.cpp Lines 1537 (patched)

Review Request 58186: Stop logging the HTTP user agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58186/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7340

Review Request 58185: Log HTTP accesses to the /files endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58185/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7340

Re: Review Request 57663: Updated documentation for multiple HTTP authenticators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57663/#review171032 --- Ship it! Ship It! - Vinod Kone On March 23, 2017, 10:43

Re: Review Request 57667: Added executor authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57667/#review171031 --- docs/authentication.md Lines 120 (patched)

Re: Review Request 57925: Added further tests for executor secret generation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57925/#review171028 --- src/tests/slave_tests.cpp Lines 5904-5905 (patched)

Re: Review Request 57731: Fixed a test in MasterAuthorizationTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57731/#review171025 --- Ship it! Ship It! - Greg Mann On March 17, 2017, 3:55 p.m.,

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57730/#review171024 --- Ship it! Ship It! - Greg Mann On March 17, 2017, 3:53 p.m.,

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review171023 --- Ship it! Ship It! - Greg Mann On March 28, 2017, 8:24 a.m.,

Re: Review Request 57667: Added executor authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57667/ --- (Updated April 4, 2017, 6:57 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58175/#review171006 --- Patch looks great! Reviews applied: [58174, 58175] Passed

Re: Review Request 57535: Applied RegisterAgent ACL to the master.

> On March 17, 2017, 9:32 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 684-686 (patched) > > > > > > Could you leave a TODO here to update this function to use `Principal` > > when MESOS-7202 is

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/#review171002 --- Ship it! Ship It! - James Peach On April 3, 2017, 10:35

Re: Review Request 57817: Suppress offers for frameworks on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review170997 --- Fix it, then Ship it!

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/ --- (Updated April 5, 2017, 1:47 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/ --- (Updated April 5, 2017, 1:46 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- (Updated April 5, 2017, 1:46 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated April 5, 2017, 1:46 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

> On April 4, 2017, 5:42 p.m., Andrew Schwartzmeyer wrote: > > Ship It! This patch fixes the `CombinedAuthenticatorTest.MultipleAuthenticators` test failure that otherwise reproduces on Windows 10 with the VS 2017 tools. - Andrew ---

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58175/#review170995 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 4, 2017,

Re: Review Request 57816: Add a scheduler flag `offers_suppressed_on_register`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57816/#review170994 --- Ship it! Ship It! - James Peach On April 3, 2017, 10:34

Re: Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58175/#review170993 --- Ship it! Ship It! - Anand Mazumdar On April 4, 2017, 2:15

Re: Review Request 58174: Fixed the signatures of some test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58174/#review170986 --- Ship it! Ship It! - Anand Mazumdar On April 4, 2017, 2:11

Re: Review Request 58173: Fixed 'CombinedAuthenticator' to avoid an extra copy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58173/#review170982 --- Ship it! Ship It! - Anand Mazumdar On April 4, 2017, 2:11

Re: Review Request 58173: Fixed 'CombinedAuthenticator' to avoid an extra copy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58173/#review170975 --- Patch looks great! Reviews applied: [58173] Passed command:

Re: Review Request 57998: Added ResourceProviderID to Resource protos.

> On April 4, 2017, 4:40 p.m., Jan Schlicht wrote: > > Sorry for not noticing this earlier: Because I've just run into this, could > > you also add a `std::hash` specialization for `ResourceProviderID` in > > `type_utils.hpp`? This will allow us to use `ResourceProviderID` as key in > > a

Re: Review Request 57998: Added ResourceProviderID to Resource protos.

> On April 4, 2017, 4:40 p.m., Jan Schlicht wrote: > > Sorry for not noticing this earlier: Because I've just run into this, could > > you also add a `std::hash` specialization for `ResourceProviderID` in > > `type_utils.hpp`? This will allow us to use `ResourceProviderID` as key in > > a

Re: Review Request 57998: Added ResourceProviderID to Resource protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57998/#review170970 --- Sorry for not noticing this earlier: Because I've just run into

Review Request 58175: Fixed an iterator bug in 'CombinedAuthenticator::authenticate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58175/ --- Review request for mesos, Anand Mazumdar, Michael Park, and Vinod Kone.

Review Request 58174: Fixed the signatures of some test helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58174/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 58173: Fixed 'CombinedAuthenticator' to avoid an extra copy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58173/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 58021: Added storage-related offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/ --- (Updated April 4, 2017, 2:47 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/#review170963 --- Bad review! Reviews applied: [57474, 57473, 57166, 56805, 57165,

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/ --- (Updated April 4, 2017, 11:22 a.m.) Review request for mesos, Adam B and

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 4, 2017, 11:21 a.m.) Review request for mesos, Adam B and

Re: Review Request 57998: Added ResourceProviderID to Resource protos.

> On March 30, 2017, 1:33 a.m., Jie Yu wrote: > > src/tests/resources_tests.cpp > > Lines 1532 (patched) > > > > > > Let's split this test into smaller tests each of which test one > > functionality. Take a look