Re: Review Request 52103: Implemented quota update in `/quota` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52103/ --- (Updated Aug. 5, 2017, 4:41 a.m.) Review request for mesos, Alexander

Re: Review Request 53691: Implemented some quota functionality tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53691/ --- (Updated Aug. 5, 2017, 4:40 a.m.) Review request for mesos, Alexander

Re: Review Request 52284: Implemented more quota validation tests and validate duplicate name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52284/ --- (Updated Aug. 5, 2017, 4:38 a.m.) Review request for mesos, Alexander

Review Request 61446: Added a test to verify a fix for MESOS-7863.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61446/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7783 and

Review Request 61445: Fixed a bug in the agent where a kill task is dropped.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61445/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7863

Review Request 61444: Renamed Framework::pending to Framework::pendingTasks in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61444/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 61441: Updated Framework::removePendingTask to take only a TaskID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61441/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 61440: Added a TODO to correctly represent framework lifecycle in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61440/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 61443: Marked Framework::hasTask in agent as const.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61443/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 61442: Introduced a Framework::idle function in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61442/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated Aug. 5, 2017, 2:08 a.m.) Review request for mesos, Andrew

Re: Review Request 61270: Added container PID namespace control protobuf field in LinuxInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61270/#review182250 --- include/mesos/mesos.proto Lines 2741-2746 (patched)

Re: Review Request 61406: Introduced `--disallow_top_level_pid_ns_sharing` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61406/#review182249 --- Fix it, then Ship it! docs/configuration.md Lines 2052-2054

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/#review182248 --- src/slave/containerizer/mesos/isolators/namespaces/pid.cpp Lines

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/#review182235 --- src/slave/containerizer/mesos/isolators/namespaces/pid.cpp Lines

Review Request 61438: Improved `NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61438/ --- Review request for mesos, Kevin Klues and Vinod Kone. Repository: mesos

Re: Review Request 61282: Added a test verifying that DefaultExecutor tasks can use nvidia GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61282/ --- (Updated Aug. 5, 2017, 12:05 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 58898: Send task kill for non-Partition Aware frameworks.

> On May 10, 2017, 11:24 p.m., Neil Conway wrote: > > My apologies for the delay in reviewing this. > > > > High-level comments: > > > > (a) Can we improve the description of the problem in the commit summary? It > > took me quite a while to figure out what is actually going on here. My > >

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/ --- (Updated Aug. 4, 2017, 11:21 p.m.) Review request for mesos, Andrew

Re: Review Request 61096: Building gRPC with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/ --- (Updated Aug. 4, 2017, 11:20 p.m.) Review request for mesos, Andrew

Re: Review Request 61394: Made the capabilities isolator work with nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61394/ --- (Updated Aug. 4, 2017, 10:33 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61282: Added a test verifying that DefaultExecutor tasks can use nvidia GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61282/ --- (Updated Aug. 4, 2017, 10:30 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 61394: Made the capabilities isolator work with nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61394/#review182242 --- Fix it, then Ship it!

Re: Review Request 61387: Made the rlimits isolator work with nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61387/#review182240 --- Ship it! Ship It! - Jie Yu On Aug. 4, 2017, 9:15 p.m.,

Re: Review Request 61394: Made the capabilities isolator work with nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61394/ --- (Updated Aug. 4, 2017, 9:57 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61387: Made the rlimits isolator work with nested containers.

> On Aug. 4, 2017, 8:58 a.m., Benjamin Bannier wrote: > > src/tests/containerizer/posix_rlimits_isolator_tests.cpp > > Lines 380-381 (patched) > > > > > > Indent by two spaces less. The pattern in this file is to

Re: Review Request 61387: Made the rlimits isolator work with nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61387/ --- (Updated Aug. 4, 2017, 9:15 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182234 --- Fix it, then Ship it! This is great! docs/health-checks.md

Re: Review Request 60440: Updated local development workflow of mesos website.

> On Aug. 2, 2017, 9:11 a.m., Benjamin Bannier wrote: > > While I see the value of being consistent with the CI bot's setup, I still > > strongly believe that we should remove this dev setup in favor of a simple > > `rake`-driven workflow (like we already discussed offline). I guess the > >

Re: Review Request 60440: Updated local development workflow of mesos website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/ --- (Updated Aug. 4, 2017, 7:01 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 61433: Checked openssl and zlib as required libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Bugs: MESOS-7809

Re: Review Request 61406: Introduced `--disallow_top_level_pid_ns_sharing` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61406/#review182232 --- Ship it! Ship It! - Gilbert Song On Aug. 4, 2017, 9 a.m.,

Review Request 61435: Added logging in docker executor on `docker stop` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61435/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6743

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/ --- (Updated Aug. 4, 2017, 6:09 p.m.) Review request for mesos, Gastón Kleiman and

Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 10:59 a.m., Benjamin Bannier wrote: > > support/mesos-website/entrypoint.sh > > Lines 23 (patched) > > > > > > Do you still recall why this was needed? It would be great to add e.g., > > a JIRA or

Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 10:52 a.m., Benjamin Bannier wrote: > > support/mesos-website/build.sh > > Lines 22 (patched) > > > > > > This script will misbehave if run from a live dev checkout (it might > > e.g., reconfigure

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review182220 --- Ship it! Ship It! - Benjamin Bannier On Aug. 4, 2017, 8:36

Re: Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- (Updated Aug. 5, 2017, 12:39 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 61387: Made the rlimits isolator work with nested containers.

> On Aug. 4, 2017, 10:58 a.m., Benjamin Bannier wrote: > > src/tests/containerizer/posix_rlimits_isolator_tests.cpp > > Lines 449 (patched) > > > > > > It would be nice to avoid hardcoding `4` here, e.g., > > >

Review Request 61428: Added pid ns sharing based on agent flag and protobuf message field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61428/ --- Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues,

Re: Review Request 61406: Introduced `--disallow_top_level_pid_ns_sharing` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61406/ --- (Updated Aug. 5, 2017, midnight) Review request for mesos, Gastón Kleiman,

Re: Review Request 61098: Added unit tests for gRPC support in libprocess.

> On Aug. 4, 2017, 3:53 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/tests/grpc_tests.cpp > > Lines 95 (patched) > > > > > > Can we just make this test conditional compile in the makefile? This fileis already

Re: Review Request 61098: Added unit tests for gRPC support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/#review182212 --- 3rdparty/libprocess/src/tests/grpc_tests.cpp Lines 95 (patched)

Re: Review Request 61095: Updated LICENSE information for grpc 1.4.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61095/#review182210 --- Ship it! Ship It! - Jie Yu On Aug. 3, 2017, 6:06 p.m.,

Re: Review Request 61275: Added a URL parameter to the resource provider driver.

> On Aug. 3, 2017, 10 a.m., Benjamin Bannier wrote: > > src/resource_provider/daemon.hpp > > Lines 44 (patched) > > > > > > I wonder if it would make more sense to keep passing a pid here like > > you did

Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/ --- (Updated Aug. 4, 2017, 10:40 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 61387: Made the rlimits isolator work with nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61387/#review182189 --- LGTM. Left mostly style comments.

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/ --- (Updated Aug. 4, 2017, 6:36 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 8:59 a.m., Benjamin Bannier wrote: > > support/mesos-website/entrypoint.sh > > Lines 23 (patched) > > > > > > Do you still recall why this was needed? It would be great to add e.g., > > a JIRA or

Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 8:52 a.m., Benjamin Bannier wrote: > > support/mesos-website/build.sh > > Lines 22 (patched) > > > > > > This script will misbehave if run from a live dev checkout (it might > > e.g., reconfigure