Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/ --- (Updated May 3, 2018, 4:54 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/ --- (Updated May 3, 2018, 12:05 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review202330 --- As discussed in our direct review, some more changes on the

Re: Review Request 66923: Added documentation on volume resize support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202340 --- PASS: Mesos patch 66923 was successfully built and tested.

Re: Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/#review202338 --- PASS: Mesos patch 66920 was successfully built and tested.

Re: Review Request 66923: Added documentation on volume resize support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/#review202331 --- Haven't finished the review yet. Have you tried using the

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/ --- (Updated May 2, 2018, 5:06 p.m.) Review request for mesos, Chun-Hung Hsiao,

Review Request 66923: Added documentation on volume resize support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66923/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/#review202329 --- src/tests/api_tests.cpp Lines 3685-3687 (patched)

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202327 --- PASS: Mesos patch 66919 was successfully built and tested.

Re: Review Request 66908: Correctly reconciled dropped operation after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66908/#review202323 --- Fix it, then Ship it!

Re: Review Request 66872: Updated FrameworkInfo comparator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66872/ --- (Updated May 2, 2018, 6:21 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202322 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On May 2, 2018, 4:41 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 580 (patched) > > > > > > How about doing these checks in a task so we could validate that a task > > could

Re: Review Request 66912: Resolved the `realpath` of the sandbox directory in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66912/#review202320 --- Ship it! Ship It! - Chun-Hung Hsiao On May 2, 2018, 6:29

Review Request 66920: Improved tests for resizing persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66920/ --- Review request for mesos, Greg Mann and Zhitao Li. Repository: mesos

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 2, 2018, 9:38 p.m.) Review request for mesos. Bugs: MESOS-8630

Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- Review request for mesos. Bugs: MESOS-8630

Re: Review Request 66916: Disabled a resource provider resubscription test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66916/#review202318 --- PASS: Mesos patch 66916 was successfully built and tested.

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 2:16 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 2:14 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66912: Resolved the `realpath` of the sandbox directory in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66912/#review202317 --- Patch looks great! Reviews applied: [66912] Passed command:

Re: Review Request 66912: Resolved the `realpath` of the sandbox directory in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66912/#review202315 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66916: Disabled a resource provider resubscription test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66916/#review202314 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 2, 2018,

Re: Review Request 66912: Resolved the `realpath` of the sandbox directory in tests.

> On May 2, 2018, 12:03 p.m., Chun-Hung Hsiao wrote: > > Do you know what are the tests that compare the real paths? I was wondering > > if we should just fix those tests for self-containedness. They are the tests listed in the attached bug, plus previous tests that had to be "fixed" like

Re: Review Request 66916: Disabled a resource provider resubscription test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66916/#review202310 --- Ship it! Ship It! - Chun-Hung Hsiao On May 2, 2018, 7:30

Review Request 66916: Disabled a resource provider resubscription test on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66916/ --- Review request for mesos, Andrew Schwartzmeyer and Chun-Hung Hsiao.

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202306 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/#review202305 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66912: Resolved the `realpath` of the sandbox directory in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66912/#review202302 --- Do you know what are the tests that compare the real paths? I was

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 12:01 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66903: Fixed incorrect enum value comparisons.

> On May 2, 2018, 5:49 p.m., James Peach wrote: > > I think the original author expected the `using > > mesos::v1::scheduler::Call;` declaration to cause `Call::SUBSCRIBE` to find > > the `v1` version. I'm fine with this change, especially if we are getting > > compiler warnings for it by

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review202300 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/ --- (Updated May 2, 2018, 6:30 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

> On April 11, 2018, 2:06 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/strings.hpp > > Lines 390-392 (patched) > > > > > > This is definitely simple but is this how C++20 std libraries implement >

Review Request 66912: Resolved the `realpath` of the sandbox directory in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66912/ --- Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Jan Schlicht. Bugs:

Re: Review Request 66908: Correctly reconciled dropped operation after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66908/#review202297 --- Patch looks great! Reviews applied: [66908] Passed command:

Re: Review Request 66901: Add the ASF events link to the website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66901/#review202295 --- Ship it! Ship It! - Benjamin Mahler On May 2, 2018, 3:36

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/#review202289 --- FAIL: Failed to apply the dependent review: 66531. Failed

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66227/ --- (Updated May 2, 2018, 10:28 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

> On May 1, 2018, 7:18 p.m., Chun-Hung Hsiao wrote: > > src/tests/master_validation_tests.cpp > > Lines 1657 (patched) > > > > > > Hmm... we don't have this check when validating `GrowVolume` because we > > are

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 10:24 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66901: Add the ASF events link to the website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66901/#review202286 --- Ship it! Built locally on a Mac and tested in my heavily

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review202285 --- Just leaving the things we discussed here for a record. The

Re: Review Request 66903: Fixed incorrect enum value comparisons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66903/#review202283 --- Patch looks great! Reviews applied: [66903] Passed command:

Re: Review Request 66903: Fixed incorrect enum value comparisons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66903/#review202282 --- Ship it! I think the original author expected the `using

Re: Review Request 66908: Correctly reconciled dropped operation after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66908/#review202281 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66908: Correctly reconciled dropped operation after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66908/ --- Review request for mesos, Gaston Kleiman and Greg Mann. Bugs: MESOS-8870

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review202276 --- Patch looks great! Reviews applied: [66644] Passed command:

Re: Review Request 66776: Changed failure check for a call to os::system().

> On May 2, 2018, 12:49 p.m., Benjamin Bannier wrote: > > LGTM, but could you please create a ticket for fixing the weird semantics > > of `os::system`? Opened https://issues.apache.org/jira/browse/MESOS-8869 - Benno --- This is an

Re: Review Request 66776: Changed failure check for a call to os::system().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66776/#review202274 --- Ship it! LGTM, but could you please create a ticket for fixing

Re: Review Request 66904: Added 'Ninja' byproducts for jemalloc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66904/#review202270 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66901: Add the ASF events link to the website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66901/#review202268 --- Patch looks great! Reviews applied: [66901] Passed command:

Re: Review Request 66904: Added 'Ninja' byproducts for jemalloc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66904/#review202267 --- Ship it! Ship It! - Benjamin Bannier On May 2, 2018, 12:34

Re: Review Request 66903: Fixed incorrect enum value comparisons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66903/#review202266 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66904: Added 'Ninja' byproducts for jemalloc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66904/ --- Review request for mesos, Benjamin Bannier and Benno Evers. Bugs: MESOS-8866

Review Request 66903: Fixed incorrect enum value comparisons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66903/ --- Review request for mesos and James Peach. Bugs: MESOS-8865

Re: Review Request 66885: Removed unnecessary `get()` accessors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66885/#review202262 --- Ship it! Thanks for fixing these. I looked why we missed

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202261 --- Bad patch! Reviews applied: [66858, 66227, 66051, 66052, 66532,

Re: Review Request 66900: Avoid copying of re-register framework messages in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66900/#review202260 --- Patch looks great! Reviews applied: [66860, 66900] Passed

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review202259 --- FAIL: Some of the unit tests failed. Please check the relevant