Re: Review Request 67193: Added the Mesos 1.6.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67193/#review203395 --- site/source/blog/2018-05-17-mesos-1-6-0-released.md Lines 32

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203394 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

> On May 17, 2018, 4:21 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/windows/shell.hpp > > Lines 279-291 (original), 283-306 (patched) > > > > > > (Old comment: Since the size is `constexpr`

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203390 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67193: Added the Mesos 1.6.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67193/#review203389 --- PASS: Mesos patch 67193 was successfully built and tested. All

Re: Review Request 67190: Overloaded `stringify` for `Error`s to reduce overheads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67190/#review203387 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67202: Added ContainerID to container logger prepare interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67202/#review203384 --- Fix it, then Ship it! Let's please explain the motivation for

Re: Review Request 67194: Windows: Fixed cURL copy command to run only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67194/#review203386 --- PASS: Mesos patch 67194 was successfully built and tested.

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203385 --- PASS: Mesos patch 67195 was successfully built and tested.

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203382 --- 3rdparty/stout/include/stout/internal/windows/inherit.hpp Lines

Re: Review Request 67193: Added the Mesos 1.6.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67193/#review203381 --- Ship it! Ship It! - James Peach On May 17, 2018, 10:35

Re: Review Request 67193: Added the Mesos 1.6.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67193/ --- (Updated May 17, 2018, 10:35 p.m.) Review request for mesos, Alexander

Review Request 67202: Added ContainerID to container logger prepare interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67202/ --- Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Till Toenshoff.

Re: Review Request 67190: Overloaded `stringify` for `Error`s to reduce overheads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67190/ --- (Updated May 17, 2018, 10:25 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67193: Added the Mesos 1.6.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67193/#review203379 --- site/source/blog/2018-05-17-mesos-1-6-0-released.md Lines 26

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/ --- (Updated May 17, 2018, 10:23 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67136: Added a function to get rlimits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203380 --- PASS: Mesos patch 67136 was successfully built and tested.

Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-8926

Re: Review Request 67193: Added the Mesos 1.6.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67193/#review203378 --- Fix it, then Ship it! Everything else looked good.

Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- Review request for mesos, James Peach and Jiang Yan Xu. Bugs: mesos-8340

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 15, 2018, 11:05 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 361 (original), 360-365 (patched) > > > > > > Moving our previous discussion from

Review Request 67194: Windows: Fixed cURL copy command to run only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67194/ --- Review request for mesos, Benjamin Bannier and John Kordich. Repository: mesos

Review Request 67193: Added the Mesos 1.6.0 release blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67193/ --- Review request for mesos, Alexander Rukletsov, Gaston Kleiman, Gilbert Song,

Re: Review Request 67136: Added a function to get rlimits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203373 --- Fix it, then Ship it! src/posix/rlimits.cpp Lines 147

Re: Review Request 67189: Windows: Removed guards now that `os::shell` exists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67189/#review203368 --- PASS: Mesos patch 67189 was successfully built and tested.

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review203366 --- src/tests/fetcher_tests.cpp Lines 1023-1026 (original),

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

> On May 14, 2018, 9:34 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 74 (patched) > > > > > > This should just be `is Abs = path::absolute(path)`. The function is > > already

Re: Review Request 67158: Updated the CSI client to use the new libprocess gRPC interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67158/ --- (Updated May 17, 2018, 7:38 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67156: Renamed `grpc::Channel` to `grpc::client::Connection`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67156/ --- (Updated May 17, 2018, 7:37 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 17, 2018, 7:36 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 67191: Supported custom error types for the `Future(Try<...>)` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67191/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.

Review Request 67190: Made `stringify` overloads for strings more efficient.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67190/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park.

Review Request 67189: Windows: Removed guards now that `os::shell` exists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67189/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Review Request 67188: Windows: Implemented `os::shell` and enabled tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67188/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/#review203358 --- 3rdparty/stout/CMakeLists.txt Line 35 (original), 36 (patched)

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review203361 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/#review203354 --- 3rdparty/CMakeLists.txt Lines 760 (patched)

Re: Review Request 67055: Updated cpplint to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67055/#review203357 --- Ship it! Ship It! - Eric Chung On May 16, 2018, 2:29 p.m.,

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 17, 2018, 6:11 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67164: Supported custom error types for `Try` in `AssertSome`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67164/ --- (Updated May 17, 2018, 6:10 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- Review request for mesos, Gaston Kleiman and Gilbert Song. Bugs: MESOS-8847

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review203351 --- Patch looks great! Reviews applied: [67185] Passed command:

Re: Review Request 67153: Enforced that `allowed_devices` entries must have a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67153/#review203350 --- PASS: Mesos patch 67153 was successfully built and tested.

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review203346 --- PASS: Mesos patch 67185 was successfully built and tested.

Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/ --- Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao Li.

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

> On May 17, 2018, 11:12 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Line 154 (original), 154 (patched) > > > > > > Do we want to actively disallow passing in lvalue `request`s

Re: Review Request 67155: Renamed `GRPC_RPC` and adapted the new gRPC async API.

> On May 17, 2018, 11:12 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Line 132 (original), 159 (patched) > > > > > > Do we want to actively disallow passing in lvalue `method`s

Re: Review Request 67055: Updated cpplint to be compatible with Python 3.

> On May 16, 2018, 7:08 p.m., Eric Chung wrote: > > > > Benjamin Bannier wrote: > I don't believe that requiring additional dependencies for these very > basic tools is a good idea, as it would add another hurdle to getting started > with contributing to Mesos (the situation is completely

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

> On May 17, 2018, 11:12 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 188 (patched) > > > > > > Why do we `move` here? It seems both not needed to me as `shared_ptr`'s >

Re: Review Request 67055: Updated cpplint to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67055/#review203326 --- Ship it! Ship It! - Benjamin Bannier On May 16, 2018, 4:29

Re: Review Request 67055: Updated cpplint to be compatible with Python 3.

> On May 16, 2018, 7:08 p.m., Eric Chung wrote: > > I don't believe that requiring additional dependencies for these very basic tools is a good idea, as it would add another hurdle to getting started with contributing to Mesos (the situation is completely different for tools configuring

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203323 --- 3rdparty/libprocess/include/process/grpc.hpp Line 154

Re: Review Request 67158: Updated the CSI client to use the new libprocess gRPC interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67158/#review203322 --- Fix it, then Ship it! src/csi/client.cpp Lines 31-38

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203317 --- Fix it, then Ship it!

Re: Review Request 67156: Renamed `grpc::Channel` to `grpc::client::Connection`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67156/#review203320 --- Fix it, then Ship it!

Re: Review Request 67155: Renamed `GRPC_RPC` and adapted the new gRPC async API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67155/#review203324 --- Fix it, then Ship it!

Re: Review Request 67164: Supported custom error types for `Try` in `AssertSome`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67164/#review203314 --- Thanks for tackling this. Could you link MESOS-7220? We should