Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 19, 2018, 4:42 a.m.) Review request for mesos and Andrew

Re: Review Request 67228: Added allocator benchmark test for various simulations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67228/#review203470 --- PASS: Mesos patch 67228 was successfully built and tested.

Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/#review203469 --- PASS: Mesos patch 67224 was successfully built and tested.

Re: Review Request 67189: Windows: Removed guards now that `os::shell` exists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67189/#review203468 --- PASS: Mesos patch 67189 was successfully built and tested.

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203467 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/#review203466 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67228: Added allocator benchmark test for various simulations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67228/ --- Review request for mesos, Benjamin Mahler, Greg Mann, Kapil Arya, and Vinod

Review Request 67226: Renamed tests/allocator.hpp to tests/mock_allocator.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67226/ --- Review request for mesos, Benjamin Mahler, Greg Mann, Kapil Arya, and Vinod

Review Request 67227: Extracted allocator test fixture into header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67227/ --- Review request for mesos, Benjamin Mahler, Greg Mann, Kapil Arya, and Vinod

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/#review203463 --- PASS: Mesos patch 65666 was successfully built and tested.

Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.

Review Request 67223: Used move constructors for making CSI gRPC calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li. Bugs:

Re: Review Request 67188: Windows: Implemented `os::shell` and enabled tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67188/ --- (Updated May 18, 2018, 4:12 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 18, 2018, 10:48 p.m.) Review request for mesos and Andrew

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 18, 2018, 10:46 p.m.) Review request for mesos and Andrew

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 18, 2018, 10:32 p.m.) Review request for mesos and Andrew

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/ --- (Updated May 18, 2018, 10:31 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated May 18, 2018, 10:30 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review203455 --- 3rdparty/stout/include/stout/os/posix/realpath.hpp Lines 68-81

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review203430 --- 3rdparty/stout/include/stout/os/posix/realpath.hpp Lines 51

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/#review203454 --- It's very hard to reason about the correctness of this patch

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203453 --- 3rdparty/stout/include/stout/path.hpp Lines 60 (patched)

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203452 --- 3rdparty/stout/include/stout/internal/windows/inherit.hpp Lines

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/ --- (Updated May 18, 2018, 9:59 p.m.) Review request for mesos and Andrew

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

> On May 17, 2018, 11:21 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > > Lines 34 (patched) > > > > > > What do the second and third arguments represent? Second

Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67217/#review203451 --- PASS: Mesos patch 67217 was successfully built and tested.

Re: Review Request 67188: Windows: Implemented `os::shell` and enabled tests.

> On May 18, 2018, 11:07 a.m., John Kordich wrote: > > 3rdparty/stout/include/stout/os/windows/shell.hpp > > Lines 383 (patched) > > > > > > Do we need to worry about quote escaping here? Oh yeah... we do... Will

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 18, 2018, 5:26 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 669 (original), 618 (patched) > > > > > > Why return `wait()` when the state is DESTROYING, rather than just > >

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203446 --- Patch looks great! Reviews applied: [67164, 67190, 67191, 67154,

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203444 --- Ship it! Haven't take a good at these but they might be

Re: Review Request 67211: Used `*_SOME` macro for checking `Try` values in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67211/#review203443 --- Ship it! Haven't take a good at these but they might be

Re: Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67210/#review203442 --- Fix it, then Ship it! Haven't take a good at these but they

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65666/ --- (Updated May 18, 2018, 6:44 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67217/ --- Review request for mesos, Benjamin Bannier and Benno Evers. Bugs: MESOS-8923

Re: Review Request 67189: Windows: Removed guards now that `os::shell` exists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67189/#review203436 --- Ship it! Ship It! - John Kordich On May 17, 2018, 7:03

Re: Review Request 67188: Windows: Implemented `os::shell` and enabled tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67188/#review203435 --- Fix it, then Ship it!

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

> On March 26, 2018, 2:27 p.m., Jan Schlicht wrote: > > This is missing a test for `operations_pending`. You could wait with a > > `DROP_PROTOBUF(UpdateOperationStatusMessage)` after applying an operation, > > then check that `operations_pending` is "1", then (manually) send the > >

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/ --- (Updated May 18, 2018, 5:34 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review203428 --- src/slave/containerizer/composing.cpp Line 669 (original), 618

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 15, 2018, 11:05 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 361 (original), 360-365 (patched) > > > > > > Moving our previous discussion from

Re: Review Request 67201: Whitelist handles that can be inherited by a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67201/#review203432 --- Patch looks great! Reviews applied: [67201] Passed command:

Re: Review Request 67208: Windows: Updated information on docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67208/#review203429 --- docs/health-checks.md Lines 565-581 (patched)

Re: Review Request 67207: Windows: Changed health check image to be an environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67207/#review203427 --- src/checks/checker_process.cpp Lines 1372-1374 (patched)

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review203392 --- Ship it! 3rdparty/stout/include/stout/path.hpp Lines 87

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203426 --- src/slave/containerizer/mesos/launch.cpp Lines 484-485 (patched)

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203420 --- Patch looks great! Reviews applied: [67195] Passed command:

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203417 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67136: Added a function to get rlimits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203416 --- PASS: Mesos patch 67136 was successfully built and tested.

Re: Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67215/#review203415 --- PASS: Mesos patch 67215 was successfully built and tested.

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203414 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67136: Added a function to get rlimits.

> On May 17, 2018, 11:07 p.m., James Peach wrote: > > src/posix/rlimits.cpp > > Lines 147 (patched) > > > > > > Use `ErrnoError` (also in the rest of the file if you feel like it). Done, also snuck in a fix for the

Re: Review Request 67136: Added a function to get rlimits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/ --- (Updated May 18, 2018, 2:36 p.m.) Review request for mesos, Jie Yu and James

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 15, 2018, 8:28 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1110-1113 (patched) > > > > > > Why not just `O_CLOEXEC` all the handles opened on Linux (so that you

Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67215/ --- Review request for mesos, Jie Yu and James Peach. Repository: mesos

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 18, 2018, 2:36 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 15, 2018, 11:05 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 361 (original), 360-365 (patched) > > > > > > Moving our previous discussion from

Re: Review Request 67194: Windows: Fixed cURL copy command to run only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67194/#review203410 --- Ship it! Ship It! - Benjamin Bannier On May 17, 2018, 11:27

Re: Review Request 67189: Windows: Removed guards now that `os::shell` exists.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67189/#review203409 --- Patch looks great! Reviews applied: [67188, 67189] Passed

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203408 --- PASS: Mesos patch 67212 was successfully built and tested.

Review Request 67212: Used `*_SOME` macro for checking `Try` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos

Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67210/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos

Review Request 67211: Used `*_SOME` macro for checking `Try` values in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67211/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos

Re: Review Request 67208: Windows: Updated information on docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67208/#review203406 --- PASS: Mesos patch 67208 was successfully built and tested.

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/#review203404 --- Patch looks great! Reviews applied: [66882, 66819, 66820, 66822,

Review Request 67208: Windows: Updated information on docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67208/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston

Review Request 67207: Windows: Changed health check image to be an environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67207/ --- Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston

Re: Review Request 67164: Supported custom error types for `Try` in `AssertSome`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67164/#review203401 --- Ship it! Ship It! - Benjamin Bannier On May 17, 2018, 8:10