Review Request 67377: White list fds that child processes can inherit in mesos containerizer.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67377/
---

Review request for mesos.


Repository: mesos


Description
---

White list fds that child processes can inherit in mesos containerizer.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
eac1d16f2388385fec04ff8f013ce0ebf4e97f0f 
  src/slave/containerizer/mesos/launcher.hpp 
f69d934d2e1a129e10df8c7f5c78723e832adc7d 
  src/slave/containerizer/mesos/launcher.cpp 
2fe47d368cb82a46328e1f636baa836272db244c 
  src/slave/containerizer/mesos/linux_launcher.hpp 
0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 
  src/slave/containerizer/mesos/linux_launcher.cpp 
80e444501e429c1e1ae354abcd51f86430316ada 
  src/tests/containerizer/launcher.hpp a8e436f164b67d937ebcff35e084d3ca755c003c 
  src/tests/containerizer/launcher.cpp a92d9890f0931425d69ef8ce0896d081b8722079 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
01f2b38cfa67b144298c361e92170322864ac201 


Diff: https://reviews.apache.org/r/67377/diff/1/


Testing
---


Thanks,

Radhika Jandhyala

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67255/
---

(Updated May 30, 2018, 3:01 a.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Refactored to use the `RPC` enum and have a simpler wrapper in SLRP.


Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943


Repository: mesos


Description (updated)
---

For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled`

To add these per-CSI-call metrics, each method in `csi::v0::Client`,
e.g., `csi::v0::Client::Probe`, is changed to
`csi::v0::Client::call`, to make RPC calls based on the RPC enum
value. A `call` helper function in SLRP is also added to intercept CSI
calls and update the corresponding metrics.


Diffs (updated)
-

  src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809 
  src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9 
  src/resource_provider/storage/provider.cpp 
63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 
  src/tests/csi_client_tests.cpp d5993d617056e86ae5a1224258cc6e0741466166 


Diff: https://reviews.apache.org/r/67255/diff/8/

Changes: https://reviews.apache.org/r/67255/diff/7-8/


Testing
---

sudo make check

A unit test for the metrics will be introduced in the next patch.


Thanks,

Chun-Hung Hsiao

Review Request 67375: Added the `RPC` enum and `RPCTraits` helper.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67375/
---

Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.


Bugs: MESOS-8943
https://issues.apache.org/jira/browse/MESOS-8943


Repository: mesos


Description
---

To make it easy to enumerate all types of CSI RPC calls, the `RPC` enum
is introduced. The `RPCTraits` helper class can be used to determine the
request and response type of a particular RPC.


Diffs
-

  src/CMakeLists.txt f86884de2beb946c8bfc2bb8260e09a9c98ce625 
  src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 
  src/csi/rpc.hpp PRE-CREATION 
  src/csi/rpc.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67375/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65666/
---

(Updated May 30, 2018, 2:55 a.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Rebased.


Bugs: MESOS-8383
https://issues.apache.org/jira/browse/MESOS-8383


Repository: mesos


Description
---

This patch adds the `ROOT_OperationStateMetrics` test that issues a
`CREATE_VOLUME` followed by two `DESTROY_VOLUME`s. The first one will
fail due to an out-of-band deletion of the actual volume, and the second
one will fail due to modifying the resource version.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
04a75fc4d53d1b7211e64755097b06b1e68cc3b3 


Diff: https://reviews.apache.org/r/65666/diff/7/

Changes: https://reviews.apache.org/r/65666/diff/6-7/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67224/
---

(Updated May 30, 2018, 2:56 a.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Rebased.


Repository: mesos


Description
---

To avoid double counting when the operator aggregates the
`csi_controller_plugin_terminations` and `csi_node_plugin_terminations`,
these two are now merged into `csi_plugin/container_terminations`.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 
  src/tests/storage_local_resource_provider_tests.cpp 
04a75fc4d53d1b7211e64755097b06b1e68cc3b3 


Diff: https://reviews.apache.org/r/67224/diff/4/

Changes: https://reviews.apache.org/r/67224/diff/3-4/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65665: Added operation state metrics in SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65665/
---

(Updated May 30, 2018, 2:55 a.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Addressed Jie's comments.


Bugs: MESOS-8383
https://issues.apache.org/jira/browse/MESOS-8383


Repository: mesos


Description
---

This patch adds `operations_pending`, `operations_finished`,
`operations_failed`, and `operations_dropped` metrics to count the
occurances of these operation states.

Additionally, An error log in `_applyOperation()` is removed because the
error is already logged at the call site.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 


Diff: https://reviews.apache.org/r/65665/diff/12/

Changes: https://reviews.apache.org/r/65665/diff/11-12/


Testing
---

sudo make check
A unit test is added in the next patch in chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 67374: Updated flags to support choosing the random sorter.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67374/#review204029
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67369', '67370', '67371', '67372', '67373', '67374']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67374

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67374/logs/mesos-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


   "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
   (Link target) -> 
 sorter_tests.obj : error LNK2019: unresolved external symbol "public: 
__cdecl mesos::internal::master::allocator::RandomSorter::RandomSorter(void)" 
(??0RandomSorter@allocator@master@internal@mesos@@QEAA@XZ) referenced in 
function "private: virtual void __cdecl 
mesos::internal::tests::CommonSorterTest_BENCHMARK_FullSort_Test::TestBody(void)" 
(?TestBody@?$CommonSorterTest_BENCHMARK_FullSort_Test@VRandomSorter@allocator@master@internal@mesos@@@tests@internal@mesos@@EEAAXXZ)
 [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
 sorter_tests.obj : error LNK2019: unresolved external symbol "public: 
virtual __cdecl 
mesos::internal::master::allocator::RandomSorter::~RandomSorter(void)" 
(??1RandomSorter@allocator@master@intern

Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review204026
---



PASS: Mesos patch 67320 was successfully built and tested.

Reviews applied: `['67320']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67320

- Mesos Reviewbot Windows


On May 28, 2018, 11:25 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67320/
> ---
> 
> (Updated May 28, 2018, 11:25 a.m.)
> 
> 
> Review request for mesos and Zhitao Li.
> 
> 
> Bugs: MESOS-8942
> https://issues.apache.org/jira/browse/MESOS-8942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this patch subscribers to the master operator streaming API
> start receiving task health (check) updates. This allows subscribers
> to maintain more accurate view of the cluster's state, closer to
> what the traditional `state.json` endpoint offers.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67320/diff/2/
> 
> 
> Testing
> ---
> 
> make check on
> * Mac OS 10.13.4
> * various linux distros
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 67374: Updated flags to support choosing the random sorter.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67374/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.


Bugs: MESOS-8936
https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
---

This deprecates `--user_sorter` in favor of `--role_sorter`.

This patch also modifies the `--allocator` default to exclude "DRF"
from the value, while still ensuring the previous default works.

For now, both sorter flags must be set to `drf` or `random`.


Diffs
-

  include/mesos/allocator/allocator.hpp 
e5a5355646c834280008867e89eb258eaefc2f1d 
  src/master/allocator/allocator.cpp e3dd7376b5f05e72d9b9aa895ed3aebc461e4372 
  src/master/constants.hpp b31e5f027b44d371050cea9a4662a4b54127812f 
  src/master/flags.hpp 4715f2bf4eb62808265f3062f93e370faa53e63d 
  src/master/flags.cpp 4ad13752719daf2cfad1f578edffc1f16a101760 
  src/master/main.cpp 3eb1f89cb877fdd84434954ed80e753b1f859338 


Diff: https://reviews.apache.org/r/67374/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 67373: Added typedefs for using the allocator with random sorters.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67373/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.


Bugs: MESOS-8936
https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
955ae3e6a9e3c790fb260311ec4b4ef725a826d3 


Diff: https://reviews.apache.org/r/67373/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 67372: Updated sorter tests to run against multiple sorters where possible.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67372/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.


Bugs: MESOS-8936
https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
---

Several of the sorter tests, including the benchmarks, were agnostic
to the sorter implementation. These have been updated to run for both
`DRFSorter` and `RandomSorter`. The remainder have been updated to
be called DRFSorter tests.


Diffs
-

  src/tests/sorter_tests.cpp da4e0f64a565af1d9458ff256ae0eafddd0a6b68 


Diff: https://reviews.apache.org/r/67372/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 67371: Introduced a random sorter as an alternative to the DRF sorter.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67371/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.


Bugs: MESOS-8936
https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
---

This sorter returns a weighted random shuffling of its clients
upon each `sort()` request.

This implementation is a copy of the `DRFSorter` with share
calculation logic (including the `dirty` bit) removed and an
adjusted `sort()` implementation. Work needs to be done to
reduce the amount of duplicated logic needed across sorter
implementations, but it is left unaddressed here.


Diffs
-

  src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 
  src/master/allocator/sorter/random/sorter.hpp PRE-CREATION 
  src/master/allocator/sorter/random/sorter.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67371/diff/1/


Testing
---

Unit tests added in subsequent patch.


Thanks,

Benjamin Mahler

Review Request 67370: Added a test for weighted shuffling.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67370/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu.


Bugs: MESOS-8936
https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/sorter_tests.cpp da4e0f64a565af1d9458ff256ae0eafddd0a6b68 


Diff: https://reviews.apache.org/r/67370/diff/1/


Testing
---


Thanks,

Benjamin Mahler

Review Request 67369: Introduced a weighted shuffle algorithm implementation.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67369/
---

Review request for mesos, Gaston Kleiman, Greg Mann, and meng han.


Bugs: MESOS-8936
https://issues.apache.org/jira/browse/MESOS-8936


Repository: mesos


Description
---

This will be used by the random sorter in order to support weights.


Diffs
-

  src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 
  src/master/allocator/sorter/random/utils.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67369/diff/1/


Testing
---

Test added in subsequent patch.


Thanks,

Benjamin Mahler

Re: Review Request 67335: Added `windows/cpu` and `windows/mem` isolators into `agent.md`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67335/#review204025
---


Ship it!




Ship It!

- Gilbert Song


On May 28, 2018, 7:59 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67335/
> ---
> 
> (Updated May 28, 2018, 7:59 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `windows/cpu` and `windows/mem` isolators into `agent.md`.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md af0c0405da54bad748dcf4de1af0d1cad2dd4661 
> 
> 
> Diff: https://reviews.apache.org/r/67335/diff/1/
> 
> 
> Testing
> ---
> 
> Not a code change.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67363: Switched test devices for the `linux/devices` isolator tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/#review204024
---



Patch looks great!

Reviews applied: [67362, 67363]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 29, 2018, 1:36 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67363/
> ---
> 
> (Updated May 29, 2018, 1:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `cpuid` device is not always available when running tests
> in a VM, so switch to `/dev/net/tun`. For the purposes of this
> test, is doesn't matter what the device is as long as it is
> in a subdirectory.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp 
> efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 
> 
> 
> Diff: https://reviews.apache.org/r/67363/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67320: Sent task (health) check updates over the operator streaming API.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review204023
---


Ship it!




Ship It!

- Zhitao Li


On May 28, 2018, 4:25 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67320/
> ---
> 
> (Updated May 28, 2018, 4:25 a.m.)
> 
> 
> Review request for mesos and Zhitao Li.
> 
> 
> Bugs: MESOS-8942
> https://issues.apache.org/jira/browse/MESOS-8942
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With this patch subscribers to the master operator streaming API
> start receiving task health (check) updates. This allows subscribers
> to maintain more accurate view of the cluster's state, closer to
> what the traditional `state.json` endpoint offers.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67320/diff/2/
> 
> 
> Testing
> ---
> 
> make check on
> * Mac OS 10.13.4
> * various linux distros
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204021
---



PASS: Mesos patch 67365 was successfully built and tested.

Reviews applied: `['67365']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67365

- Mesos Reviewbot Windows


On May 29, 2018, 3:46 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> ---
> 
> (Updated May 29, 2018, 3:46 p.m.)
> 
> 
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added MESOS-8340 to the 1.7.x CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061 
>   docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d 
> 
> 
> Diff: https://reviews.apache.org/r/67365/diff/1/
> 
> 
> Testing
> ---
> 
> Manual inspection of the dev website.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/
---

Review request for mesos, Xudong Ni and Jiang Yan Xu.


Bugs: MESOS-8340
https://issues.apache.org/jira/browse/MESOS-8340


Repository: mesos


Description
---

Added MESOS-8340 to the 1.7.x CHANGELOG.


Diffs
-

  CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061 
  docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d 


Diff: https://reviews.apache.org/r/67365/diff/1/


Testing
---

Manual inspection of the dev website.


Thanks,

James Peach

Re: Review Request 67363: Switched test devices for the `linux/devices` isolator tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/#review204019
---



PASS: Mesos patch 67363 was successfully built and tested.

Reviews applied: `['67362', '67363']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67363

- Mesos Reviewbot Windows


On May 29, 2018, 8:36 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67363/
> ---
> 
> (Updated May 29, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `cpuid` device is not always available when running tests
> in a VM, so switch to `/dev/net/tun`. For the purposes of this
> test, is doesn't matter what the device is as long as it is
> in a subdirectory.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp 
> efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 
> 
> 
> Diff: https://reviews.apache.org/r/67363/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67360: Added link targets to master and agent flags.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67360/#review204016
---


Ship it!




Ship It!

- Jie Yu


On May 29, 2018, 5:46 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67360/
> ---
> 
> (Updated May 29, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link targets for the master and agent flag reference. This pattern
> should be maintained so that documentation authors can link to flags in
> a standard way.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md af0c0405da54bad748dcf4de1af0d1cad2dd4661 
>   docs/configuration/master-and-agent.md 
> df1868161a683a9df4f8afa2647ddfe5d224987f 
>   docs/configuration/master.md 6f55ad9100ac920c7d630414a9f1ff2720a505ef 
> 
> 
> Diff: https://reviews.apache.org/r/67360/diff/1/
> 
> 
> Testing
> ---
> 
> Manual inspection of the generated site.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67362: Updated `linux/devices` isolator tests for compiler compatibility.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67362/#review204013
---



PASS: Mesos patch 67362 was successfully built and tested.

Reviews applied: `['67362']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67362

- Mesos Reviewbot Windows


On May 29, 2018, 8:20 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67362/
> ---
> 
> (Updated May 29, 2018, 8:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `linux/devices` isolator tests fail to build on on
> Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4)
> 4.8.4` due to what seems to me a compiler bug, possibly
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824.
> 
> Work around any compiler issues by defining the test cases
> in a separate vector so that the copmiler doesn't have any
> raw strings in the macro expansion.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp 
> efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 
> 
> 
> Diff: https://reviews.apache.org/r/67362/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67363: Switched test devices for the `linux/devices` isolator tests.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/#review204012
---


Ship it!




Ship It!

- Jie Yu


On May 29, 2018, 8:36 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67363/
> ---
> 
> (Updated May 29, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `cpuid` device is not always available when running tests
> in a VM, so switch to `/dev/net/tun`. For the purposes of this
> test, is doesn't matter what the device is as long as it is
> in a subdirectory.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp 
> efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 
> 
> 
> Diff: https://reviews.apache.org/r/67363/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67362: Updated `linux/devices` isolator tests for compiler compatibility.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67362/#review204011
---


Ship it!




Ship It!

- Jie Yu


On May 29, 2018, 8:20 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67362/
> ---
> 
> (Updated May 29, 2018, 8:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `linux/devices` isolator tests fail to build on on
> Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4)
> 4.8.4` due to what seems to me a compiler bug, possibly
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824.
> 
> Work around any compiler issues by defining the test cases
> in a separate vector so that the copmiler doesn't have any
> raw strings in the macro expansion.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_devices_isolator_tests.cpp 
> efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 
> 
> 
> Diff: https://reviews.apache.org/r/67362/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Joseph Wu]

> On May 29, 2018, 1:38 p.m., John Kordich wrote:
> > I'm not sure why review bot is failing for Linux. Will investigate. Seems 
> > to build just fine for me.

You probably need to add any new stout headers to the Makefile(s).  The 
`distcheck` won't pick up headers automatically.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204009
---


On May 24, 2018, 7:13 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 24, 2018, 7:13 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 95359ec84ed631bdd7b4fb5192e03f68cc57ed61 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/6/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204009
---



I'm not sure why review bot is failing for Linux. Will investigate. Seems to 
build just fine for me.

- John Kordich


On May 25, 2018, 2:13 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 25, 2018, 2:13 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 95359ec84ed631bdd7b4fb5192e03f68cc57ed61 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/6/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Review Request 67363: Switched test devices for the `linux/devices` isolator tests.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/
---

Review request for mesos, Alexander Rukletsov and Jie Yu.


Bugs: MESOS-8958
https://issues.apache.org/jira/browse/MESOS-8958


Repository: mesos


Description
---

The `cpuid` device is not always available when running tests
in a VM, so switch to `/dev/net/tun`. For the purposes of this
test, is doesn't matter what the device is as long as it is
in a subdirectory.


Diffs
-

  src/tests/containerizer/linux_devices_isolator_tests.cpp 
efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 


Diff: https://reviews.apache.org/r/67363/diff/1/


Testing
---

sudo make check (Fedora 27)


Thanks,

James Peach

Review Request 67362: Updated `linux/devices` isolator tests for compiler compatibility.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67362/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

The `linux/devices` isolator tests fail to build on on
Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4)
4.8.4` due to what seems to me a compiler bug, possibly
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824.

Work around any compiler issues by defining the test cases
in a separate vector so that the copmiler doesn't have any
raw strings in the macro expansion.


Diffs
-

  src/tests/containerizer/linux_devices_isolator_tests.cpp 
efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 


Diff: https://reviews.apache.org/r/67362/diff/1/


Testing
---

sudo make check (Fedora 27)


Thanks,

James Peach

Re: Review Request 67331: Documented the `linux/devices` isolator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/#review204007
---



PASS: Mesos patch 67331 was successfully built and tested.

Reviews applied: `['67360', '67331']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67331

- Mesos Reviewbot Windows


On May 29, 2018, 5:45 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67331/
> ---
> 
> (Updated May 29, 2018, 5:45 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the `linux/devices` isolator in the Mesos containerizer
> documentation, upgrade guide and CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
>   docs/isolators/linux-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
>   docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 
> 
> 
> Diff: https://reviews.apache.org/r/67331/diff/2/
> 
> 
> Testing
> ---
> 
> Manually build and viewed the website.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/#review204004
---



PASS: Mesos patch 67356 was successfully built and tested.

Reviews applied: `['67354', '67355', '67356']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67356

- Mesos Reviewbot Windows


On May 29, 2018, 2:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67356/
> ---
> 
> (Updated May 29, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
> huang, Ilya Pronin, and James Peach.
> 
> 
> Bugs: MESOS-3475
> https://issues.apache.org/jira/browse/MESOS-3475
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch removes `os::setenv()`, `os::unsetenv()` calls that are
> currently used to implicitly configure both `MesosExecutorDriver` and
> v1 Executor via global environment variables. This change prepares a
> map containing modified environment and passes it to a constructor of
> an executor.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
>   src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67356/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 67360: Added link targets to master and agent flags.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67360/
---

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Repository: mesos


Description
---

Added link targets for the master and agent flag reference. This pattern
should be maintained so that documentation authors can link to flags in
a standard way.


Diffs
-

  docs/configuration/agent.md af0c0405da54bad748dcf4de1af0d1cad2dd4661 
  docs/configuration/master-and-agent.md 
df1868161a683a9df4f8afa2647ddfe5d224987f 
  docs/configuration/master.md 6f55ad9100ac920c7d630414a9f1ff2720a505ef 


Diff: https://reviews.apache.org/r/67360/diff/1/


Testing
---

Manual inspection of the generated site.


Thanks,

James Peach

Re: Review Request 67331: Documented the `linux/devices` isolator.

[James Peach]

> On May 25, 2018, 11:31 p.m., Jie Yu wrote:
> > docs/isolators/linux-devices.md
> > Lines 14 (patched)
> > 
> >
> > Can you add some example of `--allowed_devices`, or provide a link to 
> > the example?

I added a link.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/#review203922
---


On May 25, 2018, 10:11 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67331/
> ---
> 
> (Updated May 25, 2018, 10:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the `linux/devices` isolator in the Mesos containerizer
> documentation, upgrade guide and CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
>   docs/isolators/linux-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
>   docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 
> 
> 
> Diff: https://reviews.apache.org/r/67331/diff/1/
> 
> 
> Testing
> ---
> 
> Manually build and viewed the website.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67331: Documented the `linux/devices` isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67331/
---

(Updated May 29, 2018, 5:45 p.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8792
https://issues.apache.org/jira/browse/MESOS-8792


Repository: mesos


Description
---

Documented the `linux/devices` isolator in the Mesos containerizer
documentation, upgrade guide and CHANGELOG.


Diffs (updated)
-

  CHANGELOG b78915daeddc5126c5db0ada2de1bcd79caf2d6b 
  docs/isolators/linux-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 42a09771000f6fdebc660f7d771e4cc17fd40ded 
  docs/upgrades.md fb6b865af5caa4ec7181842a257a8cf0aefd18f3 


Diff: https://reviews.apache.org/r/67331/diff/2/

Changes: https://reviews.apache.org/r/67331/diff/1-2/


Testing
---

Manually build and viewed the website.


Thanks,

James Peach

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/#review203998
---



PASS: Mesos patch 67358 was successfully built and tested.

Reviews applied: `['67335', '67342', '67343', '67358']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67358

- Mesos Reviewbot Windows


On May 29, 2018, 2:22 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67358/
> ---
> 
> (Updated May 29, 2018, 2:22 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 
> 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67358/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67357: Added constant time comparison of JWT signatures.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67357/#review203996
---



PASS: Mesos patch 67357 was successfully built and tested.

Reviews applied: `['67357']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67357

- Mesos Reviewbot Windows


On May 29, 2018, 7:22 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67357/
> ---
> 
> (Updated May 29, 2018, 7:22 a.m.)
> 
> 
> Review request for Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A vulnerability in our JWT implementation allows an unauthenticated
> remote attacker to execute to execute timing 
> [attacks](https://codahale.com/a-lesson-in-timing-attacks/).
> 
> This patch removes the vulnerability by adding a constant time
> comparison of hashes, where the whole message is visited during
> the comparison instead of returning at the first failure.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/jwt.cpp 4477ddd17dede2b924a47e33942b39244f10316f 
> 
> 
> Diff: https://reviews.apache.org/r/67357/diff/1/
> 
> 
> Testing
> ---
> 
> ```sh
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67274/#review203989
---


Ship it!




Ship It!

- Jie Yu


On May 28, 2018, 3:11 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67274/
> ---
> 
> (Updated May 28, 2018, 3:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and 
> Neil Conway.
> 
> 
> Bugs: MESOS-8945
> https://issues.apache.org/jira/browse/MESOS-8945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Internally values of scalar resources are stored in a fixed point
> representation. This can lead to (expected) precision loss.
> 
> This patch adds resource validation ensuring that values of scalar
> resources are either zero or large enough so that they are still
> represented as non-zero values after conversion to the internal fixed
> point format.
> 
> While this patch should not change valid, intended use cases, it might
> change the behavior for erroneous, already broken framework workflows.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 192d086e60b81c0ae8e26d4120beee2034f63d3e 
>   src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
> 
> 
> Diff: https://reviews.apache.org/r/67274/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67009: Added tests of resource provider registrar recovery.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67009/#review203988
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67009']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67009

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67009/logs/mesos-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zoo

Re: Review Request 67344: Made disk allocatable on their own.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67344/#review203987
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67344']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67344

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67344/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (120 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1039 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (41 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (47 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (89 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (826 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (850 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (733 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (759 ms total)

[--] Global test environment tear-down
[==] 980 tests from 95 test cases ran. (466328 ms total)
[  PASSED  ] 979 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] RoleTest.ImplicitRoleStaticReservation

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67344/logs/mesos-tests-stderr.log):

```
I0529 16:15:00.307246 14216 master.cpp:10843] Updating the state of task 
b653d684-ad2a-4f76-a324-c3103c5d97df of framework 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0529 16:15:00.308220  8676 slave.cpp:3935] Shutting down framework 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf-
I0529 16:15:00.308220  8676 slave.cpp:6656] Shutting down executor 
'b653d684-ad2a-4f76-a324-c3103c5d97df' of framework 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf- at executor(1)@192.10.1.5:51588
I0529 16:15:00.309227  8676 slave.cpp:929] Agent I0529 16:15:00.135238 15052 
exec.cpp:162] Version: 1.7.0
I0529 16:15:00.162236 15632 exec.cpp:236] Executor registered on agent 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf-S0
I0529 16:15:00.166225  9996 executor.cpp:178] Received SUBSCRIBED event
I0529 16:15:00.171244  9996 executor.cpp:182] Subscribed executor on 
windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0529 16:15:00.171244  9996 executor.cpp:178] Received LAUNCH event
I0529 16:15:00.176244  9996 executor.cpp:665] Starting task 
b653d684-ad2a-4f76-a324-c3103c5d97df
I0529 16:15:00.261247  9996 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0529 16:15:00.280213  9996 executor.cpp:678] Forked command at 2040
I0529 16:15:00.309227 15944 exec.cpp:445] Executor asked to shutdown
I0529 16:15:00.310227 11812 executor.cpp:178] Received SHUTDOWN event
I0529 16:15:00.310227 11812 executor.cpp:781] Shutting down
I0529 16:15:00.310227 11812 executor.cpp:894] Sending SIGTERM to process tree 
at pid 204terminating
W0529 16:15:00.310227  8676 slave.cpp:3931] Ignoring shutdown framework 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf- because it is terminating
I0529 16:15:00.310227 14216 master.cpp:10942] Removing task 
b653d684-ad2a-4f76-a324-c3103c5d97df with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework bc0aa997-0e1c-4231-8b20-fec9a8ce3daf- on 
agent bc0aa997-0e1c-4231-8b20-fec9a8ce3daf-S0 at slave(447)@192.10.1.5:51567 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0529 16:15:00.313230 14216 master.cpp:1293] Agent 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf-S0 at slave(447)@192.10.1.5:51567 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0529 16:15:00.313230 14216 master.cpp:3303] Disconnecting agent 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf-S0 at slave(447)@192.10.1.5:51567 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0529 16:15:00.313230 14216 master.cpp:3322] Deactivating agent 
bc0aa997-0e1c-4231-8b20-fec9a8ce3daf-S0 at slave(447)@192.10.1.5:51567 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0529 16:15:00.314246 14272 hierarchical.cpp:344] Removed fram

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67274/#review203986
---



PASS: Mesos patch 67274 was successfully built and tested.

Reviews applied: `['67274']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274

- Mesos Reviewbot Windows


On May 28, 2018, 3:11 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67274/
> ---
> 
> (Updated May 28, 2018, 3:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and 
> Neil Conway.
> 
> 
> Bugs: MESOS-8945
> https://issues.apache.org/jira/browse/MESOS-8945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Internally values of scalar resources are stored in a fixed point
> representation. This can lead to (expected) precision loss.
> 
> This patch adds resource validation ensuring that values of scalar
> resources are either zero or large enough so that they are still
> represented as non-zero values after conversion to the internal fixed
> point format.
> 
> While this patch should not change valid, intended use cases, it might
> change the behavior for erroneous, already broken framework workflows.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 192d086e60b81c0ae8e26d4120beee2034f63d3e 
>   src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
> 
> 
> Diff: https://reviews.apache.org/r/67274/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review203982
---



PASS: Mesos patch 67343 was successfully built and tested.

Reviews applied: `['67335', '67342', '67343']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67343

- Mesos Reviewbot Windows


On May 29, 2018, 2:21 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> ---
> 
> (Updated May 29, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When `cgroups/*` is specified in the agent flag `--isolation`, we will
> automatically load all the local enabled cgroups subsystems in the
> cgroups isolator with one exception: the `perf_event` subsystem, we
> will only automatically load it when the agent flag `--perf_events` is
> specified, otherwise it will be skipped.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 93197b05eb837d02c6c113264f20a33d6ed92d7f 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d663a5770418b7ffe2b3af50b9181ecde183c67 
> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67358/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
---

(Updated May 29, 2018, 10:21 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

When `cgroups/*` is specified in the agent flag `--isolation`, we will
automatically load all the local enabled cgroups subsystems in the
cgroups isolator with one exception: the `perf_event` subsystem, we
will only automatically load it when the agent flag `--perf_events` is
specified, otherwise it will be skipped.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
93197b05eb837d02c6c113264f20a33d6ed92d7f 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d663a5770418b7ffe2b3af50b9181ecde183c67 


Diff: https://reviews.apache.org/r/67343/diff/2/

Changes: https://reviews.apache.org/r/67343/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Review Request 67357: Added constant time comparison of JWT signatures.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67357/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

A vulnerability in our JWT implementation allows an unauthenticated
remote attacker to execute to execute timing 
[attacks](https://codahale.com/a-lesson-in-timing-attacks/).

This patch removes the vulnerability by adding a constant time
comparison of hashes, where the whole message is visited during
the comparison instead of returning at the first failure.


Diffs
-

  3rdparty/libprocess/src/jwt.cpp 4477ddd17dede2b924a47e33942b39244f10316f 


Diff: https://reviews.apache.org/r/67357/diff/1/


Testing
---

```sh
make check
```


Thanks,

Alexander Rojas

Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/
---

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
huang, Ilya Pronin, and James Peach.


Bugs: MESOS-3475
https://issues.apache.org/jira/browse/MESOS-3475


Repository: mesos


Description
---

This patch removes `os::setenv()`, `os::unsetenv()` calls that are
currently used to implicitly configure both `MesosExecutorDriver` and
v1 Executor via global environment variables. This change prepares a
map containing modified environment and passes it to a constructor of
an executor.


Diffs
-

  src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
  src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 


Diff: https://reviews.apache.org/r/67356/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik

Review Request 67355: Removed `os::getenv()` calls from `MesosProcess`.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67355/
---

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
huang, Ilya Pronin, and James Peach.


Bugs: MESOS-3475
https://issues.apache.org/jira/browse/MESOS-3475


Repository: mesos


Description
---

This patch adds overloaded constructor for `v1::executor::Mesos` class
that accepts `environment` parameter that is passed over to
`MesosProcess` constructor. This change is needed to get rid of
`os::getenv()` calls, so that v1 Executor can be used in tests that
require thread safety.


Diffs
-

  include/mesos/v1/executor.hpp ca48f29483f3f5caeb070f33d009ab89c9f4829b 
  src/executor/executor.cpp 5e95f999535a81bf6873144a83d520897b3cdc8a 
  src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 


Diff: https://reviews.apache.org/r/67355/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik

Review Request 67354: Removed `os::getenv()` calls from `MesosExecutorDriver`.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67354/
---

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent 
huang, Ilya Pronin, and James Peach.


Bugs: MESOS-3475
https://issues.apache.org/jira/browse/MESOS-3475


Repository: mesos


Description
---

This patch adds overloaded constructor for `MesosExecutorDriver` that
accepts `environment` parameter and stores it in the class variable.
This new constructor is needed to get rid of `os::getenv()` calls,
so that `MesosExecutorDriver` can be used in tests that require
thread safety.


Diffs
-

  include/mesos/executor.hpp d14c0369f6731100d27092142b56f108f8881003 
  src/exec/exec.cpp 65a671d7ce83a51087d290ba039d18deba6313c2 


Diff: https://reviews.apache.org/r/67354/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 67270: Fixed compilation issues in libprocess example.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/
---

(Updated May 29, 2018, 1:46 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description (updated)
---

* Added the mandatory help string argument to calls
  to 'route()', failing compilation.

* The response returned from the '/vars' endpoint had
  its 'type' field set to 'NONE', causing indefinite
  hanging when trying to access the endpoint. Switched
  to a constructor for OK that implicitly sets that field.

* Removed a stray pid variable in main.

* Added http:: namespace to disambiguate calls to 'post()'.

* Added a name to the example process.

* Commented out example code that commits instant
  self-termination by default.


Diffs (updated)
-

  3rdparty/libprocess/examples/example.cpp 
a97665ee6b75c5b31397b5a10002fa23a7fe370a 


Diff: https://reviews.apache.org/r/67270/diff/5/

Changes: https://reviews.apache.org/r/67270/diff/4-5/


Testing
---

Compiled the `example.cpp` file.


Thanks,

Benno Evers

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67212/#review203978
---



PASS: Mesos patch 67212 was successfully built and tested.

Reviews applied: `['67210', '67211', '67212']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67212

- Mesos Reviewbot Windows


On May 29, 2018, 8:13 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67212/
> ---
> 
> (Updated May 29, 2018, 8:13 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `*_SOME` macro for checking `Try` values.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 0692e3148829738c736b47446fdebe013211b930 
>   src/tests/protobuf_io_tests.cpp 91c1806291fe5cd6b8ac0fcd864dce73de301fd8 
>   src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
>   src/tests/secret_generator_tests.cpp 
> 7fd649b2bb403d943955b5df1299c5c58b2c7582 
>   src/tests/state_tests.cpp 1a2bfb870da3e9044ee39da843da489fbe65586a 
>   src/tests/zookeeper_tests.cpp f2f9858499f1093fb05b89d36d0e2d6711222e9f 
>   src/tests/zookeeper_url_tests.cpp 498606a70e5e1ef726ea08fbb0d6775c7e14ec31 
> 
> 
> Diff: https://reviews.apache.org/r/67212/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67270: Fixed compilation issues in libprocess example.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203974
---


Ship it!




Ship It!

- Benjamin Bannier


On May 24, 2018, 3:33 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> ---
> 
> (Updated May 24, 2018, 3:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Added the mandatory help string argument to calls
>   to 'route()', failing compilation.
> 
> * The response returned from the '/vars' endpoint had
>   its 'type' field set to 'NONE', causing indefinite
>   hanging when trying to access the endpoint. Switched
>   to a constructor for OK that implicitly sets that field.
> 
> * Removed a stray pid variable in main.
> 
> * Added http:: namespace to disambiguate calls to 'post()'.
> 
> * Commented out example code that commits instant
>   self-termination by default.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/examples/example.cpp 
> 8c507aefa050543dfa6184626c494918c96d35e7 
> 
> 
> Diff: https://reviews.apache.org/r/67270/diff/4/
> 
> 
> Testing
> ---
> 
> Compiled the `example.cpp` file.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67270: Fixed compilation issues in libprocess example.

[Benjamin Bannier]

> On May 25, 2018, 5:37 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/examples/example.cpp
> > Lines 128-129 (original), 120-121 (patched)
> > 
> >
> > Without this `main` does nothing useful anymore, let's leave this in 
> > for now.
> 
> Benno Evers wrote:
> On the contrary, it runs a working HTTP server. If it's not commented 
> out, `main` immediately commits suicide, which imho hardly qualifies as 
> "doing something useful".

Makes sense.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67270/#review203886
---


On May 24, 2018, 3:33 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67270/
> ---
> 
> (Updated May 24, 2018, 3:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Added the mandatory help string argument to calls
>   to 'route()', failing compilation.
> 
> * The response returned from the '/vars' endpoint had
>   its 'type' field set to 'NONE', causing indefinite
>   hanging when trying to access the endpoint. Switched
>   to a constructor for OK that implicitly sets that field.
> 
> * Removed a stray pid variable in main.
> 
> * Added http:: namespace to disambiguate calls to 'post()'.
> 
> * Commented out example code that commits instant
>   self-termination by default.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/examples/example.cpp 
> 8c507aefa050543dfa6184626c494918c96d35e7 
> 
> 
> Diff: https://reviews.apache.org/r/67270/diff/4/
> 
> 
> Testing
> ---
> 
> Compiled the `example.cpp` file.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67340: Fixed python3/mesos-style.py type error.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67340/#review203972
---


Ship it!




Ship It!

- Alexander Rukletsov


On May 28, 2018, 1:16 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67340/
> ---
> 
> (Updated May 28, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8954
> https://issues.apache.org/jira/browse/MESOS-8954
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The main challenge when switching from Python 2 to Python 3 is
> to handle the strings, as many of them are now byte strings. I
> have checked the other uses of `sys.stderr.write` while working
> on this commit to check that it was the last issue of that type
> in python3/mesos-style.py.
> 
> 
> Diffs
> -
> 
>   support/python3/mesos-style.py c0e918c611020a4dbba4c65bd4ac849a716f63e2 
> 
> 
> Diff: https://reviews.apache.org/r/67340/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67009: Added tests of resource provider registrar recovery.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67009/
---

(Updated May 29, 2018, 10:54 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Fixed issues raised by Chun.


Bugs: MESOS-8837
https://issues.apache.org/jira/browse/MESOS-8837


Repository: mesos


Description
---

Added tests of resource provider registrar recovery.


Diffs (updated)
-

  src/tests/resource_provider_manager_tests.cpp 
77a59e4d285b455154990f9b5cf80525f26583c9 


Diff: https://reviews.apache.org/r/67009/diff/2/

Changes: https://reviews.apache.org/r/67009/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 67009: Added tests of resource provider registrar recovery.

[Benjamin Bannier]

> On May 26, 2018, 12:37 a.m., Chun-Hung Hsiao wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 846 (patched)
> > 
> >
> > Since the purpose of this test and the one below is the registrar, not 
> > the underlying storage, it seems to me that the in-memory store is 
> > sufficient for this test (there is no need to create a new 
> > `mesos::state::Storage` instance), and also makes this test rely on fewer 
> > prerequisits. WDYT?

On construction the `Registrar` takes ownership of the given `storage`; this 
means we cannot meaningfully refer to the `storage` after that anymore. With 
that, it seems to only feasible way to recover the state from that storage 
afterwards would require reading from the file system which is why I choose a 
`LevelDBStorage` instead of e.g., a `InMemoryStorage`.

Dropping.


> On May 26, 2018, 12:37 a.m., Chun-Hung Hsiao wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 847 (patched)
> > 
> >
> > Is there a reason why `os::getcwd()` is used here instead of 
> > `sandbox.get()`? Ditto below.

Not really, other than ignorance on that value. Thanks for pointing this out, 
adjusted now.


> On May 26, 2018, 12:37 a.m., Chun-Hung Hsiao wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Line 844 (original), 853 (patched)
> > 
> >
> > Could you briefly explain why you're advocating this pattern? I 
> > personally prefer the original pattern. Ditto below.

We want to perform some checks on the recovered registry below, so we need to 
bind it to a name. I added a check here as well now.

Dropping.


> On May 26, 2018, 12:37 a.m., Chun-Hung Hsiao wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 883-884 (patched)
> > 
> >
> > We could do `ASSERT_SOME_NE(nullptr, registrar);` here and below.

Great idea. I ultimately went with `ASSERT_SOME_NE(Owned(nullptr), 
registrar)`.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67009/#review203911
---


On May 29, 2018, 10:54 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67009/
> ---
> 
> (Updated May 29, 2018, 10:54 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-8837
> https://issues.apache.org/jira/browse/MESOS-8837
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests of resource provider registrar recovery.
> 
> 
> Diffs
> -
> 
>   src/tests/resource_provider_manager_tests.cpp 
> 77a59e4d285b455154990f9b5cf80525f26583c9 
> 
> 
> Diff: https://reviews.apache.org/r/67009/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67211: Used `*_SOME` macro for checking `Try` values in libprocess.

[Benjamin Bannier]

> On May 18, 2018, 8:57 p.m., Chun-Hung Hsiao wrote:
> > Haven't take a good at these but they might be candidates to use the new 
> > macros:
> > ```
> > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' 
> > 3rdparty/libprocess -r
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:  
> > EXPECT_TRUE(error.isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:  
> > EXPECT_TRUE(error.isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:  
> > ASSERT_TRUE(t->isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:  
> > EXPECT_TRUE(error.isError());
> > 3rdparty/libprocess/src/tests/state_machine_tests.cpp:  
> > EXPECT_TRUE(error.isError());
> > ```
> > We could fix them in a follow-up patch.

I have updated this patch to fix some of these as well. Note in general the fix 
here does not apply to some checks we perform on `Result` values of the form

(EXPECT\|ASSERT)_TRUE(.*isError)


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67211/#review203443
---


On May 29, 2018, 10:13 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67211/
> ---
> 
> (Updated May 29, 2018, 10:13 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `*_SOME` macro for checking `Try` values in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 4661f2e332835b309b45d3a469324cad0f9684c1 
>   3rdparty/libprocess/src/tests/jwt_tests.cpp 
> f4b2c7cf3f685ae2730789db3a330ad0bc3b8d1b 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 24fe2208b3100faf0248f65594819014105a9494 
>   3rdparty/libprocess/src/tests/state_machine_tests.cpp 
> 60e6b33718201bb3c1e7459859110bbc6352a2ff 
> 
> 
> Diff: https://reviews.apache.org/r/67211/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

[Benjamin Bannier]

> On May 18, 2018, 8:58 p.m., Chun-Hung Hsiao wrote:
> > Haven't take a good at these but they might be candidates to use the new 
> > macros:
> > ```
> > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' src -r
> > src/tests/containerizer/cgroups_isolator_tests.cpp:  
> > ASSERT_FALSE(check.isError());
> > src/tests/containerizer/cgroups_tests.cpp:
> > ASSERT_FALSE(hierarchy.isError());
> > src/tests/containerizer/cgroups_tests.cpp:  
> > EXPECT_FALSE(cpuHierarchy.isError());
> > src/tests/containerizer/cgroups_tests.cpp:  
> > EXPECT_FALSE(memHierarchy.isError());
> > src/tests/containerizer/routing_tests.cpp:  EXPECT_FALSE(eth0.isError());
> > src/tests/containerizer/routing_tests.cpp:  EXPECT_FALSE(lo.isError());
> > src/tests/containerizer/routing_tests.cpp:  EXPECT_FALSE(gateway.isError());
> > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError());
> > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError());
> > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError());
> > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError());
> > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError());
> > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError());
> > src/tests/mesos.cpp:  ASSERT_FALSE(hierarchy.isError());
> > src/tests/protobuf_io_tests.cpp:  ASSERT_TRUE(read.isNone());
> > src/tests/protobuf_io_tests.cpp:  ASSERT_TRUE(read.isNone());
> > src/tests/resources_tests.cpp:  EXPECT_TRUE(r.mem().isNone());
> > src/tests/resources_tests.cpp:  EXPECT_TRUE(r.ports().isNone());
> > src/tests/state_tests.cpp:  EXPECT_TRUE(future2->isNone());
> > src/tests/zookeeper_tests.cpp:  ASSERT_TRUE(leader->isNone());
> > src/tests/zookeeper_url_tests.cpp:  
> > EXPECT_TRUE(url->authentication.isNone());
> > src/tests/zookeeper_url_tests.cpp:  
> > EXPECT_FALSE(url->authentication.isNone());
> > src/tests/zookeeper_url_tests.cpp:  
> > EXPECT_FALSE(url->authentication.isNone());
> > src/tests/zookeeper_url_tests.cpp:  
> > EXPECT_FALSE(url->authentication.isNone());
> > src/tests/zookeeper_url_tests.cpp:  
> > EXPECT_FALSE(url->authentication.isNone());
> > src/tests/zookeeper_url_tests.cpp:  
> > EXPECT_FALSE(url->authentication.isNone());
> > ```
> > We could fix them in a follow-up patch.

I have updated this patch to fix some of these as well. Note in general the fix 
here does not apply to some checks we perform on `Result` values of the form

(EXPECT\|ASSERT)_TRUE(.*isError)


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67212/#review203444
---


On May 29, 2018, 10:13 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67212/
> ---
> 
> (Updated May 29, 2018, 10:13 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `*_SOME` macro for checking `Try` values.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 0692e3148829738c736b47446fdebe013211b930 
>   src/tests/protobuf_io_tests.cpp 91c1806291fe5cd6b8ac0fcd864dce73de301fd8 
>   src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
>   src/tests/secret_generator_tests.cpp 
> 7fd649b2bb403d943955b5df1299c5c58b2c7582 
>   src/tests/state_tests.cpp 1a2bfb870da3e9044ee39da843da489fbe65586a 
>   src/tests/zookeeper_tests.cpp f2f9858499f1093fb05b89d36d0e2d6711222e9f 
>   src/tests/zookeeper_url_tests.cpp 498606a70e5e1ef726ea08fbb0d6775c7e14ec31 
> 
> 
> Diff: https://reviews.apache.org/r/67212/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67210/
---

(Updated May 29, 2018, 10:13 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
---

Fixed additional occurrences; tweaking as suggested by Chun.


Repository: mesos


Description
---

Used `*_SOME` macro for checking `Try` values in stout.


Diffs (updated)
-

  3rdparty/stout/tests/none_tests.cpp b6bbb882ca2d61db9d93870895bc076612f26f84 
  3rdparty/stout/tests/os/sendfile_tests.cpp 
2a8568365c88ee7207c38f74599dcd3ba0f73410 


Diff: https://reviews.apache.org/r/67210/diff/2/

Changes: https://reviews.apache.org/r/67210/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

[Benjamin Bannier]

> On May 18, 2018, 8:53 p.m., Chun-Hung Hsiao wrote:
> > Haven't take a good at these but they might be candidates to use the new 
> > macros:
> > ```
> > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' 
> > 3rdparty/stout/ -r
> > ...
> > 3rdparty/stout//tests/ip_tests.cpp:EXPECT_FALSE(network.isError());
> > 3rdparty/stout//tests/mac_tests.cpp:EXPECT_FALSE(mac.isError());
> > 3rdparty/stout//tests/none_tests.cpp:  EXPECT_TRUE(o.isNone());
> > 3rdparty/stout//tests/none_tests.cpp:  EXPECT_TRUE(o.isNone());
> > 3rdparty/stout//tests/none_tests.cpp:  EXPECT_TRUE(o.isNone());
> > 3rdparty/stout//tests/none_tests.cpp:  EXPECT_TRUE(r.isNone());
> > 3rdparty/stout//tests/none_tests.cpp:  EXPECT_TRUE(r.isNone());
> > 3rdparty/stout//tests/none_tests.cpp:  EXPECT_TRUE(r.isNone());
> > 3rdparty/stout//tests/os_tests.cpp:ASSERT_FALSE(process.isError());
> > 3rdparty/stout//tests/os_tests.cpp:ASSERT_FALSE(process.isError());
> > ```
> > We could fix them in a follow-up patch.

I have updated this patch to fix some of these as well. Note in general the fix 
here does not apply to some checks we perform on `Result` values of the form

(EXPECT\|ASSERT)_TRUE(.*isError)


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67210/#review203442
---


On May 29, 2018, 10:13 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67210/
> ---
> 
> (Updated May 29, 2018, 10:13 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `*_SOME` macro for checking `Try` values in stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/none_tests.cpp 
> b6bbb882ca2d61db9d93870895bc076612f26f84 
>   3rdparty/stout/tests/os/sendfile_tests.cpp 
> 2a8568365c88ee7207c38f74599dcd3ba0f73410 
> 
> 
> Diff: https://reviews.apache.org/r/67210/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67212/
---

(Updated May 29, 2018, 10:13 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
---

Fixed additional occurrences.


Repository: mesos


Description
---

Used `*_SOME` macro for checking `Try` values.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp 0692e3148829738c736b47446fdebe013211b930 
  src/tests/protobuf_io_tests.cpp 91c1806291fe5cd6b8ac0fcd864dce73de301fd8 
  src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
  src/tests/secret_generator_tests.cpp 7fd649b2bb403d943955b5df1299c5c58b2c7582 
  src/tests/state_tests.cpp 1a2bfb870da3e9044ee39da843da489fbe65586a 
  src/tests/zookeeper_tests.cpp f2f9858499f1093fb05b89d36d0e2d6711222e9f 
  src/tests/zookeeper_url_tests.cpp 498606a70e5e1ef726ea08fbb0d6775c7e14ec31 


Diff: https://reviews.apache.org/r/67212/diff/2/

Changes: https://reviews.apache.org/r/67212/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 67211: Used `*_SOME` macro for checking `Try` values in libprocess.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67211/
---

(Updated May 29, 2018, 10:13 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
---

Fixed additional occurrences.


Repository: mesos


Description
---

Used `*_SOME` macro for checking `Try` values in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/http_tests.cpp 
4661f2e332835b309b45d3a469324cad0f9684c1 
  3rdparty/libprocess/src/tests/jwt_tests.cpp 
f4b2c7cf3f685ae2730789db3a330ad0bc3b8d1b 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
24fe2208b3100faf0248f65594819014105a9494 
  3rdparty/libprocess/src/tests/state_machine_tests.cpp 
60e6b33718201bb3c1e7459859110bbc6352a2ff 


Diff: https://reviews.apache.org/r/67211/diff/2/

Changes: https://reviews.apache.org/r/67211/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 67348: Changed python3 support check script to print to `stderr`.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67348/#review203962
---


Ship it!




Ship It!

- Armand Grillet


On mai 29, 2018, 7:48 matin, Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67348/
> ---
> 
> (Updated mai 29, 2018, 7:48 matin)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The scripts this might be used in might use `stdout` to report
> results we do not intend to interfere with, e.g.,
> `support/apply-reviews.py` can print commands to execute in dry run
> mode.
> 
> This patch makes the check script print to `stderr` instead of
> `stdout`.
> 
> 
> Diffs
> -
> 
>   support/check-python3.py 08252d8f8c091fe55d814135fe29b53481efec95 
> 
> 
> Diff: https://reviews.apache.org/r/67348/diff/1/
> 
> 
> Testing
> ---
> 
> * could not apply result of `apply-reviews.py --dry-run` withou this patch
> * can apply result after patch
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 67348: Changed python3 support check script to print to `stderr`.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67348/
---

Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.


Repository: mesos


Description
---

The scripts this might be used in might use `stdout` to report
results we do not intend to interfere with, e.g.,
`support/apply-reviews.py` can print commands to execute in dry run
mode.

This patch makes the check script print to `stderr` instead of
`stdout`.


Diffs
-

  support/check-python3.py 08252d8f8c091fe55d814135fe29b53481efec95 


Diff: https://reviews.apache.org/r/67348/diff/1/


Testing
---

* could not apply result of `apply-reviews.py --dry-run` withou this patch
* can apply result after patch


Thanks,

Benjamin Bannier