Re: Review Request 68696: Eliminating an unnecessary copy when devolving a scheduler call.

2018-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68696/#review208540 --- PASS: Mesos patch 68696 was successfully built and tested.

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

2018-09-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/#review208538 --- Almost there! I'm wondering about the casting to `Resource` in

Review Request 68696: Eliminating an unnecessary copy when devolving a scheduler call.

2018-09-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68696/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Review Request 68695: Reduced protobuf copying in evolve.cpp.

2018-09-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68695/ --- Review request for mesos, Greg Mann and Meng Zhu. Repository: mesos

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-11 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208533 --- src/tests/hierarchical_allocator_benchmarks.cpp Lines 350-372

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208530 --- src/tests/hierarchical_allocator_benchmarks.cpp Lines 71-82

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

2018-09-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/#review208536 --- 3rdparty/libprocess/configure.ac Lines 805 (patched)

Re: Review Request 68640: Added version check and bundling of libevent.

2018-09-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/#review208531 --- 3rdparty/Makefile.am Lines 327 (patched)

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

2018-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/#review208535 --- PASS: Mesos patch 68679 was successfully built and tested.

Re: Review Request 68660: Disabled SIGCHLD handling in the libev event loop.

2018-09-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68660/#review208534 --- Ship it! Looks good! We should remove our libev patch file

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

2018-09-11 Thread James Peach
> On Sept. 11, 2018, 11 a.m., Till Toenshoff wrote: > > 3rdparty/stout/tests/os/filesystem_tests.cpp > > Line 817 (original), 817 (patched) > > > > > > According to the BSD manpages, `statvfs` does not have a member

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/#review208526 --- PASS: Mesos patch 68591 was successfully built and tested.

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 11, 2018, 3:22 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
> On Sept. 4, 2018, 7:25 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 278-279 (patched) > > > > > > I feel there are some ambiguities as to which parameters are > >

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
> On Sept. 4, 2018, 7:25 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 143 (patched) > > > > > > Let's add a comment here regarding what this is for, and show an > > example of

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68591/ --- (Updated Sept. 11, 2018, 3:15 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 11, 2018, 3:15 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

2018-09-11 Thread Zhitao Li
> On Sept. 11, 2018, 10:35 a.m., Benno Evers wrote: > > src/slave/slave.cpp > > Lines 1607 (patched) > > > > > > If I understand the slave code correctly, I think this would checkpoint > > the new state every time

Re: Review Request 67022: Refreshed checkpointed SlaveInfo if `--reconfiguration_policy==any`.

2018-09-11 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67022/#review208520 --- Fix it, then Ship it! src/slave/slave.cpp Lines 1607

Re: Review Request 68686: Added Robin Goegge to contributors list.

2018-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68686/#review208519 --- PASS: Mesos patch 68686 was successfully built and tested.

Re: Review Request 68686: Added Robin Goegge to contributors list.

2018-09-11 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68686/#review208518 --- Ship it! Ship It! - Till Toenshoff On Sept. 11, 2018, 3:17

Re: Review Request 68686: Added Robin Goegge to contributors list.

2018-09-11 Thread Robin Gögge
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68686/#review208517 --- Ship it! Ship It! - Robin Gögge On Sept. 11, 2018, 3:17

Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62187/#review208516 --- PASS: Mesos patch 62187 was successfully built and tested.

Review Request 68686: Added Robin Goegge to contributors list.

2018-09-11 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68686/ --- Review request for mesos, Benjamin Bannier and Robin Gögge. Repository: mesos

Re: Review Request 68538: Added Python 3.6 and pip to Docker images.

2018-09-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/#review208514 --- Fix it, then Ship it! LGTM. I'll fix remaining issues before

Re: Review Request 68538: Added Python 3.6 and pip to Docker images.

2018-09-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/#review208512 --- PASS: Mesos patch 68538 was successfully built and tested.

Re: Review Request 68679: Fixed stout `FsTest.Used` test.

2018-09-11 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/#review208511 --- We need to find a different solution...

Re: Review Request 68538: Added Python 3.6 and pip to Docker images.

2018-09-11 Thread Robin Gögge
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68538/ --- (Updated Sept. 11, 2018, 10:25 a.m.) Review request for mesos, Andrew

Re: Review Request 68538: Added Python 3.6 and pip to Docker images.

2018-09-11 Thread Robin Gögge
> On Sept. 10, 2018, 9:07 p.m., Benjamin Bannier wrote: > > support/mesos-build/ubuntu-16.04-arm.dockerfile > > Lines 42 (patched) > > > > > > Is this still needed if we explicitly pull in python36 below? This is