Re: Review Request 70899: Refactored the agent's task-killing code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70899/ --- (Updated June 21, 2019, 11:59 p.m.) Review request for mesos, Benjamin

Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70834/ --- (Updated June 21, 2019, 11:58 p.m.) Review request for mesos, Benjamin

Re: Review Request 70839: Added agent capability for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70839/ --- (Updated June 21, 2019, 11:57 p.m.) Review request for mesos, Benjamin

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 9:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that something

Review Request 70927: Fixed a memory "leak" of filters in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70927/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9852

Review Request 70928: WIP: leak test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70928/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9852

Re: Review Request 70884: Added optional 'host' string member to UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/#review216071 --- 3rdparty/libprocess/src/pid.cpp Lines 74 (patched)

Re: Review Request 70884: Added optional 'host' string member to UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/ --- (Updated June 21, 2019, 10:25 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 70924: Added registry operations for DE/RE-ACTIVATE_AGENT calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70924/#review216070 --- Fix it, then Ship it! src/master/registry_operations.cpp

Re: Review Request 70914: Defined `mapped_type` for `ResourceQuantities` and `ResourceLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70914/#review216068 --- This makes the json serialization pretty implicit, why not just

Re: Review Request 70923: Added a registry operation for the DRAIN_AGENT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70923/#review216065 --- Fix it, then Ship it! src/master/registry_operations.cpp

Re: Review Request 70922: Added master minimum capability for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70922/#review216059 --- Fix it, then Ship it! src/tests/master_tests.cpp Line 5035

Re: Review Request 70925: Exposed the MESOS-9856 bug in revivieOffers() in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70925/#review216064 --- Ship it! Thanks! Usually we would put this test after the fix,

Re: Review Request 70926: Fixed clearing offer filters for unrelated roles by reviveOffers().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70926/#review216063 --- Ship it! Ship It! - Benjamin Mahler On June 21, 2019, 5:38

Re: Review Request 70886: WIP: Override source address for executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70886/#review216060 --- Patch looks great! Reviews applied: [70747, 70748, 70810, 70883,

Review Request 70926: Fixed clearing offer filters for unrelated roles by reviveOffers().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70926/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9856

Review Request 70925: Exposed the MESOS-9856 bug in revivieOffers() in a test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70925/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9856

Re: Review Request 70911: Added master endpoints for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70911/#review216056 --- Fix it, then Ship it! In the description: s/tn operator/an

Re: Review Request 70903: Killed all tasks on the agent when draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70903/#review216058 --- src/slave/slave.cpp Lines 1005-1009 (patched)

Re: Review Request 70911: Added master endpoints for agent draining.

> On June 21, 2019, 3:23 p.m., James DeFelice wrote: > > include/mesos/master/master.proto > > Lines 93 (patched) > > > > > > are these new APIs experimental? if so, they should be labeled as such > > Joseph Wu

Re: Review Request 70910: Added ACLs for agent draining APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70910/#review216052 --- Ship it! - Greg Mann On June 20, 2019, 9 p.m., Joseph Wu

Re: Review Request 70900: Updated an equality operator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70900/#review216054 --- src/common/type_utils.cpp Line 573 (original)

Re: Review Request 70911: Added master endpoints for agent draining.

> On June 21, 2019, 3:22 p.m., James DeFelice wrote: > > is there a related patch to add these new APIs to the operator V1 API > > documentation, along w/ expected response codes from mesos? +1 There should either be a ticket filed or an item added to a google doc that tracks all the pieces

Re: Review Request 70899: Refactored the agent's task-killing code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70899/#review216051 --- Fix it, then Ship it! Refactor looks reasonable. One possible

Re: Review Request 70907: Added recovery of agent drain information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70907/#review216022 --- Fix it, then Ship it! src/slave/state.cpp Lines 210 (patched)

Review Request 70924: Added registry operations for DE/RE-ACTIVATE_AGENT calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70924/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and

Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70834/#review216050 --- src/slave/slave.cpp Lines 752 (patched)

Re: Review Request 70839: Added agent capability for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70839/#review216049 --- Fix it, then Ship it! src/slave/constants.cpp Line 44

Review Request 70923: Added a registry operation for the DRAIN_AGENT call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70923/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and

Re: Review Request 70749: Introduced optional new scheme for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/ --- (Updated June 21, 2019, 3:32 p.m.) Review request for mesos, Alexander

Re: Review Request 70749: Introduced optional new scheme for hostname validation.

> On June 21, 2019, 1:32 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 808 (patched) > > > > > > I know you just moved it, but where do these 100ms come from and how > > could we be

Re: Review Request 70911: Added master endpoints for agent draining.

> On June 21, 2019, 8:23 a.m., James DeFelice wrote: > > include/mesos/master/master.proto > > Lines 93 (patched) > > > > > > are these new APIs experimental? if so, they should be labeled as such By the time the

Re: Review Request 70911: Added master endpoints for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70911/#review216046 --- include/mesos/master/master.proto Lines 93 (patched)

Re: Review Request 70911: Added master endpoints for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70911/#review216045 --- is there a related patch to add these new APIs to the operator V1

Review Request 70922: Added master minimum capability for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70922/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70795/ --- (Updated June 21, 2019, 3:05 p.m.) Review request for mesos, Alexander

Review Request 70921: Add OpenSSL related changes to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70921/ --- Review request for mesos, Joseph Wu and Till Toenshoff. Repository: mesos

Re: Review Request 70748: Changed semantics of libprocess TLS flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/ --- (Updated June 21, 2019, 3:01 p.m.) Review request for mesos, Alexander

Re: Review Request 70748: Changed semantics of some libprocess TLS flags.

> On June 21, 2019, 1:06 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Line 96 (original), 96 (patched) > > > > > > Additional to the updates above, we also need to call this out in the > >

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 2:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that something

Re: Review Request 70911: Added master endpoints for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70911/ --- (Updated June 21, 2019, 6:10 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 70798: Improved `namespaces/ipc` isolator for configurable IPC support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70798/ --- (Updated June 21, 2019, 9:08 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 70907: Added recovery of agent drain information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70907/#review216040 --- Patch looks great! Reviews applied: [70822, 70839, 70834, 70835,

Re: Review Request 70749: Introduced optional new scheme for hostname validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70749/#review215999 --- Fix it, then Ship it! Just saw that I did not yet submit this

Re: Review Request 70795: Updated SSL docs to include new libprocess flag.

> On June 21, 2019, 1:34 a.m., Till Toenshoff wrote: > > docs/ssl.md > > Lines 194 (patched) > > > > > > I wonder if we should already start a deprecation of the `libprocess` > > scheme - that would be: > > -

Re: Review Request 70906: Fixed pid checkpointing for `TestContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70906/ --- (Updated June 21, 2019, 11:59 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 70820: Updated `filesystem/linux` isolator for configurable IPC support.

> On June 21, 2019, 8:27 a.m., Gilbert Song wrote: > > could we consider to do the decouple now? > > Gilbert Song wrote: > probably still need a deprecation cycle :( Yes, and I have added a TODO in mesos.proto for the deprecation cycle. - Qian

Re: Review Request 70844: Implemented `cleanup` method of the `namespaces/ipc` isolator.

> On June 21, 2019, 8:26 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > > Lines 400 (patched) > > > > > > if the shmPath not exists, should we log a warning? No, because

Re: Review Request 70798: Improved `namespaces/ipc` isolator for configurable IPC support.

> On June 21, 2019, 8:24 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp > > Lines 52-54 (patched) > > > > > > consider to return Result for no parent case? What do you mean

Re: Review Request 70919: Replaced the old `struct Quota`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70919/#review216036 --- Patch looks great! Reviews applied: [70914, 70915, 70916, 70917,