45022/diff/
Testing
---
Thanks,
Alex Clemmer
consistency elsewhere in another
comment?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124879
-------
ly generated e-mail. To reply, visit:
https://reviews.apache.org/r/45022/#review124867
---
On March 18, 2016, 7:39 a.m., Alex Clemmer wrote:
>
> ---
> This is an auto
------
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/44084/diff/
Testing
---
Thanks,
Alex Clemmer
7dace7d579c1b18afcf2278f9689b205cf57877f
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/44978/diff/
Testing
---
Thanks,
Alex Clemmer
6a391ff198ab724f689bcef79d4e2e05a786cbc2
Diff: https://reviews.apache.org/r/44082/diff/
Testing
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
9ee233b988c08d953e70345c55bcdd5c2f7c101b
Diff: https://reviews.apache.org/r/44081/diff/
Testing
---
Thanks,
Alex Clemmer
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44081/#review124257
-------
On March 14, 2016, 9:10 p.m., Alex Clemmer wrote:
>
> ---
/3rdparty/stout/include/stout/posix/os.hpp
9ee233b988c08d953e70345c55bcdd5c2f7c101b
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
6a391ff198ab724f689bcef79d4e2e05a786cbc2
Diff: https://reviews.apache.org/r/44080/diff/
Testing
---
Thanks,
Alex Clemmer
acaed9b3f8a04964092cef413133834d0cf5a145
src/tests/containerizer/memory_test_helper.cpp
92579a28336b3c15ba7fdbb4a9f769ac7182aeb6
Diff: https://reviews.apache.org/r/45300/diff/
Testing
---
make check
Thanks,
Alex Clemmer
/posix/os.hpp
9ee233b988c08d953e70345c55bcdd5c2f7c101b
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
6a391ff198ab724f689bcef79d4e2e05a786cbc2
Diff: https://reviews.apache.org/r/45299/diff/
Testing
---
make check
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/44084/diff/
Testing
---
Thanks,
Alex Clemmer
To reply, visit:
https://reviews.apache.org/r/45015/#review124661
-------
On March 24, 2016, 7:58 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e
------
Thanks,
Alex Clemmer
too.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44748/#review124515
---
On March 22, 2016, 5:21 p.m., Alex
/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/44748/diff/
Testing
---
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp
1715bf5e6c590e7d14f59d517b30a281346365be
Diff: https://reviews.apache.org/r/44747/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/45009/diff/
Testing
---
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/44748/diff/
Testing
---
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp
1715bf5e6c590e7d14f59d517b30a281346365be
Diff: https://reviews.apache.org/r/44747/diff/
Testing
---
Thanks,
Alex Clemmer
7dace7d579c1b18afcf2278f9689b205cf57877f
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/44978/diff/
Testing
---
Thanks,
Alex Clemmer
/rename.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/44084/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/44978/diff/
Testing
---
Thanks,
Alex Clemmer
ows/rm.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/45022/diff/
Testing
---
Thanks,
Alex Clemmer
y/stout/include/stout/os/windows/exists.hpp
9211851e4562e04045276421b359c3c78cdae7f1
3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83
Diff: https://reviews.apache.org/r/45015/diff/
Testing
---
Thanks,
Alex Clemmer
Testing
---
Thanks,
Alex Clemmer
)
-
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp
ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1
Diff: https://reviews.apache.org/r/44078/diff/
Testing
---
Thanks,
Alex Clemmer
: https://reviews.apache.org/r/44082/diff/
Testing
---
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/posix/os.hpp
9ee233b988c08d953e70345c55bcdd5c2f7c101b
Diff: https://reviews.apache.org/r/44081/diff/
Testing
---
Thanks,
Alex Clemmer
dd44f9209ad283bfea95f16a8c1017e309757f23
Diff: https://reviews.apache.org/r/44808/diff/
Testing
---
Thanks,
Alex Clemmer
9ee233b988c08d953e70345c55bcdd5c2f7c101b
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
6a391ff198ab724f689bcef79d4e2e05a786cbc2
Diff: https://reviews.apache.org/r/44080/diff/
Testing
---
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/44748/diff/
Testing
---
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp
1715bf5e6c590e7d14f59d517b30a281346365be
Diff: https://reviews.apache.org/r/44747/diff/
Testing
---
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/44748/diff/
Testing
---
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/write.hpp
PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp
1715bf5e6c590e7d14f59d517b30a281346365be
Diff: https://reviews.apache.org/r/44747/diff/
Testing
---
Thanks,
Alex Clemmer
1715bf5e6c590e7d14f59d517b30a281346365be
Diff: https://reviews.apache.org/r/44747/diff/
Testing
---
Thanks,
Alex Clemmer
,
Alex Clemmer
---
Thanks,
Alex Clemmer
)
-
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp
ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1
Diff: https://reviews.apache.org/r/44078/diff/
Testing
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
c10c6d9d7c68a2d5b27d68736a49d212e70dcd05
Diff: https://reviews.apache.org/r/44045/diff/
Testing
---
Thanks,
Alex Clemmer
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43708/#review123086
---
On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote:
>
> ---
> This is a
party/libprocess/cmake/Process3rdpartyConfigure.cmake
e42cf190bd0d0a768002ca8b28d53aa910543fb7
3rdparty/libprocess/cmake/ProcessConfigure.cmake
61edad985a74528bfb1f8935040670a802587061
Diff: https://reviews.apache.org/r/43708/diff/
Testing
---
Thanks,
Alex Clemmer
/containerizer/mesos/launch.cpp
9fb55aa342559d2f982e7e6ccfef2f0e702bc214
Diff: https://reviews.apache.org/r/44076/diff/
Testing
---
Thanks,
Alex Clemmer
sting
---
Thanks,
Alex Clemmer
ess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp
(line 44)
<https://reviews.apache.org/r/41632/#comment183748>
Can we get rid of the trailing whitespace here?
- Alex Clemmer
On March 3, 2016, 3 a.m., Daniel Pravat wrote:
>
> --
eLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f
Diff: https://reviews.apache.org/r/43906/diff/
Testing
---
Thanks,
Alex Clemmer
hat I know almost nothing about
the autotools build, so I'm not exactly qualified to vote on that.
- Alex Clemmer
On March 2, 2016, 6:15 a.m., Diana Arroyo wrote:
>
> ---
> This is an automatically generated e-mail. To re
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422
Diff: https://reviews.apache.org/r/43908/diff/
Testing
---
Thanks,
Alex Clemmer
bc420c9c10d93ddd619a9eb2c5f4db67f31d722f
Diff: https://reviews.apache.org/r/43907/diff/
Testing
---
Thanks,
Alex Clemmer
rge of two commits, unfortunately.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121532
---
On Feb. 25, 20
ystem_tests.cpp`
and `os_tests.cpp`. So I've removed them from `os.hpp`.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121532
-------
On Feb. 25, 2016, 7:40 p.m., Alex Cl
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43907/#review121530
-------
On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote:
>
>
g/r/43889/#comment183301>
Oh wait. Sorry, I marked this as ship it, but you forgot to update the
Makefile.am (my build just failed as a result).
As soon as you update that and test the build, you should push this up, and
then I think it's ready to go.
- Alex Clemmer
On Ma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121560
---
Ship it!
- Alex Clemmer
On March 2, 2016, 12:52 a.m., Diana
/43905/diff/
Testing
---
Thanks,
Alex Clemmer
s is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
>
> (Updated Feb. 25, 2016, 7:42 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van
> Remoortere, Joseph Wu, a
> On March 1, 2016, 10:10 a.m., Alex Clemmer wrote:
> > Ship It!
Ah, oops, sorry folks. :( Meant to click this for a different review.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42036/#review121412
---
Ship it!
Ship It!
- Alex Clemmer
On Jan. 7, 2016, 9:47 p.m
://reviews.apache.org/r/43694/diff/
Testing
---
Thanks,
Alex Clemmer
/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a
Diff: https://reviews.apache.org/r/43692/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/43694/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/43698/diff/
Testing
---
Thanks,
Alex Clemmer
Ood catch, thanks Yi. :)
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43698/#review119659
---
On Feb. 29, 20
include paths in a bunch of places now, and this is bad. Every time we add a
directory, we'll need to add it to two places. Why not just add it to the
libmesos configuration once, and have both other things consume that
configuration instead?
Thoughts?
- Alex Clemmer
On Fe
txt (line 37)
<https://reviews.apache.org/r/41092/#comment182588>
See comment above and comment in the master review for my recommendations
here -- thinking it woudl be better to just put this into a single variable in
`SlaveConfigure.cmake`.
- Alex Clemmer
On Feb. 13, 2016, 4:23 a.m.,
indeed!
src/master/CMakeLists.txt (line 33)
<https://reviews.apache.org/r/44003/#comment182581>
Same comment as the dependencies -- we should make this something like the
following, much like we did with the agent.
```
target_link_libraries(${MASTER_TARGET} ${MASTER_LIBS})
> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52
> > <https://reviews.apache.org/r/43416/diff/2/?file=1253414#file1253414line52>
> >
> > Why is the cast to `size_t` needed here?
>
88b355e09f76f0412c74ad69556572f0079deb8f
Diff: https://reviews.apache.org/r/43416/diff/
Testing
---
Thanks,
Alex Clemmer
88b355e09f76f0412c74ad69556572f0079deb8f
Diff: https://reviews.apache.org/r/43416/diff/
Testing
---
Thanks,
Alex Clemmer
, which I think should
address the problems you are having here? :) let me know.
https://reviews.apache.org/r/43697/
https://reviews.apache.org/r/43698/
https://reviews.apache.org/r/43699/
- Alex Clemmer
On Feb. 25, 2016, 3:28 p.m., Diana Arroyo wrote
che.org/r/43697/
https://reviews.apache.org/r/43698/
https://reviews.apache.org/r/43699/
Do you think this addresses the problem you have? Let me know if you have any
other concerns or things I can help with.
- Alex Clemmer
On Feb. 25, 2016, 8:41 a.m., Dia
/windows.hpp
d3ba0b4ff5d2d125252389a0f8f618c78aa6d948
Diff: https://reviews.apache.org/r/44078/diff/
Testing
---
Thanks,
Alex Clemmer
/os/windows/shell.hpp
42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b
Diff: https://reviews.apache.org/r/44077/diff/
Testing
---
Thanks,
Alex Clemmer
6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9
Diff: https://reviews.apache.org/r/44076/diff/
Testing
---
Thanks,
Alex Clemmer
e0039fdab20ba547dc2bb78c544549c30c535294
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp
42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b
Diff: https://reviews.apache.org/r/44075/diff/
Testing
---
Thanks,
Alex Clemmer
/
Testing
---
Thanks,
Alex Clemmer
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
Diff: https://reviews.apache.org/r/43407/diff/
Testing
---
Thanks,
Alex Clemmer
> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52
> > <https://reviews.apache.org/r/43416/diff/2/?file=1253414#file1253414line52>
> >
> > Why is the cast to `size_t` needed here?
>
/diff/
Testing
---
Thanks,
Alex Clemmer
Diff: https://reviews.apache.org/r/44042/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/43907/diff/
Testing
---
Thanks,
Alex Clemmer
/os_tests.cpp
a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422
Diff: https://reviews.apache.org/r/43908/diff/
Testing
---
Thanks,
Alex Clemmer
,
Alex Clemmer
/containerizer/mesos/launch.hpp
7e29ca2b8bec1c20aef122472cff60f6003603ad
src/slave/containerizer/mesos/launch.cpp
6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9
Diff: https://reviews.apache.org/r/43905/diff/
Testing
---
Thanks,
Alex Clemmer
/launch.hpp
7e29ca2b8bec1c20aef122472cff60f6003603ad
src/slave/containerizer/mesos/launch.cpp
6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9
Diff: https://reviews.apache.org/r/43904/diff/
Testing
---
Thanks,
Alex Clemmer
/r/43903/diff/
Testing
---
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/43410/diff/
Testing
---
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/tests/CMakeLists.txt
3c65d0422dc6e198180d53d1c9e6cb2839137434
3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp
27626ae28db090f1a002239ff5c674b82e8fc9a8
Diff: https://reviews.apache.org/r/43411/diff/
Testing
---
Thanks,
Alex Clemmer
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/43416/#review120623
---
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail
visit:
https://reviews.apache.org/r/43411/#review120616
-------
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generat
------
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43410/
> ---
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
Diff: https://reviews.apache.org/r/43407/diff/
Testing
---
Thanks,
Alex Clemmer
views.apache.org/r/43407/#review118923
---
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43407/
>
/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake
a27cb98fa45cbd135ebfeca65e215fb3ff054739
Diff: https://reviews.apache.org/r/43697/diff/
Testing
---
Thanks,
Alex Clemmer
aa51b
Diff: https://reviews.apache.org/r/43707/diff/
Testing
---
Thanks,
Alex Clemmer
tests/CMakeLists.txt
3c65d0422dc6e198180d53d1c9e6cb2839137434
Diff: https://reviews.apache.org/r/43709/diff/
Testing
---
Thanks,
Alex Clemmer
cmake
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673
3rdparty/libprocess/cmake/ProcessConfigure.cmake
2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca
Diff: https://reviews.apache.org/r/43708/diff/
Testing
---
Thanks,
Alex Clemmer
601 - 700 of 1316 matches
Mail list logo