078ef4f4e7bf5e1522804a720c51cfa5518d8efd
src/slave/containerizer/mesos/containerizer.cpp
89b7e8db38916d69d9b2d4fe305d4397b0859a10
Diff: https://reviews.apache.org/r/51670/diff/
Testing
---
make check
Thanks,
Gilbert Song
check
Thanks,
Gilbert Song
check
Thanks,
Gilbert Song
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51592/#review147633
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 1, 2016, 6:11 p.m
ill only container
> > top level executor containers.
>
> Gilbert Song wrote:
> I have a different thought on this. According to the prvisioner::recover()
> ```
> virtual process::Future recover(
> const std::list& states,
> const
/provisioner_paths_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/51393/diff/
Testing
---
make check
Thanks,
Gilbert Song
src/slave/containerizer/mesos/provisioner/provisioner.cpp
8e35ff49ec99a242e764095dcfbb541c5e41ec71
Diff: https://reviews.apache.org/r/51343/diff/
Testing
---
make check
Thanks,
Gilbert Song
---
make check
Thanks,
Gilbert Song
/provisioner_appc_tests.cpp
b3ba176e506a6d1528290c07a8a0555b12c8cf70
Diff: https://reviews.apache.org/r/51420/diff/
Testing
---
make check
Thanks,
Gilbert Song
to recognize alive sub-containers.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review146901
-------
)
-
src/slave/containerizer/mesos/provisioner/paths.cpp
86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb
Diff: https://reviews.apache.org/r/51392/diff/
Testing
---
make check
Thanks,
Gilbert Song
8dc4175c60e4a9776ddb8ad21774fa4b30c28d00
src/tests/containerizer/provisioner_paths_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/51359/diff/
Testing
---
make check
Thanks,
Gilbert Song
/provisioner/paths.hpp
9829d6b52c8547ae22297a5bc47852ce5a219e4c
src/slave/containerizer/mesos/provisioner/paths.cpp
86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb
Diff: https://reviews.apache.org/r/51358/diff/
Testing
---
make check
Thanks,
Gilbert Song
/paths.hpp
9829d6b52c8547ae22297a5bc47852ce5a219e4c
src/slave/containerizer/mesos/provisioner/paths.cpp
86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb
Diff: https://reviews.apache.org/r/51323/diff/
Testing (updated)
---
make check
Thanks,
Gilbert Song
/provisioner.cpp
8e35ff49ec99a242e764095dcfbb541c5e41ec71
Diff: https://reviews.apache.org/r/51402/diff/
Testing
---
make check
Thanks,
Gilbert Song
/provisioner_appc_tests.cpp
b3ba176e506a6d1528290c07a8a0555b12c8cf70
Diff: https://reviews.apache.org/r/51421/diff/
Testing
---
make check
Thanks,
Gilbert Song
96e24500a12825161553eb050da389088b122695
Diff: https://reviews.apache.org/r/51780/diff/
Testing
---
make check
Thanks,
Gilbert Song
/51780/diff/
Testing
---
make check
Thanks,
Gilbert Song
ks.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51780/#review148435
---
On Sept. 11, 2016, 3:10 p.m., Gil
in provisioner::recover.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51402/#review148300
---
On Sep
/mesos_containerizer_tests.cpp
96e24500a12825161553eb050da389088b122695
Diff: https://reviews.apache.org/r/51780/diff/
Testing
---
make check
Thanks,
Gilbert Song
.apache.org/r/51673/#review147974
---
On Sept. 6, 2016, 2:53 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/51673/diff/
Testing
---
make check
Thanks,
Gilbert Song
/provisioner.cpp
8e35ff49ec99a242e764095dcfbb541c5e41ec71
Diff: https://reviews.apache.org/r/51402/diff/
Testing
---
make check
Thanks,
Gilbert Song
/provisioner_appc_tests.cpp
b3ba176e506a6d1528290c07a8a0555b12c8cf70
Diff: https://reviews.apache.org/r/51420/diff/
Testing
---
make check
Thanks,
Gilbert Song
.apache.org/r/51503/#review148376
---
On Sept. 9, 2016, 1:07 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51503/
> -
------
On Sept. 9, 2016, 1:07 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51402/
> ---
Thanks,
Gilbert Song
,
Gilbert Song
://reviews.apache.org/r/51668/diff/
Testing
---
make check
Thanks,
Gilbert Song
Diff: https://reviews.apache.org/r/51770/diff/
Testing
---
make check
Thanks,
Gilbert Song
)
<https://reviews.apache.org/r/51864/#comment216312>
We already have such `LOG(INFO)` in provisioner::_provisioner().
Why do we add this here?
And each isolator should already have similar log info message as well. This
would make it duplicate.
- Gilbert Song
On Sept. 13
)
<https://reviews.apache.org/r/51865/#comment216315>
do we need this `internal`?
src/master/validation.cpp (lines 61 - 63)
<https://reviews.apache.org/r/51865/#comment216314>
This is not necessary, because it is a required field.
- Gilbert Song
On Sept. 13, 2016, 3:47 p.m
list of known containers, which will be used
for isolator::recover nested aware support.
Diffs
-
include/mesos/slave/containerizer.proto
16dd3a19145b9764273cdb9a8899e353c98730e5
Diff: https://reviews.apache.org/r/51779/diff/
Testing
---
make check
Thanks,
Gilbert Song
dc43cad4d9e0bec0f4017ac53d740687c060b332
Diff: https://reviews.apache.org/r/51816/diff/
Testing
---
N/A.
Thanks,
Gilbert Song
96e24500a12825161553eb050da389088b122695
Diff: https://reviews.apache.org/r/51780/diff/
Testing
---
make check
Thanks,
Gilbert Song
)
-
CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538
docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332
Diff: https://reviews.apache.org/r/51816/diff/
Testing
---
N/A.
Thanks,
Gilbert Song
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51668/#review147941
-------
On Sept. 12, 2016, 11:42 a.m., Gilbert Song wrote:
>
> ---
> This is
/containerizer.cpp (line 1109)
<https://reviews.apache.org/r/51784/#comment216026>
Could we just have `arguments` MergeFrom? Because singular field (e.g.,
`value`) may be overwritten by some user modules accidentally.
- Gilbert Song
On Sept. 10, 2016, 5:17 p.m., Jie Yu
/mesos/containerizer.cpp
1a120f191e4ff0e2b31dd0a9a6bced784a56612c
Diff: https://reviews.apache.org/r/51672/diff/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/51669/diff/
Testing
---
make check
Thanks,
Gilbert Song
/slave/containerizer/mesos/containerizer.cpp
1a120f191e4ff0e2b31dd0a9a6bced784a56612c
Diff: https://reviews.apache.org/r/51671/diff/
Testing
---
make check
Thanks,
Gilbert Song
src/slave/containerizer/mesos/containerizer.cpp
1a120f191e4ff0e2b31dd0a9a6bced784a56612c
Diff: https://reviews.apache.org/r/51670/diff/
Testing
---
make check
Thanks,
Gilbert Song
/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51878/#review148848
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 13, 2016, 6:52
src/tests/containerizer/mesos_containerizer_tests.cpp
96e24500a12825161553eb050da389088b122695
Diff: https://reviews.apache.org/r/51825/diff/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/51668/diff/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51922/#review149082
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 15, 2016, 10:37
/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f
src/tests/containerizer/mesos_containerizer_tests.cpp
96e24500a12825161553eb050da389088b122695
Diff: https://reviews.apache.org/r/51825/diff/
Testing
---
make check
Thanks,
Gilbert Song
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review149116
---
On Sept. 15, 2016, 12:46 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
src/tests/master_validation_tests.cpp (lines 2031 - 2032)
<https://reviews.apache.org/r/51865/#comment216718>
Just nits:
Either move below
`task1.mutable_container()->add_network_infos();`
or newline below L2032.
- Gilbert Song
On Sept. 15, 2016, 6:34 a.m., Alex
We will attach container state in error/failure, but a log here should be
more explicitly helpful for debugging.
Just want to point out that, when people see (e.g., "5 isolators"), most
users will be really curious about what exactly they are.
I would suggest ju
> On Sept. 16, 2016, 1:09 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 903-904
> > <https://reviews.apache.org/r/51864/diff/3/?file=1498873#file1498873line903>
> >
> > This is not correct. We dont alway
/provisioner_appc_tests.cpp
b3ba176e506a6d1528290c07a8a0555b12c8cf70
Diff: https://reviews.apache.org/r/51421/diff/
Testing
---
make check
Thanks,
Gilbert Song
/tests/containerizer/mesos_containerizer_tests.cpp
72346c748598e4c0787dba09d9ccb59f244b0df5
src/tests/containerizer/provisioner_appc_tests.cpp
b3ba176e506a6d1528290c07a8a0555b12c8cf70
Diff: https://reviews.apache.org/r/51770/diff/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/51503/diff/
Testing
---
make check
Thanks,
Gilbert Song
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52235/#review150344
---
On Sept. 24, 2016, 11:50 a.m., Gilbert Song wrote:
>
> ---
>
make it easier for the shepherd.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52004/#review149385
-------
On Sept. 18, 2016, 10:30 a.m., Gilbert Song wrote:
>
> ---
://reviews.apache.org/r/52233/diff/
Testing
---
Thanks,
Gilbert Song
/51669/diff/
Testing
---
make check
Thanks,
Gilbert Song
ainer "xxx". Then, the streaming function will
print it out as "xxx.yyy".
Diffs (updated)
-
src/common/type_utils.cpp 9cb6274231bc373e796dc8e91e9340025b57ad1e
Diff: https://reviews.apache.org/r/51825/diff/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/51674/diff/
Testing
---
make check
Thanks,
Gilbert Song
144b0db501d40d4e0bba12672723616bedd76e7e
Diff: https://reviews.apache.org/r/52235/diff/
Testing
---
Thanks,
Gilbert Song
ff: https://reviews.apache.org/r/52241/diff/
Testing
---
Thanks,
Gilbert Song
.
Diffs
-
src/tests/containerizer/filesystem_isolator_tests.cpp
680d68b7490ccc145f26037c96d4e23bd74a6f58
Diff: https://reviews.apache.org/r/52240/diff/
Testing
---
Thanks,
Gilbert Song
349d307284809353d950c6f281aa8605eb9289e9
src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c
src/tests/containerizer/mock_containerizer.hpp
840c51148399d2d2ebfb59106c1732ed5e91e61e
Diff: https://reviews.apache.org/r/51670/diff/
Testing
---
make check
Thanks,
Gilbert
for nested
containers.
Diffs (updated)
-
src/slave/containerizer/mesos/containerizer.hpp
16f9e3e92e90fe7f8a0ebd24e567800e1f285bc9
Diff: https://reviews.apache.org/r/51668/diff/
Testing
---
make check
Thanks,
Gilbert Song
PRE-CREATION
Diff: https://reviews.apache.org/r/52234/diff/
Testing
---
Thanks,
Gilbert Song
/containerizer/mesos/containerizer.cpp
144b0db501d40d4e0bba12672723616bedd76e7e
Diff: https://reviews.apache.org/r/51673/diff/
Testing
---
make check
Thanks,
Gilbert Song
ner.
Thanks, it does look cleaner.
Note: I decide to go with `Option` for the helper parameter.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52234/#review150342
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52254/#review150377
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 26, 2016, 12:26
5db4be4bdc7b9a3a2a66a17f8a9ac74c8d3dfbf6
Diff: https://reviews.apache.org/r/52233/diff/
Testing
---
Thanks,
Gilbert Song
3f38dddfb4c089322fe4e13b1ef2070b4835885c
Diff: https://reviews.apache.org/r/52393/diff/
Testing
---
make check
Thanks,
Gilbert Song
/containerizer.cpp
522d2c37229b07b66a0824c3e246c32f8d803b10
Diff: https://reviews.apache.org/r/52412/diff/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52541/#review151513
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 4, 2016, 6:16 p.m
: https://reviews.apache.org/r/52612/diff/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52538/#review151703
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 4, 2016, 6:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52573/#review151718
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 5, 2016, 2:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52572/#review151717
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 5, 2016, 2:15 p.m
> On Oct. 6, 2016, 12:45 p.m., Gilbert Song wrote:
> > src/tests/containerizer/filesystem_isolator_tests.cpp, lines 199-219
> > <https://reviews.apache.org/r/52539/diff/1/?file=1522501#file1522501line199>
> >
> > Consider a followup patch to move this to test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52546/#review151716
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 4, 2016, 11:07 p.m
20169>
Use `const` if sounds good to you.
Maybe we can chat a little bit to find the balance?
- Gilbert Song
On Oct. 4, 2016, 6:15 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52539/#review151727
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 4, 2016, 6:15 p.m
who is new to this part to
read.
- Gilbert Song
On Oct. 5, 2016, 2:15 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/52537/diff/
Testing
---
make check
Verified that this test would fail if we removed the fix in
https://reviews.apache.org/r/52480/
Thanks,
Gilbert Song
.
Repository: mesos
Description
---
Refactored the provisioner recover test.
Diffs
-
src/tests/containerizer/provisioner_appc_tests.cpp
6ef1c926d7aa942e241a24d4d3838a5f2d7c4bd1
Diff: https://reviews.apache.org/r/52536/diff/
Testing
---
make check
Thanks,
Gilbert Song
please rebase?
- Gilbert Song
On Aug. 25, 2016, 9:22 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51988/#review149344
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 17, 2016, 12:47
/paths.cpp eb414caae5847949854743d4e3c603217a897898
Diff: https://reviews.apache.org/r/52009/diff/
Testing
---
make check
Thanks,
Gilbert Song
2cc8e764ff18c95c29598df75cdb370ccf120662
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp
af9f3736b487b595e8768e56ce60dc4823db28a1
Diff: https://reviews.apache.org/r/52006/diff/
Testing
---
make check
Thanks,
Gilbert Song
0a85935550e36c9142d845465cfa70a1634a647a
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
ea418252956c8089acc5a491888ed7f6df6cafcd
Diff: https://reviews.apache.org/r/52010/diff/
Testing
---
make check
Thanks,
Gilbert Song
src/slave/paths.cpp eb414caae5847949854743d4e3c603217a897898
Diff: https://reviews.apache.org/r/52008/diff/
Testing
---
make check
Thanks,
Gilbert Song
ac0397f65bb2a675ad1eae0f7cfa95f10145fc63
src/slave/containerizer/mesos/isolators/docker/runtime.cpp
b589cd691ae6aacd2dcd00878e43d58f15abfe11
Diff: https://reviews.apache.org/r/52004/diff/
Testing
---
make check
Thanks,
Gilbert Song
6333e9c881b10184fac2f15f5f4a6f7d781a655f
src/slave/containerizer/mesos/isolators/volume/image.cpp
c25205bb80d8008e7879c7a9e6fc274ea0cee5f3
Diff: https://reviews.apache.org/r/52003/diff/
Testing
---
make check
Thanks,
Gilbert Song
c25b0eeff44d66c2045fd8daf0feb8ea3db718e4
src/slave/containerizer/mesos/isolators/appc/runtime.cpp
a96298b801e8ef217dc0e88187b527e3c43a338e
Diff: https://reviews.apache.org/r/52005/diff/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51981/#review149341
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 17, 2016, 11:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51944/#review149305
---
Could you rebase?
- Gilbert Song
On Sept. 16, 2016, 1:38 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51975/#review149300
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 16, 2016, 3:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51976/#review149301
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 16, 2016, 3:46
901 - 1000 of 2187 matches
Mail list logo
