Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

/tests/oversubscription_tests.cpp 0333281c247dd182860a49f39be791c00679bf6b Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/3rdparty/stout/include/stout/os.hpp 03e6f75850561b5eb92da4771fbe18e4057ad520 Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation

ered by `getModulePath`, no? Yeh I can use ``getModulePath`` here. I think I was trying to minimize the changes :) - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#revi

Re: Review Request 40553: Enable mesos tests installation

4975bea8a7a701e0414426760692720f73dea7f5 src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Review Request 41424: Install picojson.h if we are using the bundled version.

04d0fa324bf6eab98a51fc08298b9da2992d29d1 Diff: https://reviews.apache.org/r/41424/diff/ Testing --- Build an external module that implicitly depends on picojson.h Thanks, James Peach

Review Request 41425: Fix the Mesos pkg-config.

/mesos/lib/pkgconfig pkg-config --cflags mesos -DPICOJSON_USE_INT64 -D__STDC_FORMAT_MACROS -I/opt/mesos/include $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --cflags-only-I mesos -I/opt/mesos/include Thanks, James Peach

Re: Review Request 41424: Install picojson.h if we are using the bundled version.

depends on picojson.h Thanks, James Peach

Re: Review Request 41425: Fix the Mesos pkg-config.

Thanks, James Peach

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

0333281c247dd182860a49f39be791c00679bf6b Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

/tests/oversubscription_tests.cpp 0333281c247dd182860a49f39be791c00679bf6b Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation

://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation

a6cca472f4dfab12cd6eccab6972206d842177aa src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Review Request 41658: Track the allocation candidates to bound the allocation queue.

/diff/ Testing --- make check. Thanks, James Peach

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

mail. To reply, visit: https://reviews.apache.org/r/40975/#review112206 ------- On Jan. 4, 2016, 4:31 p.m., James Peach wrote: > > --- > This is an autom

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

--- None. Thanks, James Peach

Re: Review Request 41425: Fix the Mesos pkg-config.

iew. I have a very simple build that consumes the existing ``pkg-config`` support. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/#review111806 -------

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review112647 --- On Jan. 4, 2016, 4:31 p.m., James Peach wrote: > >

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

0975/diff/raw/ > > [1164/1164] -> "40975.patch" [1] > > No files to lint > > > > Error: Commit message summary (the first line) must end in a period. > > James Peach wrote: > Well AFAICT "Document that libprocess ignores SIGPIPE." *does*

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

. Repository: mesos Description --- Document that libprocess ignores SIGPIPE. Diffs (updated) - 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 Diff: https://reviews.apache.org/r/40975/diff/ Testing --- None. Thanks, James Peach

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

rect in the commit I am pushing; I don't know how to convince the tooling of that. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review113286 --- On Jan. 7, 2016, 5:30 p.m.

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

--- None. Thanks, James Peach

Re: Review Request 40975: Document that libprocess ignores SIGPIPE.

/ Testing --- None. Thanks, James Peach

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

build libraries > > into these paths (i.e. what you write will only work with automake). > > > > Like I already pointed out on #40553, you should really lift the level > > of abstraction here, and use a function to get this path. > > James Peach wrote: >

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

) - src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/3rdparty/stout/include/stout/os.hpp 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation

/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

a6cca472f4dfab12cd6eccab6972206d842177aa src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

877139e97249761658dce3b1058cdc2e2a52367b Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

/ Testing --- Thanks, James Peach

Review Request 42370: Accept the 3-field version of HDFS du output.

: https://reviews.apache.org/r/42370/diff/ Testing --- make check on Centos6 w/ devtoolset-3. Running in production for a number of weeks. Thanks, James Peach

Re: Review Request 42370: Accept the 3-field version of HDFS du output.

t for you and commit. Thanks James! Thanks Jie! - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42370/#review114803 -------

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

) - src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/3rdparty/stout/include/stout/os.hpp 486a632bcccd24a7ceb5b5fdc58da5df269c4a21 Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation

: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation

s.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/3rdparty/stout/include/stout/os.hpp ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6 Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

e943ab99baf3d74679a5da89a89f6a4b7ead src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/include/stout/os.hpp ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6 Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf Diff: https://reviews.apache.org/r/39780/diff/ Testing --- make check Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

ath, I'd like to do that as separate Jira tickets. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116610 ------- On Jan. 27, 2016, 5:54 p.m., James Peach wrote: > >

Re: Review Request 40553: Enable mesos tests installation.

Diff: https://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 Diff: https://reviews.apache.org/r/43149/diff/ Testing --- make check on OS X. Running in production for many months. Thanks, James Peach

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

/process.cpp 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 Diff: https://reviews.apache.org/r/43149/diff/ Testing --- make check on OS X. Running in production for many months. Thanks, James Peach

Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

--- Document LIBPROCESS_THREAD_COUNT. Diffs - docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 Diff: https://reviews.apache.org/r/43165/diff/ Testing --- Source inspection. Thanks, James Peach

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

--- Source inspection. Thanks, James Peach

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

overridden" is correct here. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43165/#review117759 --- On

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

/3rdparty/stout/include/stout/posix/os.hpp 2eed65d2ed7ae8a6377646971bc6b1c252a65cbb Diff: https://reviews.apache.org/r/39782/diff/ Testing --- No code changes. Thanks, James Peach

Re: Review Request 40553: Enable mesos tests installation.

://reviews.apache.org/r/40553/diff/ Testing --- Thanks, James Peach

Review Request 33446: Link to mesos-containerizer from the main documentation page.

documentation and verify the link is corect using ``middleman server``. Thanks, James Peach

Re: Review Request 33446: Link to mesos-containerizer from the main documentation page.

/ Testing --- Build the Mesos documentation and verify the link is corect using ``middleman server``. Thanks, James Peach

Review Request 33491: Set the supplementary groups list when switching users.

https://reviews.apache.org/r/33491/diff/ Testing --- Ran "make check" on CentOS 7 & and OS X 10.10.3. Thanks, James Peach

Re: Review Request 33491: Set the supplementary groups list when switching users.

t: https://reviews.apache.org/r/33491/#review81404 ------- On April 23, 2015, 8:16 p.m., James Peach wrote: > > --- > This is an automatically generated e-

Re: Review Request 33491: Set the supplementary groups list when switching users.

t in the call to > > `::setgid` above and `::setuid` below? Is it possible for only some of > > these calls to fail with EPERM? > > James Peach wrote: > If you do a ``setgid`` to your current GID, it succeeds and does nothing, > but ``initgroups`` ends up calling

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

x27;d be inclined to cast this the other way to preserve the ``-1`` return value from ``read(2)``, ie. ``static_cast(LOREM_IPSUM.size())``. Same comment for checking the ``sendfile(2)`` return value. - James Peach On Oct. 14, 2016, 3:19 p.m.,

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

2245> Can you just make ``length`` type ``ssize_t``? - James Peach On Oct. 14, 2016, 3:14 p.m., Aaron Wood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 52696: Harden stout

org/r/52696/#comment47> Where does ``VARIANTS`` come from? - James Peach On Oct. 14, 2016, 3:20 p.m., Aaron Wood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 52997: Improve Socket::connect error message.

FAILED ] HTTPTest.Endpoints 1 FAILED TEST ``` Thanks, James Peach

Re: Review Request 52997: Improve Socket::connect error message.

0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] HTTPTest.Endpoints 1 FAILED TEST ``` Thanks, James Peach

Re: Review Request 52997: Improve Socket::connect error message.

mbda needs to take a copy), since ``connect`` takes a reference to the address. On Oct. 18, 2016, 9:41 p.m., James Peach wrote: > > Can you also follow up with a review to change the logging level in > > libprocess for failing to close the socket if we fail to connect? > > Maybe it

Re: Review Request 52997: Improve Socket::connect error message.

> On Oct. 18, 2016, 9:41 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, line 114 > > <https://reviews.apache.org/r/52997/diff/1/?file=1540940#file1540940line114> > > > > Missing reference. > > James Peach wrote: >

Re: Review Request 52997: Improve Socket::connect error message.

0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] HTTPTest.Endpoints 1 FAILED TEST ``` Thanks, James Peach

Re: Review Request 52997: Improve Socket::connect error message.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/#review153245 --- On Oct. 18, 2016, 10:43 p.m., James Peach wrote: > > --- > This is an automatically g

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

nse for Windows. NTFS has streams, which have different semantics that extended attributes. I doubt that you would want this API on Windows. - James Peach On Oct. 20, 2016, 3:20 a.m., Qian Zhang wrote: > > --- > This is a

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

tps://reviews.apache.org/r/53041/#comment222953> FreeBSD would need a third branch for the (extattr)[https://www.freebsd.org/cgi/man.cgi?query=extattr&sektion=2&apropos=0&manpath=FreeBSD+10.3-RELEASE+and+Ports] API. It looks like stout does attempt to support FreeBS

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

- James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153347 --- On Oct. 21, 2016, 9:29 a.m., Qian Zhang wrote: > >

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 20, 2016, 4:03 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 64 > > <https://reviews.apache.org/r/53041/diff/1/?file=1541992#file1541992line64> > > > > You could use ``std::vector`` here to avoid manual memory

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 20, 2016, 4:03 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 24 > > <https://reviews.apache.org/r/53041/diff/1/?file=1541992#file1541992line24> > > > > Since the flags differ between platform, it might be

Review Request 53137: Fix build option argument handling.

c8d48be41d526c45ee00b404d0ad2b67ea11587f Diff: https://reviews.apache.org/r/53137/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

Review Request 53138: Fix build option argument handling.

1644035d7fe1a45c798b13dbfb3c66f74466f2a2 Diff: https://reviews.apache.org/r/53138/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

Review Request 53136: Emit the build options at the end of configure.

. Thanks, James Peach

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 284 > > <https://reviews.apache.org/r/52647/diff/3/?file=1538065#file1538065line284> > > > > Can you just make ``length`` type ``ssize_t``? > > Aaron

Re: Review Request 52645: Harden Mesos

645/#comment223138> I wasn't able to figure this line out, so it probably needs a comment to explain where ``VARIANTS`` comes from and what this filtering is doing. - James Peach On Oct. 21, 2016, 6:31 p.m., Aaron

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

tps://reviews.apache.org/r/52754/#comment223139> Why remove this? It looks like it is actually used? - James Peach On Oct. 21, 2016, 6:31 p.m., Aaron Wood wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 21, 2016, 4:19 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 26 > > <https://reviews.apache.org/r/53041/diff/2/?file=1542972#file1542972line26> > > > > FreeBSD would need a third branch for the > > (extat

Re: Review Request 53136: Emit the build options at the end of configure.

--- Make check on OS X and Fedora 24. Thanks, James Peach

Re: Review Request 53138: Fix build option argument handling.

) - 3rdparty/libprocess/configure.ac 1644035d7fe1a45c798b13dbfb3c66f74466f2a2 Diff: https://reviews.apache.org/r/53138/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

Re: Review Request 53137: Fix build option argument handling.

) - configure.ac c8d48be41d526c45ee00b404d0ad2b67ea11587f Diff: https://reviews.apache.org/r/53137/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

Review Request 53180: Remove broken documentation link to the manjaro project.

--- Remove broken documentation link to the manjaro project. Diffs - docs/container-image.md 623839775776c4830e0db011ca9c163026686262 Diff: https://reviews.apache.org/r/53180/diff/ Testing --- None. Thanks, James Peach

Re: Review Request 53180: Remove broken documentation link to the manjaro project.

. Repository: mesos Description --- Remove broken documentation link to the manjaro project. Diffs (updated) - docs/container-image.md 623839775776c4830e0db011ca9c163026686262 Diff: https://reviews.apache.org/r/53180/diff/ Testing --- None. Thanks, James Peach

Re: Review Request 53137: Fix build option argument handling.

) - configure.ac c8d48be41d526c45ee00b404d0ad2b67ea11587f Diff: https://reviews.apache.org/r/53137/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

Re: Review Request 53136: Emit the build options at the end of configure.

--- Make check on OS X and Fedora 24. Thanks, James Peach

Re: Review Request 53138: Fix build option argument handling.

) - 3rdparty/libprocess/configure.ac 1644035d7fe1a45c798b13dbfb3c66f74466f2a2 Diff: https://reviews.apache.org/r/53138/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

Re: Review Request 52647: Fix new sign comparison errors in libprocess produced by hardened flags

> On Oct. 18, 2016, 3:14 a.m., James Peach wrote: > > 3rdparty/libprocess/src/tests/io_tests.cpp, line 284 > > <https://reviews.apache.org/r/52647/diff/3/?file=1538065#file1538065line284> > > > > Can you just make ``length`` type ``ssize_t``? > > Aaron

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

> On Oct. 27, 2016, 5:03 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, lines 71-72 > > > > > > I think James made a valid point there that errno might not be > > preserved across delete. So

Re: Review Request 53137: Fix build option argument handling.

) - configure.ac c8d48be41d526c45ee00b404d0ad2b67ea11587f Diff: https://reviews.apache.org/r/53137/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

Re: Review Request 53138: Fix build option argument handling.

) - 3rdparty/libprocess/configure.ac 1644035d7fe1a45c798b13dbfb3c66f74466f2a2 Diff: https://reviews.apache.org/r/53138/diff/ Testing --- Make check on OS X and Fedora 24. Thanks, James Peach

<    1   2   3   4   5   6   7   8   9   10   >