Re: Review Request 63730: Passed operations from resource provider to agent.

in `message.hpp` is already fixed in `master`. src/resource_provider/manager.cpp Line 477 (original), 477 (patched) <https://reviews.apache.org/r/63730/#comment268523> Remove the space after `resourceProvider`. - Jan Schlicht On Nov. 13, 2017, 7:33 p.m., Benjamin Bannier

Re: Review Request 63555: Publish resource provider resources before container launch or update.

> On Nov. 9, 2017, 1:52 p.m., Jan Schlicht wrote: > > src/slave/slave.hpp > > Lines 538 (patched) > > <https://reviews.apache.org/r/63555/diff/1/?file=1881011#file1881011line538> > > > > What's the motivation for this `extra` parameter? It isn't used

Review Request 63798: Added resource provider support for all offer operations.

to allow offer pipelining. Diffs - src/slave/slave.cpp d8bacebc74790e955490a158c37ac0d9e75fd6b5 src/tests/resource_provider_manager_tests.cpp ecfe2b4c0952838d6312df603f8eb2f458725175 Diff: https://reviews.apache.org/r/63798/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63797: Changed resource checkpointing to no longer failover.

/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63732: Reconciled offer operations between agent and master.

erwise frameworks will receive no feedback for these operations. - Jan Schlicht On Nov. 13, 2017, 7:33 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 63912: Changed agent (re-)registration to set resource versions.

://reviews.apache.org/r/63912/diff/2/ Changes: https://reviews.apache.org/r/63912/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 62502: Added an event to publish resources.

345b883a8c629bf5bed83e9236632c277f2eb0eb Diff: https://reviews.apache.org/r/62502/diff/3/ Changes: https://reviews.apache.org/r/62502/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Review Request 63986: Refactored 'MockResourceProvider' to include default functions.

://reviews.apache.org/r/63986/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

: https://reviews.apache.org/r/63751/diff/7/ Changes: https://reviews.apache.org/r/63751/diff/6-7/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63798: Added resource provider support for all offer operations.

Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

acfeac16884b00581a3523607ff26f44f6dca53a src/tests/reservation_tests.cpp 470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/5/ Changes: https://reviews.apache.org/r/63751/diff/4-5/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63798: Added resource provider support for all offer operations.

://reviews.apache.org/r/63798/diff/2/ Changes: https://reviews.apache.org/r/63798/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

/ Changes: https://reviews.apache.org/r/63751/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/4/ Changes: https://reviews.apache.org/r/63751/diff/3-4/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

470f7341686e69d0a71fb234a26b277c45c29780 Diff: https://reviews.apache.org/r/63751/diff/6/ Changes: https://reviews.apache.org/r/63751/diff/5-6/ Testing --- make check Thanks, Jan Schlicht

Review Request 63622: Provided handling for offer operation updates.

/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63622/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63689: Used `Master::_apply` consistently for all offer operations.

Or we move the switch to `Master::_apply` so that `Slave::apply` is only called for `RESERVE`, `UNRESERVE`, `CREATE`, `DESTROY`. - Jan Schlicht On Nov. 9, 2017, 1:02 a.m., Jie Yu wrote: > > --- > This is an automatically g

Re: Review Request 63622: Provided handling for offer operation updates.

--- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

Diff: https://reviews.apache.org/r/63622/diff/4/ Changes: https://reviews.apache.org/r/63622/diff/3-4/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63555: Publish resource provider resources before container launch or update.

urces of all executor of all frameworks? Or am I missing something here? I'd expect that only the RP resources of the task/executor that's about to get started should be published. Hence `resourceProviderManager->publish(info.id(), executor->allocatedResources())` should be enough. - Jan Sc

Re: Review Request 63622: Provided handling for offer operation updates.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63622/#review190355 --- On Nov. 7, 2017, 3:20 p.m., Jan Schlicht wrote: > > ---

Re: Review Request 63622: Provided handling for offer operation updates.

/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63622/diff/3/ Changes: https://reviews.apache.org/r/63622/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 src/tests/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63622/diff/2/ Changes: https://reviews.apache.org/r/63622/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63622: Provided handling for offer operation updates.

> src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 > src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 > src/tests/resource_provider_manager_tests.cpp > 4008b1c751d6227b99adef756e95174d7d8a62f2 > > > Diff: https://reviews.apache.org/r/63622/diff/3/ > > > Testing > --- > > make check > > > Thanks, > > Jan Schlicht > >

Re: Review Request 63620: Updated offer operation handling to set resource versions.

ee212c1a21b432d3aa8e90d748d12cb0a754d57c Diff: https://reviews.apache.org/r/63620/diff/2/ Changes: https://reviews.apache.org/r/63620/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63621: Added a devolve function for 'OfferOperationStatus'.

e05fcd4d0f423a2ba13bdcf6ba6561b43e31977d Diff: https://reviews.apache.org/r/63621/diff/2/ Changes: https://reviews.apache.org/r/63621/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Review Request 63679: Added test helpers for storage operations.

Description --- See summary. Diffs - src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 Diff: https://reviews.apache.org/r/63679/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63625: Added a test for resource conversion using a resource provider.

://reviews.apache.org/r/63625/diff/2/ Changes: https://reviews.apache.org/r/63625/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Review Request 63620: Updated offer operation handling to set resource versions.

--- make check Thanks, Jan Schlicht

Review Request 63625: Added a test for resource conversion using a resource provider.

Description --- Added a test for resource conversion using a resource provider. Diffs - src/tests/resource_provider_manager_tests.cpp 4008b1c751d6227b99adef756e95174d7d8a62f2 Diff: https://reviews.apache.org/r/63625/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63621: Added a devolve function for 'OfferOperationStatus'.

Description --- See summary. Diffs - src/internal/devolve.hpp 48d9c33fff376f7842f9b72bf84056482cefadcd src/internal/devolve.cpp e05fcd4d0f423a2ba13bdcf6ba6561b43e31977d Diff: https://reviews.apache.org/r/63621/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 63584: Added agent ID to offer operation protobuf helper.

/r/63584/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 63584: Added agent ID to offer operation protobuf helper.

da0a84eb828e2fb064ba466d9e525cd3a85fc43a src/common/protobuf_utils.cpp 4ce7021b01b9fb52ae1a8d95aa686c5b79164d67 src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 Diff: https://reviews.apache.org/r/63584/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64381: Mesos: Used a namespace for UUID.

/tests/task_status_update_manager_tests.cpp d180e8c485591c787efa3e4a30fd8b1b113019bd Diff: https://reviews.apache.org/r/64381/diff/2/ Changes: https://reviews.apache.org/r/64381/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64448: Added a missing include.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64448/#review193246 --- Ship it! Ship It! - Jan Schlicht On Dec. 8, 2017, 1:52 p.m

Re: Review Request 64168: Introduced a 'UUID' type.

://reviews.apache.org/r/64168/diff/3/ Changes: https://reviews.apache.org/r/64168/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64151: Added a V1 API call to list resource providers.

32781fd8f124f71e61744804aec3fe4da59a5df2 src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa Diff: https://reviews.apache.org/r/64151/diff/8/ Changes: https://reviews.apache.org/r/64151/diff/7-8/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64380: Stout: Used a namespace for UUID.

://reviews.apache.org/r/64381/ Thanks, Jan Schlicht

Re: Review Request 64381: Mesos: Used a namespace for UUID.

e81b65bb67954e14eb82d8b80ffa679c2f9515fb src/tests/task_status_update_manager_tests.cpp d180e8c485591c787efa3e4a30fd8b1b113019bd Diff: https://reviews.apache.org/r/64381/diff/3/ Changes: https://reviews.apache.org/r/64381/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64168: Introduced a 'UUID' type.

: https://reviews.apache.org/r/64168/diff/4/ Changes: https://reviews.apache.org/r/64168/diff/3-4/ Testing --- make check Thanks, Jan Schlicht

Review Request 64247: Fixed a flaky test case in reservation tests.

--gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine) Thanks, Jan Schlicht

Re: Review Request 63389: Added a mock resource provider manager.

m not opening an issue for that. - Jan Schlicht On Nov. 15, 2017, 3:46 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 64151: Added a V1 API call to list resource providers.

eviews.apache.org/r/64151/diff/6/?file=1909016#file1909016line881> > > > > This needs to be tweaked if we use a `MockResourceProvider`. The latest rebase no longer changes ResourceProviderManager. Dropping. - Jan ------- This is an automatically generated e-mail. To reply, visit: https://reviews.

Re: Review Request 64370: Provided resource providere infos in 'UPDATE_STATE' message.

---------- On Dec. 6, 2017, 11:16 a.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64370/ > ---

Re: Review Request 64370: Provided resource provider infos in 'UpdateState' message.

: https://reviews.apache.org/r/64370/diff/2/ Changes: https://reviews.apache.org/r/64370/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64151: Added a V1 API call to list resource providers.

32781fd8f124f71e61744804aec3fe4da59a5df2 src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa Diff: https://reviews.apache.org/r/64151/diff/7/ Changes: https://reviews.apache.org/r/64151/diff/6-7/ Testing --- make check Thanks, Jan Schlicht

Review Request 64380: Stout: Used a namespace for UUID.

://reviews.apache.org/r/64380/diff/1/ Testing --- Tests are run in https://reviews.apache.org/r/64381/ Thanks, Jan Schlicht

Re: Review Request 64168: Introduced a 'UUID' type.

25cfd4730c3d77d1886745204b13ca3cb140620c Diff: https://reviews.apache.org/r/64168/diff/2/ Changes: https://reviews.apache.org/r/64168/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Review Request 64381: Mesos: Used a namespace for UUID.

--- make check Thanks, Jan Schlicht

Review Request 64370: Provided resource providere infos in 'UPDATE_STATE' message.

/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01 Diff: https://reviews.apache.org/r/64370/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

=ResourceProviderCapability/ReservationTest.MasterFailover/1 --gtest_repeat=2000 --gtest_break_on_failure` while running `stress --cpu 8 --io 8` in the background (on a 4 core machine) Thanks, Jan Schlicht

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

) Thanks, Jan Schlicht

Re: Review Request 64380: Stout: Used a namespace for UUID.

Thanks, Jan Schlicht

Re: Review Request 64381: Mesos: Used a namespace for UUID.

(updated) --- Tests are run as part of https://reviews.apache.org/r/64380 Thanks, Jan Schlicht

Re: Review Request 64168: Introduced a 'UUID' type.

bf789a05771b7c25f2fc2a8a5b35d38519e4793b src/tests/slave_tests.cpp 5228e03af1585817108094c587da6ae30d67df67 Diff: https://reviews.apache.org/r/64168/diff/5/ Changes: https://reviews.apache.org/r/64168/diff/4-5/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 64168: Introduced a 'UUID' type.

bf789a05771b7c25f2fc2a8a5b35d38519e4793b src/tests/slave_tests.cpp 5228e03af1585817108094c587da6ae30d67df67 Diff: https://reviews.apache.org/r/64168/diff/6/ Changes: https://reviews.apache.org/r/64168/diff/5-6/ Testing --- make check Thanks, Jan Schlicht

Review Request 64546: Fixed a flaky test.

=*ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider* --gtest_repeat=1000 --gtest_break_on_failure (with 'stress' running in the background) Thanks, Jan Schlicht

Re: Review Request 64543: Exposed resource provider information in master 'GET_AGENTS' response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64543/#review193543 --- Ship it! Ship It! - Jan Schlicht On Dec. 12, 2017, 3:38 p.m

Re: Review Request 64713: Fixed a crash when resubscribing resource providers.

ed. Dropping. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64713/#review194146 --- On Dec. 20, 2017, 2:24 p.m., Jan Schlicht wrote:

Re: Review Request 64713: Fixed a crash when resubscribing resource providers.

. Diffs (updated) - src/resource_provider/manager.cpp e3fcb64b630924e1bb497625708cad3f0fdc064a Diff: https://reviews.apache.org/r/64713/diff/2/ Changes: https://reviews.apache.org/r/64713/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 66934: Added token-based authentication to resource provider tests.

: https://reviews.apache.org/r/66934/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 66939: Improved validation messages for some operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66939/#review202548 --- Ship it! Ship It! - Jan Schlicht On May 5, 2018, 1:41 a.m

Re: Review Request 66933: Added a realm for resource provider authentication.

/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 66934: Added token-based authentication to resource provider tests.

--- make check Thanks, Jan Schlicht

Re: Review Request 66933: Added a realm for resource provider authentication.

n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66933/#review202623 ------- On May 7, 2018, 2:12 p.m., Jan Schlicht wrote: > > --- > Th

Re: Review Request 66932: Adden token based authentication for resource providers.

: https://reviews.apache.org/r/66932/diff/2/ Changes: https://reviews.apache.org/r/66932/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 66934: Added token-based authentication to resource provider tests.

/ Testing --- make check Thanks, Jan Schlicht

Review Request 67501: Added authorization for resource provider operations.

f6f77692112d2299f3009fde4468f82bfd934c60 Diff: https://reviews.apache.org/r/67501/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

ched) <https://reviews.apache.org/r/67547/#comment287288> We don't have to start a master to test this response of the agent API. - Jan Schlicht On June 12, 2018, 6:08 p.m., Benno Evers wrote: > > --- > This is an automatically

Re: Review Request 67547: Added check for API endpoints not supporting streaming responses.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67547/#review204684 --- Ship it! Ship It! - Jan Schlicht On June 13, 2018, 1:02 p.m

Re: Review Request 67521: Made some headers standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67521/#review204531 --- Ship it! Ship It! - Jan Schlicht On June 11, 2018, 11:58

Re: Review Request 67522: Moved some constant definitions into header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67522/#review204532 --- Ship it! Ship It! - Jan Schlicht On June 11, 2018, 11:58

Re: Review Request 67501: Added authorization for storage operations.

4180341e2c7b16503a4376c501f611bb78ba901c src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a src/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60 Diff: https://reviews.apache.org/r/67501/diff/4/ Changes: https://reviews.apache.org/r/67501/diff/3-4/ Testing --- make check Thanks, Jan

Re: Review Request 67501: Added authorization for storage operations.

ole, destroy operations authorized per creator principal. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review205178 ------- On June 21, 2018, 2:34 p.m., Jan Schlicht wrote: > >

Re: Review Request 67501: Added authorization for storage operations.

/tests/authorization_tests.cpp f6f77692112d2299f3009fde4468f82bfd934c60 Diff: https://reviews.apache.org/r/67501/diff/5/ Changes: https://reviews.apache.org/r/67501/diff/4-5/ Testing --- make check Thanks, Jan Schlicht

Review Request 66904: Added 'Ninja' byproducts for jemalloc.

b7362d2be75e4de06092f16698a784b7a78994cb Diff: https://reviews.apache.org/r/66904/diff/1/ Testing --- Ran ``` mkdir build && cd build && cmake -G Ninja -D ENABLE_JEMALLOC_ALLOCATOR=ON && ninja ``` and checked that `jemalloc` third-party dependency is build. Thanks, Jan Schlicht

Re: Review Request 66931: Fixed a race in resource provider resubscription test.

await that one before we reset `resourceProvider` with a new instance. - Jan Schlicht On May 3, 2018, 1:46 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 66933: Added a flag for resource provider authentication.

6ca3d79fd38c800f258c571bb58164427db2ac7c src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 Diff: https://reviews.apache.org/r/66933/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 66934: Removed credential-based authentication of 'MockResourceProvider'.

://reviews.apache.org/r/66934/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 66932: Adden token based authentication for resource providers.

, Jan Schlicht

Re: Review Request 63107: Added operation feedback for storage operations.

_provider/message.hpp Line 36 (original), 37 (patched) <https://reviews.apache.org/r/63107/#comment265825> I'll rebase on https://reviews.apache.org/r/62903/, it'll be `UPDATE_STATE` then. - Jan Schlicht On Oct. 18, 2017, 4:39 p.m., Jan

Re: Review Request 64805: Changed 'ConstantEndpointDetector' to have value semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64805/#review194850 --- Ship it! Ship It! - Jan Schlicht On Dec. 22, 2017, 2:36 p.m

Review Request 65045: Tested correct operation handling during master failover.

Description --- Tested correct operation handling during master failover. Diffs - src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e Diff: https://reviews.apache.org/r/65045/diff/1/ Testing --- make check Thanks, Jan Schlicht

Review Request 65043: Moved agent response code into 'protobuf_utils.cpp'.

--- make check Thanks, Jan Schlicht

Review Request 65044: Added the list of operations to the 'GET_AGENTS' response.

fda13072743d57d29cdf7ac3c76c0d42a8d36116 Diff: https://reviews.apache.org/r/65044/diff/1/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 65044: Added the list of operations to the 'GET_AGENTS' response.

://reviews.apache.org/r/65044/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 Diff: https://reviews.apache.org/r/65044/diff/3/ Changes: https://reviews.apache.org/r/65044/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 65045: Tested correct operation handling during master failover.

/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 Diff: https://reviews.apache.org/r/65045/diff/3/ Changes: https://reviews.apache.org/r/65045/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

ps://reviews.apache.org/r/65044/#review195544 ------- On Jan. 18, 2018, 3:10 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65044/ > -

Re: Review Request 65126: Added a resource provider test case.

0edf22431aad85945aeb808a05f11e0bd832bccf Diff: https://reviews.apache.org/r/65126/diff/2/ Changes: https://reviews.apache.org/r/65126/diff/1-2/ Testing --- make check Thanks, Jan Schlicht

Re: Review Request 65126: Added a resource provider test case.

hat it's about `UpdateSlaveMessage`. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65126/#review195412 ------- On Jan. 16, 2018, 12:04 p.m., Jan Schlicht wrote: > > ---

Re: Review Request 65045: Tested correct operation handling during master failover.

eviews.apache.org/r/65045/#review195415 ------- On Jan. 16, 2018, 2:45 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

check Thanks, Jan Schlicht

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195927 ------- On Jan. 22, 2018, 3:02 p.m., Jan Schlicht wrote: > > --- > Thi

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

ts, why exaclty do > > we need it here? > > Jan Schlicht wrote: > The allocation interval is set to 1000s in the test fixture to avoid a > race. This is a problem in this particular test case as it is the only one in > this fixture that runs a framework and needs to get

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

wise, no longer changing the allocation interval here. - Jan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195914 ------- On

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

check Thanks, Jan Schlicht

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

. It usually takes a few thousand iterations to trigger the flakyness in the old code. And only when the host is under heavy load. Thanks, Jan Schlicht

Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

=MasterTest.UpdateSlaveMessageWithPendingOffers --gtest_repeat=1 --gtest_break_on_failure` while running `stress -c 4 -i 8 -m 2 -d 6` on a 4 core machine. It usually takes a few thousand iterations to trigger the flakyness in the old code. And only when the host is under heavy load. Thanks, Jan

Re: Review Request 65125: Added a helper function for resource provider tests.

/ Changes: https://reviews.apache.org/r/65125/diff/2-3/ Testing --- make check Thanks, Jan Schlicht

<    3   4   5   6   7   8   9   10   >