56bcbcc08fa0f98416c5048080adb25efc588019
src/tests/master_maintenance_tests.cpp
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37623/diff/
Testing
---
Thanks,
Joris Van Remoortere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38061/#review97733
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 2, 2015, 4:34
ines 232 - 233)
<https://reviews.apache.org/r/37336/#comment154083>
indent by 2, not 4. Elsewhere as well.
3rdparty/libprocess/src/subprocess.cpp (lines 239 - 240)
<https://reviews.apache.org/r/37336/#comment154084>
I would leave a space before the return.
- Joris Van Remoort
,
Joris Van Remoortere
://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp
85466dbb36b3ac545562eafe8041ad79993fdf9f
Diff: https://reviews.apache.org/r/38171/diff/
Testing
---
Thanks,
Joris Van
://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp
1839d28638cd82dae10ba9b0f99c1a97cf34f9c9
Diff: https://reviews.apache.org/r/38172/diff/
Testing
---
Thanks,
Joris Van
1839d28638cd82dae10ba9b0f99c1a97cf34f9c9
Diff: https://reviews.apache.org/r/38172/diff/
Testing
---
Thanks,
Joris Van Remoortere
: https://reviews.apache.org/r/38173/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
make any changes required in the chain to stay
consistent.
- Joris Van Remoortere
On Sept. 9, 2015, 4:02 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37878/#review98212
---
Ship it!
- Joris Van Remoortere
On Sept. 9, 2015, 4:01 p.m
nt154519>
let's use backticks ```
3rdparty/libprocess/src/process.cpp (line 1023)
<https://reviews.apache.org/r/37877/#comment154511>
nice catch.
3rdparty/libprocess/src/process.cpp (line 2826)
<https://reviews.apache.org/r/37877/#
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38028/#review98281
---
Ship it!
- Joris Van Remoortere
On Sept. 9, 2015, 10:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38030/#review98279
---
Ship it!
- Joris Van Remoortere
On Sept. 9, 2015, 10:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38076/#review98285
---
Ship it!
- Joris Van Remoortere
On Sept. 9, 2015, 10:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review98288
---
Ship it!
- Joris Van Remoortere
On Sept. 9, 2015, 10:20 p.m
dparty/stout/include/stout/json.hpp (line 547)
<https://reviews.apache.org/r/38031/#comment154621>
Should we initialize this like this?
```
char buffer[50] {};
```
- Joris Van Remoortere
On Sept. 9, 2015, 10:20 p.m., Joseph Wu wrote:
>
> -
n automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37032/
> ---
>
> (Updated Sept. 10, 2015, 7:36 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van
> Remoortere, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37370/#review98506
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 10, 2015, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38265/#review98519
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 10, 2015, 6
tps://reviews.apache.org/r/37877/#comment155021>
renaming these to `expected`
3rdparty/libprocess/src/process.cpp (line 951)
<https://reviews.apache.org/r/37877/#comment155023>
substituting the triple backticks to single backticks. sorry for the
confusion.
- Joris Van Remoortere
On Sept.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38282/#review98523
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 11, 2015, 12
Toenshoff.
Repository: mesos
Description
---
See summary.
Diffs
-
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
ebf8cd656625b7fd414cacaa87f156c95df29438
Diff: https://reviews.apache.org/r/38305/diff/
Testing
---
make check
Thanks,
Joris Van Remoortere
---
make check with and without ssl enabled.
Thanks,
Joris Van Remoortere
docker provisioner test.
Thanks,
Joris Van Remoortere
/src/tests/time_tests.cpp
60791ff20671859a0da91524ae8e40ff52c907d0
3rdparty/libprocess/src/tests/timeseries_tests.cpp
ec6f4868a65b89244fb4bb8234a77c87831863c3
Diff: https://reviews.apache.org/r/38307/diff/
Testing
---
make check.
Thanks,
Joris Van Remoortere
ris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38305/#review98628
-----------
On Sept. 11, 2015, 5:09 p.m., Joris Van Remoortere wrote:
>
> --
mment to make this more clear.
Thanks!
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review97884
---
On Sept. 2, 2015,
dfab4971e04a81ac98ed118ea877bcca5db17bb5
src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b
src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5
Diff: https://reviews.apache.org/r/37173/diff/
Testing
---
Thanks,
Joris Van Remoortere
c90311fa2152810e7604a0a2dee630bd14929574
Diff: https://reviews.apache.org/r/37170/diff/
Testing
---
Thanks,
Joris Van Remoortere
c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37172/diff/
Testing
---
Thanks,
Joris Van Remoortere
/sorter/drf/sorter.cpp
bfc273493419fe46a4d907f4f7fa282cff71b800
src/master/allocator/sorter/sorter.hpp
536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04
Diff: https://reviews.apache.org/r/37176/diff/
Testing
---
Thanks,
Joris Van Remoortere
6aae14a3c39b9aee76147b691b0170946e1120b5
Diff: https://reviews.apache.org/r/37177/diff/
Testing
---
Thanks,
Joris Van Remoortere
c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
Diff: https://reviews.apache.org/r/37175/diff/
Testing
---
Thanks,
Joris Van Remoortere
/scheduler/scheduler.proto
bd5e82a614b1163b29f9b20e562208efa1ba4b55
Diff: https://reviews.apache.org/r/37178/diff/
Testing
---
Thanks,
Joris Van Remoortere
---
Thanks,
Joris Van Remoortere
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37622/diff/
Testing
---
Thanks,
Joris Van Remoortere
/diff/
Testing
---
Thanks,
Joris Van Remoortere
/diff/
Testing
---
Thanks,
Joris Van Remoortere
/allocator.hpp
aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp
fbf353d8bdd4322275057e392a958fca77ecd8b3
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
Diff: https://reviews.apache.org/r/37280/diff/
Testing
---
Thanks,
Joris Van
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37621/diff/
Testing
---
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/37283/diff/
Testing
---
Thanks,
Joris Van Remoortere
c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37623/diff/
Testing
---
Thanks,
Joris Van Remoortere
c90311fa2152810e7604a0a2dee630bd14929574
Diff: https://reviews.apache.org/r/37180/diff/
Testing
---
The tests break as expected.
With the scheduler API change there are CHECKs that fail.
Once we update the API these will be resolved.
Thanks,
Joris Van Remoortere
https://reviews.apache.org/r/37175/#review97527
-------
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-ma
place(name, resources.get());
> > }
> > }
Added a comment, as per our discussion offline.
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/#review98320
-
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review97073
---
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> --
--
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37283/
>
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
Diff: https://reviews.apache.org/r/37170/diff/
Testing
---
Thanks,
Joris Van Remoortere
---
Thanks,
Joris Van Remoortere
---
Thanks,
Joris Van Remoortere
c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
Diff: https://reviews.apache.org/r/37175/diff/
Testing
---
Thanks,
Joris Van Remoortere
. To reply, visit:
https://reviews.apache.org/r/37175/#review98790
-------
On Sept. 14, 2015, 12:46 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e
/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5
Diff: https://reviews.apache.org/r/37177/diff/
Testing
---
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/37282/diff/
Testing
---
Thanks,
Joris Van Remoortere
---
Thanks,
Joris Van Remoortere
reply, visit:
https://reviews.apache.org/r/37180/#review97064
-----------
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37180/
&g
Diff: https://reviews.apache.org/r/37284/diff/
Testing
---
Thanks,
Joris Van Remoortere
ixed in updated review.
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98792
---
On Sept. 13, 2015, 8:34
fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37622/diff/
Testing
---
Thanks,
Joris Van Remoortere
Van Remoortere
JIRA MESOS-3420 to discuss
the semantics further.
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98806
----------
38031/#comment155600>
Can you add a comment here and below where the behavior isn't quite a
"dummy" equality check?
It is easy to glance over what you are doing here.
- Joris Van Remoortere
On Sept. 11, 2015, 5:42 p.m., Joseph Wu wrote:
>
>
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38031/
> ---
>
> (Updated Sept. 15, 2015, 5:24 p.m.)
>
>
> Review request for mesos,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review99555
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 15, 2015, 12
/#comment156512>
Fits on 1 line.
- Joris Van Remoortere
On Sept. 16, 2015, 7:38 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
mework that has:
(1) tasks running
(2) reserved resources
(3) offered resources
- Joris Van Remoortere
On Sept. 18, 2015, 8:29 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
commit this.
- Joris Van Remoortere
On Sept. 17, 2015, 10:02 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
contributors to start working on
windows support, and that eventually this will be refactored more.
- Joris Van Remoortere
On Sept. 17, 2015, 10:03 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To rep
pache.org/r/38251/
> ---
>
> (Updated Sept. 14, 2015, 2:19 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Bugs: MESOS-3169
> https://issues.apache.org/jira/browse/MESOS-3169
>
>
> Repository: mesos
>
>
> Descript
navailableResources to filter.
src/master/allocator/mesos/hierarchical.hpp (line 1335)
<https://reviews.apache.org/r/38324/#comment156659>
new line
src/master/allocator/mesos/hierarchical.hpp (lines 1401 - 1402)
<https://reviews.apache.org/r/38324/#comme
.hpp (line 1311)
<https://reviews.apache.org/r/38244/#comment156647>
we can add a new line here.
src/master/allocator/mesos/hierarchical.hpp
<https://reviews.apache.org/r/38244/#comment156646>
no need to remove this.
tps://reviews.apache.org/r/38246/#comment156651>
Let's clarify why unavailableResources is added here.
include/mesos/master/allocator.hpp (line 160)
<https://reviews.apache.org/r/38246/#comment156650>
typo
- Joris Van Remoortere
On Sept. 18, 2015, 10:55 p.m., Artem
/#comment156691>
Let's make sure both slaves register before we schedule the machine for
maintenance mode.
- Joris Van Remoortere
On Sept. 19, 2015, 6:14 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically g
)
<https://reviews.apache.org/r/37585/#comment156695>
It wasn't clear at first what you meant by "this is not allowed", as you
are stating a rule above.
- Joris Van Remoortere
On Sept. 19, 2015, 1:27 a.m., Joseph Wu wrote:
>
> ---
f6112c98ffcc46ebcaf5581e821d5481d2f6b494
src/slave/containerizer/linux_launcher.cpp
fd0ffcf838a745ccd458d57821d358eceb85be26
Diff: https://reviews.apache.org/r/38634/diff/
Testing
---
Thanks,
Joris Van Remoortere
/containerizer/linux_launcher.cpp
fd0ffcf838a745ccd458d57821d358eceb85be26
Diff: https://reviews.apache.org/r/38635/diff/
Testing
---
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/38636/diff/
Testing
---
Thanks,
Joris Van Remoortere
://reviews.apache.org/r/38637/diff/
Testing
---
make check
on ubuntu 15.04 with systemd 219 verified that pids get assigned to the
`mesos_executor.slice`, and operator is warned about lack of proper resource
isolation upon recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38632/#review100032
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 22, 2015, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38568/#review100065
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 22, 2015, 6
ly generated e-mail. To reply, visit:
https://reviews.apache.org/r/38635/#review100109
-------
On Sept. 22, 2015, 5:29 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an auto
src/slave/containerizer/linux_launcher.cpp
fd0ffcf838a745ccd458d57821d358eceb85be26
Diff: https://reviews.apache.org/r/38636/diff/
Testing
---
Thanks,
Joris Van Remoortere
s.hpp e31a4183170c3442ac4a15365c229391e7e91480
src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f
Diff: https://reviews.apache.org/r/38635/diff/
Testing
---
Thanks,
Joris Van Remoortere
roper resource
isolation upon recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van Remoortere
rizer/linux_launcher.cpp
fd0ffcf838a745ccd458d57821d358eceb85be26
Diff: https://reviews.apache.org/r/38634/diff/
Testing
---
Thanks,
Joris Van Remoortere
-
>
> (Updated Sept. 22, 2015, 8:55 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till
> Toenshoff.
>
>
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
>
>
> Repository: mesos
>
>
>
g/r/38653/#comment157253>
new line after we wrap the previous
same below.
- Joris Van Remoortere
On Sept. 22, 2015, 11:24 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
with Kapil. LGTM. Thank you for enabling a test
again :-)
- Joris Van Remoortere
On Sept. 21, 2015, 10:38 p.m., Niklas Nielsen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
459af1b98ba577863d88d521f3ba8792959f42b4
Diff: https://reviews.apache.org/r/38634/diff/
Testing
---
Thanks,
Joris Van Remoortere
add4196dfd06c0f602ff5ebd39960dc05c4cd11f
Diff: https://reviews.apache.org/r/38635/diff/
Testing
---
Thanks,
Joris Van Remoortere
recovery if the executor pid is no longer in the slice.
Thanks,
Joris Van Remoortere
/linux_launcher.cpp
459af1b98ba577863d88d521f3ba8792959f42b4
Diff: https://reviews.apache.org/r/38636/diff/
Testing
---
Thanks,
Joris Van Remoortere
ed the detection logic.
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38634/#review100120
---
On Sept. 23, 2015, 8:34
start?
Next patch :-)
- Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38634/#review100168
---
On Sept. 23, 2015, 8:34
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38635/#review100171
---
On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100287
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 23, 2015, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/#review100308
---
Ship it!
Ship It!
- Joris Van Remoortere
On Sept. 23, 2015, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38634/#review100168
-----------
On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
>
: https://reviews.apache.org/r/38634/diff/
Testing
---
Thanks,
Joris Van Remoortere
mail. To reply, visit:
https://reviews.apache.org/r/38635/#review100306
-----------
On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> ---
> This is an automatically generat
501 - 600 of 1678 matches
Mail list logo
