Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 16 > > <https://reviews.apache.org/r/45668/diff/2/?file=1328041#file1328041line16> > > > > the previous version was working fine on ubuntu and centos. why the &g

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127912 ------- On Abr. 8, 2016, 10:41 p.m., Juan Larriba wrote: > > --- > Thi

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
r_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d Diff: https://reviews.apache.org/r/45668/diff/ Testing --- Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-09 Thread Juan Larriba
lly generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127944 ------- On Abr. 8, 2016, 11:26 p.m., Juan Larriba wrote: > > --- > This is an aut

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review127677 ------- On Abr. 6, 2016, 3:49 p.m., Juan Larriba wrote: > > --- >

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
e9b1d7219b261475fb29118ee27d11743c2c5e0d Diff: https://reviews.apache.org/r/45668/diff/ Testing --- Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-08 Thread Juan Larriba
/diff/ Testing --- Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-06 Thread Juan Larriba
using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45361: Remove rmdir_tests.cpp from CMake Windows build

2016-03-27 Thread Juan Larriba
iff: https://reviews.apache.org/r/45361/diff/ Testing --- Correctly built mesos agent on Windows with CMake. Thanks, Juan Larriba

Re: Review Request 45656: Enable CMake build for Linux

2016-04-03 Thread Juan Larriba
mesos both on ubuntu:14.04 and on centos:7 Thanks, Juan Larriba

Review Request 45656: Enable CMake build for Linux

2016-04-03 Thread Juan Larriba
on ubuntu:14.04 and on centos:7 Thanks, Juan Larriba

Re: Review Request 45656: Enable CMake build for Linux

2016-04-03 Thread Juan Larriba
mesos both on ubuntu:14.04 and on centos:7 Thanks, Juan Larriba

Re: Review Request 45656: Enable CMake build for Linux

2016-04-03 Thread Juan Larriba
mesos both on ubuntu:14.04 and on centos:7 Thanks, Juan Larriba

Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

2016-04-04 Thread Juan Larriba
, Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

2016-04-04 Thread Juan Larriba
docker_build.sh on both centos:7 and ubuntu:14.04 Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

2016-04-04 Thread Juan Larriba
I will and modify the testing done field. - Juan ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review126819

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-13 Thread Juan Larriba
ink specifying configuration options this way doesn't work with > > cmake. > > > > Not sure what the right way is. cc @hausdorff > > Juan Larriba wrote: > export CONFIGURATION='-DVERBOSE="1"' > > Vinod Kone wrote: > We need to ma

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-25 Thread Juan Larriba
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review129387 --- On Abr. 18, 2016, 1:58 p.m., Juan Larriba wrote: > >

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-04-26 Thread Juan Larriba
r Mesos w/ CMake); was just hoping > > we could get away with having just one Jenkins job (parameterized). > > Juan Larriba wrote: > I will try to submit a more generic proposal to convert from autotools to > cmake parameters so the same Jenkins job can be used for building, I have had

Re: Review Request 45668: Enable CMake build.

2016-05-22 Thread Juan Larriba
28ef4dce3f473adab9919d4c2170075a0900af41 Diff: https://reviews.apache.org/r/45668/diff/ Testing --- Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build

2016-05-22 Thread Juan Larriba
gt; # Remove "'". > > CONFIGURATION=${CONFIGURATION//\'/} I have always used a variable. Nice to note that it can be done directly inline. - Juan --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 45668: Enable CMake build

2016-05-22 Thread Juan Larriba
: https://reviews.apache.org/r/45668/diff/ Testing --- Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build.

2016-05-22 Thread Juan Larriba
> > # Replace "--" with "-D". > > CONFIGURATION=${CONFIGURATION//--/-D} > > Juan Larriba wrote: > We have just replaced all "-" with "_" in the previous step. > > Vinod Kone wrote: > I see. Lets do &qu

Re: Review Request 45668: Enable CMake build

2016-05-22 Thread Juan Larriba
and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build.

2016-05-24 Thread Juan Larriba
/45668/diff/ Testing --- Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-05-12 Thread Juan Larriba
r Mesos w/ CMake); was just hoping > > we could get away with having just one Jenkins job (parameterized). > > Juan Larriba wrote: > I will try to submit a more generic proposal to convert from autotools to > cmake parameters so the same Jenkins job can be used for building, I have had

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

2016-04-18 Thread Juan Larriba
://reviews.apache.org/r/45668/diff/ Testing --- Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc. Thanks, Juan Larriba