/paths.hpp
c0fe2a4ae8d8b6de24ab265d483d3edc11c68a0e
src/slave/containerizer/mesos/paths.cpp
e090392ed079993968f8664d89ad6c49eca3f3c4
Diff: https://reviews.apache.org/r/54401/diff/
Testing
---
GTEST_FILTER-"" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
w-on patch.
Thanks,
Kevin Klues
="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
patch.
Thanks,
Kevin Klues
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54355/#review158121
-------
On Dec. 6, 2016, 4:55 a.m., Kevin Klues wrote:
>
> ---
> This is an
The real test is encapsulated in https://reviews.apache.org/r/54367
Thanks,
Kevin Klues
://reviews.apache.org/r/54441/diff/
Testing
---
make check
Thanks,
Kevin Klues
ed in follow-on patch.
Thanks,
Kevin Klues
://reviews.apache.org/r/54442/diff/
Testing
---
make check
The real test is encapsulated in https://reviews.apache.org/r/54367
Thanks,
Kevin Klues
/containerizer/mesos/io/switchboard.cpp
19f2b625f2aa4b790fbe80b8dfad44b219f2c24e
Diff: https://reviews.apache.org/r/54441/diff/
Testing
---
make check
Thanks,
Kevin Klues
aff6c2150bfe8086fd51b548cb6339acc23f78c9
Diff: https://reviews.apache.org/r/54442/diff/
Testing
---
make check
The real test is encapsulated in https://reviews.apache.org/r/54367
Thanks,
Kevin Klues
aff6c2150bfe8086fd51b548cb6339acc23f78c9
Diff: https://reviews.apache.org/r/54442/diff/
Testing
---
make check
The real test is encapsulated in https://reviews.apache.org/r/54367
Thanks,
Kevin Klues
aff6c2150bfe8086fd51b548cb6339acc23f78c9
Diff: https://reviews.apache.org/r/54442/diff/
Testing
---
make check
The real test is encapsulated in https://reviews.apache.org/r/54367
Thanks,
Kevin Klues
d.cpp
0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6
src/tests/containerizer/io_switchboard_tests.cpp
c8fe8768db705d97299215ab69b91babb8bbc2f9
Diff: https://reviews.apache.org/r/54356/diff/
Testing
---
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
os/io/switchboard.hpp
839665a22aca9b1c1c1cf4992406bc924ee2b065
src/slave/containerizer/mesos/io/switchboard.cpp
0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6
Diff: https://reviews.apache.org/r/54441/diff/
Testing
---
make check
Thanks,
Kevin Klues
src/slave/containerizer/mesos/io/switchboard_main.cpp
aff6c2150bfe8086fd51b548cb6339acc23f78c9
Diff: https://reviews.apache.org/r/54442/diff/
Testing
---
make check
The real test is encapsulated in https://reviews.apache.org/r/54367
Thanks,
Kevin Klues
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*RecoverThenKillSwitchboardContainerDestroyed*" src/mesos-tests
Thanks,
Kevin Klues
://reviews.apache.org/r/54368/diff/
Testing
---
Tested in subsequent patch.
Thanks,
Kevin Klues
do GTEST_FILTER="*DestroyDebugContainerOnRecover*" src/mesos-tests
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54432/#review158273
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 6, 2016, 6:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54433/#review158274
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 6, 2016, 6:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54434/#review158277
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 6, 2016, 6:44 p.m
/54465/diff/
Testing
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
/mesos/io/switchboard_main.cpp
6ce4cdb08e3e15eda21dcb740c4390613a88f5c5
Diff: https://reviews.apache.org/r/54465/diff/
Testing
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
Diff: https://reviews.apache.org/r/54465/diff/
Testing
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
-
>
> (Updated Dec. 7, 2016, 5:21 a.m.)
>
>
> Review request for mesos, Kevin Klues and Vinod Kone.
>
>
> Bugs: MESOS-6737
> https://issues.apache.org/jira/browse/MESOS-6737
>
>
> Repository: mesos
>
>
> Description
> ---
>
/switchboard_main.cpp
4a9ed22ca63f0aa55ebbf7b85404a1b168a8e34a
Diff: https://reviews.apache.org/r/54486/diff/
Testing
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54487/#review158383
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 7, 2016, 7:28 p.m
/switchboard.cpp (line 1102)
<https://reviews.apache.org/r/54496/#comment229152>
We never launch the io switchboard process with vlog turned on, so we may
never see this log. But it doesn't hurt to have during debugging.
- Kevin Klues
On Dec. 7, 2016, 8:15 p.m., Anand Maz
/switchboard.cpp (line 792)
<https://reviews.apache.org/r/54506/#comment229217>
s/destoryed/destroyed
src/slave/containerizer/mesos/io/switchboard.cpp (line 799)
<https://reviews.apache.org/r/54506/#comment229218>
s/serer/server/
- Kevin Klues
On Dec. 7, 2016, 11:35 p.m.,
- 3780)
<https://reviews.apache.org/r/54281/#comment229238>
Small nit, but could you put the strings above the `Call` declaration to
keep the call declaration and its field assignments all grouped together?
- Kevin Klues
On Dec. 7, 2016, 7:19 p.m., Vinod Kone
;https://reviews.apache.org/r/54518/#comment229248>
Do you mean:
```
if (WIFEXITED(status.get()) && WEXITSTATUS(status.get()) == 0)
```
src/slave/containerizer/mesos/io/switchboard.cpp (line 834)
<https://reviews.apache.org/r/54518/#comment229249>
s/is/if/
- Ke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54518/#review158489
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 8, 2016, 1:46 a.m
---
The io switchboard itself enforces that it is always set to false.
Diffs
-
src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3
Diff: https://reviews.apache.org/r/54559/diff/
Testing
---
Thanks,
Kevin Klues
, committing the tests and running them in the standard way would break the
build currently.
Thanks,
Kevin Klues
s-tests
GTEST_FILTER="*ReceiveHeartbeat*" src/mesos-tests
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54562/#review158620
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 9, 2016, 1:24 a.m
er this to Jie. I am indifferent. What do you think?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54560/#review158616
--
https://reviews.apache.org/r/54560/diff/
Testing
---
Tests in subsequent patch. Because of a pending unix domain socket reconnect
bug, committing the tests and running them in the standard way would break the
build currently.
Thanks,
Kevin Klues
causes two tests in the second test to fail if
run in the same process as the first.
GTEST_FILTER="*SendHeartbeat*" src/mesos-tests
GTEST_FILTER="*ReceiveHeartbeat*" src/mesos-tests
Thanks,
Kevin Klues
to
explicitly set 'kind' to 'POLL' in the 'Socket::create()' call.
Diffs
-
3rdparty/libprocess/src/http.cpp c0eaeff28ea5005d4dfae32118cb8e0f5e650a67
Diff: https://reviews.apache.org/r/54627/diff/
Testing
---
../configure --enable-ssl --enable-libevent
GTEST_FILTER="" make -j check
src/mesos-tests
Thanks,
Kevin Klues
TER-"" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
s.apache.org/r/54620/#comment229578>
Maybe this belongs in a separate patch, but we should only close stdinFd
here if we are not a pty.
- Kevin Klues
On Dec. 10, 2016, 5:08 a.m., Vinod Kone wrote:
>
> ---
> This is an auto
ly, visit:
https://reviews.apache.org/r/54627/#review158778
---
On Dec. 10, 2016, 6:29 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically gen
/diff/
Testing
---
GTEST_FILTER="" make -j check
GTEST_FILTER="AgentAPIStreamingTest.AttachInputToNestedContainerSession*"
src/mesos-tests
Thanks,
Kevin Klues
: https://reviews.apache.org/r/54632/diff/
Testing (updated)
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*AgentAPIStreamingTest.AttachInputToNestedContainerSession*"
src/mesos-tests
Thanks,
Kevin Klues
---
GTEST_FILTER="" make -j 40 check
Thanks,
Kevin Klues
---
Tests in subsequent patch. Because of a pending unix domain socket reconnect
bug, committing the tests and running them in the standard way would break the
build currently.
Thanks,
Kevin Klues
74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3
Diff: https://reviews.apache.org/r/54630/diff/
Testing
---
GTEST_FILTER="" make -j 40 check
Thanks,
Kevin Klues
> On Dec. 10, 2016, 10:36 p.m., Kevin Klues wrote:
> > src/slave/containerizer/mesos/io/switchboard.hpp, line 155
> > <https://reviews.apache.org/r/54620/diff/1/?file=1581300#file1581300line155>
> >
> > Shouldn't this be called `isEnabled()`. When I
; make -j check
src/mesos-tests
sudo src/mesos-tests
Thanks,
Kevin Klues
j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/#review158816
---
Ship it!
Do we know why the build failed?
- Kevin Klues
On
hboard.cpp
a354188a3656b5c2fd797b214f6c02714d70ce2c
src/tests/containerizer/io_switchboard_tests.cpp
ecadeee179fc2a22967b324928bfb11e140a6987
Diff: https://reviews.apache.org/r/54628/diff/
Testing
---
GTEST_FILTER-"" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
ws.apache.org/r/54627/diff/
Testing
---
../configure --enable-ssl --enable-libevent
GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests
../configure
GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests
Thanks,
Kevin Klues
the second test to fail if
run in the same process as the first.
GTEST_FILTER="*SendHeartbeat*" src/mesos-tests
GTEST_FILTER="*ReceiveHeartbeat*" src/mesos-tests
Thanks,
Kevin Klues
quot; src/mesos-tests
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54673/#review158895
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 12, 2016, 7:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54671/#review158896
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 12, 2016, 7:21 p.m
s.hpp 3c292bac9394347318865f49782907def6541742
src/slave/flags.cpp a5f5203320ba6657c0a1573447a8ee002172614b
Diff: https://reviews.apache.org/r/54630/diff/
Testing
---
GTEST_FILTER="" make -j 40 check
Thanks,
Kevin Klues
run in the same process as the first.
GTEST_FILTER="*SendHeartbeat*" src/mesos-tests
GTEST_FILTER="*ReceiveHeartbeat*" src/mesos-tests
Thanks,
Kevin Klues
everything passed).
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54561/#review158899
---
On Dec. 12, 2016,
org/r/54681/#comment229768>
Given these new semantics, I would probably print the whole usage string
and list the exact set of flags that were missing.
As it is written now, it wouldn't be obvious that a flag was missing.
- Kevin Klues
On Dec. 12, 2016, 11:43 p.m., J
fix it once we add a
proper dependency check?
- Kevin Klues
On Dec. 12, 2016, 11:42 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54683/#review158930
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 12, 2016, 11:43 p.m
nice to print all missing flags
at once though so that you don't have to run it mutliple times to catch all of
the missing flags. I think it's fine for now though.
- Kevin Klues
On Dec. 13, 2016, 12:11 a.m., Jie Yu wrote:
>
> ---
/switchboard.hpp (lines 81 - 99)
<https://reviews.apache.org/r/54686/#comment229784>
Is there a reason not to put the implementation of this in the .cpp file?
Seems weird to have all other functions defined in the cpp file, but define
this one in the header.
- Kevin Klues
On Dec. 13, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54687/#review158945
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 13, 2016, 1:10 a.m
a TTY client to make sure the window resized properly.
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54727/#review159084
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 14, 2016, 12:46 a.m
che.org/r/54720/#comment230040>
Wait until slvae recovered? Your future is on `slave::Slave::_recover`
- Kevin Klues
On Dec. 13, 2016, 10:20 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To
> On Dec. 14, 2016, 1:10 a.m., Kevin Klues wrote:
> > src/tests/containerizer/io_switchboard_tests.cpp, line 809
> > <https://reviews.apache.org/r/54720/diff/1/?file=1583056#file1583056line809>
> >
> > I think you need the new:
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54720/
> -------
>
> (Updated Dec. 13, 2016, 10:20 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Kevin Klues.
>
>
> Repository: mesos
>
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54731/#review159109
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 14, 2016, 4:15 a.m
re
> any plan to fix these?
>
> Jie Yu wrote:
> Yes. I'll fix those. thanks!
Should this be closed now?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54486/#review158513
-
/io_switchboard_tests.cpp
5bd9dc4a776fe8a0d04ed31aa167f10c394984e6
Diff: https://reviews.apache.org/r/54561/diff/
Testing (updated)
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
first time around when
implementing this? Should this be called "DEFAULT_BUFFERED_READ_SIZE"?
- Kevin Klues
On Dec. 17, 2016, 9:35 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To re
, but what values can be returned
to `ControlFlow`. I'm guessing `Break()`, `Continue()`, and `T`?
- Kevin Klues
On Dec. 17, 2016, 9:39 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To re
what's going on
with your change (plus we lose the discarded case).
- Kevin Klues
On Dec. 17, 2016, 9:40 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
for me to have
a simple build directive that we simply remove once of the rename is complete,
compared to a custom install-hook that creates a symlink.
- Kevin Klues
On Jan. 9, 2017, 8:02 p.m., James Peach wrote:
>
> ---
> T
> On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote:
> > What is the reason for this change? It seems much more intuitive for me to
> > have a simple build directive that we simply remove once of the rename is
> > complete, compared to a custom install-hook that creates a syml
s.apache.org/r/55355/#comment232239>
It's probably worth mentioning here why we grab a reference to the accept
(i.e. so that we can discard it in `finalize()` so that they FD associated with
the socket doesn't get leaked).
- Kevin Klues
On Jan. 9, 2017,
k
sudo src/mesos-tests
Thanks,
Kevin Klues
4b134f8420e1ef5cd139e0e4b8b08b1ff32e3a30
Diff: https://reviews.apache.org/r/55810/diff/
Testing
---
GTEST_FILTER="ContentType/AgentAPITest.LaunchNestedContainerSession/1"
src/mesos-tests --gtest_repeat=-1 --gtest_break_on_failure
Thanks,
Kevin Klues
on_failure
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55810/#review162684
-------
On Jan. 24, 2017, 10:45 p.m., Kevin Klues wrote:
>
> ---
--
src/slave/containerizer/mesos/containerizer.cpp
4f0a773676da45fa40ad1ad9cdfab2a19249247d
Diff: https://reviews.apache.org/r/56195/diff/
Testing
---
Tests still pending. WIll update when complete.
Thanks,
Kevin Klues
Ill update when complete.
Thanks,
Kevin Klues
9249247d
Diff: https://reviews.apache.org/r/56195/diff/
Testing
---
Tests still pending. WIll update when complete.
Thanks,
Kevin Klues
7 test cases ran. (390804 ms total)
[ PASSED ] 1477 tests.
```
Mac OS X (El Capitan)
```
GTEST_FILTER="" make -j check
src/mesos-tests
[ FAILED ] 3 tests, listed below:
[ FAILED ] ExamplesTest.V1JavaFramework
[ FAILED ] ExamplesTest.PythonFramework
```
Thanks,
Kevin Klues
)
<https://reviews.apache.org/r/49864/#comment206964>
I would probably pull this in from:
`using mesos::internal::slave::MESOS_CONTAINERIZER`
- Kevin Klues
On July 10, 2016, 6:28 a.m., Haris Choudhary wrote:
>
> -
Remount /run as 'noexec'
`GTEST_FILTER="*NVIDIA*" make -j check`
Ran a master/agent/execute set running 'nvidia-smi' both inside and outside a
docker container.
Both setups ran successfully.
Thanks,
Kevin Klues
on the proper error message.
Thanks,
Kevin Klues
olume.cpp
4b3651a8266b1ba193f6d207cd3be1ce55629703
Diff: https://reviews.apache.org/r/50592/diff/
Testing (updated)
---
Remount /run as 'noexec'
`GTEST_FILTER="*NVIDIA*" make -j check`
Also ran a master/agent/execute set running 'nvidia-smi' both inside and
outside a docker container.
Both setups ran successfully.
Thanks,
Kevin Klues
ate review: https://reviews.apache.org/r/50644/
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50592/#review144270
---
On July 2
at the agent
failed without root on the proper error message.
Thanks,
Kevin Klues
50671/diff/
Testing
---
GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests
Thanks,
Kevin Klues
/slave/containerizer/containerizer.cpp
d66356de06394fe5a006cbf1947d4f9055e6d111
Diff: https://reviews.apache.org/r/50672/diff/
Testing
---
GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests
Thanks,
Kevin Klues
Diff: https://reviews.apache.org/r/49736/diff/
Testing
---
$ cmake ..
$ make -j
$ make -j check
Manually inspected: `3rdparty/elfio-3.1/src/elfio-3.1/elfio/elfio_note.hpp`
and saw that the patch is applied.
Thanks,
Kevin Klues
k
src/mesos-tests
sudo src/mesos-tests
Appeared to have one unrelated flaky test fail:
`ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
Rerunning the tests a second time passed.
Thanks,
Kevin Klues
601 - 700 of 1353 matches
Mail list logo
