from:"Vinod Kone"

Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

2016-06-08 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48435/#review136705
---



same comments as previous review.

- Vinod Kone


On June 8, 2016, 6:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48435/
> ---
> 
> (Updated June 8, 2016, 6:26 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone.
> 
> 
> Bugs: MESOS-5572
> https://issues.apache.org/jira/browse/MESOS-5572
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed operator API RPC handlers to `http::Response` in agent.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp c4dfa8fdaa374b9c6b1e1a5ee8cb423bb2ece897 
>   src/slave/slave.hpp 52aeb0d3727ce89ac792fc7e7a4b88ca01d15cdd 
> 
> Diff: https://reviews.apache.org/r/48435/diff/
> 
> 
> Testing
> ---
> 
> Test by `./bin/mesos-tests.sh --gtest_filter="*AgentAPITest*"`
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48442: Removed redundant expectations for `disconnected` callbacks.

2016-06-08 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48442/#review136708
---


Ship it!




Can you add more details to the description on why `disconnected` callback is 
no longer called?

- Vinod Kone


On June 8, 2016, 7:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48442/
> ---
> 
> (Updated June 8, 2016, 7:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These expectations are no longer needed after MESOS-4029 since
> we now explicitly destroy the scheduler process in the `TestMesos`
> destructor. This ensures that there cannot be any unexpected
> callbacks thereafter. Also, fixed a wrong expectation in
> `Teardown` test. We explicitly close the socket now after
> https://reviews.apache.org/r/44729/
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
> 
> Diff: https://reviews.apache.org/r/48442/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=1000) no gmock warnings were generated
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

2016-06-08 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48381/#review136695
---


Fix it, then Ship it!





CHANGELOG 
<https://reviews.apache.org/r/48381/#comment201798>

Keep this. We are now including all issues (even those described up top) 
here.


- Vinod Kone


On June 7, 2016, 11:35 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48381/
> ---
> 
> (Updated June 7, 2016, 11:35 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated CHANGELOG for 'work_dir' flag changes.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 3f018a58b05c3110c72eab06928dc2d373c141fc 
> 
> Diff: https://reviews.apache.org/r/48381/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48437: Fixed `Subscribed` events to include heartbeat interval.

2016-06-08 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48437/#review136707
---




src/internal/evolve.cpp (line 173)
<https://reviews.apache.org/r/48437/#comment201821>

Can you add a TODO to have the master pass the heartbeat interval to the 
evolve function? Seems a bit unfortunate that evolve.cpp knows about master's 
logic.


- Vinod Kone


On June 8, 2016, 6:31 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48437/
> ---
> 
> (Updated June 8, 2016, 6:31 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5567
> https://issues.apache.org/jira/browse/MESOS-5567
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes modifies the `evolve` function to pass around
> the heartbeat interval info. This might need some tinkering
> if we decide to make heartbeat interval configurable in the
> near future.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
> 
> Diff: https://reviews.apache.org/r/48437/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

2016-06-08 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47700/#review136698
---


Ship it!




Ship It!

- Vinod Kone


On June 8, 2016, 5:36 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47700/
> ---
> 
> (Updated June 8, 2016, 5:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5222
> https://issues.apache.org/jira/browse/MESOS-5222
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a benchmark for measuring the time taken to
> reconcile a large number of unknown tasks using the scheduler
> library/driver.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
> 
> Diff: https://reviews.apache.org/r/47700/diff/
> 
> 
> Testing
> ---
> 
> make check (There is a 10x disrepancy between the library/driver. Would file 
> a followup JIRA for it)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48435/#review136818
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 2:01 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48435/
> ---
> 
> (Updated June 9, 2016, 2:01 a.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone.
> 
> 
> Bugs: MESOS-5572
> https://issues.apache.org/jira/browse/MESOS-5572
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed operator API RPC handlers to `http::Response` in agent.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp c4dfa8fdaa374b9c6b1e1a5ee8cb423bb2ece897 
>   src/slave/slave.hpp 52aeb0d3727ce89ac792fc7e7a4b88ca01d15cdd 
> 
> Diff: https://reviews.apache.org/r/48435/diff/
> 
> 
> Testing
> ---
> 
> Test by `./bin/mesos-tests.sh --gtest_filter="*AgentAPITest*"`
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48449: Add Task proto message to v1/mesos.proto.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48449/#review136821
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, midnight, Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48449/
> ---
> 
> (Updated June 9, 2016, midnight)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Task proto message to v1/mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
> 
> Diff: https://reviews.apache.org/r/48449/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48434: Changed operator API RPC handlers to `http::Response` in master.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48434/#review136817
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 2 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48434/
> ---
> 
> (Updated June 9, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone.
> 
> 
> Bugs: MESOS-5572
> https://issues.apache.org/jira/browse/MESOS-5572
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed operator API RPC handlers to `http::Response` in master.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
> 
> Diff: https://reviews.apache.org/r/48434/diff/
> 
> 
> Testing
> ---
> 
> Test by `./bin/mesos-tests.sh --gtest_filter="*MasterAPITest*"`
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48400: Extract task collection logic to helper function.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48400/#review136820
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, midnight, Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48400/
> ---
> 
> (Updated June 9, 2016, midnight)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a helper function _tasks() to collect tasks. This is
> to be used by both tasks() and getTasks() in operator API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
> 
> Diff: https://reviews.apache.org/r/48400/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48437: Fixed `Subscribed` events to include heartbeat interval.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48437/#review136814
---


Ship it!




Ship It!

- Vinod Kone


On June 8, 2016, 9:46 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48437/
> ---
> 
> (Updated June 8, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5567
> https://issues.apache.org/jira/browse/MESOS-5567
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes modifies the `evolve` function to pass around
> the heartbeat interval info. This might need some tinkering
> if we decide to make heartbeat interval configurable in the
> near future.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
>   src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c 
> 
> Diff: https://reviews.apache.org/r/48437/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48299: Updated balloon framework spacing and logging.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48299/#review136540
---


Fix it, then Ship it!





src/examples/balloon_framework.cpp (lines 52 - 53)
<https://reviews.apache.org/r/48299/#comment201601>

IIRC for constructors we use the format on the left.



src/examples/balloon_framework.cpp (line 173)
<https://reviews.apache.org/r/48299/#comment201602>

..lost on agent..


- Vinod Kone


On June 6, 2016, 11:51 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48299/
> ---
> 
> (Updated June 6, 2016, 11:51 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes some whitespace for the balloon framework and
> changes most logging messages to use glog.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
> 
> Diff: https://reviews.apache.org/r/48299/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review136542
---




src/examples/balloon_framework.cpp (lines 53 - 58)
<https://reviews.apache.org/r/45604/#comment201603>

don't need to do this anymore. flags now support required without default!



src/examples/balloon_framework.cpp (lines 66 - 69)
<https://reviews.apache.org/r/45604/#comment201604>

see above. don't need this.



src/examples/balloon_framework.cpp (lines 84 - 89)
<https://reviews.apache.org/r/45604/#comment201605>

ditto.



src/examples/balloon_framework.cpp (lines 119 - 121)
<https://reviews.apache.org/r/45604/#comment201606>

These need not be Option anymore.



src/examples/balloon_framework.cpp (line 183)
<https://reviews.apache.org/r/45604/#comment201608>

// If there is an active task, or ...


- Vinod Kone


On June 6, 2016, 11:55 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45604/
> ---
> 
> (Updated June 6, 2016, 11:55 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This gives the example `balloon-framework` enough options to run
> outside of the build environment:
> 
> * Adds an option for restricting the number of resources per task
>   (otherwise, it will eat up an entire node).
> * Adds an option for persisting the framework and launching one task
>   after another.
> * Adds filters for declined offers.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
>   src/tests/balloon_framework_test.sh 
> a242f6cb9ca1850e5fef90e0938f41044bdaddbf 
> 
> Diff: https://reviews.apache.org/r/45604/diff/
> 
> 
> Testing
> ---
> 
> ```
> make check 
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 48051: Expose livereload port in site docker.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48051/#review136536
---


Ship it!




Ship It!

- Vinod Kone


On May 31, 2016, 7:23 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48051/
> ---
> 
> (Updated May 31, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Kevin Klues, Neil Conway, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposing port 35729 is necessary to enable livereload
> provided by middleman-livereload gem.
> 
> 
> Diffs
> -
> 
>   site/Dockerfile 80e28e96be53909a8c3c1eb3c05dbbc7e698a5a5 
>   site/README.md 91bfd5fff16c7848431bdfc9206f42d18e102ace 
> 
> Diff: https://reviews.apache.org/r/48051/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu following instructions in` site/README.md`
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 48303: Split the balloon scheduler into a Process to support metrics.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48303/#review136546
---




src/examples/balloon_framework.cpp (line 139)
<https://reviews.apache.org/r/48303/#comment201617>

s/behaviors/behavior/ ?



src/examples/balloon_framework.cpp (line 231)
<https://reviews.apache.org/r/48303/#comment201618>

why this change?


- Vinod Kone


On June 7, 2016, 12:29 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48303/
> ---
> 
> (Updated June 7, 2016, 12:29 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `BalloonSchedulerProcess` which holds a subset of the `Scheduler`
> class's methods.  The `BalloonScheduler` dispatches to the process
> when for non-logging business logic.  This also opens up the balloon 
> framework for libprocess metrics.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
> 
> Diff: https://reviews.apache.org/r/48303/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 46407: Updated balloon executor.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46407/#review136538
---


Fix it, then Ship it!





src/examples/balloon_executor.cpp (line 143)
<https://reviews.apache.org/r/46407/#comment201598>

s/scheduler/executor/ ?



src/examples/balloon_executor.cpp (lines 152 - 156)
<https://reviews.apache.org/r/46407/#comment201600>

any particular reason TASK_RUNNING is sent by this thread instead of 
`thread`? because, as it currently stands, `thread` might theoretically send 
its update before this thread sends TASK_RUNNING.


- Vinod Kone


On June 6, 2016, 11:48 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46407/
> ---
> 
> (Updated June 6, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixes the logic in the example `balloon-executor` to work in cases not
> exercised by the `ROOT_CGROUPS_BalloonFramework` test.
> 
> * The "task" logic was moved into a separate thread.  This fixes the 
>   case where the balloon executor does not exceed the memory limit.
>   (i.e. by Unblocking the driver's thread while sending status updates.)
> * Changed log messages to use glog.
> * Added logic to prevent multiple task launches with the same executor.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 2a79c353e96930d25495732d15b83c82247974bb 
> 
> Diff: https://reviews.apache.org/r/46407/diff/
> 
> 
> Testing
> ---
> 
> See next review in this chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 45905: Added metrics to the balloon framework.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45905/#review136550
---


Fix it, then Ship it!





src/examples/balloon_framework.cpp (line 256)
<https://reviews.apache.org/r/45905/#comment201621>

s/allowed_terminations/launch_failures/ ?


- Vinod Kone


On June 7, 2016, 12:30 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45905/
> ---
> 
> (Updated June 7, 2016, 12:30 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds metrics to gauge the health of the framework.  This includes:
> 
> * uptime_secs = How long the framework has been running.
> * registered = If the framework is registered.
> * tasks_finished = Number of tasks finished (successfully).
> * tasks_oomed = Number of tasks that were OOM killed.
> * allowed_terminations = Number of terminal status updates which
>   are acceptable due to infrastructure reasons.
> * abnormal_terminations = Number of terminal status updates which 
>   were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
> 
> Diff: https://reviews.apache.org/r/45905/diff/
> 
> 
> Testing
> ---
> 
> ```
> make check
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> 
> # Also launched two instances on a cluster.
> # This one OOM's:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
> --balloon_limit=256MB --task_memory=128MB 
> --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor; 
> --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
> 
> # This one does not OOM:
> ./balloon-framework --master=zk://localhost:2181/mesos --checkpoint 
> --balloon_limit=256MB --task_memory=256MB 
> --executor_uri="https://s3.amazonaws.com/url/to/balloon-executor; 
> --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./balloon-executor"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 48264: Added test for optional request.object field.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48264/#review136259
---




src/tests/authorization_tests.cpp (line 2106)
<https://reviews.apache.org/r/48264/#comment201282>

what do you mean by "is only allowed for `ANY`"?

did you mean "matches an ACL whose Object is `ANY`" ?



src/tests/authorization_tests.cpp (line 2121)
<https://reviews.apache.org/r/48264/#comment201281>

s/principle/principal/


- Vinod Kone


On June 6, 2016, 8:19 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48264/
> ---
> 
> (Updated June 6, 2016, 8:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As MESOS-5405 changes the request.object
> field to optional. We need to check that it only
> matches an `ANY` ACL.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a 
> 
> Diff: https://reviews.apache.org/r/48264/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX) + repeat new test 100 times
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48267/#review136260
---




CHANGELOG (line 40)
<https://reviews.apache.org/r/48267/#comment201284>

s/these fields/any of these fields/ ?

I don't follow what you mean by "the request should be allowed only for 
ACLs with `ANY` semantics" ?


- Vinod Kone


On June 6, 2016, 9:54 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48267/
> ---
> 
> (Updated June 6, 2016, 9:54 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The changed semantic of the `Request` protobug message with
> MESOS-5405 should be added to the CHANGELOG.
> 
> 
> Diffs
> -
> 
>   CHANGELOG cbc1a037467c1bfeb1b499afcc8f6764b88bff58 
> 
> Diff: https://reviews.apache.org/r/48267/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48271: Used tense consistently in 1.0 Changelog.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48271/#review136261
---


Ship it!




Ship It!

- Vinod Kone


On June 6, 2016, 10:45 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48271/
> ---
> 
> (Updated June 6, 2016, 10:45 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used tense consistently in 1.0 Changelog.
> 
> 
> Diffs
> -
> 
>   CHANGELOG cbc1a037467c1bfeb1b499afcc8f6764b88bff58 
> 
> Diff: https://reviews.apache.org/r/48271/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48263: Fixed documentation for MESOS-5405.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48263/#review136266
---




docs/authorization.md (line 635)
<https://reviews.apache.org/r/48263/#comment201289>

Is there a place which lists for each of the actions which fields in Object 
will be set? If not, we should have it.


- Vinod Kone


On June 6, 2016, 8:22 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48263/
> ---
> 
> (Updated June 6, 2016, 8:22 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As MESOS-5405 changes the fields in `request` to optional,
> we need to update the documentation.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 189b70d7055c4605f87b537bd2c955f0383faab3 
> 
> Diff: https://reviews.apache.org/r/48263/diff/
> 
> 
> Testing
> ---
> 
> viewed documentation via gist: 
> https://gist.github.com/joerg84/0971f48b8ae88a335f88c1344d4cf180
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48272: Added 1.0 changed to upgraded.md.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48272/#review136258
---




docs/upgrades.md (line 50)
<https://reviews.apache.org/r/48272/#comment201280>

s/0-29-x/1-0-x/ ?



docs/upgrades.md (line 173)
<https://reviews.apache.org/r/48272/#comment201287>

This section seems like duplicate of what we have in CHANGELOG. What do you 
think about removing this text from here and just point the table entries above 
to CHANGELOG?


- Vinod Kone


On June 6, 2016, 10:46 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48272/
> ---
> 
> (Updated June 6, 2016, 10:46 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos 1.0 changed need to be reflected in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md be6db7d1c70e893bf74075db4658d92fb57cfa79 
> 
> Diff: https://reviews.apache.org/r/48272/diff/
> 
> 
> Testing
> ---
> 
> checked as gist: 
> https://gist.github.com/joerg84/2426fca01ef09bb4af6454afa28faa56
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48115: Added maintenance V1 header.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48115/#review136279
---


Ship it!




Ship It!

- Vinod Kone


On June 5, 2016, 5:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48115/
> ---
> 
> (Updated June 5, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5505
> https://issues.apache.org/jira/browse/MESOS-5505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added maintenance V1 header.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/maintenance/maintenance.hpp PRE-CREATION 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
> 
> Diff: https://reviews.apache.org/r/48115/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-06 Thread Vinod Kone



> On June 6, 2016, 4:30 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 2951
> > <https://reviews.apache.org/r/48116/diff/1/?file=1406733#file1406733line2951>
> >
> > why want this function to return `v1::master::Response` instead of 
> > `http::Response` to be consistent with how we did for others. since this 
> > response doesn't have a body, this could be an empty `v1::master::Response`.
> 
> haosdent huang wrote:
> Hi, @vinodkone, thank you very much for your review. According to the 
> design document, seems we need return `Accepted` here?
> 
> ```
> Example #2: Call with parameters but no return.
> 
> TEARDOWN_FRAMEWORK HTTP Request (JSON):
> POST /api/v1/  HTTP/1.1
> 
> Host: masterhost:5050
> Content-Type: application/json
> 
> {
>   “type”  : “TEARDOWN_FRAMEWORK”,
> 
>  “teardown_network” : {
> 
> “framework_id” : “1242352-1235235-1235235-235235”
>   
>   }
> }
> 
> TEARDOWN_FRAMEWORK HTTP Response:
> HTTP/1.1 202 Accepted
> ```

teardown happens asynchronously, so we send 202. afaict, updating of 
maintenance schedule is done before we return a response? if yes, that should 
be a 200? not sure why the original maintenance handler returned 202 in the 
first place. @kaysoky?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48116/#review136286
---


On June 5, 2016, 6 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48116/
> ---
> 
> (Updated June 5, 2016, 6 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5505
> https://issues.apache.org/jira/browse/MESOS-5505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/master/http.cpp 4fbf5638fb9ae8e7b28c21529d15735e46a85ffb 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
> 
> Diff: https://reviews.apache.org/r/48116/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48248: Fixed typos in comments and log messages.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48248/#review136471
---


Ship it!




Ship It!

- Vinod Kone


On June 7, 2016, 1:39 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48248/
> ---
> 
> (Updated June 7, 2016, 1:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
> https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typos in comments and log messages.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ecefeb36df81a4d0e522f320106accd17108f014 
>   src/slave/slave.cpp 03a845ebdbb057051ced2d6b7a0d3e5aafd5ac55 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 5591a6784afd10b4c7535f90c2e6745fa74c318b 
>   src/tests/master_allocator_tests.cpp 
> ec46913e7fed4bc8cda68ff20d04d6714ecb644d 
>   src/tests/master_maintenance_tests.cpp 
> d5dec6789de9cb27cb1feb11ea5c57b7d04d29ca 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 7c41215251403500bb53f26e845e5c34afc19f1e 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
>   src/tests/partition_tests.cpp 956493d5b2fb531dcedc477b2fdbbc0609e01412 
>   src/tests/reconciliation_tests.cpp 092dff165097315cbebd20bc32fb9fcf5370d136 
>   support/test-upgrade.py 49932006f781072ee517863f1d77232e0cf80552 
> 
> Diff: https://reviews.apache.org/r/48248/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48249: Checked metrics after slave removal in partition tests.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48249/#review136472
---


Ship it!




Ship It!

- Vinod Kone


On June 7, 2016, 1:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48249/
> ---
> 
> (Updated June 7, 2016, 1:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
> https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Checked metrics after slave removal in partition tests.
> 
> 
> Diffs
> -
> 
>   src/tests/partition_tests.cpp 956493d5b2fb531dcedc477b2fdbbc0609e01412 
> 
> Diff: https://reviews.apache.org/r/48249/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48275: Updated log messages and doc pages for slave -> agent rename.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48275/#review136255
---


Ship it!




Ship It!

- Vinod Kone


On June 6, 2016, 12:37 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48275/
> ---
> 
> (Updated June 6, 2016, 12:37 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated log messages and doc pages for slave -> agent rename.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/state.json.md 
> c5852bd01dd5f72a9a11991a033d8c97b111ad21 
>   docs/endpoints/master/state.md 8e0650f84ae13ef7952971ffb9732ec379cffd40 
>   src/master/http.cpp 4fbf5638fb9ae8e7b28c21529d15735e46a85ffb 
>   src/master/master.cpp e5c84ac79012a5fc267fd63de81508d04c05cb4d 
> 
> Diff: https://reviews.apache.org/r/48275/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48263: Fixed documentation for MESOS-5405.

2016-06-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48263/#review136265
---


Ship it!




Ship It!

- Vinod Kone


On June 6, 2016, 8:22 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48263/
> ---
> 
> (Updated June 6, 2016, 8:22 a.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As MESOS-5405 changes the fields in `request` to optional,
> we need to update the documentation.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 189b70d7055c4605f87b537bd2c955f0383faab3 
> 
> Diff: https://reviews.apache.org/r/48263/diff/
> 
> 
> Testing
> ---
> 
> viewed documentation via gist: 
> https://gist.github.com/joerg84/0971f48b8ae88a335f88c1344d4cf180
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48342: Added checks for `reason` field to task reconciliation tests.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48342/#review136476
---


Ship it!




Ship It!

- Vinod Kone


On June 7, 2016, 1:43 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48342/
> ---
> 
> (Updated June 7, 2016, 1:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
> https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This merits testing, because it is a significant part of the
> task reconciliation interface.
> 
> 
> Diffs
> -
> 
>   src/tests/reconciliation_tests.cpp 092dff165097315cbebd20bc32fb9fcf5370d136 
> 
> Diff: https://reviews.apache.org/r/48342/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48344: Parameterized partition tests with registry "strictness".

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48344/#review136479
---


Ship it!




Ship It!

- Vinod Kone


On June 7, 2016, 1:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48344/
> ---
> 
> (Updated June 7, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jan Schlicht, and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
> https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should test that the same partition behavior is implemented
> for both strict and non-strict registry configurations.
> 
> 
> Diffs
> -
> 
>   src/tests/partition_tests.cpp 956493d5b2fb531dcedc477b2fdbbc0609e01412 
> 
> Diff: https://reviews.apache.org/r/48344/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Also manually modified the master in a way that breaks non-strict registry 
> slave removal behavior (by never inserting into the `slaves.removed` 
> collection in the master) and verified that these test do _not_ break in 
> master but they _do_ break after this patch is applied.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48250: Cleaned up task state reconciliation tests.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48250/#review136474
---




src/tests/reconciliation_tests.cpp 
<https://reviews.apache.org/r/48250/#comment201518>

state is a required field though. so not settting it is a bit weird. i 
would rather set a dummy state and add a comment saying it's dummy.

status.set_state(TASK_KILLED); // Dummy.

here and everywhere else.


- Vinod Kone


On June 7, 2016, 1:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48250/
> ---
> 
> (Updated June 7, 2016, 1:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
> https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Task state reconciliation is documented to only look at the
> `taskId` and `slaveId` fields of the TaskStatus that is sent to
> the master; hence, setting the `state` field of TaskStatus is
> redundant at best and misleading at worst.
> 
> Along the way, make use of C++11 initializer lists.
> 
> 
> Diffs
> -
> 
>   src/tests/reconciliation_tests.cpp 092dff165097315cbebd20bc32fb9fcf5370d136 
> 
> Diff: https://reviews.apache.org/r/48250/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48343: Moved two tests from PartitionTest to MasterTest.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48343/#review136478
---




src/tests/partition_tests.cpp 
<https://reviews.apache.org/r/48343/#comment201522>

Hmm. Instead of moving them to master_tests.cpp, keep them in 
partition_tests.cpp and have them inherit from a different testfixture than 
`PartitionTest`. These are partiton tests after all.


- Vinod Kone


On June 7, 2016, 1:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48343/
> ---
> 
> (Updated June 7, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jan Schlicht, and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
> https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> PartitionTest will soon be parameterized with whether to run
> the registry in "strict" mode; since these tests don't
> depend on the registry, there's no point running them twice.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
>   src/tests/partition_tests.cpp 956493d5b2fb531dcedc477b2fdbbc0609e01412 
> 
> Diff: https://reviews.apache.org/r/48343/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48046/#review136495
---



Any updates on this?

- Vinod Kone


On May 30, 2016, 4:23 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48046/
> ---
> 
> (Updated May 30, 2016, 4:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implement v1::master::Call::GET_TASKS.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 0fdda31bb2bdda46d23663379116fb7cc567055a 
>   src/internal/evolve.cpp 4f25f1a892b4834fc4d79b6fd1bd0edd458b7a58 
>   src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/tests/api_tests.cpp 0b6bfadae3a969b3cd1a48e5095e64c953193543 
> 
> Diff: https://reviews.apache.org/r/48046/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Incomplete yet. A draft patch to show general idea how to refactor existing 
> endpoints that uses `jsonify` in OK().
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 47816: Show framework id in log of long-lived-framework.

2016-06-07 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47816/#review136494
---


Ship it!




Ship It!

- Vinod Kone


On May 25, 2016, 6:47 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47816/
> ---
> 
> (Updated May 25, 2016, 6:47 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5451
> https://issues.apache.org/jira/browse/MESOS-5451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the framework registers for the first time, framework id is
> included in returned http event. Hence, log should be printed
> after update of framework id.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 8269e38e828d392dc42a97966ed643c1e2d5f1ed 
> 
> Diff: https://reviews.apache.org/r/47816/diff/
> 
> 
> Testing
> ---
> 
> run long-lived-framework and see framework id printed properly.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48084/#review136910
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48084/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5503
> https://issues.apache.org/jira/browse/MESOS-5503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::master::Call::GET_MAINTENANCE_STATUS.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Vinod Kone



> On June 9, 2016, 10 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 2874
> > <https://reviews.apache.org/r/48257/diff/2/?file=1412869#file1412869line2874>
> >
> > to be consistent with how we did others, lets have this function return 
> > JSON::Object, i.e., JSON::Protobuf(schedule)
> > 
> > that way the evolve overload can still take JSON::Object.

looks like you are doing the same thing in the next review as well. i guess 
that's a pattern we could use as well. dropping this.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48257/#review136907
---


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48257/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
> https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48257/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48257/#review136909
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48257/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
> https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48257/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48286/#review136923
---


Ship it!




No tests for this and the previous review?

- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48286/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
> https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented STOP_MAINTENANCE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48286/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48257/#review136907
---




src/master/http.cpp (line 2874)
<https://reviews.apache.org/r/48257/#comment202015>

to be consistent with how we did others, lets have this function return 
JSON::Object, i.e., JSON::Protobuf(schedule)

that way the evolve overload can still take JSON::Object.


- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48257/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
> https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48257/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48260/#review136921
---




src/tests/api_tests.cpp (lines 323 - 337)
<https://reviews.apache.org/r/48260/#comment202028>

same comments as previous review.


- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48260/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5503
> https://issues.apache.org/jira/browse/MESOS-5503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.GetMaintenanceStatus`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48260/diff/
> 
> 
> Testing
> ---
> 
> Test in CentOS 7.2
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*MasterAPITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48259/#review136912
---




src/tests/api_tests.cpp (line 73)
<https://reviews.apache.org/r/48259/#comment202017>

make this private? 

also move this below public functions.



src/tests/api_tests.cpp (line 113)
<https://reviews.apache.org/r/48259/#comment202022>

this returns `Nothing` and not `Accepted`.

I actually think this helper is a bit confusing than useful. Just calling 
http::post() directly in the tests that don't expect a v1::Response is probably 
better?



src/tests/api_tests.cpp (line 261)
<https://reviews.apache.org/r/48259/#comment202024>

s/schedule/v1Schedule/



src/tests/api_tests.cpp (lines 264 - 268)
<https://reviews.apache.org/r/48259/#comment202025>

lets just have an evolve function that evolves unversioned schedule to 
v1::maintenance::schedule?



src/tests/api_tests.cpp (lines 295 - 299)
<https://reviews.apache.org/r/48259/#comment202027>

lets have and use devolve() here.


- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48259/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
> https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48259/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

2016-06-09 Thread Vinod Kone



> On June 9, 2016, 9:26 p.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, line 171
> > <https://reviews.apache.org/r/48046/diff/4/?file=1411800#file1411800line171>
> >
> > What does this comment mean? I didn't follow.
> > 
> > Also, comments should start with a capital letter and end in a period.
> 
> Jay Guo wrote:
> This line of code is intended to invoke `set_has_get_tasks()` (private 
> method), which is to toggle `GET_TASKS` bit.
> ```
> inline void Call::set_has_get_tasks() {
>   _has_bits_[0] |= 0x0020u;
> }
> ```
> However this line looks a bit weird, so I left the comment there. If you 
> know any other way to toggle the bit, let me know.

I see. Just kill the comment. I think it is clear that you creating get_tasks() 
object.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48046/#review136822
---


On June 9, 2016, 12:49 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48046/
> ---
> 
> (Updated June 9, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implement v1::master::Call::GET_TASKS.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
>   src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48046/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48285/#review136922
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48285/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5506
> https://issues.apache.org/jira/browse/MESOS-5506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented START_MAINTENANCE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48046/#review136822
---




src/master/http.cpp (line 645)
<https://reviews.apache.org/r/48046/#comment201905>

you want to rebase this on top of haosdent's recent changes that I 
committed.



src/master/http.cpp (lines 1412 - 1415)
<https://reviews.apache.org/r/48046/#comment201906>

uncomment this after you rebase because `getTasks` will return 
http::Response() now.



src/tests/api_tests.cpp (line 164)
<https://reviews.apache.org/r/48046/#comment201907>

s/presents/is present/



src/tests/api_tests.cpp (line 171)
<https://reviews.apache.org/r/48046/#comment201908>

What does this comment mean? I didn't follow.

Also, comments should start with a capital letter and end in a period.



src/tests/api_tests.cpp (line 217)
<https://reviews.apache.org/r/48046/#comment202005>

give it a name, say "test"



src/tests/api_tests.cpp (lines 229 - 233)
<https://reviews.apache.org/r/48046/#comment202006>

do we really need this expectation? i think scheduler receiving the update 
should be enough to gurantee that master has already updated the state of the 
task?



src/tests/api_tests.cpp (line 246)
<https://reviews.apache.org/r/48046/#comment202007>

see above. kill this?



src/tests/api_tests.cpp (line 249)
<https://reviews.apache.org/r/48046/#comment202003>

ditto. see above.



src/tests/api_tests.cpp (line 262)
<https://reviews.apache.org/r/48046/#comment202004>

align this with first argument.
    
    ```
ASSERT_EQ(arg1,
  arg2);
```


- Vinod Kone


On June 9, 2016, 12:49 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48046/
> ---
> 
> (Updated June 9, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implement v1::master::Call::GET_TASKS.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
>   src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48046/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review136898
---




src/tests/master_tests.cpp (lines 2495 - 2518)
<https://reviews.apache.org/r/48450/#comment202008>

same comments apply as in the previous review.



src/tests/master_tests.cpp (line 2558)
<https://reviews.apache.org/r/48450/#comment202009>

this is awesome. thanks for going the extra mile to write this test!!


- Vinod Kone


On June 9, 2016, midnight, Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, midnight)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-09 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48116/#review136905
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48116/
> ---
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5505
> https://issues.apache.org/jira/browse/MESOS-5505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48116/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-25 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47695/#review134796
---


Ship it!




Ship It!

- Vinod Kone


On May 24, 2016, 2:38 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47695/
> ---
> 
> (Updated May 24, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5431
> https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this changes, we include below items to make it more convenience to
> develop and generate the website.
> 
> * added `doxygen` and `javadoc` to `rake` default target.
> * added `build.sh` as the wrapper for the website generation to make
>   sure we clean up generated documents when exit.
> * switched the `Dockerfile` to based on `centos:7` because the default
>   `doxygen` version in `ubuntu:14.04` doesn't include `jquery.js`
>   correctly when generate `doxygen` documents.
> * adjusted the `Dockerfile` and `README.md` locations to avoid we
>   distract at finding the website generation document.
> * updated `release-guide.md` with the new website generation and
>   development workflows.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md 36e79796657a37b0b4649602281556f4ae471c34 
>   site/.gitignore 987a5d3cc161a67de1fb21c2002ed9698bbb0689 
>   site/Gemfile 14c50340d66fd7a703949a7932ab93a6b60f4e07 
>   site/Gemfile.lock 065107ec25f0eff28e2a09051b61152d49f77f9a 
>   site/README.md 468021ef4f8ed942c4a16784bc82349af9ae0d5e 
>   site/Rakefile 845ec3fd8b9e47ebe49991db30718912d4f9c41e 
>   site/build.sh PRE-CREATION 
>   support/site-docker/Dockerfile 8ea3d5c5fe531ec76950ed0bf110d7d477339158 
>   support/site-docker/README.md 957117e1211f06b40c5fb621039dd90aff562a87 
> 
> Diff: https://reviews.apache.org/r/47695/diff/
> 
> 
> Testing
> ---
> 
> Tested in OS X and Ubuntu 14.04
> 
> For document changes, could verified from 
> https://github.com/haosdent/mesos/tree/MESOS-5431/site
> 
> To verify website works fine after this changes, could check it via this gif:
> 
> ![website.gif](https://issues.apache.org/jira/secure/attachment/12805684/website.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-25 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47702/#review134805
---


Ship it!




Ship It!

- Vinod Kone


On May 23, 2016, 9:08 p.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47702/
> ---
> 
> (Updated May 23, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-4788
> https://issues.apache.org/jira/browse/MESOS-4788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/framework.html 
> f108e92f5b8d9ed4de718e55aa7302728a84003e 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
> 
> Diff: https://reviews.apache.org/r/47702/diff/
> 
> 
> Testing
> ---
> 
> make check (see attached screenshot for ui after the change)
> 
> 
> File Attachments
> 
> 
> image after making the change
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/23/a2b9738e-b33a-4fce-98b0-9457d42a31f7__Screen_Shot_2016-05-23_at_12.38.01_PM.png
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

2016-05-24 Thread Vinod Kone



> On May 25, 2016, 1:27 a.m., Joseph Wu wrote:
> > src/sched/sched.cpp, line 325
> > 
> >
> > On inspection, there's another (rarer) leak that can appear if:
> > 
> > 1) Master sends offers to the framework.
> > 2) Network partition disconnects the framework.
> > 3) Framework uses `acceptOffers` or `declinesOffers`.
> > 4) Because the framework is `!connected`, both `acceptOffers` and 
> > `declinesOffers` exit early and do not modify `savedOffers`.
> > 
> > It would be correct to clear `savedOffers` when the framework 
> > disconnects.  (Because all offers become invalid.)
> 
> haosdent huang wrote:
> Nice comment!

Lets do this in a follow up review to keep this review on point.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47804/#review134675
---


On May 25, 2016, 12:51 a.m., Dario Rexin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47804/
> ---
> 
> (Updated May 25, 2016, 12:51 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-5449
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-5449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MesosScheduler.declineOffers has been changed ~6 months ago to send a Decline 
> message instead of calling acceptOffers with an empty list of task infos. The 
> changed version of declineOffer however did not remove the offerId from the 
> savedOffers map, causing a memory leak.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 9e55885 
> 
> Diff: https://reviews.apache.org/r/47804/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Dario Rexin
> 
>

Review Request 47866: Updated committers.md.

2016-05-25 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47866/
---

Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Repository: mesos


Description
---

Added committers that were not updated on the committers doc.


Diffs
-

  docs/committers.md bb77ed1c1cf761380a4c7cd281267b342b604f13 

Diff: https://reviews.apache.org/r/47866/diff/


Testing
---

N/A


Thanks,

Vinod Kone

Re: Review Request 48595: Exposed the logging process `PID` in libprocess.

2016-06-14 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48595/#review137556
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/logging.hpp (line 42)
<https://reviews.apache.org/r/48595/#comment202698>

s/setLevel/set_level/

stout and libprocess use snake case.


- Vinod Kone


On June 12, 2016, 6:02 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48595/
> ---
> 
> (Updated June 12, 2016, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
> https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed the logging process `PID` in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/logging.hpp 
> 651cb3736705124bec9e4366c0e7adc5d5b488f0 
>   3rdparty/libprocess/include/process/process.hpp 
> 646059e2740a32dd9c483dfa56c71dc46727862c 
>   3rdparty/libprocess/src/logging.cpp 
> 222449b904268a47868be374bf8202aafe6516fe 
>   3rdparty/libprocess/src/process.cpp 
> b4cdba6b0cd4f8f373f37118cd2e9d4955f2425a 
> 
> Diff: https://reviews.apache.org/r/48595/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

2016-06-14 Thread Vinod Kone



> On June 13, 2016, 10:07 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 596-632
> > <https://reviews.apache.org/r/48585/diff/5/?file=1416175#file1416175line596>
> >
> > s/mesos:://
> 
> Anand Mazumdar wrote:
> I guess @haosdent had to add them due to there being an already existing 
> `master` namespace in our code. The compiler would have barfed otherwise due 
> to it not being able to find a `Call` class in the existing `master` 
> namespace. Hence, it _had_ to be fully qualified.
> 
> Since, we _only_ use the unversioned protobuf internally in our code, we 
> should just do `using mesos::master::Call` and then just use `Call::TYPE` for 
> referring to it. Sound good?
> 
> Vinod Kone wrote:
> I see. Qualified mesos::master::Call seems fine then. `using 
> mesos::master::Call`  might be weird because we also have scheduler::Call in 
> this file.
> 
> haosdent huang wrote:
> Oh, yes, as @anandmazumdar said, we need add mesos:: otherwise compiler 
> return errors. @vinodkone Could I drop these issues?

yup!


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48585/#review137403
---


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48585/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Devolved v1 operator protos to unversioned operator protos in Master.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/master/validation.hpp e1271bbaebaac52a078eedfdc2299c7c6f4474f8 
>   src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be 
> 
> Diff: https://reviews.apache.org/r/48585/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48524: Moved flag validation after check for required flags.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48524/#review137380
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:54 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48524/
> ---
> 
> (Updated June 9, 2016, 11:54 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved flag validation after check for required flags.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> 9271f722e5281d7be5e165021c2c48d3b3453a8e 
> 
> Diff: https://reviews.apache.org/r/48524/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 48510: Passed `ContentType` enum by value instead of const ref.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48510/#review137381
---


Ship it!




Ship It!

- Vinod Kone


On June 10, 2016, midnight, Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48510/
> ---
> 
> (Updated June 10, 2016, midnight)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
>   src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
> 
> Diff: https://reviews.apache.org/r/48510/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48511: Renamed `responseContentType` to `responseType`.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48511/#review137385
---



hmm. i dont think `responseType` is that clear. what is a http response type? 
type could as well refer to status code. or maybe accept type. 
`responseContentType` is explicit.

- Vinod Kone


On June 9, 2016, 9:30 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48511/
> ---
> 
> (Updated June 9, 2016, 9:30 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Minor: The type of the variable is already `ContentType`. The
> name `responseType` has sufficient information that this
> refers to the content type of the response.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
>   src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
> 
> Diff: https://reviews.apache.org/r/48511/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48303: Split the balloon scheduler into a Process to support metrics.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48303/#review137386
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:53 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48303/
> ---
> 
> (Updated June 9, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `BalloonSchedulerProcess` which holds a subset of the `Scheduler`
> class's methods.  The `BalloonScheduler` dispatches to the process
> when for non-logging business logic.  This also opens up the balloon 
> framework for libprocess metrics.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
> 
> Diff: https://reviews.apache.org/r/48303/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review137387
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:48 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45604/
> ---
> 
> (Updated June 9, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This gives the example `balloon-framework` enough options to run
> outside of the build environment:
> 
> * Adds an option for restricting the number of resources per task
>   (otherwise, it will eat up an entire node).
> * Adds an option for persisting the framework and launching one task
>   after another.
> * Adds filters for declined offers.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
>   src/tests/balloon_framework_test.sh 
> a242f6cb9ca1850e5fef90e0938f41044bdaddbf 
> 
> Diff: https://reviews.apache.org/r/45604/diff/
> 
> 
> Testing
> ---
> 
> ```
> make check 
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 46407: Updated balloon executor.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46407/#review137391
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46407/
> ---
> 
> (Updated June 9, 2016, 11:09 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixes the logic in the example `balloon-executor` to work in cases not
> exercised by the `ROOT_CGROUPS_BalloonFramework` test.
> 
> * The "task" logic was moved into a separate thread.  This fixes the 
>   case where the balloon executor does not exceed the memory limit.
>   (i.e. by Unblocking the driver's thread while sending status updates.)
> * Changed log messages to use glog.
> * Added logic to prevent multiple task launches with the same executor.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 2a79c353e96930d25495732d15b83c82247974bb 
> 
> Diff: https://reviews.apache.org/r/46407/diff/
> 
> 
> Testing
> ---
> 
> See next review in this chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 48584: Added unversioned protos for master API.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48584/#review137402
---


Ship it!




Ship It!

- Vinod Kone


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48584/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unversioned protos for master API.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.hpp PRE-CREATION 
>   include/mesos/master/master.proto PRE-CREATION 
>   src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
> 
> Diff: https://reviews.apache.org/r/48584/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48587: Added unversioned protos for agent API.

2016-06-13 Thread Vinod Kone



> On June 13, 2016, 8:18 p.m., Anand Mazumdar wrote:
> > Can we name the unversioned proto file as just `agent.proto`? It would be 
> > good to not introduce the `Slave` terminology going forward :-)

also the package name, class name, namespace etc.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/#review137370
---


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48587/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unversioned protos for agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/slave/slave.hpp PRE-CREATION 
>   include/mesos/slave/slave.proto PRE-CREATION 
>   src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
> 
> Diff: https://reviews.apache.org/r/48587/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48585/#review137403
---




src/master/http.cpp (line 573)
<https://reviews.apache.org/r/48585/#comment202528>

s/mesos:://



src/master/http.cpp (lines 596 - 632)
<https://reviews.apache.org/r/48585/#comment202529>

s/mesos:://



src/master/http.cpp (line 1289)
<https://reviews.apache.org/r/48585/#comment202530>

s/mesos:://



src/master/http.cpp (line 1293)
<https://reviews.apache.org/r/48585/#comment202531>

s/mesos:://



src/master/http.cpp (lines 1324 - 1381)
<https://reviews.apache.org/r/48585/#comment202532>

s/mesos:://



src/master/master.hpp (lines 1286 - 1306)
<https://reviews.apache.org/r/48585/#comment202533>

s/mesos:://



src/master/validation.hpp (line 49)
<https://reviews.apache.org/r/48585/#comment202534>

s/mesos:://



src/master/validation.cpp (lines 57 - 129)
<https://reviews.apache.org/r/48585/#comment202535>

s/mesos:://


- Vinod Kone


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48585/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Devolved v1 operator protos to unversioned operator protos in Master.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/master/validation.hpp e1271bbaebaac52a078eedfdc2299c7c6f4474f8 
>   src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be 
> 
> Diff: https://reviews.apache.org/r/48585/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48588/#review137405
---



please remove mesos:: prefix for calls and responses. also shouldn't use 
`slave` keyword per previous review comments.

- Vinod Kone


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48588/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Devolved v1 operator protos to unversioned operator protos in Agent.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
>   src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
>   src/slave/validation.hpp 59b12f0109f6fa4c570f02d90834502a8edebe45 
>   src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a 
> 
> Diff: https://reviews.apache.org/r/48588/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-13 Thread Vinod Kone



> On June 13, 2016, 7:41 a.m., Neil Conway wrote:
> > src/tests/scheduler_http_api_tests.cpp, line 974
> > <https://reviews.apache.org/r/48614/diff/1/?file=1416557#file1416557line974>
> >
> > Why are we fetching the stream ID?

looks like you forgot to set the stream ID header when sending the acknowledge 
call. if you don't set it the BadRequest response might be due to the missing 
stream id and not malformed uuid. after you fix this, make sure you set an 
expectation on the response body and not just response status code.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48614/#review137239
---


On June 13, 2016, 6:51 a.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48614/
> ---
> 
> (Updated June 13, 2016, 6:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5224
> https://issues.apache.org/jira/browse/MESOS-5224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds logic to the master/agent validation helpers
> to see if the status update acknowledgments have a valid UUID
> set conforming to one of the supported versions.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 309fbed81c9ff0ccc4ff4ee3ee70cf8f1fb2ac55 
>   src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a 
>   src/tests/scheduler_http_api_tests.cpp 
> c12205f90e4f2da2c6ad7a0ea75777601eb0ef13 
> 
> Diff: https://reviews.apache.org/r/48614/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

2016-06-13 Thread Vinod Kone



> On June 13, 2016, 10:07 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 596-632
> > <https://reviews.apache.org/r/48585/diff/5/?file=1416175#file1416175line596>
> >
> > s/mesos:://
> 
> Anand Mazumdar wrote:
> I guess @haosdent had to add them due to there being an already existing 
> `master` namespace in our code. The compiler would have barfed otherwise due 
> to it not being able to find a `Call` class in the existing `master` 
> namespace. Hence, it _had_ to be fully qualified.
> 
> Since, we _only_ use the unversioned protobuf internally in our code, we 
> should just do `using mesos::master::Call` and then just use `Call::TYPE` for 
> referring to it. Sound good?

I see. Qualified mesos::master::Call seems fine then. `using 
mesos::master::Call`  might be weird because we also have scheduler::Call in 
this file.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48585/#review137403
---


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48585/
> ---
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Devolved v1 operator protos to unversioned operator protos in Master.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/master/validation.hpp e1271bbaebaac52a078eedfdc2299c7c6f4474f8 
>   src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be 
> 
> Diff: https://reviews.apache.org/r/48585/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48511: Renamed `responseContentType` to `responseType`.

2016-06-13 Thread Vinod Kone



> On June 13, 2016, 9:29 p.m., Vinod Kone wrote:
> > hmm. i dont think `responseType` is that clear. what is a http response 
> > type? type could as well refer to status code. or maybe accept type. 
> > `responseContentType` is explicit.
> 
> Anand Mazumdar wrote:
> hmm .. The _type_ of the variable is `ContentType`. Hence, just having 
> the variable name as `responseType` is _intuitive_ to the reader that this 
> refers to the content type of the response. That being said, looks like this 
> reasoning might not be that obvious.
> 
> How about just renaming it as `acceptType` to be more intuitive?

`acceptType` sounds good to me inside `master::Http::api()`. The handlers 
themselves should call the parameter `contentType` instead of `acceptType`?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48511/#review137385
---


On June 9, 2016, 9:30 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48511/
> ---
> 
> (Updated June 9, 2016, 9:30 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Minor: The type of the variable is already `ContentType`. The
> name `responseType` has sufficient information that this
> refers to the content type of the response.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
>   src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
> 
> Diff: https://reviews.apache.org/r/48511/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48666: Captured alias variables by const ref in the Master.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48666/#review137423
---


Ship it!




Ship It!

- Vinod Kone


On June 13, 2016, 11:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48666/
> ---
> 
> (Updated June 13, 2016, 11:19 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp dd80367768a1edbb6ff94d40819b9755a8b8135f 
> 
> Diff: https://reviews.apache.org/r/48666/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48583: Added `VersionInfo`, `Flag`, `Metrics` to unversioned mesos protos.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48583/#review137400
---


Ship it!




Ship It!

- Vinod Kone


On June 12, 2016, 6 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48583/
> ---
> 
> (Updated June 12, 2016, 6 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We add `VersionInfo`, `Flag`, `Metrics` to v1 mesos protos in 549a0340,
> but didn't add them to unversioned mesos protos as well. This change
> attempt to fix this.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto dbffb16f4317df786ee38999a49e4e89733ff9ff 
> 
> Diff: https://reviews.apache.org/r/48583/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48613: Added validation logic for UUID's.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48613/#review137406
---




3rdparty/stout/include/stout/uuid.hpp (lines 54 - 78)
<https://reviews.apache.org/r/48613/#comment202536>

As suggested by Neil in the subsequent review, lets have `fromBytes()` 
return a Try instead and do the validation there.

Should we also protect `fromString()` from invalid UUID strings? If yes, 
lets change that to return Try as well.


- Vinod Kone


On June 13, 2016, 6:51 a.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48613/
> ---
> 
> (Updated June 13, 2016, 6:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5224
> https://issues.apache.org/jira/browse/MESOS-5224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a `validateFromBytes` function for validating
> UUID's by checking if they are one of the supported UUID
> versions.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/uuid.hpp 
> e3cf21ff986112694a417981c22009323cb23987 
>   3rdparty/stout/tests/uuid_tests.cpp 
> 50295ad25843a3938a5a58f5ba7f082f8ffeba45 
> 
> Diff: https://reviews.apache.org/r/48613/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-13 Thread Vinod Kone



> On June 13, 2016, 9:31 p.m., Joseph Wu wrote:
> > src/master/http.cpp, line 2901
> > <https://reviews.apache.org/r/48116/diff/4/?file=1416130#file1416130line2901>
> >
> > Do we want to standardize this return code (200 -> 202)?  From the 
> > design doc, it seemed like empty responses should be handled with a 202.
> > 
> >     Feel free to drop this is not an issue.
> 
> Vinod Kone wrote:
> No response could result in 200 or 202 depending on the semantics of the 
> request.

But looks like `_updateMaintenanceSchedule()` should actually return 202 
because it calls `allocator->updateUnavailability()` which is asynchronous.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48116/#review137383
---


On June 12, 2016, 5:46 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48116/
> ---
> 
> (Updated June 12, 2016, 5:46 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5505
> https://issues.apache.org/jira/browse/MESOS-5505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48116/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48299: Updated balloon framework spacing and logging.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48299/#review137389
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48299/
> ---
> 
> (Updated June 9, 2016, 11:09 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
> https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changes some whitespace for the balloon framework and
> changes most logging messages to use glog.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
> 
> Diff: https://reviews.apache.org/r/48299/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-13 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48614/#review137407
---




src/master/validation.cpp (line 308)
<https://reviews.apache.org/r/48614/#comment202537>

`uuid` is a required field so don't need to do the if check here.

after addressing the previous comments this should be,

```
Try uuid = UUID::fromBytes(call.acknowledge.uuid());
if (uuid.isError()) {
  return Error("Invalid UUID: " + uuid.error());
}

```



src/slave/validation.cpp (line 148)
<https://reviews.apache.org/r/48614/#comment202538>

if blocks have "{" on the same line as the if statement. see above.

```
Try uuid = UUID::fromBytes(status.uuid());
if (uuid.isError()) {
  return Error("Invalid UUID: " + uuid.error());
}

```


- Vinod Kone


On June 13, 2016, 6:51 a.m., Deshna Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48614/
> ---
> 
> (Updated June 13, 2016, 6:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5224
> https://issues.apache.org/jira/browse/MESOS-5224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds logic to the master/agent validation helpers
> to see if the status update acknowledgments have a valid UUID
> set conforming to one of the supported versions.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 309fbed81c9ff0ccc4ff4ee3ee70cf8f1fb2ac55 
>   src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a 
>   src/tests/scheduler_http_api_tests.cpp 
> c12205f90e4f2da2c6ad7a0ea75777601eb0ef13 
> 
> Diff: https://reviews.apache.org/r/48614/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-13 Thread Vinod Kone



> On June 13, 2016, 9:31 p.m., Joseph Wu wrote:
> > src/master/http.cpp, line 2901
> > <https://reviews.apache.org/r/48116/diff/4/?file=1416130#file1416130line2901>
> >
> > Do we want to standardize this return code (200 -> 202)?  From the 
> > design doc, it seemed like empty responses should be handled with a 202.
> > 
> > Feel free to drop this is not an issue.

No response could result in 200 or 202 depending on the semantics of the 
request.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48116/#review137383
---


On June 12, 2016, 5:46 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48116/
> ---
> 
> (Updated June 12, 2016, 5:46 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5505
> https://issues.apache.org/jira/browse/MESOS-5505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 
>   src/master/http.cpp cd089cf6afd654b07608548f441a0e225df6425e 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48116/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48272: Added 1.0 changed to upgrades.md.

2016-06-08 Thread Vinod Kone



> On June 6, 2016, 2:52 p.m., Vinod Kone wrote:
> > docs/upgrades.md, line 173
> > <https://reviews.apache.org/r/48272/diff/1/?file=1406841#file1406841line173>
> >
> > This section seems like duplicate of what we have in CHANGELOG. What do 
> > you think about removing this text from here and just point the table 
> > entries above to CHANGELOG?
> 
> Joerg Schad wrote:
> I actually considered that, but decided against it for the following 
> reason:
> IMO this document is for operators who want to understand what might be 
> problematic when upgrading between different version (which by natures 
> duplicates some information from the CHANGELOG). Also the table should be 
> just optional, so those changes should be mentioned in the "0.28 ->  1.0" 
> section as well as in the table.
> 
> Vinod Kone wrote:
> Why can't operators look at CHANGELOG? Everything in the Deprecations 
> section in CHANGELOG should be something the operators should be aware of. Is 
> there stuff in upgrades.md that is not in CHANGELOG?

lets cleanup CHANGELOG and upgrades.md in a follow up patch.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48272/#review136258
---


On June 6, 2016, 3:26 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48272/
> ---
> 
> (Updated June 6, 2016, 3:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos 1.0 changed need to be reflected in upgrades.md.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md be6db7d1c70e893bf74075db4658d92fb57cfa79 
> 
> Diff: https://reviews.apache.org/r/48272/diff/
> 
> 
> Testing
> ---
> 
> checked as gist: 
> https://gist.github.com/joerg84/2426fca01ef09bb4af6454afa28faa56
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48343: Moved two tests from PartitionTest to MasterTest.

2016-06-08 Thread Vinod Kone



> On June 7, 2016, 3:18 p.m., Vinod Kone wrote:
> > src/tests/partition_tests.cpp, line 574
> > <https://reviews.apache.org/r/48343/diff/1/?file=1408804#file1408804line574>
> >
> > Hmm. Instead of moving them to master_tests.cpp, keep them in 
> > partition_tests.cpp and have them inherit from a different testfixture than 
> > `PartitionTest`. These are partiton tests after all.
> 
> Neil Conway wrote:
> Arguably they aren't necessarily partition tests, if we say that an agent 
> is "partitioned" if it has failed health checks (which is what the rest of 
> the `PartitionTest` cases cover). The TCP socket breaking between master and 
> agent isn't treated as indicating the agent is partitioned / due for removal, 
> it just means the agent is currently disconnected.
> 
> Happy to keep them in `partition_tests.cpp` if you'd prefer though.

These tests are simulating one way network partitions; the naming and comments 
say as much. So yea, lets keep them in partition_tests.cpp.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48343/#review136478
---


On June 7, 2016, 1:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48343/
> ---
> 
> (Updated June 7, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jan Schlicht, and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
> https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> PartitionTest will soon be parameterized with whether to run
> the registry in "strict" mode; since these tests don't
> depend on the registry, there's no point running them twice.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
>   src/tests/partition_tests.cpp 956493d5b2fb531dcedc477b2fdbbc0609e01412 
> 
> Diff: https://reviews.apache.org/r/48343/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47822/#review135406
---


Ship it!




LGTM modulo the comments I made. I'll fix them when committing. Thanks.

- Vinod Kone


On May 25, 2016, 4:27 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47822/
> ---
> 
> (Updated May 25, 2016, 4:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, 
> Benjamin Bannier, Greg Mann, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5293
> https://issues.apache.org/jira/browse/MESOS-5293
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master and agent code for routing endpoints are made
> consistent. Now they both capture 'this' variable in the
> lambda calls in routing function arguments. Continuations
> are no more need to be static.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp dd1f509e9464af7d02db0182b0eebd63993dd029 
>   src/slave/slave.hpp 0de6a570e8b4699771048295ec3fcedf84593495 
>   src/slave/slave.cpp 2941cf1b6ea1e4deabfcbbe3f4897c06a28531a5 
> 
> Diff: https://reviews.apache.org/r/47822/diff/
> 
> 
> Testing
> ---
> 
> Unit tests.
> 
> On ubuntu 16.04:
> sudo GTEST_FILTER="*SlaveEndpointTest*.*" make -j2 check
> 
> Manual testing.
> 
> 1. Ran master with:
> 
> 
>sudo  ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> 
> 
> 2. ACL File:
> 
> 
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "NONE" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   } 
> 
> 
> 3. Ran slave with:
> 
> 
>sudo ./bin/mesos-slave.sh --master=127.0.0.1:5050 --ip=0.0.0.0 
> --acls=file:///home/abhishek/testAcl
> 
> 
> 4. Ran toy-framework with:
> 
> 
>sudo ./no-executor-framework --master=master@127.0.0.1:5050 
> --command="echo hello"
> 
> 
> 5. Output while hitting "http://127.0.0.1:5051/slave(1)/containers" - HTTP 
> error 403: Forbidden
> 
> 6. Changed ACL to:
> 
> 
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "ANY" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   }
> 
> 
> 7. Ran slave and framework again.
> 
> 8. Output:
> 
> 
> 
> [{"container_id":"2059c6a5-d168-4db7-912d-1c70b61fdb5d","executor_id":"699","executor_name":"Command
>  Executor (Task: 699) (Command: sh -c 'echo 
> hello')","framework_id":"48e2fe51-afba-44c5-958e-0ad3cee6454b-","source":"699","statistics":{"cpus_limit":0.2,"cpus_system_time_secs":0.01,"cpus_user_time_secs":0.04,"mem_limit_bytes":67108864,"mem_rss_bytes":88477696,"timestamp":1464168040.50791},"status":{}},{"container_id":"a0be0340-ca6b-4fc4-9862-4af143a7961e",...
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

2016-05-28 Thread Vinod Kone



> On May 25, 2016, 9:45 a.m., Jan Schlicht wrote:
> > src/slave/http.cpp, line 384
> > <https://reviews.apache.org/r/47822/diff/1/?file=1393299#file1393299line384>
> >
> > s/slaveFlags/slave->flags/, see comment above.

don't need to pass the flags at all since this is now a member function. i'll 
fix this while committing.


> On May 25, 2016, 9:45 a.m., Jan Schlicht wrote:
> > src/slave/http.cpp, line 783
> > <https://reviews.apache.org/r/47822/diff/1/?file=1393299#file1393299line783>
> >
> > s/localSlave/slave/

no need to pass `slave` at all because this is now a non-static member 
function. i'll fix this while committing.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47822/#review134743
---


On May 25, 2016, 4:27 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47822/
> ---
> 
> (Updated May 25, 2016, 4:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, 
> Benjamin Bannier, Greg Mann, Jan Schlicht, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5293
> https://issues.apache.org/jira/browse/MESOS-5293
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master and agent code for routing endpoints are made
> consistent. Now they both capture 'this' variable in the
> lambda calls in routing function arguments. Continuations
> are no more need to be static.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp dd1f509e9464af7d02db0182b0eebd63993dd029 
>   src/slave/slave.hpp 0de6a570e8b4699771048295ec3fcedf84593495 
>   src/slave/slave.cpp 2941cf1b6ea1e4deabfcbbe3f4897c06a28531a5 
> 
> Diff: https://reviews.apache.org/r/47822/diff/
> 
> 
> Testing
> ---
> 
> Unit tests.
> 
> On ubuntu 16.04:
> sudo GTEST_FILTER="*SlaveEndpointTest*.*" make -j2 check
> 
> Manual testing.
> 
> 1. Ran master with:
> 
> 
>sudo  ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos
> 
> 
> 2. ACL File:
> 
> 
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "NONE" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   } 
> 
> 
> 3. Ran slave with:
> 
> 
>sudo ./bin/mesos-slave.sh --master=127.0.0.1:5050 --ip=0.0.0.0 
> --acls=file:///home/abhishek/testAcl
> 
> 
> 4. Ran toy-framework with:
> 
> 
>sudo ./no-executor-framework --master=master@127.0.0.1:5050 
> --command="echo hello"
> 
> 
> 5. Output while hitting "http://127.0.0.1:5051/slave(1)/containers" - HTTP 
> error 403: Forbidden
> 
> 6. Changed ACL to:
> 
> 
>   {
> "get_endpoints": [
>   {
> "principals": { "type": "ANY" },
> "paths": { "values": ["/flags", "/monitor/statistics", "/containers"] 
> }
>   }
> ]
>   }
> 
> 
> 7. Ran slave and framework again.
> 
> 8. Output:
> 
> 
> 
> [{"container_id":"2059c6a5-d168-4db7-912d-1c70b61fdb5d","executor_id":"699","executor_name":"Command
>  Executor (Task: 699) (Command: sh -c 'echo 
> hello')","framework_id":"48e2fe51-afba-44c5-958e-0ad3cee6454b-","source":"699","statistics":{"cpus_limit":0.2,"cpus_system_time_secs":0.01,"cpus_user_time_secs":0.04,"mem_limit_bytes":67108864,"mem_rss_bytes":88477696,"timestamp":1464168040.50791},"status":{}},{"container_id":"a0be0340-ca6b-4fc4-9862-4af143a7961e",...
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 48008: Added v1 protos for master and agent APIs.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48008/
---

(Updated May 29, 2016, 1:17 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Changes
---

Deleted agent::Event because it doesn't exist.


Bugs: MESOS-2257 and MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2257
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

Also added common protos to v1/mesos.proto.


Diffs (updated)
-

  include/mesos/master/allocator.proto 555f51b621b21b87b8db00b9ea62cd911d229504 
  include/mesos/v1/agent.hpp PRE-CREATION 
  include/mesos/v1/agent.proto PRE-CREATION 
  include/mesos/v1/master.hpp PRE-CREATION 
  include/mesos/v1/master.proto PRE-CREATION 
  include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d 

Diff: https://reviews.apache.org/r/48008/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48015/
---

Review request for mesos.


Bugs: MESOS-4791
https://issues.apache.org/jira/browse/MESOS-4791


Repository: mesos


Description
---

The logic is same as what we did for the master.


Diffs
-

  src/internal/evolve.hpp 4d1cb7f2a180f4f4a44491393393449d36ed616b 
  src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 
  src/slave/http.cpp 64a99d539a0957b92d42c25c8dda298199383018 
  src/slave/slave.hpp 78a6ecfe29881f1723d7d603a99962afdd5a81a8 
  src/slave/slave.cpp 97d15da2a20c74d3a502abac68cc7a695e06a189 
  src/tests/api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/48015/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 48014: Added the route handler for v1 agent API.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48014/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

This is just the basic structure for handling the calls. Actual calls
will be implemented later.


Diffs
-

  src/slave/http.cpp 64a99d539a0957b92d42c25c8dda298199383018 
  src/slave/slave.hpp 78a6ecfe29881f1723d7d603a99962afdd5a81a8 
  src/slave/slave.cpp 97d15da2a20c74d3a502abac68cc7a695e06a189 
  src/slave/validation.hpp 070a77115f0d6f22615fc5bd42537e6d1b86f0bf 
  src/slave/validation.cpp dccc788d7ec782b08abe4b58d8b92031939fa2d7 

Diff: https://reviews.apache.org/r/48014/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48015/
---

(Updated May 29, 2016, 1:39 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Changes
---

added reviewers.


Bugs: MESOS-5475
https://issues.apache.org/jira/browse/MESOS-5475


Repository: mesos


Description
---

The logic is same as what we did for the master.


Diffs
-

  src/internal/evolve.hpp 4d1cb7f2a180f4f4a44491393393449d36ed616b 
  src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 
  src/slave/http.cpp 64a99d539a0957b92d42c25c8dda298199383018 
  src/slave/slave.hpp 78a6ecfe29881f1723d7d603a99962afdd5a81a8 
  src/slave/slave.cpp 97d15da2a20c74d3a502abac68cc7a695e06a189 
  src/tests/api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/48015/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 48008: Added v1 protos for master and agent APIs.

2016-05-28 Thread Vinod Kone



> On May 28, 2016, 10:58 p.m., Kevin Klues wrote:
> > include/mesos/v1/agent.hpp, lines 35-36
> > <https://reviews.apache.org/r/48008/diff/2/?file=1400524#file1400524line35>
> >
> > Why is this wrapped and the one aboove not? They are the same line 
> > length

it's not of the same length! this has Response::Type (longer string) as 
parameter whereas the above one has Call::Type (shorter string) as parameter.


> On May 28, 2016, 10:58 p.m., Kevin Klues wrote:
> > include/mesos/v1/master.hpp, lines 35-36
> > <https://reviews.apache.org/r/48008/diff/2/?file=1400526#file1400526line35>
> >
> > Same comment as above.

see above.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48008/#review135398
-------


On May 28, 2016, 8:29 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48008/
> ---
> 
> (Updated May 28, 2016, 8:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.
> 
> 
> Bugs: MESOS-2257 and MESOS-2720
> https://issues.apache.org/jira/browse/MESOS-2257
> https://issues.apache.org/jira/browse/MESOS-2720
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added common protos to v1/mesos.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.proto 
> 555f51b621b21b87b8db00b9ea62cd911d229504 
>   include/mesos/v1/agent.hpp PRE-CREATION 
>   include/mesos/v1/agent.proto PRE-CREATION 
>   include/mesos/v1/master.hpp PRE-CREATION 
>   include/mesos/v1/master.proto PRE-CREATION 
>   include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d 
> 
> Diff: https://reviews.apache.org/r/48008/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48012/
---

(Updated May 29, 2016, 1:19 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Changes
---

changed variable name.


Bugs: MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

The idea is to extract JSON::Object representation of flags into a
function that can be used by both the old JSON REST API handler and the
new v1 API handler.


Diffs (updated)
-

  src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
  src/internal/evolve.hpp 4d1cb7f2a180f4f4a44491393393449d36ed616b 
  src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 
  src/master/http.cpp bbbf0a00e486b96e036f59a3107789d0322bc6cd 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/master.cpp 6442762c9fdfa368d5d9d7cd43b97f5addaf7f17 
  src/master/validation.hpp 580f420a72f33290bcbe718bad839084d4209b8c 
  src/master/validation.cpp 982b61da5fe34dbe46190477e75ee7a4e4cdce9c 
  src/tests/api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/48012/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-28 Thread Vinod Kone



> On May 29, 2016, 1:36 a.m., Vinod Kone wrote:
> >

Can you rebased this?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/#review135408
---


On May 18, 2016, 4:13 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46373/
> ---
> 
> (Updated May 18, 2016, 4:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: mesos-5060
> https://issues.apache.org/jira/browse/mesos-5060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [MESOS-5060]
> The patch did the following changes:
> 1. Fix the length logic in files.cpp.
> 2. Add some tests to test the /files/read.json endponit with
> negative length.
> 
> 
> Diffs
> -
> 
>   src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/46373/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> request 'files/read.json' endpoint with negative offset or length argument
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/#review135408
---


Ship it!





src/files/files.cpp (line 374)
<https://reviews.apache.org/r/46373/#comment200423>

Can we fix the pailer to not send -1 length in a follow up patch?


- Vinod Kone


On May 18, 2016, 4:13 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46373/
> ---
> 
> (Updated May 18, 2016, 4:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: mesos-5060
> https://issues.apache.org/jira/browse/mesos-5060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [MESOS-5060]
> The patch did the following changes:
> 1. Fix the length logic in files.cpp.
> 2. Add some tests to test the /files/read.json endponit with
> negative length.
> 
> 
> Diffs
> -
> 
>   src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/46373/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> request 'files/read.json' endpoint with negative offset or length argument
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Review Request 48011: Added overload for `http::OK()` that takes ContentType.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48011/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

Needed this for subsequent review.


Diffs
-

  3rdparty/libprocess/include/process/http.hpp 
10f6fb90e436300bc47f4d5d2ad4beabd19026ba 

Diff: https://reviews.apache.org/r/48011/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 48010: Updated Makefile.am to properly build the v1 API protos.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48010/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

And also header files.


Diffs
-

  src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 

Diff: https://reviews.apache.org/r/48010/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 48009: Added v1 protos for maintenance, allocator and quota.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48009/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-2257 and MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2257
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

Note that these files are copies of their non-versioned counterparts.
The only difference is in their package name.


Diffs
-

  include/mesos/v1/maintenance/maintenance.proto PRE-CREATION 
  include/mesos/v1/master/allocator.proto PRE-CREATION 
  include/mesos/v1/quota/quota.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/48009/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 48008: Added v1 protos for master and agent APIs.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48008/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-2257 and MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2257
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

Also added common protos to v1/mesos.proto.


Diffs
-

  include/mesos/master/allocator.proto 555f51b621b21b87b8db00b9ea62cd911d229504 
  include/mesos/v1/agent.hpp PRE-CREATION 
  include/mesos/v1/agent.proto PRE-CREATION 
  include/mesos/v1/master.hpp PRE-CREATION 
  include/mesos/v1/master.proto PRE-CREATION 
  include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d 

Diff: https://reviews.apache.org/r/48008/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 48008: Added v1 protos for master and agent APIs.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48008/
---

(Updated May 28, 2016, 8:29 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Changes
---

fixed missing braces.


Bugs: MESOS-2257 and MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2257
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

Also added common protos to v1/mesos.proto.


Diffs (updated)
-

  include/mesos/master/allocator.proto 555f51b621b21b87b8db00b9ea62cd911d229504 
  include/mesos/v1/agent.hpp PRE-CREATION 
  include/mesos/v1/agent.proto PRE-CREATION 
  include/mesos/v1/master.hpp PRE-CREATION 
  include/mesos/v1/master.proto PRE-CREATION 
  include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d 

Diff: https://reviews.apache.org/r/48008/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48012/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

The idea is to extract JSON::Object representation of flags into a
function that can be used by both the old JSON REST API handler and the
new v1 API handler.


Diffs
-

  src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
  src/internal/evolve.hpp 4d1cb7f2a180f4f4a44491393393449d36ed616b 
  src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 
  src/master/http.cpp bbbf0a00e486b96e036f59a3107789d0322bc6cd 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/master.cpp 6442762c9fdfa368d5d9d7cd43b97f5addaf7f17 
  src/master/validation.hpp 580f420a72f33290bcbe718bad839084d4209b8c 
  src/master/validation.cpp 982b61da5fe34dbe46190477e75ee7a4e4cdce9c 
  src/tests/api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/48012/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 47988: Added move constructor/assignment to `Try`.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47988/#review135413
---


Ship it!




Ship It!

- Vinod Kone


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47988/
> ---
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added move constructor/assignment to `Try`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/try.hpp 
> 89dedec0c818263f17f220a2e71ed470bf75a42f 
> 
> Diff: https://reviews.apache.org/r/47988/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47987/#review135412
---




3rdparty/stout/include/stout/result.hpp (lines 65 - 67)
<https://reviews.apache.org/r/47987/#comment200425>

what does this do? can you add some more info to the description for 
posterity?


- Vinod Kone


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47987/
> ---
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Constrained constructible types constructor for `Result`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/result.hpp 
> 5d93ee03248249117f8ce259ebb1b126803e1a5c 
> 
> Diff: https://reviews.apache.org/r/47987/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47986: Added move constructor/assignment operator to `Result`.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47986/#review135411
---


Ship it!




Ship It!

- Vinod Kone


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47986/
> ---
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added move constructor/assignment operator to `Result`.
> Note that `Some` still makes a copy and would be fixed in
> a separate patch.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/result.hpp 
> 5d93ee03248249117f8ce259ebb1b126803e1a5c 
> 
> Diff: https://reviews.apache.org/r/47986/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47989: Added move semantics to `Future::set`.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47989/#review135414
---


Ship it!




Ship It!

- Vinod Kone


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47989/
> ---
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/future.hpp 
> 455b750430ae04d16f610c24c0ea0feb8a033708 
> 
> Diff: https://reviews.apache.org/r/47989/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

2016-05-30 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47987/#review135466
---


Ship it!




Ship It!

- Vinod Kone


On May 29, 2016, 9:05 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47987/
> ---
> 
> (Updated May 29, 2016, 9:05 a.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This ensures that `Result` can only be created from constructible
> types. This logic is similar to the one already present in `Option`. 
> Somehow, this constaint was never added for `Result`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/result.hpp 
> 5d93ee03248249117f8ce259ebb1b126803e1a5c 
> 
> Diff: https://reviews.apache.org/r/47987/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

2016-05-30 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48029/#review135471
---


Ship it!




Ship It!

- Vinod Kone


On May 30, 2016, 7:50 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48029/
> ---
> 
> (Updated May 30, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5512
> https://issues.apache.org/jira/browse/MESOS-5512
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 407867be635b5ed4f7bbec1d82df4e3fa1ff6730 
>   src/slave/slave.hpp 19f95e40a2ca4c94449083de2455c4b2c4a5a77d 
>   src/tests/api_tests.cpp 83669431d6bcf45cbb6059c828fe5b7579fe2169 
> 
> Diff: https://reviews.apache.org/r/48029/diff/
> 
> 
> Testing
> ---
> 
> ./bin/mesos-tests.sh --gtest_filter="*GetLoggingLevel*" --verbose
> GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*GetLoggingLevel*" --verbose
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*GetLoggingLevel*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47990/#review135416
---



what's the reason for not having a rvalue ref overload?

- Vinod Kone


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47990/
> ---
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of having separate rvalue overload for `write`,
> this change takes the sink argument by value
> and then does a move. This has the additional small
> overhead of performing an extra move.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 10f6fb90e436300bc47f4d5d2ad4beabd19026ba 
>   3rdparty/libprocess/src/http.cpp b7839b1402d0660a2461085f5a1db191296e3308 
> 
> Diff: https://reviews.apache.org/r/47990/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 48018: Implemented v1::agent::Call::CHECK_HEALTH.

2016-05-29 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48018/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-5478
https://issues.apache.org/jira/browse/MESOS-5478


Repository: mesos


Description
---

Implemented v1::agent::Call::CHECK_HEALTH.


Diffs
-

  src/slave/http.cpp 64a99d539a0957b92d42c25c8dda298199383018 
  src/slave/slave.hpp 78a6ecfe29881f1723d7d603a99962afdd5a81a8 
  src/tests/api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/48018/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 48008: Added v1 protos for master and agent APIs.

2016-05-29 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48008/
---

(Updated May 29, 2016, 6:56 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Changes
---

fixed VersionInfo.


Bugs: MESOS-2257 and MESOS-2720
https://issues.apache.org/jira/browse/MESOS-2257
https://issues.apache.org/jira/browse/MESOS-2720


Repository: mesos


Description
---

Also added common protos to v1/mesos.proto.


Diffs (updated)
-

  include/mesos/master/allocator.proto 555f51b621b21b87b8db00b9ea62cd911d229504 
  include/mesos/v1/agent.hpp PRE-CREATION 
  include/mesos/v1/agent.proto PRE-CREATION 
  include/mesos/v1/master.hpp PRE-CREATION 
  include/mesos/v1/master.proto PRE-CREATION 
  include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d 

Diff: https://reviews.apache.org/r/48008/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

2016-05-28 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47991/#review135417
---



don't think i follow this change. can you explain why wrapping it in owned 
performs better?

- Vinod Kone


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47991/
> ---
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change passes the `Request` object by wrapping it in
> `Owned` instead of copying it when forwarding it to `defer`.
> Ideally, this should have been a `unique_ptr`, but our
> `defer` callbacks don't currently support moves.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 988fb3b81259e7b0a6a002f5799d667892874538 
> 
> Diff: https://reviews.apache.org/r/47991/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 48017: Implemented v1::master::Call::CHECK_HEALTH.

2016-05-29 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48017/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


Bugs: MESOS-5477
https://issues.apache.org/jira/browse/MESOS-5477


Repository: mesos


Description
---

Implemented v1::master::Call::CHECK_HEALTH.


Diffs
-

  src/master/http.cpp bbbf0a00e486b96e036f59a3107789d0322bc6cd 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/tests/api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/48017/diff/


Testing
---

make check


Thanks,

Vinod Kone

< 2 3 4 5 6 7 8 9 10 11 >

601 - 700 of 3008 matches

Mail list logo