and release GPU in `Future DockerContainerizerProcess::_update()` when
a task terminates.
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review143692
---
To reply, visit:
https://reviews.apache.org/r/50123/#review143639
-------
On 七月 18, 2016, 9:17 a.m., Yubo Li wrote:
>
> ---
> This is an automatica
string from/to `Docker::Device` tranformations.
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review143844
-----
gt; .then(defer(...));
> > ```
> >
> > You can also refer to
> > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/gpu/isolator.cpp#L356
> > to get some detail.
>
> Yubo Li wrote:
> `Future.get()` will block
and serializing.
Diffs (updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
exposed into docker container, and
passed allocated GPUs to it.
Diffs (updated)
-
src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
12bad2db03bcf755317c654f028b628c5c407a62
Diff: https://reviews.apache.org/r/50125/diff/
Testing
---
make check
Thanks,
Yubo Li
---
make check
Thanks,
Yubo Li
/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
be called
> > when the executor is launched.
>
> Yubo Li wrote:
> This logic is called when the task terminates. We allocate GPU in
> `Future DockerContainerizerProcess::update()` when a task launches,
> and release GPU in `Future DockerContainerizerProcess::_update()`
>
,
Yubo Li
9174a3810d0da34b99dc257e9c77f83107fdd9f5
src/tests/mesos.cpp 30492d7e3b4c5e9ae9d2b2446cadba62d43a3c65
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
/nvidia_gpu_isolator_tests.cpp
fea1f9f0a03373692ef2a6dd2bc5722dc6f46d5b
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu" make
-j check
Thanks,
Yubo Li
://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
(updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
62e8fcc6fa7bd856aab6148ca6e6cad66b436f04
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
---
make check
Thanks,
Yubo Li
/docker_containerizer_tests.cpp
42d4364b6fcbc94c7852721511001c103cb5a90d
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j
check
Thanks,
Yubo Li
the 'gpu/nvidia' isolator check for docker and external containerizers.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
c1a87e9e5c07529bc1d077f68477108a40506806
Diff: https://reviews.apache.org/r/50947/diff/
Testing
---
make check
Thanks,
Yubo Li
check
Thanks,
Yubo Li
/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
the 'gpu/nvidia' isolator check for docker and external containerizers.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
c1a87e9e5c07529bc1d077f68477108a40506806
Diff: https://reviews.apache.org/r/50947/diff/
Testing
---
make check
Thanks,
Yubo Li
the 'gpu/nvidia' isolator check for docker and external containerizers.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
c1a87e9e5c07529bc1d077f68477108a40506806
Diff: https://reviews.apache.org/r/50947/diff/
Testing
---
make check
Thanks,
Yubo Li
(updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
Thanks,
Yubo Li
for docker and external containerizers.
Diffs
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
c1a87e9e5c07529bc1d077f68477108a40506806
Diff: https://reviews.apache.org/r/50947/diff/
Testing
---
make check
Thanks,
Yubo Li
12bad2db03bcf755317c654f028b628c5c407a62
Diff: https://reviews.apache.org/r/50125/diff/
Testing
---
make check
Thanks,
Yubo Li
/docker_containerizer_tests.cpp
4e5b1fd1628504d346cced545f7911d6b6443773
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j
check
Thanks,
Yubo Li
/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885
src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62
Diff: https://reviews.apache.org/r/50841/diff/
Testing
---
make check
Thanks,
Yubo Li
30492d7e3b4c5e9ae9d2b2446cadba62d43a3c65
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
,
Yubo Li
multiple
devices.
Diffs
-
src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3
src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5
Diff: https://reviews.apache.org/r/50124/diff/
Testing
---
make check
Thanks,
Yubo Li
/executor.cpp 69511044e39bc05d7d6240264ec70b6e6f44edba
Diff: https://reviews.apache.org/r/50125/diff/
Testing
---
make check
Thanks,
Yubo Li
515842d381ca8a91ad481f66c7be057dff2f3f28
src/docker/executor.cpp 69511044e39bc05d7d6240264ec70b6e6f44edba
src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu" make
-j check
Thanks,
Yubo Li
/mesos.cpp d073d79c5797ecb021f0294ab6586a000f3ca600
Diff: https://reviews.apache.org/r/50126/diff/
Testing
---
make check
Thanks,
Yubo Li
e4eccfc3810bed3649a3ab80e252849470de4c72
src/tests/mesos.cpp d073d79c5797ecb021f0294ab6586a000f3ca600
Diff: https://reviews.apache.org/r/50126/diff/
Testing
---
make check
Thanks,
Yubo Li
rently
`--nvidia_gpus_devices` forces us to do this. We would talk with Ben and Kevin
to remove this retriction for docker containerizer soon.
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review144762
-
/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5
src/tests/mesos.cpp 30492d7e3b4c5e9ae9d2b2446cadba62d43a3c65
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
to it.
Diffs (updated)
-
src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
Thanks,
Yubo Li
43ca4317d608b3b43dd7bd0d1b55c721e7364885
src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62
Diff: https://reviews.apache.org/r/50841/diff/
Testing
---
make check
Thanks,
Yubo Li
t; make -j
check
Thanks,
Yubo Li
(updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
---
make check
Thanks,
Yubo Li
/nvidia-uvm:mrw,/dev/nvidia0:/dev/nvidia0:mrw"
- Yubo
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/#review144311
---
On 七月 29, 2016, 9:54 a.m., Yubo Li wrote:
>
> -
62e8fcc6fa7bd856aab6148ca6e6cad66b436f04
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
---
make check
Thanks,
Yubo Li
to it.
Diffs (updated)
-
src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d
src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review146263
-------
On 八月 15, 2016, 7:30 a.m., Yubo Li wrote:
>
> ---
> This is an auto
/docker_containerizer_tests.cpp
42d4364b6fcbc94c7852721511001c103cb5a90d
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j
check
Thanks,
Yubo Li
(updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d
src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723
Diff: https://reviews.apache.org/r/50841/diff/
Testing
---
make check
Thanks,
Yubo Li
62e8fcc6fa7bd856aab6148ca6e6cad66b436f04
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
y
> > may be needed, but I don't see why they would be part of this patch,
> > specifically.
>
> Guangya Liu wrote:
> OK, then we can split this to two patches, one for adding those header
> files and the other is for gpu related.
>
> Yubo Li wrote:
>
clear why this is added as part of this commit. I.e. I
> > don't see `set` being used anwywhere in the code that's being added.
removed
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
Phull.
Repository: mesos
Description
---
Added missed headers.
Diffs
-
src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d
Diff: https://reviews.apache.org/r/51425/diff/
Testing
---
make check
Thanks,
Yubo Li
src/tests/mesos.hpp ad31276aeb2cb7ed5ba3e091a9085f35addf17c4
src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d
src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723
Diff: https://reviews.apache.org/r/50841/diff/
Testing
---
make check
Thanks,
Yubo Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review146814
---
On 八月 25, 2016, 9:38 a.m., Yubo Li wrote:
>
> ---
> T
62e8fcc6fa7bd856aab6148ca6e6cad66b436f04
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
don't have
> > an allocator set, then we really shouldn't even be calling this function
> > regardless of anything else that is going on.
> >
> > Also, the string should read:
> > ```
> > "The `allocateNvidiaGpu` function was called without an
. Changed.
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/#review146816
---
On 八月 22, 2016,
ockerExecutorProcess`.
Good idea. Changed as your comments.
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50125/#review146823
-----
this have to do with the GPU test? Do we have to check this
> > here?
I'll delete it. Thanks!
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#revie
gt; not required.```
Fixed comments as you suggested.
- Yubo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review146831
-------
---
make check
Thanks,
Yubo Li
: https://reviews.apache.org/r/50125/diff/
Testing
---
make check
Thanks,
Yubo Li
-------
On 九月 20, 2016, 9:25 a.m., Yubo Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50599/
> -
/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d
src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723
Diff: https://reviews.apache.org/r/50841/diff/
Testing
---
make check
Thanks,
Yubo Li
(updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
/docker_containerizer_tests.cpp
42d4364b6fcbc94c7852721511001c103cb5a90d
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j
check
Thanks,
Yubo Li
the 'gpu/nvidia' isolator check for docker and external containerizers.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
c1a87e9e5c07529bc1d077f68477108a40506806
Diff: https://reviews.apache.org/r/50947/diff/
Testing
---
make check
Thanks,
Yubo Li
62e8fcc6fa7bd856aab6148ca6e6cad66b436f04
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
6a0e613bde6889864a37ffd7ec0b454e5fe4df1c
Diff: https://reviews.apache.org/r/50123/diff/
Testing
---
make check
Thanks,
Yubo Li
.
Also, added the error string for leaked GPUs:
```
container->termination.fail(
"Failed to kill the Docker container: " +
(kill.isFailed() ? kill.failure() : "discarded future") +
(container->gpus.empty() ?
"" : &q
/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d
src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982
Diff: https://reviews.apache.org/r/50841/diff/
Testing
---
make check
Thanks,
Yubo Li
(updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp 7c38123f1bedc7cda9c30ce9dd9877b7c41988fb
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
://reviews.apache.org/r/50125/diff/
Testing
---
make check
Thanks,
Yubo Li
/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d
src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
the 'gpu/nvidia' isolator check for docker and external containerizers.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
c1a87e9e5c07529bc1d077f68477108a40506806
Diff: https://reviews.apache.org/r/50947/diff/
Testing
---
make check
Thanks,
Yubo Li
/docker_containerizer_tests.cpp
d0261421bf7662b65877f5ca19d51b25d7af7952
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j
check
Thanks,
Yubo Li
()` function to:
```
static Try parse(
const std::string& host,
const std::string& container,
const std::string& permissions)
```
- Yubo
---
This is an automatically generated e-mail. To reply, visi
at the call site. For someone reading the
> code top to bottom it makes it look like we are *always* allocating /
> deallocating / etc. GPUs, which is cnfusing. The checks inside the function
> are to make sure that we don't accidentally call them somewhere without the
> proper check at the cal
is started/terminated.
Diffs (updated)
-
src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d
src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723
Diff: https://reviews.apache.org/r/50841/diff/
Testing
---
make check
Thanks,
Yubo Li
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/#review153839
-------
On 十月 24, 2016, 5 a.m., Yubo Li wrote:
>
> ---
> Thi
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/#review154911
---
On 十一月 2, 2016, 7:27 a.m., Yubo Li wrote:
>
> ---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52735/#review155254
-------
On 十一月 7, 2016, 1:53 p.m., Yubo Li wrote:
>
> ---
---
Thanks,
Yubo Li
/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d
src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
/docker_containerizer_tests.cpp
c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16
Diff: https://reviews.apache.org/r/50127/diff/
Testing
---
GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j
check
Thanks,
Yubo Li
---
make check
Thanks,
Yubo Li
(updated)
---
make -j4 check
Thanks,
Yubo Li
.
Diffs (updated)
-
src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562
Diff: https://reviews.apache.org/r/50125/diff/
Testing
---
make check
Thanks,
Yubo Li
On 十一月 2, 2016, 7:28 a.m., Yubo Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50125/
> ---
>
> (Update
the 'gpu/nvidia' isolator check for docker and external containerizers.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
2e722691475c84afae14009014ea70cc0fdd0e65
Diff: https://reviews.apache.org/r/50947/diff/
Testing
---
make check
Thanks,
Yubo Li
Phull.
Repository: mesos
Description
---
Added helper function to parse string input to 'Docker::Device'
structure.
Diffs
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
Diff: https://reviews.apache.org/r/53532/diff/
Testing
---
Thanks,
Yubo Li
o turn 'Docker::Device' into a string.
Diffs
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
/containerizer/docker.hpp 006f929eca0e0a6b1de941821ac72869ba393d2d
src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c
Diff: https://reviews.apache.org/r/50599/diff/
Testing
---
make check
Thanks,
Yubo Li
o turn 'Docker::Device' into a string.
Diffs (updated)
-
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e
Diff: https://reviews.apache.org/r/50128/diff/
Testing
---
make check
Thanks,
Yubo Li
1 - 100 of 218 matches
Mail list logo
